binutils-gdb/ld
Tamar Christina 74edb473c9 PE/Windows x86_64: Fix weak undef symbols after image base change
The change in PR19011 changed the image load address from being in the lower
32-bit address space to the higher 64-bit address space.

However when you have a weak undef symbol which stays undef at the end of
linking the linker has to resolve this (Windows loader does not support undef
symbols).  As such typically these would resolve to 0.

The relocation used for these weak symbols are the normal 32-bit PC_REL call
relocs.  So when doing the overflow check LD checks if the distance between the
symbol and the call is within range.  However now that the load address is
> 32-bits and the symbol val is 0 this overflow check will always fail.

As such the linker gives a bogus error.  This patch makes the linker not emit
the overflow failure but chooses to still let the check be performed (as it's
mid-end code).

One down side of this is that it does break the common convention that the call
be to sym at 0x0. i.e. before you'd get

      401015:   74 05                   je     40101c
      401017:   e8 e4 ef bf ff          callq  0

and now you get

   140001015:   74 05                   je     14000101c
   140001017:   e8 e4 ef ff bf          call   100000000

since the call is PC_REL there's no way to get the range large enough to
resolve to 0.  As such I have chosen to leave it as the furthest simple range
that we can still represent.

By only ignoring the error we leave the symbol value itself to still be 0
such that the if(<symbol>) checks still work correctly.

bfd/ChangeLog:

2021-04-01  Tamar Christina  <tamar.christina@arm.com>

	PR ld/26659
	* cofflink.c (_bfd_coff_generic_relocate_section): Ignore overflow.

ld/ChangeLog:

2021-04-01  Tamar Christina  <tamar.christina@arm.com>

	PR ld/26659
	* testsuite/ld-pe/pe.exp: Add test.
	* testsuite/ld-pe/pr26659-weak-undef-sym.d: New test.
	* testsuite/ld-pe/pr26659-weak-undef-sym.s: New test.
2021-04-01 17:54:04 +01:00
..
emulparams Use bool in ld 2021-03-31 10:49:23 +10:30
emultempl Use bool in ld 2021-03-31 10:49:23 +10:30
po
scripttempl aix: implement TLS relocation for gas and ld 2021-03-12 22:47:33 +10:30
testsuite PE/Windows x86_64: Fix weak undef symbols after image base change 2021-04-01 17:54:04 +01:00
.gitignore
aclocal.m4
ChangeLog PE/Windows x86_64: Fix weak undef symbols after image base change 2021-04-01 17:54:04 +01:00
ChangeLog-0001
ChangeLog-0203
ChangeLog-2004
ChangeLog-2005
ChangeLog-2006
ChangeLog-2007
ChangeLog-2008
ChangeLog-2009
ChangeLog-2010
ChangeLog-2011
ChangeLog-2012
ChangeLog-2013
ChangeLog-2014
ChangeLog-2015
ChangeLog-2016
ChangeLog-2017
ChangeLog-2018
ChangeLog-2019
ChangeLog-2020
ChangeLog-9197
ChangeLog-9899
config.in
configure Use bool in ld 2021-03-31 10:49:23 +10:30
configure.ac Use bool in ld 2021-03-31 10:49:23 +10:30
configure.host
configure.tgt
deffile.h
deffilep.y
dep-in.sed
elf-hints-local.h Remove bfd_stdint.h 2021-03-31 10:49:23 +10:30
fdl.texi
gen-doc.texi
genscrba.sh
genscripts.sh
h8-doc.texi
ld.h Use bool in ld 2021-03-31 10:49:23 +10:30
ld.texi
ldbuildid.c Remove strneq macro and use startswith. 2021-04-01 15:00:56 +02:00
ldbuildid.h Use bool in ld 2021-03-31 10:49:23 +10:30
ldcref.c Use bool in ld 2021-03-31 10:49:23 +10:30
ldctor.c Use bool in ld 2021-03-31 10:49:23 +10:30
ldctor.h Use bool in ld 2021-03-31 10:49:23 +10:30
ldelf.c Use bool in ld 2021-03-31 10:49:23 +10:30
ldelf.h Use bool in ld 2021-03-31 10:49:23 +10:30
ldelfgen.c Use bool in ld 2021-03-31 10:49:23 +10:30
ldelfgen.h Use bool in ld 2021-03-31 10:49:23 +10:30
ldemul.c Use bool in ld 2021-03-31 10:49:23 +10:30
ldemul.h Use bool in ld 2021-03-31 10:49:23 +10:30
ldexp.c Use bool in ld 2021-03-31 10:49:23 +10:30
ldexp.h Use bool in ld 2021-03-31 10:49:23 +10:30
ldfile.c Use bool in ld 2021-03-31 10:49:23 +10:30
ldfile.h Use bool in ld 2021-03-31 10:49:23 +10:30
ldgram.y Use bool in ld 2021-03-31 10:49:23 +10:30
ldint.texi
ldlang.c Use bool in ld 2021-03-31 10:49:23 +10:30
ldlang.h Use bool in ld 2021-03-31 10:49:23 +10:30
ldlex-wrapper.c
ldlex.h
ldlex.l
ldmain.c Use bool in ld 2021-03-31 10:49:23 +10:30
ldmain.h Use bool in ld 2021-03-31 10:49:23 +10:30
ldmisc.c Use bool in ld 2021-03-31 10:49:23 +10:30
ldmisc.h Use bool in ld 2021-03-31 10:49:23 +10:30
ldver.c
ldver.h
ldwrite.c Use bool in ld 2021-03-31 10:49:23 +10:30
ldwrite.h
lexsup.c Use bool in ld 2021-03-31 10:49:23 +10:30
libdep_plugin.c
MAINTAINERS
Makefile.am riscv --enable-targets=all on 32-bit host 2021-03-12 23:01:01 +10:30
Makefile.in riscv --enable-targets=all on 32-bit host 2021-03-12 23:01:01 +10:30
mri.c Use bool in ld 2021-03-31 10:49:23 +10:30
mri.h
NEWS
pe-dll.c Use bool in ld 2021-03-31 10:49:23 +10:30
pe-dll.h Use bool in ld 2021-03-31 10:49:23 +10:30
pep-dll.c
pep-dll.h Use bool in ld 2021-03-31 10:49:23 +10:30
plugin.c Use bool in ld 2021-03-31 10:49:23 +10:30
plugin.h Use bool in ld 2021-03-31 10:49:23 +10:30
README
stamp-h.in
sysdep.h Use bool in ld 2021-03-31 10:49:23 +10:30
testplug2.c Use bool in ld 2021-03-31 10:49:23 +10:30
testplug3.c Use bool in ld 2021-03-31 10:49:23 +10:30
testplug4.c Use bool in ld 2021-03-31 10:49:23 +10:30
testplug.c Use bool in ld 2021-03-31 10:49:23 +10:30
TODO

This file contains invisible Unicode characters

This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

		README for LD

This is the GNU linker.  It is distributed with other "binary
utilities" which should be in ../binutils.  See ../binutils/README for
more general notes, including where to send bug reports.

There are many features of the linker:

* The linker uses a Binary File Descriptor library (../bfd)
  that it uses to read and write object files.  This helps
  insulate the linker itself from the format of object files.

* The linker supports a number of different object file
  formats.  It can even handle multiple formats at once:
  Read two input formats and write a third.

* The linker can be configured for cross-linking.

* The linker supports a control language.

* There is a user manual (ld.texi), as well as the
  beginnings of an internals manual (ldint.texi).

Installation
============

See ../binutils/README.

If you want to make a cross-linker, you may want to specify
a different search path of -lfoo libraries than the default.
You can do this by setting the LIB_PATH variable in ./Makefile
or using the --with-lib-path configure switch.

To build just the linker, make the target all-ld from the top level
directory (one directory above this one).

Porting to a new target
=======================

See the ldint.texi manual.

Reporting bugs etc
===========================

See ../binutils/README.

Known problems
==============

The Solaris linker normally exports all dynamic symbols from an
executable.  The GNU linker does not do this by default.  This is
because the GNU linker tries to present the same interface for all
similar targets (in this case, all native ELF targets).  This does not
matter for normal programs, but it can make a difference for programs
which try to dlopen an executable, such as PERL or Tcl.  You can make
the GNU linker export all dynamic symbols with the -E or
--export-dynamic command line option.

HP/UX 9.01 has a shell bug that causes the linker scripts to be
generated incorrectly.  The symptom of this appears to be "fatal error
- scanner input buffer overflow" error messages.  There are various
workarounds to this:
  * Build and install bash, and build with "make SHELL=bash".
  * Update to a version of HP/UX with a working shell (e.g., 9.05).
  * Replace "(. ${srcdir}/scripttempl/${SCRIPT_NAME}.sc)" in
    genscripts.sh with "sh ${srcdir}..." (no parens) and make sure the
    emulparams script used exports any shell variables it sets.

Copyright (C) 2012-2021 Free Software Foundation, Inc.

Copying and distribution of this file, with or without modification,
are permitted in any medium without royalty provided the copyright
notice and this notice are preserved.