mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-12-15 04:31:49 +08:00
Code Issues Packages Projects Releases Wiki Activity
94ea6ddb94
binutils-gdb/gdb/dwarf2
History
Simon Marchi df4397e378 gdb: remove move constructor and move assignment operator from cooked_index 
Building with clang++-14, I see:

      CXX    dwarf2/cooked-index.o
    In file included from /home/smarchi/src/binutils-gdb/gdb/dwarf2/cooked-index.c:21:
    /home/smarchi/src/binutils-gdb/gdb/dwarf2/cooked-index.h:172:12: error: explicitly defaulted move constructor is implicitly deleted [-Werror,-Wdefaulted-function-deleted]
      explicit cooked_index (cooked_index &&other) = default;
               ^
    /home/smarchi/src/binutils-gdb/gdb/dwarf2/cooked-index.h:225:16: note: move constructor of 'cooked_index' is implicitly deleted because field 'm_storage' has a deleted move constructor
      auto_obstack m_storage;
                   ^
    /home/smarchi/src/binutils-gdb/gdb/../gdbsupport/gdb_obstack.h:128:28: note: 'auto_obstack' has been explicitly marked deleted here
      DISABLE_COPY_AND_ASSIGN (auto_obstack);
                               ^
    In file included from /home/smarchi/src/binutils-gdb/gdb/dwarf2/cooked-index.c:21:
    /home/smarchi/src/binutils-gdb/gdb/dwarf2/cooked-index.h:174:17: error: explicitly defaulted move assignment operator is implicitly deleted [-Werror,-Wdefaulted-function-deleted]
      cooked_index &operator= (cooked_index &&other) = default;
                    ^
    /home/smarchi/src/binutils-gdb/gdb/dwarf2/cooked-index.h:225:16: note: move assignment operator of 'cooked_index' is implicitly deleted because field 'm_storage' has a deleted move assignment operator
      auto_obstack m_storage;
                   ^
    /home/smarchi/src/binutils-gdb/gdb/../gdbsupport/gdb_obstack.h:128:3: note: 'operator=' has been explicitly marked deleted here
      DISABLE_COPY_AND_ASSIGN (auto_obstack);
      ^
    /home/smarchi/src/binutils-gdb/gdb/../include/ansidecl.h:425:8: note: expanded from macro 'DISABLE_COPY_AND_ASSIGN'
      void operator= (const TYPE &) = delete
           ^

We explicitly make cooked_index have a default move constructor and
move assignment operator.  But it doesn't actually happen because
cooked_index has a field of type auto_obstack, which isn't movable.
We don't actually need cooked_index to be movable at the moment, so
remove those lines.

Change-Id: Ifc1fe3d7d67e3ae1a14363d6c1869936fe80b0a2
2022-04-14 11:32:34 -04:00
..
abbrev-cache.c Introduce DWARF abbrev cache 2022-04-12 09:31:16 -06:00
abbrev-cache.h Introduce DWARF abbrev cache 2022-04-12 09:31:16 -06:00
abbrev.c Statically examine abbrev properties 2022-04-12 09:31:16 -06:00
abbrev.h Statically examine abbrev properties 2022-04-12 09:31:16 -06:00
attribute.c
attribute.h
comp-unit-head.c
comp-unit-head.h
cooked-index.c gdb: fix "passing NULL to memcpy" UBsan error in dwarf2/cooked-index.c 2022-04-12 14:42:02 -04:00
cooked-index.h gdb: remove move constructor and move assignment operator from cooked_index 2022-04-14 11:32:34 -04:00
cu.c Delete DWARF psymtab code 2022-04-12 09:31:17 -06:00
cu.h gdb: rename start_symtab/end_symtab to start_compunit_symtab/end_compunit_symtab 2022-04-04 12:58:07 -04:00
die.h
dwz.c
dwz.h
expr.c
expr.h
file-and-dir.h Add "fullname" handling to file_and_directory 2022-04-12 09:31:16 -06:00
frame-tailcall.c
frame-tailcall.h
frame.c Unify gdb printf functions 2022-03-29 12:46:24 -06:00
frame.h
index-cache.c Rename write_psymtabs_to_index 2022-04-12 09:31:16 -06:00
index-cache.h
index-common.c Add new overload of dwarf5_djb_hash 2022-04-12 09:31:16 -06:00
index-common.h Add new overload of dwarf5_djb_hash 2022-04-12 09:31:16 -06:00
index-write.c Delete DWARF psymtab code 2022-04-12 09:31:17 -06:00
index-write.h Rename write_psymtabs_to_index 2022-04-12 09:31:16 -06:00
leb.c
leb.h
line-header.c gdb: change file_file_name to return an std::string 2022-04-07 20:31:31 -04:00
line-header.h Delete DWARF psymtab code 2022-04-12 09:31:17 -06:00
loc.c gdb: remove symbol value macros 2022-04-11 10:45:36 -04:00
loc.h gdb/dwarf: pass an array of values to the dwarf evaluator 2022-04-03 17:18:20 +01:00
macro.c gdb: change file_file_name to return an std::string 2022-04-07 20:31:31 -04:00
macro.h
public.h Delete DWARF psymtab code 2022-04-12 09:31:17 -06:00
read.c gdb: change subfile::name and buildsym_compunit::m_comp_dir to strings 2022-04-12 14:13:10 -04:00
read.h Remove dwarf2_per_cu_data::v 2022-04-12 09:31:17 -06:00
sect-names.h
section.c
section.h
stringify.c
stringify.h