binutils-gdb/ld
Renlin Li 93f4de3929 [BFD][PR21703]Override the new defined symbol with the old normal symbol when --allow-multiple-definition is provided.
The behavior of _bfd_elf_merge_symbol and _bfd_generic_link_add_one_symbol is
inconsistent.

In multiple definition case, _bfd_elf_merge_symbol decided to override the old
symbol definition with the new defintion, (size, type, target data)
In _bfd_generic_link_add_one_symbol, it simply return without doing anything
because of allow-multiple-definition is provided.
This leaves the symbol in a wrong state.

Here, following the documentation, I made this patch to force the old definition
override the new definition if the old symbol is not dynamic or weak.
Because, in those two cases, it's expected to do some merge. I have checked
that, those two cases are properly handled.

bfd/
	PR ld/21703
	* elflink.c (_bfd_elf_merge_symbol): Handle multiple definition case.

ld/

	PR ld/21703
	* testsuite/ld-elf/elf.exp: Run new tests.
	* testsuite/ld-elf/pr21703-1.s: New.
	* testsuite/ld-elf/pr21703-2.s: New.
	* testsuite/ld-elf/pr21703-3.s: New.
	* testsuite/ld-elf/pr21703-4.s: New.
	* testsuite/ld-elf/pr21703-r.sd: New.
	* testsuite/ld-elf/pr21703-shared.sd: New.
	* testsuite/ld-elf/pr21703.sd: New.
	* testsuite/ld-elf/pr21703.ver: New.
2017-10-24 13:01:48 +01:00
..
emulparams ELF: Call check_relocs after opening all inputs 2017-10-16 03:50:13 -07:00
emultempl RISC-V: Add R_RISCV_DELETE, which marks bytes for deletion 2017-10-19 09:19:32 -07:00
po ld whitespace fixes 2017-10-12 23:30:43 +10:30
scripttempl ld whitespace fixes 2017-10-12 23:30:43 +10:30
testsuite [BFD][PR21703]Override the new defined symbol with the old normal symbol when --allow-multiple-definition is provided. 2017-10-24 13:01:48 +01:00
.gitignore
aclocal.m4
ChangeLog [BFD][PR21703]Override the new defined symbol with the old normal symbol when --allow-multiple-definition is provided. 2017-10-24 13:01:48 +01:00
ChangeLog-0001
ChangeLog-0203
ChangeLog-2004
ChangeLog-2005
ChangeLog-2006
ChangeLog-2007
ChangeLog-2008
ChangeLog-2009
ChangeLog-2010
ChangeLog-2011
ChangeLog-2012
ChangeLog-2013
ChangeLog-2014
ChangeLog-2015
ChangeLog-2016
ChangeLog-9197
ChangeLog-9899
config.in Add configure flag to enable gnu hash style by default. 2017-08-08 07:25:39 +09:30
configure ld whitespace fixes 2017-10-12 23:30:43 +10:30
configure.ac ld whitespace fixes 2017-10-12 23:30:43 +10:30
configure.host
configure.tgt i386: Don't add elf32_x86_64 to supported emulations 2017-10-23 14:44:04 -07:00
deffile.h
deffilep.y ld whitespace fixes 2017-10-12 23:30:43 +10:30
dep-in.sed
elf-hints-local.h
fdl.texi
gen-doc.texi S/390: Add support for pgste marker 2017-06-23 08:00:46 +02:00
genscrba.sh
genscripts.sh ld whitespace fixes 2017-10-12 23:30:43 +10:30
h8-doc.texi
ld.h Treat common symbol as undefined for --no-define-common 2017-08-06 08:19:04 -07:00
ld.texinfo Correct -z text and other -z documentation 2017-10-17 16:47:05 +10:30
ldbuildid.c
ldbuildid.h
ldcref.c ld internationalization fixes 2017-10-11 15:04:59 +10:30
ldctor.c
ldctor.h
ldemul.c ELF: Call check_relocs after opening all inputs 2017-10-16 03:50:13 -07:00
ldemul.h ELF: Call check_relocs after opening all inputs 2017-10-16 03:50:13 -07:00
ldexp.c
ldexp.h
ldfile.c
ldfile.h
ldgram.y ld whitespace fixes 2017-10-12 23:30:43 +10:30
ldint.texinfo
ldlang.c ELF: Call check_relocs after opening all inputs 2017-10-16 03:50:13 -07:00
ldlang.h LTO rescan archives 2017-09-02 17:39:04 +09:30
ldlex-wrapper.c
ldlex.h
ldlex.l ld whitespace fixes 2017-10-12 23:30:43 +10:30
ldmain.c ld internationalization fixes 2017-10-11 15:04:59 +10:30
ldmain.h
ldmisc.c
ldmisc.h
ldver.c
ldver.h
ldwrite.c
ldwrite.h
lexsup.c ld whitespace fixes 2017-10-12 23:30:43 +10:30
MAINTAINERS
Makefile.am Correct ld/Makefile earmelfb_fuchsia dependencies 2017-10-10 14:44:58 +10:30
Makefile.in Correct ld/Makefile earmelfb_fuchsia dependencies 2017-10-10 14:44:58 +10:30
mri.c
mri.h
NEWS ld whitespace fixes 2017-10-12 23:30:43 +10:30
pe-dll.c ld whitespace fixes 2017-10-12 23:30:43 +10:30
pe-dll.h
pep-dll.c
pep-dll.h
plugin.c ld whitespace fixes 2017-10-12 23:30:43 +10:30
plugin.h
README
stamp-h.in
sysdep.h
testplug2.c
testplug3.c
testplug4.c
testplug.c
TODO

This file contains invisible Unicode characters

This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

		README for LD

This is the GNU linker.  It is distributed with other "binary
utilities" which should be in ../binutils.  See ../binutils/README for
more general notes, including where to send bug reports.

There are many features of the linker:

* The linker uses a Binary File Descriptor library (../bfd)
  that it uses to read and write object files.  This helps
  insulate the linker itself from the format of object files.

* The linker supports a number of different object file
  formats.  It can even handle multiple formats at once:
  Read two input formats and write a third.

* The linker can be configured for cross-linking.

* The linker supports a control language.

* There is a user manual (ld.texinfo), as well as the
  beginnings of an internals manual (ldint.texinfo).

Installation
============

See ../binutils/README.

If you want to make a cross-linker, you may want to specify
a different search path of -lfoo libraries than the default.
You can do this by setting the LIB_PATH variable in ./Makefile
or using the --with-lib-path configure switch.

To build just the linker, make the target all-ld from the top level
directory (one directory above this one).

Porting to a new target
=======================

See the ldint.texinfo manual.

Reporting bugs etc
===========================

See ../binutils/README.

Known problems
==============

The Solaris linker normally exports all dynamic symbols from an
executable.  The GNU linker does not do this by default.  This is
because the GNU linker tries to present the same interface for all
similar targets (in this case, all native ELF targets).  This does not
matter for normal programs, but it can make a difference for programs
which try to dlopen an executable, such as PERL or Tcl.  You can make
the GNU linker export all dynamic symbols with the -E or
--export-dynamic command line option.

HP/UX 9.01 has a shell bug that causes the linker scripts to be
generated incorrectly.  The symptom of this appears to be "fatal error
- scanner input buffer overflow" error messages.  There are various
workarounds to this:
  * Build and install bash, and build with "make SHELL=bash".
  * Update to a version of HP/UX with a working shell (e.g., 9.05).
  * Replace "(. ${srcdir}/scripttempl/${SCRIPT_NAME}.sc)" in
    genscripts.sh with "sh ${srcdir}..." (no parens) and make sure the
    emulparams script used exports any shell variables it sets.

Copyright (C) 2012-2017 Free Software Foundation, Inc.

Copying and distribution of this file, with or without modification,
are permitted in any medium without royalty provided the copyright
notice and this notice are preserved.