Go to file
Simon Marchi 9161c89ad8 gdb: remove objfile parameter from get_objfile_bfd_data
I noticed it was unused.  I think that makes sense, as it shows that
objfile_per_bfd_storage is not specific to one objfile (it can be shared
by multiple objfiles that have the same bfd).

There is one thing I wonder though, maybe I'm missing something.  If
the BFD doesn't require relocation, get_objfile_bfd_data stores the
newly allocated object in objfiles_bfd_data, so we can assume that
objfiles_bfd_data is the owner of the object.  When the bfd's refcount
drops to 0, the corresponding objfile_per_bfd_storage object in
objfiles_bfd_data is deleted.

But if the BFD requires relocation, get_objfile_bfd_data returns a newly
allocated object that isn't kept anywhere else (and isn't shared).  So
the objfile becomes the owner of the objfile_per_bfd_storage object.  In
objfile::~objfile, we have this:

    if (obfd)
      gdb_bfd_unref (obfd);
    else
      delete per_bfd;

I'm thinking that obfd could be non-nullptr, and it could require
relocation.  In that case, it would never be freed.  Anyway, that's not
really connected to this patch.

gdb/ChangeLog:

	* objfiles.c (get_objfile_bfd_data): Remove objfile parameter,
	adjust callers.

Change-Id: Ifa3158074ea6b42686780ba09d0c964b0cf14cf1
2021-04-02 11:51:45 -04:00
bfd Automatic date update in version.in 2021-04-02 00:00:15 +00:00
binutils Remove strneq macro and use startswith. 2021-04-01 15:00:56 +02:00
config GCC_CET_HOST_FLAGS: Check if host supports multi-byte NOPs 2021-03-18 08:02:46 -07:00
contrib
cpu Use bool in opcodes 2021-03-31 10:49:23 +10:30
elfcpp Add DWARF 5 support in gold. 2021-03-19 13:55:35 -07:00
etc
gas Remove strneq macro and use startswith. 2021-04-01 15:00:56 +02:00
gdb gdb: remove objfile parameter from get_objfile_bfd_data 2021-04-02 11:51:45 -04:00
gdbserver Fix inverted logic bug 2021-03-30 09:23:11 -03:00
gdbsupport New memory-tag commands 2021-03-24 14:57:53 -03:00
gnulib gnulib: import gitlog-to-changelog 2021-03-24 19:35:40 -04:00
gold PR27625, powerpc64 gold __tls_get_addr calls 2021-03-30 13:38:41 +10:30
gprof Use bool in gprof 2021-03-31 10:49:23 +10:30
include Remove strneq macro and use startswith. 2021-04-01 15:00:56 +02:00
intl
ld PE/Windows x86_64: Fix weak undef symbols after image base change 2021-04-01 17:54:04 +01:00
libctf libctf: fix ELF-in-BFD checks in the presence of ASAN 2021-03-25 16:32:51 +00:00
libdecnumber
libiberty GCC_CET_HOST_FLAGS: Check if host supports multi-byte NOPs 2021-03-18 08:02:46 -07:00
opcodes Remove strneq macro and use startswith. 2021-04-01 15:00:56 +02:00
readline
sim Fix microblaze sim build error 2021-04-01 15:53:11 +02:00
texinfo
zlib
.cvsignore
.gitattributes
.gitignore
ar-lib
ChangeLog
compile
config-ml.in
config.guess
config.rpath
config.sub
configure
configure.ac
COPYING
COPYING3
COPYING3.LIB
COPYING.LIB
COPYING.LIBGLOSS
COPYING.NEWLIB
depcomp
djunpack.bat
install-sh
libtool.m4
lt~obsolete.m4
ltgcc.m4
ltmain.sh
ltoptions.m4
ltsugar.m4
ltversion.m4
MAINTAINERS
Makefile.def
Makefile.in
Makefile.tpl
makefile.vms
missing
mkdep
mkinstalldirs
move-if-change
multilib.am
README
README-maintainer-mode
setup.com
src-release.sh
symlink-tree
test-driver
ylwrap

		   README for GNU development tools

This directory contains various GNU compilers, assemblers, linkers, 
debuggers, etc., plus their support routines, definitions, and documentation.

If you are receiving this as part of a GDB release, see the file gdb/README.
If with a binutils release, see binutils/README;  if with a libg++ release,
see libg++/README, etc.  That'll give you info about this
package -- supported targets, how to use it, how to report bugs, etc.

It is now possible to automatically configure and build a variety of
tools with one command.  To build all of the tools contained herein,
run the ``configure'' script here, e.g.:

	./configure 
	make

To install them (by default in /usr/local/bin, /usr/local/lib, etc),
then do:
	make install

(If the configure script can't determine your type of computer, give it
the name as an argument, for instance ``./configure sun4''.  You can
use the script ``config.sub'' to test whether a name is recognized; if
it is, config.sub translates it to a triplet specifying CPU, vendor,
and OS.)

If you have more than one compiler on your system, it is often best to
explicitly set CC in the environment before running configure, and to
also set CC when running make.  For example (assuming sh/bash/ksh):

	CC=gcc ./configure
	make

A similar example using csh:

	setenv CC gcc
	./configure
	make

Much of the code and documentation enclosed is copyright by
the Free Software Foundation, Inc.  See the file COPYING or
COPYING.LIB in the various directories, for a description of the
GNU General Public License terms under which you can copy the files.

REPORTING BUGS: Again, see gdb/README, binutils/README, etc., for info
on where and how to report problems.