mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
cce0ae568c
The previous patch to add -prompt/-lbl to gdb_test introduced a regression: Before, you could specify an explicit empty message to indicate you didn't want to PASS, like so: gdb_test COMMAND PATTERN "" After said patch, gdb_test no longer distinguishes no-message-specified vs empty-message, so tests that previously would be silent on PASS, now started emitting PASS messages based on COMMAND. This in turn introduced a number of PATH/DUPLICATE violations in the testsuite. This commit fixes all the regressions I could see. This patch uses the new -nopass feature introduced in the previous commit, but tries to avoid it if possible. Most of the patch fixes DUPLICATE issues the usual way, of using with_test_prefix or explicit unique messages. See previous commit's log for more info. In addition to looking for DUPLICATEs, I also looked for cases where we would now end up with an empty message in gdb.sum, due to a gdb_test being passed both no message and empty command. E.g., this in gdb.ada/bp_reset.exp: gdb_run_cmd gdb_test "" "Breakpoint $decimal, foo\\.nested_sub \\(\\).*" was resulting in this in gdb.sum: PASS: gdb.ada/bp_reset.exp: I fixed such cases by passing an explicit message. We may want to make such cases error out. Tested on x86_64 GNU/Linux, native and native-extended-gdbserver. I see zero PATH cases now. I get zero DUPLICATEs with native testing now. I still see some DUPLICATEs with native-extended-gdbserver, but those were preexisting, unrelated to the gdb_test change. Change-Id: I5375f23f073493e0672190a0ec2e847938a580b2
97 lines
2.4 KiB
Plaintext
97 lines
2.4 KiB
Plaintext
# Copyright 1998-2022 Free Software Foundation, Inc.
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# This file was written by Michael Snyder (msnyder@cygnus.com)
|
|
|
|
load_lib "trace-support.exp"
|
|
|
|
|
|
gdb_exit
|
|
gdb_start
|
|
|
|
standard_testfile actions.c
|
|
set executable $testfile
|
|
if ![gdb_trace_common_supports_arch] {
|
|
unsupported "no trace-common.h support for arch"
|
|
return -1
|
|
}
|
|
if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \
|
|
executable {debug nowarnings}] != "" } {
|
|
untested "failed to compile"
|
|
return -1
|
|
}
|
|
gdb_load $binfile
|
|
runto_main
|
|
gdb_reinitialize_dir $srcdir/$subdir
|
|
|
|
if { ![gdb_target_supports_trace] } then {
|
|
unsupported "current target does not support trace"
|
|
return 1
|
|
}
|
|
|
|
#
|
|
# test while-stepping dynamically (live target)
|
|
#
|
|
|
|
proc test_while_stepping { while_stepping } {
|
|
global fpreg
|
|
global decimal
|
|
global gdb_prompt
|
|
global executable
|
|
|
|
with_test_prefix "$while_stepping" {
|
|
clean_restart $executable
|
|
|
|
runto_main
|
|
|
|
## verify number of trace frames collected matches stepcount
|
|
|
|
gdb_delete_tracepoints
|
|
gdb_test "trace gdb_c_test" \
|
|
"Tracepoint $decimal at .*" \
|
|
"Set tracepoint at gdb_c_test"
|
|
|
|
gdb_trace_setactions "define $while_stepping <stepcount>" \
|
|
"" \
|
|
"collect \$$fpreg" "^$" \
|
|
"$while_stepping 5" "^$" \
|
|
"collect p" "^$" \
|
|
"end" "^$" \
|
|
"end" ""
|
|
|
|
gdb_test "tstart" ".*"
|
|
|
|
gdb_breakpoint "end" qualified
|
|
gdb_test "continue" \
|
|
"Continuing.*Breakpoint $decimal, end.*" \
|
|
"run trace experiment"
|
|
|
|
gdb_test "tstop" ".*"
|
|
|
|
gdb_tfind_test "frame 5 should be the last one collected" "5" "5"
|
|
|
|
gdb_test "tfind 6" "failed to find.*" \
|
|
"trace stopped after 5 stepping frames"
|
|
|
|
gdb_test "tfind none" ".*"
|
|
}
|
|
}
|
|
|
|
# Test all while-stepping aliases.
|
|
|
|
test_while_stepping "while-stepping"
|
|
test_while_stepping "stepping"
|
|
test_while_stepping "ws"
|