mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-21 04:42:53 +08:00
bb995d00b3
This patch attempts to fix a bug dealing with setting breakpoints in default symtabs that are symlinks. For example: (gdb) list 11 GNU General Public License for more details. 12 13 You should have received a copy of the GNU General Public License 14 along with this program. If not, see <http://www.gnu.org/licenses/>. */ 15 16 static int 17 foo (void) 18 { 19 return 0; /* break here */ 20 } (gdb) 21 22 int 23 main (void) 24 { 25 return foo (); 26 } (gdb) b 19 No line 19 in the current file. Make breakpoint pending on future shared library load? (y or [n]) The problem here is that when create_sals_line_offset sets the default symtab, it immediately calls symtab_to_fullname, passing that fullname to collect_symtabs_from_filename to find all matching symtabs. This fails because we end up looking for a symtab with the name of the actual file on disk (which is different in this case because of the symlink) instead of the one stored in the debug info. Since we already have the lookup name of the default symtab, use it instead of the fullname. [This fullname thing was originally added in 2007 in a series dealing with *displaying* absolute file names. Clearly, this instance has nothing to do with the display of file names.] gdb/ChangeLog PR symtab/23853 * linespec.c (create_sals_line_offset): Search for the default symtab's filename instead of its fullname. gdb/testsuite/ChangeLog PR symtab/23853 * gdb.base/symlink-sourcefile.c: New file. * gdb.base/symlink-sourcefile.exp: New file.
46 lines
1.5 KiB
Plaintext
46 lines
1.5 KiB
Plaintext
# Copyright 2019 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Test that GDB can find the default symtab when it is a symbolic link.
|
|
standard_testfile
|
|
|
|
set test "file symbolic link name"
|
|
set linksrc "link-${srcfile}"
|
|
set srcfilelink [standard_output_file $linksrc]
|
|
|
|
|
|
# Remove any existing symlink and build executable using a
|
|
# symbolic link to the actual source file.
|
|
remote_file host delete $srcfilelink
|
|
set status [remote_exec host \
|
|
"ln -sf $srcdir/$subdir/$srcfile $srcfilelink"]
|
|
if {[lindex $status 0] != 0} {
|
|
unsupported "$test (host does not support symbolic links)"
|
|
return 0
|
|
}
|
|
|
|
if {[prepare_for_testing $testfile $testfile $srcfilelink]} {
|
|
return -1
|
|
}
|
|
|
|
if {![runto_main]} {
|
|
untested "could not run to main"
|
|
return -1
|
|
}
|
|
|
|
# Using a line number ensures that the default symtab is used.
|
|
gdb_breakpoint [gdb_get_line_number "break here" $srcfile] message
|
|
gdb_continue_to_breakpoint "run to breakpoint marker"
|