mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
7c5ded6a00
As a preparation for the next patch, which will move fork_inferior from GDB to common/ (and therefore share it with gdbserver), it is interesting to convert a few functions to C++. This patch touches functions related to parsing command-line arguments to the inferior (see gdb/fork-child.c:breakup_args), the way the arguments are stored on fork_inferior (using std::vector instead of char **), and the code responsible for dealing with argv also on gdbserver. I've taken this opportunity and decided to constify a few arguments to fork_inferior/create_inferior as well, in order to make the code cleaner. And now, on gdbserver, we're using xstrdup everywhere and aren't checking for memory allocation failures anymore, as requested by Pedro: <https://sourceware.org/ml/gdb-patches/2017-03/msg00191.html> Message-Id: <025ebdb9-90d9-d54a-c055-57ed2406b812@redhat.com> Pedro Alves wrote: > On the "== NULL" check: IIUC, the old NULL check was there to > handle strdup returning NULL due to out-of-memory. > See NULL checks and comments further above in this function. > Now that you're using a std::vector, that doesn't work or make > sense any longer, since if push_back fails to allocate space for > its internal buffer (with operator new), our operator new replacement > (common/new-op.c) calls malloc_failure, which aborts gdbserver. > > Not sure it makes sense to handle out-of-memory specially in > the gdb/rsp-facing functions nowadays (maybe git blame/log/patch > submission for that code shows some guidelines). Maybe (or, probably) > it's OK to stop caring about it, but then we should consistently remove > left over code, by using xstrdup instead and remove the NULL checks. IMO this refactoring was very good to increase the readability of the code as well, because some parts of the argument handling were unnecessarily confusing before. gdb/ChangeLog: 2017-04-12 Sergio Durigan Junior <sergiodj@redhat.com> * common/common-utils.c (free_vector_argv): New function. * common/common-utils.h: Include <vector>. (free_vector_argv): New prototype. * darwin-nat.c (darwin_create_inferior): Rewrite function prototype in order to constify "exec_file" and accept a "std::string" for "allargs". * fork-child.c: Include <vector>. (breakup_args): Rewrite function, using C++. (fork_inferior): Rewrite function header, constify "exec_file_arg" and accept "std::string" for "allargs". Update the code to calculate "argv" based on "allargs". Update calls to "exec_fun" and "execvp". * gnu-nat.c (gnu_create_inferior): Rewrite function prototype in order to constify "exec_file" and accept a "std::string" for "allargs". * go32-nat.c (go32_create_inferior): Likewise. * inf-ptrace.c (inf_ptrace_create_inferior): Likewise. * infcmd.c (run_command_1): Constify "exec_file". Use "std::string" for inferior arguments. * inferior.h (fork_inferior): Update prototype. * linux-nat.c (linux_nat_create_inferior): Rewrite function prototype in order to constify "exec_file" and accept a "std::string" for "allargs". * nto-procfs.c (procfs_create_inferior): Likewise. * procfs.c (procfs_create_inferior): Likewise. * remote-sim.c (gdbsim_create_inferior): Likewise. * remote.c (extended_remote_run): Update code to accept "std::string" as argument. (extended_remote_create_inferior): Rewrite function prototype in order to constify "exec_file" and accept a "std::string" for "allargs". * rs6000-nat.c (super_create_inferior): Likewise. (rs6000_create_inferior): Likewise. * target.h (struct target_ops) <to_create_inferior>: Likewise. * windows-nat.c (windows_create_inferior): Likewise. gdb/gdbserver/ChangeLog: 2017-04-12 Sergio Durigan Junior <sergiodj@redhat.com> * server.c: Include <vector>. <program_argv, wrapper_argv>: Convert to std::vector. (start_inferior): Rewrite function to use C++. (handle_v_run): Likewise. Update code that calculates the argv based on the vRun packet; use C++. (captured_main): Likewise. |
||
|---|---|---|
| .. | ||
| agent.c | ||
| agent.h | ||
| ax.def | ||
| break-common.h | ||
| btrace-common.c | ||
| btrace-common.h | ||
| buffer.c | ||
| buffer.h | ||
| cleanups.c | ||
| cleanups.h | ||
| common-debug.c | ||
| common-debug.h | ||
| common-defs.h | ||
| common-exceptions.c | ||
| common-exceptions.h | ||
| common-regcache.c | ||
| common-regcache.h | ||
| common-types.h | ||
| common-utils.c | ||
| common-utils.h | ||
| common.host | ||
| common.m4 | ||
| create-version.sh | ||
| enum-flags.h | ||
| environ.c | ||
| environ.h | ||
| errors.c | ||
| errors.h | ||
| fileio.c | ||
| fileio.h | ||
| filestuff.c | ||
| filestuff.h | ||
| format.c | ||
| format.h | ||
| function-view.h | ||
| gdb_assert.h | ||
| gdb_locale.h | ||
| gdb_optional.h | ||
| gdb_ref_ptr.h | ||
| gdb_setjmp.h | ||
| gdb_signals.h | ||
| gdb_sys_time.h | ||
| gdb_unique_ptr.h | ||
| gdb_unlinker.h | ||
| gdb_vecs.c | ||
| gdb_vecs.h | ||
| gdb_wait.h | ||
| host-defs.h | ||
| mingw-strerror.c | ||
| new-op.c | ||
| offset-type.h | ||
| posix-strerror.c | ||
| preprocessor.h | ||
| print-utils.c | ||
| print-utils.h | ||
| ptid.c | ||
| ptid.h | ||
| queue.h | ||
| rsp-low.c | ||
| rsp-low.h | ||
| run-time-clock.c | ||
| run-time-clock.h | ||
| scoped_restore.h | ||
| signals-state-save-restore.c | ||
| signals-state-save-restore.h | ||
| signals.c | ||
| symbol.h | ||
| traits.h | ||
| underlying.h | ||
| valid-expr.h | ||
| vec.c | ||
| vec.h | ||
| version.h | ||
| x86-xstate.h | ||
| xml-utils.c | ||
| xml-utils.h | ||