mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
5d9310c4b8
This patch replaces VEC(static_tracepoint_marker_p) with std::vector, and does some c++ification around that. I thought a new overload of hex2str was useful, so I added it as well as corresponding unit tests. I also added an overload of ui_out::field_string that takes an std::string directly. gdb/ChangeLog: * tracepoint.h (struct static_tracepoint_marker): Initialize fields, define default constructor, move constructor and move assignment, disable the rest. <str_id, extra>: Make std::string. (release_static_tracepoint_marker): Remove. (free_current_marker): Remove. * tracepoint.c (free_current_marker): Remove. (parse_static_tracepoint_marker_definition): Adjust to std::string, use new hex2str overload. (release_static_tracepoint_marker): Remove. (print_one_static_tracepoint_marker): Get marker by reference and adjust to std::string. (info_static_tracepoint_markers_command): Adjust to std::vector changes * target.h (static_tracepoint_marker_p): Remove typedef. (DEF_VEC_P(static_tracepoint_marker_p)): Remove. (struct target_ops) <to_static_tracepoint_marker_at>: Return bool. <to_static_tracepoint_markers_by_strid>: Return std::vector. * target-debug.h (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove. (target_debug_print_std_vector_static_tracepoint_marker): New. (target_debug_print_struct_static_tracepoint_marker_p): Rename to... (target_debug_print_static_tracepoint_marker_p): ... this. * target-delegates.c: Re-generate. * breakpoint.h (struct tracepoint) <static_trace_marker_id>: Make std::string. * breakpoint.c (init_breakpoint_sal): Adjust to std::string. (decode_static_tracepoint_spec): Adjust to std::vector. (tracepoint_print_one_detail): Adjust to std::string. (strace_marker_decode_location): Adjust to std::string. (update_static_tracepoint): Adjust to std::string, remove call to release_static_tracepoint_marker. * linux-nat.c (linux_child_static_tracepoint_markers_by_strid): Adjust to std::vector. * remote.c (remote_static_tracepoint_marker_at): Return bool. (remote_static_tracepoint_markers_by_strid): Adjust to std::vector. * common/rsp-low.h (hex2str): New overload with explicit count of bytes. * common/rsp-low.c (hex2str): New overload with explicit count of bytes. * unittests/rsp-low-selftests.c (test_hex2str): New function. (_initialize_rsp_low_selftests): Add test_hex2str test. * unittests/tracepoint-selftests.c (test_parse_static_tracepoint_marker_definition): Adjust to std::string.
71 lines
2.2 KiB
C
71 lines
2.2 KiB
C
/* Self tests for tracepoint-related code for GDB, the GNU debugger.
|
|
|
|
Copyright (C) 2018 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "selftest.h"
|
|
#include "tracepoint.h"
|
|
|
|
namespace selftests {
|
|
namespace tracepoint_tests {
|
|
|
|
static void
|
|
test_parse_static_tracepoint_marker_definition ()
|
|
{
|
|
static_tracepoint_marker marker;
|
|
const char def[] = ("1234:6d61726b657231:6578747261207374756666,"
|
|
"abba:6d61726b657232:,"
|
|
"cafe:6d61726b657233:6d6f72657374756666");
|
|
const char *start = def;
|
|
const char *end;
|
|
|
|
parse_static_tracepoint_marker_definition (start, &end, &marker);
|
|
|
|
SELF_CHECK (marker.address == 0x1234);
|
|
SELF_CHECK (marker.str_id == "marker1");
|
|
SELF_CHECK (marker.extra == "extra stuff");
|
|
SELF_CHECK (end == strchr (start, ','));
|
|
|
|
start = end + 1;
|
|
parse_static_tracepoint_marker_definition (start, &end, &marker);
|
|
|
|
SELF_CHECK (marker.address == 0xabba);
|
|
SELF_CHECK (marker.str_id == "marker2");
|
|
SELF_CHECK (marker.extra == "");
|
|
SELF_CHECK (end == strchr (start, ','));
|
|
|
|
start = end + 1;
|
|
parse_static_tracepoint_marker_definition (start, &end, &marker);
|
|
|
|
SELF_CHECK (marker.address == 0xcafe);
|
|
SELF_CHECK (marker.str_id == "marker3");
|
|
SELF_CHECK (marker.extra == "morestuff");
|
|
SELF_CHECK (end == def + strlen (def));
|
|
}
|
|
|
|
} /* namespace tracepoint_tests */
|
|
} /* namespace selftests */
|
|
|
|
void
|
|
_initialize_tracepoint_selftests ()
|
|
{
|
|
selftests::register_test
|
|
("parse_static_tracepoint_marker_definition",
|
|
selftests::tracepoint_tests::test_parse_static_tracepoint_marker_definition);
|
|
}
|