mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-09 04:21:49 +08:00
252dcdf432
ppc64 ld optimises sequences like the following addis 3,13,wot@tprel@ha lwz 3,wot@tprel@l(3) to nop lwz 3,wot@tprel(13) when "wot" is located near enough to the thread pointer. However, the ABI doesn't require that R_PPC64_TPREL16_HA always be on an addis rt,13,imm instruction, and while ld checked for that on the high-part instruction it didn't disable the optimisation on the low-part instruction. This patch fixes that problem, disabling the tprel optimisation globally if high-part instructions don't pass sanity checks. The optimisation is also enabled for ppc32, where before ld.bfd had the code in the wrong place and ld.gold had it in a block only enabled for ppc64. bfd/ * elf32-ppc.c (ppc_elf_check_relocs): Set has_tls_reloc for high part tprel16 relocs. (ppc_elf_tls_optimize): Sanity check high part tprel16 relocs. Clear do_tls_opt on odd instructions. (ppc_elf_relocate_section): Move TPREL16_HA/LO optimisation later. Don't sanity check them here. * elf64-ppc.c (ppc64_elf_check_relocs): Set has_tls_reloc for high part tprel16 relocs. (ppc64_elf_tls_optimize): Sanity check high part tprel16 relocs. Clear do_tls_opt on odd instructions. (ppc64_elf_relocate_section): Don't sanity check TPREL16_HA. ld/ * testsuite/ld-powerpc/tls32.d: Update for TPREL_HA/LO optimisation. * testsuite/ld-powerpc/tlsexe32.d: Likewise. * testsuite/ld-powerpc/tlsldopt32.d: Likewise. * testsuite/ld-powerpc/tlsmark32.d: Likewise. * testsuite/ld-powerpc/tlsopt4_32.d: Likewise. * testsuite/ld-powerpc/tprel.s, * testsuite/ld-powerpc/tprel.d, * testsuite/ld-powerpc/tprel32.d: New tests. * testsuite/ld-powerpc/tprelbad.s, * testsuite/ld-powerpc/tprelbad.d: New test. * testsuite/ld-powerpc/powerpc.exp: Run them. gold/ * powerpc.cc (Target_powerpc): Add tprel_opt_ and accessors. (Target_powerpc::Scan::local): Sanity check tprel high relocs. (Target_powerpc::Scan::global): Likewise. (Target_powerpc::Relocate::relocate): Control tprel optimisation with tprel_opt_ and enable for 32-bit.
25 lines
681 B
Makefile
25 lines
681 B
Makefile
#source: tlsmark32.s
|
|
#source: tlslib32.s
|
|
#as: -a32
|
|
#ld:
|
|
#objdump: -dr
|
|
#target: powerpc*-*-*
|
|
|
|
.*
|
|
|
|
Disassembly of section \.text:
|
|
|
|
0+1800094 <_start>:
|
|
.*: (48 00 00 14|14 00 00 48) b 18000a8 <_start\+0x14>
|
|
.*: (38 62 90 00|00 90 62 38) addi r3,r2,-28672
|
|
.*: (80 83 00 00|00 00 83 80) lwz r4,0\(r3\)
|
|
.*: (60 00 00 00|00 00 00 60) nop
|
|
.*: (48 00 00 0c|0c 00 00 48) b 18000b0 <_start\+0x1c>
|
|
.*: (60 00 00 00|00 00 00 60) nop
|
|
.*: (4b ff ff ec|ec ff ff 4b) b 1800098 <_start\+0x4>
|
|
.*: (38 62 10 00|00 10 62 38) addi r3,r2,4096
|
|
.*: (80 83 80 00|00 80 83 80) lwz r4,-32768\(r3\)
|
|
|
|
0+18000b8 <__tls_get_addr>:
|
|
.*: (4e 80 00 20|20 00 80 4e) blr
|
|
#pass
|