mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-06 12:09:26 +08:00
4fc6c0d534
This changes attr_form_is_block to be a method. This is done separately because, unlike the other attribute functions, attr_form_is_block had special handling for the case where the argument was NULL. This required auditing each call site; in most cases, NULL was already ruled out, but in a few spots, an additional check was needed. gdb/ChangeLog 2020-02-08 Tom Tromey <tom@tromey.com> * dwarf2read.c (read_call_site_scope) (handle_data_member_location, dwarf2_add_member_fn) (mark_common_block_symbol_computed, read_common_block) (attr_to_dynamic_prop, partial_die_info::read) (var_decode_location, dwarf2_fetch_die_loc_sect_off) (dwarf2_symbol_mark_computed, set_die_type): Update. * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare method. (attr_form_is_block): Don't declare. * dwarf2/attribute.c (attribute::form_is_block): Now a method. Change-Id: Idfb290c61d738301ab991666f43e0b9cf577b2ae
122 lines
3.3 KiB
C
122 lines
3.3 KiB
C
/* DWARF attributes
|
|
|
|
Copyright (C) 1994-2020 Free Software Foundation, Inc.
|
|
|
|
Adapted by Gary Funck (gary@intrepid.com), Intrepid Technology,
|
|
Inc. with support from Florida State University (under contract
|
|
with the Ada Joint Program Office), and Silicon Graphics, Inc.
|
|
Initial contribution by Brent Benson, Harris Computer Systems, Inc.,
|
|
based on Fred Fish's (Cygnus Support) implementation of DWARF 1
|
|
support.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "dwarf2/attribute.h"
|
|
|
|
/* See attribute.h. */
|
|
|
|
CORE_ADDR
|
|
attribute::value_as_address () const
|
|
{
|
|
CORE_ADDR addr;
|
|
|
|
if (form != DW_FORM_addr && form != DW_FORM_addrx
|
|
&& form != DW_FORM_GNU_addr_index)
|
|
{
|
|
/* Aside from a few clearly defined exceptions, attributes that
|
|
contain an address must always be in DW_FORM_addr form.
|
|
Unfortunately, some compilers happen to be violating this
|
|
requirement by encoding addresses using other forms, such
|
|
as DW_FORM_data4 for example. For those broken compilers,
|
|
we try to do our best, without any guarantee of success,
|
|
to interpret the address correctly. It would also be nice
|
|
to generate a complaint, but that would require us to maintain
|
|
a list of legitimate cases where a non-address form is allowed,
|
|
as well as update callers to pass in at least the CU's DWARF
|
|
version. This is more overhead than what we're willing to
|
|
expand for a pretty rare case. */
|
|
addr = DW_UNSND (this);
|
|
}
|
|
else
|
|
addr = DW_ADDR (this);
|
|
|
|
return addr;
|
|
}
|
|
|
|
/* See attribute.h. */
|
|
|
|
bool
|
|
attribute::form_is_block () const
|
|
{
|
|
return (form == DW_FORM_block1
|
|
|| form == DW_FORM_block2
|
|
|| form == DW_FORM_block4
|
|
|| form == DW_FORM_block
|
|
|| form == DW_FORM_exprloc);
|
|
}
|
|
|
|
/* See attribute.h. */
|
|
|
|
bool
|
|
attribute::form_is_section_offset () const
|
|
{
|
|
return (form == DW_FORM_data4
|
|
|| form == DW_FORM_data8
|
|
|| form == DW_FORM_sec_offset);
|
|
}
|
|
|
|
/* See attribute.h. */
|
|
|
|
bool
|
|
attribute::form_is_constant () const
|
|
{
|
|
switch (form)
|
|
{
|
|
case DW_FORM_sdata:
|
|
case DW_FORM_udata:
|
|
case DW_FORM_data1:
|
|
case DW_FORM_data2:
|
|
case DW_FORM_data4:
|
|
case DW_FORM_data8:
|
|
case DW_FORM_implicit_const:
|
|
return true;
|
|
default:
|
|
return false;
|
|
}
|
|
}
|
|
|
|
/* DW_ADDR is always stored already as sect_offset; despite for the forms
|
|
besides DW_FORM_ref_addr it is stored as cu_offset in the DWARF file. */
|
|
|
|
bool
|
|
attribute::form_is_ref () const
|
|
{
|
|
switch (form)
|
|
{
|
|
case DW_FORM_ref_addr:
|
|
case DW_FORM_ref1:
|
|
case DW_FORM_ref2:
|
|
case DW_FORM_ref4:
|
|
case DW_FORM_ref8:
|
|
case DW_FORM_ref_udata:
|
|
case DW_FORM_GNU_ref_alt:
|
|
return true;
|
|
default:
|
|
return false;
|
|
}
|
|
}
|