Go to file
Andrew Burgess 86775fab42 gdb: fix debug expression dumping of function call expressions
In commit:

  commit 6d81691950
  CommitDate: Sat Sep 19 09:44:58 2020 +0100

    gdb/fortran: Move Fortran expression handling into f-lang.c

A bug was introduced that broke GDB's ability to perform debug dumps
of expressions containing function calls.  For example this would no
longer work:

  (gdb) set debug expression 1
  (gdb) print call_me (&val)
  Dump of expression @ 0x4eced60, before conversion to prefix form:
  	Language c, 12 elements, 16 bytes each.
  	Index                Opcode         Hex Value  String Value
  	    0          OP_VAR_VALUE  40  (...............
  	    1          OP_M2_STRING  79862864  P...............
  	    2   unknown opcode: 224  79862240  ................
  	    3          OP_VAR_VALUE  40  (...............
  	    4          OP_VAR_VALUE  40  (...............
  	    5         OP_RUST_ARRAY  79861600  `...............
  	    6     UNOP_PREDECREMENT  79861312  @...............
  	    7          OP_VAR_VALUE  40  (...............
  	    8             UNOP_ADDR  61  =...............
  	    9            OP_FUNCALL  46  ................
  	   10             BINOP_ADD  1  ................
  	   11            OP_FUNCALL  46  ................
  Dump of expression @ 0x4eced60, after conversion to prefix form:
  Expression: `call_me (&main::val, VAL(Aborted (core dumped)

The situation was even worse for Fortran function calls, or array
indexes, which both make use of the same expression opcode.

The problem was that in a couple of places the index into the
expression array was handled incorrectly causing GDB to interpret
elements incorrectly.  These issues are fixed in this commit.

There are already some tests to check GDB when 'set debug expression
1' is set, these can be found in gdb.*/debug-expr.exp.  Unfortunately
the cases above were not covered.

In this commit I have cleaned up all of the debug-expr.exp files a
little, there was a helper function that had clearly been copied into
each file, this is now moved into lib/gdb.exp.

I've added a gdb.fortran/debug-expr.exp test file, and extended
gdb.base/debug-expr.exp to cover the function call case.

gdb/ChangeLog:

	* expprint.c (print_subexp_funcall): Increment expression position
	after reading argument count.
	* f-lang.c (print_subexp_f): Skip over opcode before calling
	common function.
	(dump_subexp_body_f): Likewise.

gdb/testsuite/ChangeLog:

	* gdb.base/debug-expr.c: Add extra function to allow for an
	additional test.
	* gdb.base/debug-expr.exp (test_debug_expr): Delete, replace calls
	to this proc with gdb_test_debug_expr.  Add an extra test.
	* gdb.cp/debug-expr.exp (test_debug_expr): Delete, replace calls
	to this proc with gdb_test_debug_expr, give the tests names
	* gdb.dlang/debug-expr.exp (test_debug_expr): Delete, replace
	calls to this proc with gdb_test_debug_expr, give the tests names
	* gdb.fortran/debug-expr.exp: New file.
	* gdb.fortran/debug-expr.f90: New file.
	* lib/gdb.exp (gdb_test_debug_expr): New proc.
2020-11-06 20:58:06 +00:00
bfd Automatic date update in version.in 2020-11-06 00:00:16 +00:00
binutils elfedit: Update help message 2020-11-06 06:04:41 -08:00
config sync libiberty from gcc 2020-09-08 20:12:57 +09:30
contrib Import mklog.py from gcc repo 2020-09-25 10:24:44 -04:00
cpu Fix spelling mistakes 2020-10-05 14:20:15 +01:00
elfcpp gold: Update GNU_PROPERTY_X86_XXX macros 2020-10-13 05:21:05 -07:00
etc
gas aarch64: Update feature RAS system registers 2020-11-04 20:54:13 +00:00
gdb gdb: fix debug expression dumping of function call expressions 2020-11-06 20:58:06 +00:00
gdbserver gdb, gdbserver, gdbsupport: fix leading space vs tabs issues 2020-11-02 10:28:45 -05:00
gdbsupport gdb: use get_standard_config_dir when looking for .gdbinit 2020-11-02 17:42:11 +00:00
gnulib gnulib: Ensure all libraries are used when building gdb/gdbserver 2020-10-09 09:31:43 +01:00
gold PowerPC problem building gold with clang 2020-11-04 00:48:51 +10:30
gprof Unify Solaris procfs and largefile handling 2020-07-30 15:41:50 +02:00
include aarch64: Extract Pointer Authentication feature from Armv8.3-A 2020-11-06 13:14:14 +00:00
intl
ld Extend ld's -Map=<dir> functionality by allowing '%' to be replaced with the output file path. 2020-11-06 14:36:45 +00:00
libctf Remove libctf/mkerrors.sed 2020-10-21 11:52:17 -06:00
libdecnumber Run autoreconf -vf throughout 2020-07-29 16:03:55 -04:00
libiberty Sync libiberty and include with GCC for get_DW_UT_name. 2020-09-24 22:55:24 +02:00
opcodes aarch64: Extract Pointer Authentication feature from Armv8.3-A 2020-11-06 13:14:14 +00:00
readline Update readline/README to mention patchlevel 2020-06-30 15:17:07 -06:00
sim sim/bpf: re-generate configure 2020-11-01 19:39:11 -05:00
texinfo
zlib
.cvsignore
.gitattributes
.gitignore
ar-lib
ChangeLog Use sha256 for hashes in the release process 2020-10-28 10:35:28 -04:00
compile
config-ml.in
config.guess
config.rpath
config.sub
configure config/debuginfod.m4: Use PKG_CHECK_MODULES 2020-07-24 15:16:20 -04:00
configure.ac config/debuginfod.m4: Use PKG_CHECK_MODULES 2020-07-24 15:16:20 -04:00
COPYING
COPYING3
COPYING3.LIB
COPYING.LIB
COPYING.LIBGLOSS
COPYING.NEWLIB
depcomp
djunpack.bat
install-sh
libtool.m4
lt~obsolete.m4
ltgcc.m4
ltmain.sh
ltoptions.m4
ltsugar.m4
ltversion.m4
MAINTAINERS
Makefile.def gdb/gdbserver: add dependencies for distclean-gnulib 2020-10-14 15:05:14 +01:00
Makefile.in gdb/gdbserver: add dependencies for distclean-gnulib 2020-10-14 15:05:14 +01:00
Makefile.tpl
makefile.vms
missing
mkdep
mkinstalldirs
move-if-change
multilib.am
README
README-maintainer-mode
setup.com
src-release.sh Use sha256 for hashes in the release process 2020-10-28 10:35:28 -04:00
symlink-tree
test-driver
ylwrap

		   README for GNU development tools

This directory contains various GNU compilers, assemblers, linkers, 
debuggers, etc., plus their support routines, definitions, and documentation.

If you are receiving this as part of a GDB release, see the file gdb/README.
If with a binutils release, see binutils/README;  if with a libg++ release,
see libg++/README, etc.  That'll give you info about this
package -- supported targets, how to use it, how to report bugs, etc.

It is now possible to automatically configure and build a variety of
tools with one command.  To build all of the tools contained herein,
run the ``configure'' script here, e.g.:

	./configure 
	make

To install them (by default in /usr/local/bin, /usr/local/lib, etc),
then do:
	make install

(If the configure script can't determine your type of computer, give it
the name as an argument, for instance ``./configure sun4''.  You can
use the script ``config.sub'' to test whether a name is recognized; if
it is, config.sub translates it to a triplet specifying CPU, vendor,
and OS.)

If you have more than one compiler on your system, it is often best to
explicitly set CC in the environment before running configure, and to
also set CC when running make.  For example (assuming sh/bash/ksh):

	CC=gcc ./configure
	make

A similar example using csh:

	setenv CC gcc
	./configure
	make

Much of the code and documentation enclosed is copyright by
the Free Software Foundation, Inc.  See the file COPYING or
COPYING.LIB in the various directories, for a description of the
GNU General Public License terms under which you can copy the files.

REPORTING BUGS: Again, see gdb/README, binutils/README, etc., for info
on where and how to report problems.