mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-01-06 12:09:26 +08:00
Code Issues Packages Projects Releases Wiki Activity
8480a37e14
binutils-gdb/gdb/unittests
History
Simon Marchi 8480a37e14 gdb: pass frames as const frame_info_ptr & 
We currently pass frames to function by value, as `frame_info_ptr`.
This is somewhat expensive:

 - the size of `frame_info_ptr` is 64 bytes, which is a bit big to pass
   by value
 - the constructors and destructor link/unlink the object in the global
   `frame_info_ptr::frame_list` list.  This is an `intrusive_list`, so
   it's not so bad: it's just assigning a few points, there's no memory
   allocation as if it was `std::list`, but still it's useless to do
   that over and over.

As suggested by Tom Tromey, change many function signatures to accept
`const frame_info_ptr &` instead of `frame_info_ptr`.

Some functions reassign their `frame_info_ptr` parameter, like:

  void
  the_func (frame_info_ptr frame)
  {
    for (; frame != nullptr; frame = get_prev_frame (frame))
      {
        ...
      }
  }

I wondered what to do about them, do I leave them as-is or change them
(and need to introduce a separate local variable that can be
re-assigned).  I opted for the later for consistency.  It might not be
clear why some functions take `const frame_info_ptr &` while others take
`frame_info_ptr`.  Also, if a function took a `frame_info_ptr` because
it did re-assign its parameter, I doubt that we would think to change it
to `const frame_info_ptr &` should the implementation change such that
it doesn't need to take `frame_info_ptr` anymore.  It seems better to
have a simple rule and apply it everywhere.

Change-Id: I59d10addef687d157f82ccf4d54f5dde9a963fd0
Approved-By: Andrew Burgess <aburgess@redhat.com>
2024-02-20 10:42:25 -05:00
..
array-view-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
child-path-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
cli-utils-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
command-def-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
common-utils-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
copy_bitwise-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
enum-flags-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
environ-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
filtered_iterator-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
format_pieces-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
frame_info_ptr-selftests.c gdb: pass frames as const frame_info_ptr & 2024-02-20 10:42:25 -05:00
function-view-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
gdb_tilde_expand-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
gmp-utils-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
intrusive_list-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
lookup_name_info-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
main-thread-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
memory-map-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
memrange-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
mkdir-recursive-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
observable-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
offset-type-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
packed-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
parallel-for-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
parse-connection-spec-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
path-join-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
ptid-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
rsp-low-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
scoped_fd-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
scoped_ignore_signal-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
scoped_mmap-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
scoped_restore-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
search-memory-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
style-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
tracepoint-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
tui-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
ui-file-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
unique_xmalloc_ptr_char.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
unpack-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
utils-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
vec-utils-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00
xml-utils-selftests.c Update copyright year range in header of all files managed by GDB 2024-01-12 15:49:57 +00:00