Simon Marchi 8480a37e14 gdb: pass frames as const frame_info_ptr & ... We currently pass frames to function by value, as `frame_info_ptr`. This is somewhat expensive: - the size of `frame_info_ptr` is 64 bytes, which is a bit big to pass by value - the constructors and destructor link/unlink the object in the global `frame_info_ptr::frame_list` list. This is an `intrusive_list`, so it's not so bad: it's just assigning a few points, there's no memory allocation as if it was `std::list`, but still it's useless to do that over and over. As suggested by Tom Tromey, change many function signatures to accept `const frame_info_ptr &` instead of `frame_info_ptr`. Some functions reassign their `frame_info_ptr` parameter, like: void the_func (frame_info_ptr frame) { for (; frame != nullptr; frame = get_prev_frame (frame)) { ... } } I wondered what to do about them, do I leave them as-is or change them (and need to introduce a separate local variable that can be re-assigned). I opted for the later for consistency. It might not be clear why some functions take `const frame_info_ptr &` while others take `frame_info_ptr`. Also, if a function took a `frame_info_ptr` because it did re-assign its parameter, I doubt that we would think to change it to `const frame_info_ptr &` should the implementation change such that it doesn't need to take `frame_info_ptr` anymore. It seems better to have a simple rule and apply it everywhere. Change-Id: I59d10addef687d157f82ccf4d54f5dde9a963fd0 Approved-By: Andrew Burgess <aburgess@redhat.com>		2024-02-20 10:42:25 -05:00
..
ChangeLog-1999-2003
mi-cmd-break.c	Update copyright year range in header of all files managed by GDB	2024-01-12 15:49:57 +00:00
mi-cmd-break.h	Update copyright year range in header of all files managed by GDB	2024-01-12 15:49:57 +00:00
mi-cmd-catch.c	Update copyright year range in header of all files managed by GDB	2024-01-12 15:49:57 +00:00
mi-cmd-disas.c	Update copyright year range in header of all files managed by GDB	2024-01-12 15:49:57 +00:00
mi-cmd-env.c	Update copyright year range in header of all files managed by GDB	2024-01-12 15:49:57 +00:00
mi-cmd-file.c	gdb: rename struct shobj -> struct solib	2024-02-05 16:10:15 -05:00
mi-cmd-info.c	Update copyright year range in header of all files managed by GDB	2024-01-12 15:49:57 +00:00
mi-cmd-stack.c	gdb: pass frames as const frame_info_ptr &	2024-02-20 10:42:25 -05:00
mi-cmd-target.c	Update copyright year range in header of all files managed by GDB	2024-01-12 15:49:57 +00:00
mi-cmd-var.c	Update copyright year range in header of all files managed by GDB	2024-01-12 15:49:57 +00:00
mi-cmds.c	Update copyright year range in header of all files managed by GDB	2024-01-12 15:49:57 +00:00
mi-cmds.h	Update copyright year range in header of all files managed by GDB	2024-01-12 15:49:57 +00:00
mi-common.c	Update copyright year range in header of all files managed by GDB	2024-01-12 15:49:57 +00:00
mi-common.h	Update copyright year range in header of all files managed by GDB	2024-01-12 15:49:57 +00:00
mi-console.c	Update copyright year range in header of all files managed by GDB	2024-01-12 15:49:57 +00:00
mi-console.h	Update copyright year range in header of all files managed by GDB	2024-01-12 15:49:57 +00:00
mi-getopt.c	Update copyright year range in header of all files managed by GDB	2024-01-12 15:49:57 +00:00
mi-getopt.h	Update copyright year range in header of all files managed by GDB	2024-01-12 15:49:57 +00:00
mi-interp.c	gdb: rename struct shobj -> struct solib	2024-02-05 16:10:15 -05:00
mi-interp.h	gdb: rename struct shobj -> struct solib	2024-02-05 16:10:15 -05:00
mi-main.c	gdb: pass frames as const frame_info_ptr &	2024-02-20 10:42:25 -05:00
mi-main.h	Update copyright year range in header of all files managed by GDB	2024-01-12 15:49:57 +00:00
mi-out.c	Update copyright year range in header of all files managed by GDB	2024-01-12 15:49:57 +00:00
mi-out.h	gdb: Buffer output streams during events that might download debuginfo	2024-01-19 00:18:00 -05:00
mi-parse.c	Update copyright year range in header of all files managed by GDB	2024-01-12 15:49:57 +00:00
mi-parse.h	Update copyright year range in header of all files managed by GDB	2024-01-12 15:49:57 +00:00
mi-symbol-cmds.c	Replace search_domain with domain_search_flags	2024-01-28 10:58:16 -07:00