2
0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-01-18 12:24:38 +08:00
binutils-gdb/gdb/testsuite/gdb.threads/watchpoint-fork-mt.c
Tom de Vries ee2a6fc604 [gdb/testsuite] Fix gdb.threads/watchpoint-fork.exp race
I ran into:
...
Thread 3.1 "watchpoint-fork" hit Breakpoint 3, marker () at \
  watchpoint-fork-mt.c:42^M
42      }^M
(gdb) parent2: 1945^M

FAIL: gdb.threads/watchpoint-fork.exp: child: multithreaded: breakpoint (A) \
  after the second fork (timeout)
...
The problem is that the FAILing gdb_test expects '(gdb) ' to be the last thing
printed, but the inferior prints something after that.

A similar FAIL is described in the sources in watchpoint-fork-parent.c:
...
      printf ("child%d: %d\n", nr, (int) getpid ());
      /* Delay to get both the "child%d" and "parent%d" message printed
      	 without a race breaking expect by its endless wait on `$gdb_prompt$':
         Breakpoint 3, marker () at watchpoint-fork.c:33
         33      }
         (gdb) parent2: 14223  */
      i = sleep (1);
...

I noticed that while the executables print output, the output is not verified in
the test-case, so it's merely debug output.

Fix this by:
- guarding the prints in the executables (as well as related
  sleep and setbuf calls) with #if DEBUG, and
- compiling by default with DEBUG=0.

gdb/testsuite/ChangeLog:

2020-01-29  Tom de Vries  <tdevries@suse.de>

	* gdb.threads/watchpoint-fork-child.c: Guard prints with #if DEBUG.
	* gdb.threads/watchpoint-fork-mt.c: Same.
	* gdb.threads/watchpoint-fork-parent.c: Same.
	* gdb.threads/watchpoint-fork-st.c: Same.
	* gdb.threads/watchpoint-fork.exp: Compile with DEBUG=0.

Change-Id: I63efd4c7771f96b5f5cd87ef2ab36795484ae2be
2020-01-29 08:48:53 +01:00

175 lines
3.5 KiB
C

/* Test case for forgotten hw-watchpoints after fork()-off of a process.
Copyright 2012-2020 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program; if not, see <http://www.gnu.org/licenses/>. */
#include "watchpoint-fork.h"
#include <assert.h>
#include <unistd.h>
#include <sys/wait.h>
#include <stdio.h>
#include <stdlib.h>
#include <pthread.h>
#include <asm/unistd.h>
#include <unistd.h>
#define gettid() syscall (__NR_gettid)
/* Non-atomic `var++' should not hurt as we synchronize the threads by the STEP
variable. Hit-comments need to be duplicated there to catch both at-stops
and behind-stops, depending on the target. */
volatile int var;
void
marker (void)
{
}
static void
empty (void)
{
}
static void
mark_exit (void)
{
}
pthread_t thread;
volatile int step;
static void *
start (void *arg)
{
int i;
if (step >= 3)
goto step_3;
while (step != 1)
{
i = pthread_yield ();
assert (i == 0);
}
var++; /* validity-thread-B */
empty (); /* validity-thread-B */
step = 2;
while (step != 3)
{
if (step == 99)
goto step_99;
i = pthread_yield ();
assert (i == 0);
}
step_3:
if (step >= 5)
goto step_5;
var++; /* after-fork1-B */
empty (); /* after-fork1-B */
step = 4;
while (step != 5)
{
if (step == 99)
goto step_99;
i = pthread_yield ();
assert (i == 0);
}
step_5:
var++; /* after-fork2-B */
empty (); /* after-fork2-B */
return (void *) 5UL;
step_99:
/* We must not get caught here (against a forgotten breakpoint). */
var++;
marker ();
return (void *) 99UL;
}
int
main (void)
{
int i;
void *thread_result;
#if DEBUG
setbuf (stdout, NULL);
printf ("main: %d\n", (int) gettid ());
#endif
/* General hardware breakpoints and watchpoints validity. */
marker ();
var++; /* validity-first */
empty (); /* validity-first */
i = pthread_create (&thread, NULL, start, NULL);
assert (i == 0);
var++; /* validity-thread-A */
empty (); /* validity-thread-A */
step = 1;
while (step != 2)
{
i = pthread_yield ();
assert (i == 0);
}
/* Hardware watchpoints got disarmed here. */
forkoff (1);
var++; /* after-fork1-A */
empty (); /* after-fork1-A */
step = 3;
#ifdef FOLLOW_CHILD
/* Spawn new thread as it was deleted in the child of FORK. */
i = pthread_create (&thread, NULL, start, NULL);
assert (i == 0);
#endif
while (step != 4)
{
i = pthread_yield ();
assert (i == 0);
}
/* A sanity check for double hardware watchpoints removal. */
forkoff (2);
var++; /* after-fork2-A */
empty (); /* after-fork2-A */
step = 5;
#ifdef FOLLOW_CHILD
/* Spawn new thread as it was deleted in the child of FORK. */
i = pthread_create (&thread, NULL, start, NULL);
assert (i == 0);
#endif
i = pthread_join (thread, &thread_result);
assert (i == 0);
assert (thread_result == (void *) 5UL);
mark_exit ();
return 0;
}