mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
5068630ad3
I have patches that:
1 - make the CLI print stop info from a normal_stop observer, like MI
does.
2 - happen to change the order in which the Python and CLI/TUI
normal_stop observers are installed.
With those in place, py-events.exp regresses like shown below [1],
because the Python stop events are output before CLI prints stop info,
instead of after, and the test doesn't expect that.
With the same Python hooks, the order in which MI and Python events is
emited today is already undefined, because MI also uses the
normal_stop observer for output. I see no reason that we should in
general define the order observers, interpreters and scripting
languages get their turn at being notified of these events. So this
patch makes the test cope with Python->CLI output order too.
Tested on x86_64 Fedora 20.
gdb/testsuite/
2015-07-24 Pedro Alves <palves@redhat.com>
* gdb.python/py-events.exp: Accept output between the stop event
and the prompt.
* gdb.python/py-evsignal.exp: Likewise.
* gdb.python/py-evthreads.exp: Likewise.
[1] - The regressions in question look like:
Before said patches:
(gdb) continue
Continuing.
event type: continue
Breakpoint 2, first () at /home/pedro/gdb/mygit/build/../src/gdb/testsuite/gdb.python/py-events.c:30
30 for (i = 0; i < 2; i++)
event type: stop
event type: stop
stop reason: breakpoint
first breakpoint number: 2
breakpoint number: 2
breakpoint number: 3
all threads stopped
(gdb) PASS: gdb.python/py-events.exp: continue
After said patches:
(gdb) continue
Continuing.
event type: continue
event type: stop
event type: stop
stop reason: breakpoint
first breakpoint number: 2
breakpoint number: 2
breakpoint number: 3
all threads stopped
Breakpoint 2, first () at /home/pedro/gdb/mygit/build/../src/gdb/testsuite/gdb.python/py-events.c:30
30 for (i = 0; i < 2; i++)
(gdb) FAIL: gdb.python/py-events.exp: continue
|
||
|---|---|---|
| .. | ||
| amd64-py-framefilter-invalidarg.S | ||
| lib-types.cc | ||
| lib-types.exp | ||
| Makefile.in | ||
| py-arch.c | ||
| py-arch.exp | ||
| py-bad-printers.c | ||
| py-bad-printers.exp | ||
| py-bad-printers.py | ||
| py-block.c | ||
| py-block.exp | ||
| py-breakpoint.c | ||
| py-breakpoint.exp | ||
| py-caller-is.c | ||
| py-caller-is.exp | ||
| py-cmd.c | ||
| py-cmd.exp | ||
| py-completion.exp | ||
| py-completion.py | ||
| py-error.exp | ||
| py-error.py | ||
| py-events-shlib.c | ||
| py-events.c | ||
| py-events.exp | ||
| py-events.py | ||
| py-evsignal.exp | ||
| py-evthreads.c | ||
| py-evthreads.exp | ||
| py-explore-cc.exp | ||
| py-explore.c | ||
| py-explore.cc | ||
| py-explore.exp | ||
| py-finish-breakpoint2.cc | ||
| py-finish-breakpoint2.exp | ||
| py-finish-breakpoint2.py | ||
| py-finish-breakpoint.c | ||
| py-finish-breakpoint.exp | ||
| py-finish-breakpoint.py | ||
| py-frame-args.c | ||
| py-frame-args.exp | ||
| py-frame-args.py | ||
| py-frame-inline.c | ||
| py-frame-inline.exp | ||
| py-frame.c | ||
| py-frame.exp | ||
| py-framefilter-gdb.py.in | ||
| py-framefilter-invalidarg-gdb.py.in | ||
| py-framefilter-invalidarg.exp | ||
| py-framefilter-invalidarg.py | ||
| py-framefilter-mi.c | ||
| py-framefilter-mi.exp | ||
| py-framefilter.c | ||
| py-framefilter.exp | ||
| py-framefilter.py | ||
| py-function.exp | ||
| py-inferior.c | ||
| py-inferior.exp | ||
| py-infthread.c | ||
| py-infthread.exp | ||
| py-lazy-string.c | ||
| py-lazy-string.exp | ||
| py-linetable.c | ||
| py-linetable.exp | ||
| py-linetable.S | ||
| py-lookup-type.exp | ||
| py-mi.exp | ||
| py-objfile-script-gdb.py | ||
| py-objfile-script.c | ||
| py-objfile-script.exp | ||
| py-objfile.c | ||
| py-objfile.exp | ||
| py-parameter.exp | ||
| py-pp-integral.c | ||
| py-pp-integral.exp | ||
| py-pp-integral.py | ||
| py-pp-maint.c | ||
| py-pp-maint.exp | ||
| py-pp-maint.py | ||
| py-pp-re-notag.c | ||
| py-pp-re-notag.exp | ||
| py-pp-re-notag.py | ||
| py-pp-registration.c | ||
| py-pp-registration.exp | ||
| py-pp-registration.py | ||
| py-prettyprint.c | ||
| py-prettyprint.exp | ||
| py-prettyprint.py | ||
| py-progspace.c | ||
| py-progspace.exp | ||
| py-prompt.c | ||
| py-prompt.exp | ||
| py-section-script.c | ||
| py-section-script.exp | ||
| py-section-script.py | ||
| py-shared-sl.c | ||
| py-shared.c | ||
| py-shared.exp | ||
| py-strfns.c | ||
| py-strfns.exp | ||
| py-symbol.c | ||
| py-symbol.exp | ||
| py-symtab.exp | ||
| py-sync-interp.c | ||
| py-sync-interp.exp | ||
| py-template.cc | ||
| py-template.exp | ||
| py-type.c | ||
| py-type.exp | ||
| py-typeprint.cc | ||
| py-typeprint.exp | ||
| py-typeprint.py | ||
| py-unwind-maint.c | ||
| py-unwind-maint.exp | ||
| py-unwind-maint.py | ||
| py-unwind.c | ||
| py-unwind.exp | ||
| py-unwind.py | ||
| py-value-cc.cc | ||
| py-value-cc.exp | ||
| py-value.c | ||
| py-value.exp | ||
| py-xmethods.cc | ||
| py-xmethods.exp | ||
| py-xmethods.py | ||
| python-1.c | ||
| python.c | ||
| python.exp | ||
| source1 | ||
| source2.py | ||