mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-03 04:12:10 +08:00
a8651ef518
Since this commit:
commit 0ee6b1c511
Date: Wed May 18 13:32:04 2022 -0700
Use aarch64_features to describe register features in target descriptions.
There has been an issue with how aarch64 target descriptions are
cached within gdbserver, and specifically, how this caching impacts
the in process agent (IPA).
The function initialize_tracepoint_ftlib (gdbserver/tracepoint.cc) is
part of the IPA, this function is a constructor function, i.e. is
called as part of the global initialisation process. We can't
guarantee the ordering of when this function is called vs when other
global state is initialised.
Now initialize_tracepoint_ftlib calls initialize_tracepoint, which
calls initialize_low_tracepoint, which for aarch64 calls
aarch64_linux_read_description.
The aarch64_linux_read_description function lives in
linux-aarch64-tdesc.cc and after the above commit, depends on a
std::unordered_map having been initialized.
Prior to the above commit aarch64_linux_read_description used a global
C style array, which obviously requires no runtime initialization.
The consequence of the above is that any inferior linked with the IPA
(for aarch64) will experience undefined behaviour (access to an
uninitialized std::unordered_map) during startup, which for me
manifests as a segfault.
I propose fixing this by moving the std::unordered_map into the
function body, but leaving it static. The map will now be initialized
the first time the function is called, which removes the undefiend
behaviour.
The same problem exists for the expedited_registers global, however
this global can just be made into a function local instead. The
expedited_registers variable is used to build a pointer list which is
then passed to init_target_desc, however init_target_desc copies the
values it is given so expedited_registers does not need to live longer
than its containing function.
On most of the AArch64 machines I have access too tracing is not
supported, and so the gdb.trace/*.exp tests that use the IPA just exit
early reporting unsupported. I've added a test which links an
inferior with the IPA and just starts the inferior. No tracing is
performed. This exposes the current issue even on hosts that don't
support tracing. After this patch the test passes.
81 lines
2.7 KiB
C++
81 lines
2.7 KiB
C++
/* GNU/Linux/aarch64 specific target description, for the remote server
|
|
for GDB.
|
|
Copyright (C) 2017-2024 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
|
|
#include "linux-aarch64-tdesc.h"
|
|
|
|
#include "tdesc.h"
|
|
#include "arch/aarch64.h"
|
|
#include "linux-aarch32-low.h"
|
|
#include <inttypes.h>
|
|
#include <unordered_map>
|
|
|
|
/* Create the aarch64 target description. */
|
|
|
|
const target_desc *
|
|
aarch64_linux_read_description (const aarch64_features &features)
|
|
{
|
|
/* All possible aarch64 target descriptors. This map must live within
|
|
this function as the in-process-agent calls this function from a
|
|
constructor function, when globals might not yet have been
|
|
initialised. */
|
|
static std::unordered_map<aarch64_features, target_desc *> tdesc_aarch64_map;
|
|
|
|
if (features.vq > AARCH64_MAX_SVE_VQ)
|
|
error (_("VQ is %" PRIu64 ", maximum supported value is %d"), features.vq,
|
|
AARCH64_MAX_SVE_VQ);
|
|
|
|
if (features.svq > AARCH64_MAX_SVE_VQ)
|
|
error (_("Streaming svq is %" PRIu8 ", maximum supported value is %d"),
|
|
features.svq,
|
|
AARCH64_MAX_SVE_VQ);
|
|
|
|
struct target_desc *tdesc = tdesc_aarch64_map[features];
|
|
|
|
if (tdesc == NULL)
|
|
{
|
|
tdesc = aarch64_create_target_description (features);
|
|
|
|
/* Configure the expedited registers. By default we include x29, sp
|
|
and pc, but we allow for up to 6 pointers as this is (currently)
|
|
the most that we push.
|
|
|
|
Calling init_target_desc takes a copy of all the strings pointed
|
|
to by expedited_registers so this vector only needs to live for
|
|
the scope of this function. */
|
|
std::vector<const char *> expedited_registers (6);
|
|
expedited_registers.push_back ("x29");
|
|
expedited_registers.push_back ("sp");
|
|
expedited_registers.push_back ("pc");
|
|
|
|
if (features.vq > 0)
|
|
expedited_registers.push_back ("vg");
|
|
if (features.svq > 0)
|
|
expedited_registers.push_back ("svg");
|
|
|
|
expedited_registers.push_back (nullptr);
|
|
|
|
init_target_desc (tdesc, (const char **) expedited_registers.data ());
|
|
|
|
tdesc_aarch64_map[features] = tdesc;
|
|
}
|
|
|
|
return tdesc;
|
|
}
|