mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-09 04:21:49 +08:00
a3b60e4588
Some unaligned watchpoints were currently missed. On old kernels as specified in kernel RFE: aarch64: ptrace: BAS: Support any contiguous range (edit) https://sourceware.org/bugzilla/show_bug.cgi?id=20207 after this patch some other unaligned watchpoints will get reported as false positives. With new kernels all the watchpoints should work exactly. There may be a regresion that it now less merges watchpoints so that with multiple overlapping watchpoints it may run out of the 4 hardware watchpoint registers. But as discussed in the original thread GDB needs some generic watchpoints merging framework to be used by all the target specific code. Even current FSF GDB code does not merge it perfectly. Also with the more precise watchpoints one can technically merge them less. And I do not think it matters too much to improve mergeability only for old kernels. Still even on new kernels some better merging logic would make sense. There remains one issue: kernel-4.15.14-300.fc27.armv7hl FAIL: gdb.base/watchpoint-unaligned.exp: continue FAIL: gdb.base/watchpoint-unaligned.exp: continue (gdb) continue Continuing. Unexpected error setting watchpoint: Invalid argument. (gdb) FAIL: gdb.base/watchpoint-unaligned.exp: continue But that looks as a kernel bug to me. (1) It is not a regression by this patch. (2) It is unrelated to this patch. gdb/ChangeLog 2018-05-04 Jan Kratochvil <jan.kratochvil@redhat.com> Pedro Alves <palves@redhat.com> PR breakpoints/19806 and support for PR external/20207. * NEWS: Mention Aarch64 watchpoint improvements. * aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed watchpoints and PR external/20207 watchpoints. * nat/aarch64-linux-hw-point.c (kernel_supports_any_contiguous_range): New. (aarch64_watchpoint_offset): New. (aarch64_watchpoint_length): Support PR external/20207 watchpoints. (aarch64_point_encode_ctrl_reg): New parameter offset, new asserts. (aarch64_point_is_aligned): Support PR external/20207 watchpoints. (aarch64_align_watchpoint): New parameters aligned_offset_p and next_addr_orig_p. Support PR external/20207 watchpoints. (aarch64_downgrade_regs): New. (aarch64_dr_state_insert_one_point): New parameters offset and addr_orig. (aarch64_dr_state_remove_one_point): Likewise. (aarch64_handle_breakpoint): Update caller. (aarch64_handle_aligned_watchpoint): Likewise. (aarch64_handle_unaligned_watchpoint): Support addr_orig and aligned_offset. (aarch64_linux_set_debug_regs): Remove const from state. Call aarch64_downgrade_regs. (aarch64_show_debug_reg_state): Print also dr_addr_orig_wp. * nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ... (DR_CONTROL_MASK): ... this. (struct aarch64_debug_reg_state): New field dr_addr_orig_wp. (unsigned int aarch64_watchpoint_offset): New prototype. (aarch64_linux_set_debug_regs): Remove const from state. * utils.c (align_up, align_down): Move to ... * common/common-utils.c (align_up, align_down): ... here. * utils.h (align_up, align_down): Move to ... * common/common-utils.h (align_up, align_down): ... here. gdb/gdbserver/ChangeLog 2018-05-04 Jan Kratochvil <jan.kratochvil@redhat.com> Pedro Alves <palves@redhat.com> * linux-aarch64-low.c (aarch64_stopped_data_address): Likewise. gdb/testsuite/ChangeLog 2018-05-04 Jan Kratochvil <jan.kratochvil@redhat.com> Pedro Alves <palves@redhat.com> PR breakpoints/19806 and support for PR external/20207. * gdb.base/watchpoint-unaligned.c: New file. * gdb.base/watchpoint-unaligned.exp: New file.
527 lines
15 KiB
C++
527 lines
15 KiB
C++
/* *INDENT-OFF* */ /* ATTRIBUTE_PRINTF confuses indent, avoid running it
|
||
for now. */
|
||
/* I/O, string, cleanup, and other random utilities for GDB.
|
||
Copyright (C) 1986-2018 Free Software Foundation, Inc.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
#ifndef UTILS_H
|
||
#define UTILS_H
|
||
|
||
#include "exceptions.h"
|
||
#include "common/scoped_restore.h"
|
||
#include <chrono>
|
||
|
||
extern void initialize_utils (void);
|
||
|
||
/* String utilities. */
|
||
|
||
extern int sevenbit_strings;
|
||
|
||
/* Modes of operation for strncmp_iw_with_mode. */
|
||
|
||
enum class strncmp_iw_mode
|
||
{
|
||
/* Do a strcmp() type operation on STRING1 and STRING2, ignoring any
|
||
differences in whitespace. Returns 0 if they match, non-zero if
|
||
they don't (slightly different than strcmp()'s range of return
|
||
values). */
|
||
NORMAL,
|
||
|
||
/* Like NORMAL, but also apply the strcmp_iw hack. I.e.,
|
||
string1=="FOO(PARAMS)" matches string2=="FOO". */
|
||
MATCH_PARAMS,
|
||
};
|
||
|
||
/* Helper for strcmp_iw and strncmp_iw. Exported so that languages
|
||
can implement both NORMAL and MATCH_PARAMS variants in a single
|
||
function and defer part of the work to strncmp_iw_with_mode.
|
||
|
||
LANGUAGE is used to implement some context-sensitive
|
||
language-specific comparisons. For example, for C++,
|
||
"string1=operator()" should not match "string2=operator" even in
|
||
MATCH_PARAMS mode.
|
||
|
||
MATCH_FOR_LCD is passed down so that the function can mark parts of
|
||
the symbol name as ignored for completion matching purposes (e.g.,
|
||
to handle abi tags). */
|
||
extern int strncmp_iw_with_mode
|
||
(const char *string1, const char *string2, size_t string2_len,
|
||
strncmp_iw_mode mode, enum language language,
|
||
completion_match_for_lcd *match_for_lcd = NULL);
|
||
|
||
/* Do a strncmp() type operation on STRING1 and STRING2, ignoring any
|
||
differences in whitespace. STRING2_LEN is STRING2's length.
|
||
Returns 0 if STRING1 matches STRING2_LEN characters of STRING2,
|
||
non-zero otherwise (slightly different than strncmp()'s range of
|
||
return values). Note: passes language_minimal to
|
||
strncmp_iw_with_mode, and should therefore be avoided if a more
|
||
suitable language is available. */
|
||
extern int strncmp_iw (const char *string1, const char *string2,
|
||
size_t string2_len);
|
||
|
||
/* Do a strcmp() type operation on STRING1 and STRING2, ignoring any
|
||
differences in whitespace. Returns 0 if they match, non-zero if
|
||
they don't (slightly different than strcmp()'s range of return
|
||
values).
|
||
|
||
As an extra hack, string1=="FOO(ARGS)" matches string2=="FOO".
|
||
This "feature" is useful when searching for matching C++ function
|
||
names (such as if the user types 'break FOO', where FOO is a
|
||
mangled C++ function).
|
||
|
||
Note: passes language_minimal to strncmp_iw_with_mode, and should
|
||
therefore be avoided if a more suitable language is available. */
|
||
extern int strcmp_iw (const char *string1, const char *string2);
|
||
|
||
extern int strcmp_iw_ordered (const char *, const char *);
|
||
|
||
/* Return true if the strings are equal. */
|
||
|
||
extern bool streq (const char *, const char *);
|
||
|
||
/* A variant of streq that is suitable for use as an htab
|
||
callback. */
|
||
|
||
extern int streq_hash (const void *, const void *);
|
||
|
||
extern int subset_compare (const char *, const char *);
|
||
|
||
int compare_positive_ints (const void *ap, const void *bp);
|
||
|
||
/* Compare C strings for std::sort. */
|
||
|
||
static inline bool
|
||
compare_cstrings (const char *str1, const char *str2)
|
||
{
|
||
return strcmp (str1, str2) < 0;
|
||
}
|
||
|
||
/* A wrapper for bfd_errmsg to produce a more helpful error message
|
||
in the case of bfd_error_file_ambiguously recognized.
|
||
MATCHING, if non-NULL, is the corresponding argument to
|
||
bfd_check_format_matches, and will be freed. */
|
||
|
||
extern const char *gdb_bfd_errmsg (bfd_error_type error_tag, char **matching);
|
||
|
||
/* Reset the prompt_for_continue clock. */
|
||
void reset_prompt_for_continue_wait_time (void);
|
||
/* Return the time spent in prompt_for_continue. */
|
||
std::chrono::steady_clock::duration get_prompt_for_continue_wait_time ();
|
||
|
||
/* Parsing utilites. */
|
||
|
||
extern int parse_pid_to_attach (const char *args);
|
||
|
||
extern int parse_escape (struct gdbarch *, const char **);
|
||
|
||
/* A wrapper for an array of char* that was allocated in the way that
|
||
'buildargv' does, and should be freed with 'freeargv'. */
|
||
|
||
class gdb_argv
|
||
{
|
||
public:
|
||
|
||
/* A constructor that initializes to NULL. */
|
||
|
||
gdb_argv ()
|
||
: m_argv (NULL)
|
||
{
|
||
}
|
||
|
||
/* A constructor that calls buildargv on STR. STR may be NULL, in
|
||
which case this object is initialized with a NULL array. If
|
||
buildargv fails due to out-of-memory, call malloc_failure.
|
||
Therefore, the value is guaranteed to be non-NULL, unless the
|
||
parameter itself is NULL. */
|
||
|
||
explicit gdb_argv (const char *str)
|
||
: m_argv (NULL)
|
||
{
|
||
reset (str);
|
||
}
|
||
|
||
/* A constructor that takes ownership of an existing array. */
|
||
|
||
explicit gdb_argv (char **array)
|
||
: m_argv (array)
|
||
{
|
||
}
|
||
|
||
gdb_argv (const gdb_argv &) = delete;
|
||
gdb_argv &operator= (const gdb_argv &) = delete;
|
||
|
||
~gdb_argv ()
|
||
{
|
||
freeargv (m_argv);
|
||
}
|
||
|
||
/* Call buildargv on STR, storing the result in this object. Any
|
||
previous state is freed. STR may be NULL, in which case this
|
||
object is reset with a NULL array. If buildargv fails due to
|
||
out-of-memory, call malloc_failure. Therefore, the value is
|
||
guaranteed to be non-NULL, unless the parameter itself is
|
||
NULL. */
|
||
|
||
void reset (const char *str);
|
||
|
||
/* Return the underlying array. */
|
||
|
||
char **get ()
|
||
{
|
||
return m_argv;
|
||
}
|
||
|
||
/* Return the underlying array, transferring ownership to the
|
||
caller. */
|
||
|
||
char **release ()
|
||
{
|
||
char **result = m_argv;
|
||
m_argv = NULL;
|
||
return result;
|
||
}
|
||
|
||
/* Return the number of items in the array. */
|
||
|
||
int count () const
|
||
{
|
||
return countargv (m_argv);
|
||
}
|
||
|
||
/* Index into the array. */
|
||
|
||
char *operator[] (int arg)
|
||
{
|
||
gdb_assert (m_argv != NULL);
|
||
return m_argv[arg];
|
||
}
|
||
|
||
/* The iterator type. */
|
||
|
||
typedef char **iterator;
|
||
|
||
/* Return an iterator pointing to the start of the array. */
|
||
|
||
iterator begin ()
|
||
{
|
||
return m_argv;
|
||
}
|
||
|
||
/* Return an iterator pointing to the end of the array. */
|
||
|
||
iterator end ()
|
||
{
|
||
return m_argv + count ();
|
||
}
|
||
|
||
bool operator!= (std::nullptr_t)
|
||
{
|
||
return m_argv != NULL;
|
||
}
|
||
|
||
bool operator== (std::nullptr_t)
|
||
{
|
||
return m_argv == NULL;
|
||
}
|
||
|
||
private:
|
||
|
||
/* The wrapped array. */
|
||
|
||
char **m_argv;
|
||
};
|
||
|
||
|
||
/* Cleanup utilities. */
|
||
|
||
/* For make_cleanup_close see common/filestuff.h. */
|
||
|
||
extern struct cleanup *make_cleanup_value_free_to_mark (struct value *);
|
||
|
||
/* A deleter for a hash table. */
|
||
struct htab_deleter
|
||
{
|
||
void operator() (htab *ptr) const
|
||
{
|
||
htab_delete (ptr);
|
||
}
|
||
};
|
||
|
||
/* A unique_ptr wrapper for htab_t. */
|
||
typedef std::unique_ptr<htab, htab_deleter> htab_up;
|
||
|
||
extern void free_current_contents (void *);
|
||
|
||
extern void init_page_info (void);
|
||
|
||
/* Temporarily set BATCH_FLAG and the associated unlimited terminal size.
|
||
Restore when destroyed. */
|
||
|
||
struct set_batch_flag_and_restore_page_info
|
||
{
|
||
public:
|
||
|
||
set_batch_flag_and_restore_page_info ();
|
||
~set_batch_flag_and_restore_page_info ();
|
||
|
||
DISABLE_COPY_AND_ASSIGN (set_batch_flag_and_restore_page_info);
|
||
|
||
private:
|
||
|
||
/* Note that this doesn't use scoped_restore, because it's important
|
||
to control the ordering of operations in the destruction, and it
|
||
was simpler to avoid introducing a new ad hoc class. */
|
||
unsigned m_save_lines_per_page;
|
||
unsigned m_save_chars_per_line;
|
||
int m_save_batch_flag;
|
||
};
|
||
|
||
extern struct cleanup *make_bpstat_clear_actions_cleanup (void);
|
||
|
||
/* Path utilities. */
|
||
|
||
extern int gdb_filename_fnmatch (const char *pattern, const char *string,
|
||
int flags);
|
||
|
||
extern void substitute_path_component (char **stringp, const char *from,
|
||
const char *to);
|
||
|
||
std::string ldirname (const char *filename);
|
||
|
||
extern int count_path_elements (const char *path);
|
||
|
||
extern const char *strip_leading_path_elements (const char *path, int n);
|
||
|
||
/* GDB output, ui_file utilities. */
|
||
|
||
struct ui_file;
|
||
|
||
extern int query (const char *, ...) ATTRIBUTE_PRINTF (1, 2);
|
||
extern int nquery (const char *, ...) ATTRIBUTE_PRINTF (1, 2);
|
||
extern int yquery (const char *, ...) ATTRIBUTE_PRINTF (1, 2);
|
||
|
||
extern void begin_line (void);
|
||
|
||
extern void wrap_here (const char *);
|
||
|
||
extern void reinitialize_more_filter (void);
|
||
|
||
extern int pagination_enabled;
|
||
|
||
extern struct ui_file **current_ui_gdb_stdout_ptr (void);
|
||
extern struct ui_file **current_ui_gdb_stdin_ptr (void);
|
||
extern struct ui_file **current_ui_gdb_stderr_ptr (void);
|
||
extern struct ui_file **current_ui_gdb_stdlog_ptr (void);
|
||
|
||
/* The current top level's ui_file streams. */
|
||
|
||
/* Normal results */
|
||
#define gdb_stdout (*current_ui_gdb_stdout_ptr ())
|
||
/* Input stream */
|
||
#define gdb_stdin (*current_ui_gdb_stdin_ptr ())
|
||
/* Serious error notifications */
|
||
#define gdb_stderr (*current_ui_gdb_stderr_ptr ())
|
||
/* Log/debug/trace messages that should bypass normal stdout/stderr
|
||
filtering. For moment, always call this stream using
|
||
*_unfiltered. In the very near future that restriction shall be
|
||
removed - either call shall be unfiltered. (cagney 1999-06-13). */
|
||
#define gdb_stdlog (*current_ui_gdb_stdlog_ptr ())
|
||
|
||
/* Truly global ui_file streams. These are all defined in main.c. */
|
||
|
||
/* Target output that should bypass normal stdout/stderr filtering.
|
||
For moment, always call this stream using *_unfiltered. In the
|
||
very near future that restriction shall be removed - either call
|
||
shall be unfiltered. (cagney 1999-07-02). */
|
||
extern struct ui_file *gdb_stdtarg;
|
||
extern struct ui_file *gdb_stdtargerr;
|
||
extern struct ui_file *gdb_stdtargin;
|
||
|
||
/* Set the screen dimensions to WIDTH and HEIGHT. */
|
||
|
||
extern void set_screen_width_and_height (int width, int height);
|
||
|
||
/* More generic printf like operations. Filtered versions may return
|
||
non-locally on error. */
|
||
|
||
extern void fputs_filtered (const char *, struct ui_file *);
|
||
|
||
extern void fputs_unfiltered (const char *, struct ui_file *);
|
||
|
||
extern int fputc_filtered (int c, struct ui_file *);
|
||
|
||
extern int fputc_unfiltered (int c, struct ui_file *);
|
||
|
||
extern int putchar_filtered (int c);
|
||
|
||
extern int putchar_unfiltered (int c);
|
||
|
||
extern void puts_filtered (const char *);
|
||
|
||
extern void puts_unfiltered (const char *);
|
||
|
||
extern void puts_filtered_tabular (char *string, int width, int right);
|
||
|
||
extern void puts_debug (char *prefix, char *string, char *suffix);
|
||
|
||
extern void vprintf_filtered (const char *, va_list) ATTRIBUTE_PRINTF (1, 0);
|
||
|
||
extern void vfprintf_filtered (struct ui_file *, const char *, va_list)
|
||
ATTRIBUTE_PRINTF (2, 0);
|
||
|
||
extern void fprintf_filtered (struct ui_file *, const char *, ...)
|
||
ATTRIBUTE_PRINTF (2, 3);
|
||
|
||
extern void fprintfi_filtered (int, struct ui_file *, const char *, ...)
|
||
ATTRIBUTE_PRINTF (3, 4);
|
||
|
||
extern void printf_filtered (const char *, ...) ATTRIBUTE_PRINTF (1, 2);
|
||
|
||
extern void printfi_filtered (int, const char *, ...) ATTRIBUTE_PRINTF (2, 3);
|
||
|
||
extern void vprintf_unfiltered (const char *, va_list) ATTRIBUTE_PRINTF (1, 0);
|
||
|
||
extern void vfprintf_unfiltered (struct ui_file *, const char *, va_list)
|
||
ATTRIBUTE_PRINTF (2, 0);
|
||
|
||
extern void fprintf_unfiltered (struct ui_file *, const char *, ...)
|
||
ATTRIBUTE_PRINTF (2, 3);
|
||
|
||
extern void printf_unfiltered (const char *, ...) ATTRIBUTE_PRINTF (1, 2);
|
||
|
||
extern void print_spaces (int, struct ui_file *);
|
||
|
||
extern void print_spaces_filtered (int, struct ui_file *);
|
||
|
||
extern char *n_spaces (int);
|
||
|
||
extern void fputstr_filtered (const char *str, int quotr,
|
||
struct ui_file * stream);
|
||
|
||
extern void fputstr_unfiltered (const char *str, int quotr,
|
||
struct ui_file * stream);
|
||
|
||
extern void fputstrn_filtered (const char *str, int n, int quotr,
|
||
struct ui_file * stream);
|
||
|
||
typedef int (*do_fputc_ftype) (int c, ui_file *stream);
|
||
|
||
extern void fputstrn_unfiltered (const char *str, int n, int quotr,
|
||
do_fputc_ftype do_fputc,
|
||
struct ui_file * stream);
|
||
|
||
/* Return nonzero if filtered printing is initialized. */
|
||
extern int filtered_printing_initialized (void);
|
||
|
||
/* Display the host ADDR on STREAM formatted as ``0x%x''. */
|
||
extern void gdb_print_host_address_1 (const void *addr, struct ui_file *stream);
|
||
|
||
/* Wrapper that avoids adding a pointless cast to all callers. */
|
||
#define gdb_print_host_address(ADDR, STREAM) \
|
||
gdb_print_host_address_1 ((const void *) ADDR, STREAM)
|
||
|
||
/* Return the address only having significant bits. */
|
||
extern CORE_ADDR address_significant (gdbarch *gdbarch, CORE_ADDR addr);
|
||
|
||
/* Convert CORE_ADDR to string in platform-specific manner.
|
||
This is usually formatted similar to 0x%lx. */
|
||
extern const char *paddress (struct gdbarch *gdbarch, CORE_ADDR addr);
|
||
|
||
/* Return a string representation in hexadecimal notation of ADDRESS,
|
||
which is suitable for printing. */
|
||
|
||
extern const char *print_core_address (struct gdbarch *gdbarch,
|
||
CORE_ADDR address);
|
||
|
||
/* Callback hash_f and eq_f for htab_create_alloc or htab_create_alloc_ex. */
|
||
extern hashval_t core_addr_hash (const void *ap);
|
||
extern int core_addr_eq (const void *ap, const void *bp);
|
||
|
||
extern CORE_ADDR string_to_core_addr (const char *my_string);
|
||
|
||
extern void fprintf_symbol_filtered (struct ui_file *, const char *,
|
||
enum language, int);
|
||
|
||
extern void throw_perror_with_name (enum errors errcode, const char *string)
|
||
ATTRIBUTE_NORETURN;
|
||
|
||
extern void perror_warning_with_name (const char *string);
|
||
|
||
extern void print_sys_errmsg (const char *, int);
|
||
|
||
/* Warnings and error messages. */
|
||
|
||
extern void (*deprecated_error_begin_hook) (void);
|
||
|
||
/* Message to be printed before the warning message, when a warning occurs. */
|
||
|
||
extern const char *warning_pre_print;
|
||
|
||
extern void error_stream (const string_file &) ATTRIBUTE_NORETURN;
|
||
|
||
extern void demangler_vwarning (const char *file, int line,
|
||
const char *, va_list ap)
|
||
ATTRIBUTE_PRINTF (3, 0);
|
||
|
||
extern void demangler_warning (const char *file, int line,
|
||
const char *, ...) ATTRIBUTE_PRINTF (3, 4);
|
||
|
||
|
||
/* Misc. utilities. */
|
||
|
||
/* Allocation and deallocation functions for the libiberty hash table
|
||
which use obstacks. */
|
||
void *hashtab_obstack_allocate (void *data, size_t size, size_t count);
|
||
void dummy_obstack_deallocate (void *object, void *data);
|
||
|
||
#ifdef HAVE_WAITPID
|
||
extern pid_t wait_to_die_with_timeout (pid_t pid, int *status, int timeout);
|
||
#endif
|
||
|
||
extern int myread (int, char *, int);
|
||
|
||
/* Resource limits used by getrlimit and setrlimit. */
|
||
|
||
enum resource_limit_kind
|
||
{
|
||
LIMIT_CUR,
|
||
LIMIT_MAX
|
||
};
|
||
|
||
/* Check whether GDB will be able to dump core using the dump_core
|
||
function. Returns zero if GDB cannot or should not dump core.
|
||
If LIMIT_KIND is LIMIT_CUR the user's soft limit will be respected.
|
||
If LIMIT_KIND is LIMIT_MAX only the hard limit will be respected. */
|
||
|
||
extern int can_dump_core (enum resource_limit_kind limit_kind);
|
||
|
||
/* Print a warning that we cannot dump core. */
|
||
|
||
extern void warn_cant_dump_core (const char *reason);
|
||
|
||
/* Dump core trying to increase the core soft limit to hard limit
|
||
first. */
|
||
|
||
extern void dump_core (void);
|
||
|
||
/* Return the hex string form of LENGTH bytes of DATA.
|
||
Space for the result is malloc'd, caller must free. */
|
||
|
||
extern char *make_hex_string (const gdb_byte *data, size_t length);
|
||
|
||
#endif /* UTILS_H */
|