mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-15 04:31:49 +08:00
dda83cd783
Many spots incorrectly use only spaces for indentation (for example, there are a lot of spots in ada-lang.c). I've always found it awkward when I needed to edit one of these spots: do I keep the original wrong indentation, or do I fix it? What if the lines around it are also wrong, do I fix them too? I probably don't want to fix them in the same patch, to avoid adding noise to my patch. So I propose to fix as much as possible once and for all (hopefully). One typical counter argument for this is that it makes code archeology more difficult, because git-blame will show this commit as the last change for these lines. My counter counter argument is: when git-blaming, you often need to do "blame the file at the parent commit" anyway, to go past some other refactor that touched the line you are interested in, but is not the change you are looking for. So you already need a somewhat efficient way to do this. Using some interactive tool, rather than plain git-blame, makes this trivial. For example, I use "tig blame <file>", where going back past the commit that changed the currently selected line is one keystroke. It looks like Magit in Emacs does it too (though I've never used it). Web viewers of Github and Gitlab do it too. My point is that it won't really make archeology more difficult. The other typical counter argument is that it will cause conflicts with existing patches. That's true... but it's a one time cost, and those are not conflicts that are difficult to resolve. I have also tried "git rebase --ignore-whitespace", it seems to work well. Although that will re-introduce the faulty indentation, so one needs to take care of fixing the indentation in the patch after that (which is easy). gdb/ChangeLog: * aarch64-linux-tdep.c: Fix indentation. * aarch64-ravenscar-thread.c: Fix indentation. * aarch64-tdep.c: Fix indentation. * aarch64-tdep.h: Fix indentation. * ada-lang.c: Fix indentation. * ada-lang.h: Fix indentation. * ada-tasks.c: Fix indentation. * ada-typeprint.c: Fix indentation. * ada-valprint.c: Fix indentation. * ada-varobj.c: Fix indentation. * addrmap.c: Fix indentation. * addrmap.h: Fix indentation. * agent.c: Fix indentation. * aix-thread.c: Fix indentation. * alpha-bsd-nat.c: Fix indentation. * alpha-linux-tdep.c: Fix indentation. * alpha-mdebug-tdep.c: Fix indentation. * alpha-nbsd-tdep.c: Fix indentation. * alpha-obsd-tdep.c: Fix indentation. * alpha-tdep.c: Fix indentation. * amd64-bsd-nat.c: Fix indentation. * amd64-darwin-tdep.c: Fix indentation. * amd64-linux-nat.c: Fix indentation. * amd64-linux-tdep.c: Fix indentation. * amd64-nat.c: Fix indentation. * amd64-obsd-tdep.c: Fix indentation. * amd64-tdep.c: Fix indentation. * amd64-windows-tdep.c: Fix indentation. * annotate.c: Fix indentation. * arc-tdep.c: Fix indentation. * arch-utils.c: Fix indentation. * arch/arm-get-next-pcs.c: Fix indentation. * arch/arm.c: Fix indentation. * arm-linux-nat.c: Fix indentation. * arm-linux-tdep.c: Fix indentation. * arm-nbsd-tdep.c: Fix indentation. * arm-pikeos-tdep.c: Fix indentation. * arm-tdep.c: Fix indentation. * arm-tdep.h: Fix indentation. * arm-wince-tdep.c: Fix indentation. * auto-load.c: Fix indentation. * auxv.c: Fix indentation. * avr-tdep.c: Fix indentation. * ax-gdb.c: Fix indentation. * ax-general.c: Fix indentation. * bfin-linux-tdep.c: Fix indentation. * block.c: Fix indentation. * block.h: Fix indentation. * blockframe.c: Fix indentation. * bpf-tdep.c: Fix indentation. * break-catch-sig.c: Fix indentation. * break-catch-syscall.c: Fix indentation. * break-catch-throw.c: Fix indentation. * breakpoint.c: Fix indentation. * breakpoint.h: Fix indentation. * bsd-uthread.c: Fix indentation. * btrace.c: Fix indentation. * build-id.c: Fix indentation. * buildsym-legacy.h: Fix indentation. * buildsym.c: Fix indentation. * c-typeprint.c: Fix indentation. * c-valprint.c: Fix indentation. * c-varobj.c: Fix indentation. * charset.c: Fix indentation. * cli/cli-cmds.c: Fix indentation. * cli/cli-decode.c: Fix indentation. * cli/cli-decode.h: Fix indentation. * cli/cli-script.c: Fix indentation. * cli/cli-setshow.c: Fix indentation. * coff-pe-read.c: Fix indentation. * coffread.c: Fix indentation. * compile/compile-cplus-types.c: Fix indentation. * compile/compile-object-load.c: Fix indentation. * compile/compile-object-run.c: Fix indentation. * completer.c: Fix indentation. * corefile.c: Fix indentation. * corelow.c: Fix indentation. * cp-abi.h: Fix indentation. * cp-namespace.c: Fix indentation. * cp-support.c: Fix indentation. * cp-valprint.c: Fix indentation. * cris-linux-tdep.c: Fix indentation. * cris-tdep.c: Fix indentation. * darwin-nat-info.c: Fix indentation. * darwin-nat.c: Fix indentation. * darwin-nat.h: Fix indentation. * dbxread.c: Fix indentation. * dcache.c: Fix indentation. * disasm.c: Fix indentation. * dtrace-probe.c: Fix indentation. * dwarf2/abbrev.c: Fix indentation. * dwarf2/attribute.c: Fix indentation. * dwarf2/expr.c: Fix indentation. * dwarf2/frame.c: Fix indentation. * dwarf2/index-cache.c: Fix indentation. * dwarf2/index-write.c: Fix indentation. * dwarf2/line-header.c: Fix indentation. * dwarf2/loc.c: Fix indentation. * dwarf2/macro.c: Fix indentation. * dwarf2/read.c: Fix indentation. * dwarf2/read.h: Fix indentation. * elfread.c: Fix indentation. * eval.c: Fix indentation. * event-top.c: Fix indentation. * exec.c: Fix indentation. * exec.h: Fix indentation. * expprint.c: Fix indentation. * f-lang.c: Fix indentation. * f-typeprint.c: Fix indentation. * f-valprint.c: Fix indentation. * fbsd-nat.c: Fix indentation. * fbsd-tdep.c: Fix indentation. * findvar.c: Fix indentation. * fork-child.c: Fix indentation. * frame-unwind.c: Fix indentation. * frame-unwind.h: Fix indentation. * frame.c: Fix indentation. * frv-linux-tdep.c: Fix indentation. * frv-tdep.c: Fix indentation. * frv-tdep.h: Fix indentation. * ft32-tdep.c: Fix indentation. * gcore.c: Fix indentation. * gdb_bfd.c: Fix indentation. * gdbarch.sh: Fix indentation. * gdbarch.c: Re-generate * gdbarch.h: Re-generate. * gdbcore.h: Fix indentation. * gdbthread.h: Fix indentation. * gdbtypes.c: Fix indentation. * gdbtypes.h: Fix indentation. * glibc-tdep.c: Fix indentation. * gnu-nat.c: Fix indentation. * gnu-nat.h: Fix indentation. * gnu-v2-abi.c: Fix indentation. * gnu-v3-abi.c: Fix indentation. * go32-nat.c: Fix indentation. * guile/guile-internal.h: Fix indentation. * guile/scm-cmd.c: Fix indentation. * guile/scm-frame.c: Fix indentation. * guile/scm-iterator.c: Fix indentation. * guile/scm-math.c: Fix indentation. * guile/scm-ports.c: Fix indentation. * guile/scm-pretty-print.c: Fix indentation. * guile/scm-value.c: Fix indentation. * h8300-tdep.c: Fix indentation. * hppa-linux-nat.c: Fix indentation. * hppa-linux-tdep.c: Fix indentation. * hppa-nbsd-nat.c: Fix indentation. * hppa-nbsd-tdep.c: Fix indentation. * hppa-obsd-nat.c: Fix indentation. * hppa-tdep.c: Fix indentation. * hppa-tdep.h: Fix indentation. * i386-bsd-nat.c: Fix indentation. * i386-darwin-nat.c: Fix indentation. * i386-darwin-tdep.c: Fix indentation. * i386-dicos-tdep.c: Fix indentation. * i386-gnu-nat.c: Fix indentation. * i386-linux-nat.c: Fix indentation. * i386-linux-tdep.c: Fix indentation. * i386-nto-tdep.c: Fix indentation. * i386-obsd-tdep.c: Fix indentation. * i386-sol2-nat.c: Fix indentation. * i386-tdep.c: Fix indentation. * i386-tdep.h: Fix indentation. * i386-windows-tdep.c: Fix indentation. * i387-tdep.c: Fix indentation. * i387-tdep.h: Fix indentation. * ia64-libunwind-tdep.c: Fix indentation. * ia64-libunwind-tdep.h: Fix indentation. * ia64-linux-nat.c: Fix indentation. * ia64-linux-tdep.c: Fix indentation. * ia64-tdep.c: Fix indentation. * ia64-tdep.h: Fix indentation. * ia64-vms-tdep.c: Fix indentation. * infcall.c: Fix indentation. * infcmd.c: Fix indentation. * inferior.c: Fix indentation. * infrun.c: Fix indentation. * iq2000-tdep.c: Fix indentation. * language.c: Fix indentation. * linespec.c: Fix indentation. * linux-fork.c: Fix indentation. * linux-nat.c: Fix indentation. * linux-tdep.c: Fix indentation. * linux-thread-db.c: Fix indentation. * lm32-tdep.c: Fix indentation. * m2-lang.c: Fix indentation. * m2-typeprint.c: Fix indentation. * m2-valprint.c: Fix indentation. * m32c-tdep.c: Fix indentation. * m32r-linux-tdep.c: Fix indentation. * m32r-tdep.c: Fix indentation. * m68hc11-tdep.c: Fix indentation. * m68k-bsd-nat.c: Fix indentation. * m68k-linux-nat.c: Fix indentation. * m68k-linux-tdep.c: Fix indentation. * m68k-tdep.c: Fix indentation. * machoread.c: Fix indentation. * macrocmd.c: Fix indentation. * macroexp.c: Fix indentation. * macroscope.c: Fix indentation. * macrotab.c: Fix indentation. * macrotab.h: Fix indentation. * main.c: Fix indentation. * mdebugread.c: Fix indentation. * mep-tdep.c: Fix indentation. * mi/mi-cmd-catch.c: Fix indentation. * mi/mi-cmd-disas.c: Fix indentation. * mi/mi-cmd-env.c: Fix indentation. * mi/mi-cmd-stack.c: Fix indentation. * mi/mi-cmd-var.c: Fix indentation. * mi/mi-cmds.c: Fix indentation. * mi/mi-main.c: Fix indentation. * mi/mi-parse.c: Fix indentation. * microblaze-tdep.c: Fix indentation. * minidebug.c: Fix indentation. * minsyms.c: Fix indentation. * mips-linux-nat.c: Fix indentation. * mips-linux-tdep.c: Fix indentation. * mips-nbsd-tdep.c: Fix indentation. * mips-tdep.c: Fix indentation. * mn10300-linux-tdep.c: Fix indentation. * mn10300-tdep.c: Fix indentation. * moxie-tdep.c: Fix indentation. * msp430-tdep.c: Fix indentation. * namespace.h: Fix indentation. * nat/fork-inferior.c: Fix indentation. * nat/gdb_ptrace.h: Fix indentation. * nat/linux-namespaces.c: Fix indentation. * nat/linux-osdata.c: Fix indentation. * nat/netbsd-nat.c: Fix indentation. * nat/x86-dregs.c: Fix indentation. * nbsd-nat.c: Fix indentation. * nbsd-tdep.c: Fix indentation. * nios2-linux-tdep.c: Fix indentation. * nios2-tdep.c: Fix indentation. * nto-procfs.c: Fix indentation. * nto-tdep.c: Fix indentation. * objfiles.c: Fix indentation. * objfiles.h: Fix indentation. * opencl-lang.c: Fix indentation. * or1k-tdep.c: Fix indentation. * osabi.c: Fix indentation. * osabi.h: Fix indentation. * osdata.c: Fix indentation. * p-lang.c: Fix indentation. * p-typeprint.c: Fix indentation. * p-valprint.c: Fix indentation. * parse.c: Fix indentation. * ppc-linux-nat.c: Fix indentation. * ppc-linux-tdep.c: Fix indentation. * ppc-nbsd-nat.c: Fix indentation. * ppc-nbsd-tdep.c: Fix indentation. * ppc-obsd-nat.c: Fix indentation. * ppc-ravenscar-thread.c: Fix indentation. * ppc-sysv-tdep.c: Fix indentation. * ppc64-tdep.c: Fix indentation. * printcmd.c: Fix indentation. * proc-api.c: Fix indentation. * producer.c: Fix indentation. * producer.h: Fix indentation. * prologue-value.c: Fix indentation. * prologue-value.h: Fix indentation. * psymtab.c: Fix indentation. * python/py-arch.c: Fix indentation. * python/py-bpevent.c: Fix indentation. * python/py-event.c: Fix indentation. * python/py-event.h: Fix indentation. * python/py-finishbreakpoint.c: Fix indentation. * python/py-frame.c: Fix indentation. * python/py-framefilter.c: Fix indentation. * python/py-inferior.c: Fix indentation. * python/py-infthread.c: Fix indentation. * python/py-objfile.c: Fix indentation. * python/py-prettyprint.c: Fix indentation. * python/py-registers.c: Fix indentation. * python/py-signalevent.c: Fix indentation. * python/py-stopevent.c: Fix indentation. * python/py-stopevent.h: Fix indentation. * python/py-threadevent.c: Fix indentation. * python/py-tui.c: Fix indentation. * python/py-unwind.c: Fix indentation. * python/py-value.c: Fix indentation. * python/py-xmethods.c: Fix indentation. * python/python-internal.h: Fix indentation. * python/python.c: Fix indentation. * ravenscar-thread.c: Fix indentation. * record-btrace.c: Fix indentation. * record-full.c: Fix indentation. * record.c: Fix indentation. * reggroups.c: Fix indentation. * regset.h: Fix indentation. * remote-fileio.c: Fix indentation. * remote.c: Fix indentation. * reverse.c: Fix indentation. * riscv-linux-tdep.c: Fix indentation. * riscv-ravenscar-thread.c: Fix indentation. * riscv-tdep.c: Fix indentation. * rl78-tdep.c: Fix indentation. * rs6000-aix-tdep.c: Fix indentation. * rs6000-lynx178-tdep.c: Fix indentation. * rs6000-nat.c: Fix indentation. * rs6000-tdep.c: Fix indentation. * rust-lang.c: Fix indentation. * rx-tdep.c: Fix indentation. * s12z-tdep.c: Fix indentation. * s390-linux-tdep.c: Fix indentation. * score-tdep.c: Fix indentation. * ser-base.c: Fix indentation. * ser-mingw.c: Fix indentation. * ser-uds.c: Fix indentation. * ser-unix.c: Fix indentation. * serial.c: Fix indentation. * sh-linux-tdep.c: Fix indentation. * sh-nbsd-tdep.c: Fix indentation. * sh-tdep.c: Fix indentation. * skip.c: Fix indentation. * sol-thread.c: Fix indentation. * solib-aix.c: Fix indentation. * solib-darwin.c: Fix indentation. * solib-frv.c: Fix indentation. * solib-svr4.c: Fix indentation. * solib.c: Fix indentation. * source.c: Fix indentation. * sparc-linux-tdep.c: Fix indentation. * sparc-nbsd-tdep.c: Fix indentation. * sparc-obsd-tdep.c: Fix indentation. * sparc-ravenscar-thread.c: Fix indentation. * sparc-tdep.c: Fix indentation. * sparc64-linux-tdep.c: Fix indentation. * sparc64-nbsd-tdep.c: Fix indentation. * sparc64-obsd-tdep.c: Fix indentation. * sparc64-tdep.c: Fix indentation. * stabsread.c: Fix indentation. * stack.c: Fix indentation. * stap-probe.c: Fix indentation. * stubs/ia64vms-stub.c: Fix indentation. * stubs/m32r-stub.c: Fix indentation. * stubs/m68k-stub.c: Fix indentation. * stubs/sh-stub.c: Fix indentation. * stubs/sparc-stub.c: Fix indentation. * symfile-mem.c: Fix indentation. * symfile.c: Fix indentation. * symfile.h: Fix indentation. * symmisc.c: Fix indentation. * symtab.c: Fix indentation. * symtab.h: Fix indentation. * target-float.c: Fix indentation. * target.c: Fix indentation. * target.h: Fix indentation. * tic6x-tdep.c: Fix indentation. * tilegx-linux-tdep.c: Fix indentation. * tilegx-tdep.c: Fix indentation. * top.c: Fix indentation. * tracefile-tfile.c: Fix indentation. * tracepoint.c: Fix indentation. * tui/tui-disasm.c: Fix indentation. * tui/tui-io.c: Fix indentation. * tui/tui-regs.c: Fix indentation. * tui/tui-stack.c: Fix indentation. * tui/tui-win.c: Fix indentation. * tui/tui-winsource.c: Fix indentation. * tui/tui.c: Fix indentation. * typeprint.c: Fix indentation. * ui-out.h: Fix indentation. * unittests/copy_bitwise-selftests.c: Fix indentation. * unittests/memory-map-selftests.c: Fix indentation. * utils.c: Fix indentation. * v850-tdep.c: Fix indentation. * valarith.c: Fix indentation. * valops.c: Fix indentation. * valprint.c: Fix indentation. * valprint.h: Fix indentation. * value.c: Fix indentation. * value.h: Fix indentation. * varobj.c: Fix indentation. * vax-tdep.c: Fix indentation. * windows-nat.c: Fix indentation. * windows-tdep.c: Fix indentation. * xcoffread.c: Fix indentation. * xml-syscall.c: Fix indentation. * xml-tdesc.c: Fix indentation. * xstormy16-tdep.c: Fix indentation. * xtensa-config.c: Fix indentation. * xtensa-linux-nat.c: Fix indentation. * xtensa-linux-tdep.c: Fix indentation. * xtensa-tdep.c: Fix indentation. gdbserver/ChangeLog: * ax.cc: Fix indentation. * dll.cc: Fix indentation. * inferiors.h: Fix indentation. * linux-low.cc: Fix indentation. * linux-nios2-low.cc: Fix indentation. * linux-ppc-ipa.cc: Fix indentation. * linux-ppc-low.cc: Fix indentation. * linux-x86-low.cc: Fix indentation. * linux-xtensa-low.cc: Fix indentation. * regcache.cc: Fix indentation. * server.cc: Fix indentation. * tracepoint.cc: Fix indentation. gdbsupport/ChangeLog: * common-exceptions.h: Fix indentation. * event-loop.cc: Fix indentation. * fileio.cc: Fix indentation. * filestuff.cc: Fix indentation. * gdb-dlfcn.cc: Fix indentation. * gdb_string_view.h: Fix indentation. * job-control.cc: Fix indentation. * signals.cc: Fix indentation. Change-Id: I4bad7ae6be0fbe14168b8ebafb98ffe14964a695
707 lines
22 KiB
C
707 lines
22 KiB
C
/* Read the export table symbols from a portable executable and
|
||
convert to internal format, for GDB. Used as a last resort if no
|
||
debugging symbols recognized.
|
||
|
||
Copyright (C) 2003-2020 Free Software Foundation, Inc.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||
|
||
Contributed by Raoul M. Gough (RaoulGough@yahoo.co.uk). */
|
||
|
||
#include "defs.h"
|
||
|
||
#include "coff-pe-read.h"
|
||
|
||
#include "bfd.h"
|
||
#include "gdbtypes.h"
|
||
|
||
#include "command.h"
|
||
#include "gdbcmd.h"
|
||
#include "symtab.h"
|
||
#include "symfile.h"
|
||
#include "objfiles.h"
|
||
#include "gdbsupport/common-utils.h"
|
||
#include "coff/internal.h"
|
||
|
||
#include <ctype.h>
|
||
|
||
/* Internal section information */
|
||
|
||
/* Coff PE read debugging flag:
|
||
default value is 0,
|
||
value 1 outputs problems encountered while parsing PE file,
|
||
value above 1 also lists all generated minimal symbols. */
|
||
static unsigned int debug_coff_pe_read;
|
||
|
||
struct read_pe_section_data
|
||
{
|
||
CORE_ADDR vma_offset; /* Offset to loaded address of section. */
|
||
unsigned long rva_start; /* Start offset within the pe. */
|
||
unsigned long rva_end; /* End offset within the pe. */
|
||
enum minimal_symbol_type ms_type; /* Type to assign symbols in
|
||
section. */
|
||
unsigned int index; /* BFD section number. */
|
||
std::string section_name; /* Recorded section name. */
|
||
};
|
||
|
||
#define IMAGE_SCN_CNT_CODE 0x20
|
||
#define IMAGE_SCN_CNT_INITIALIZED_DATA 0x40
|
||
#define IMAGE_SCN_CNT_UNINITIALIZED_DATA 0x80
|
||
#define PE_SECTION_INDEX_TEXT 0
|
||
#define PE_SECTION_INDEX_DATA 1
|
||
#define PE_SECTION_INDEX_BSS 2
|
||
#define PE_SECTION_TABLE_SIZE 3
|
||
#define PE_SECTION_INDEX_INVALID -1
|
||
|
||
/* Get the index of the named section in our own array, which contains
|
||
text, data and bss in that order. Return PE_SECTION_INDEX_INVALID
|
||
if passed an unrecognised section name. */
|
||
|
||
static int
|
||
read_pe_section_index (const char *section_name)
|
||
{
|
||
if (strcmp (section_name, ".text") == 0)
|
||
{
|
||
return PE_SECTION_INDEX_TEXT;
|
||
}
|
||
|
||
else if (strcmp (section_name, ".data") == 0)
|
||
{
|
||
return PE_SECTION_INDEX_DATA;
|
||
}
|
||
|
||
else if (strcmp (section_name, ".bss") == 0)
|
||
{
|
||
return PE_SECTION_INDEX_BSS;
|
||
}
|
||
|
||
else
|
||
{
|
||
return PE_SECTION_INDEX_INVALID;
|
||
}
|
||
}
|
||
|
||
/* Get the index of the named section in our own full array.
|
||
text, data and bss in that order. Return PE_SECTION_INDEX_INVALID
|
||
if passed an unrecognised section name. */
|
||
|
||
static int
|
||
get_pe_section_index (const char *section_name,
|
||
struct read_pe_section_data *sections,
|
||
int nb_sections)
|
||
{
|
||
int i;
|
||
|
||
for (i = 0; i < nb_sections; i++)
|
||
if (sections[i].section_name == section_name)
|
||
return i;
|
||
return PE_SECTION_INDEX_INVALID;
|
||
}
|
||
|
||
/* Structure used by get_section_vmas function below
|
||
to access section_data array and the size of the array
|
||
stored in nb_sections field. */
|
||
struct pe_sections_info
|
||
{
|
||
int nb_sections;
|
||
struct read_pe_section_data *sections;
|
||
};
|
||
|
||
/* Record the virtual memory address of a section. */
|
||
|
||
static void
|
||
get_section_vmas (bfd *abfd, asection *sectp, void *context)
|
||
{
|
||
struct pe_sections_info *data = (struct pe_sections_info *) context;
|
||
struct read_pe_section_data *sections = data->sections;
|
||
int sectix = get_pe_section_index (sectp->name, sections,
|
||
data->nb_sections);
|
||
|
||
if (sectix != PE_SECTION_INDEX_INVALID)
|
||
{
|
||
/* Data within the section start at rva_start in the pe and at
|
||
bfd_get_section_vma() within memory. Store the offset. */
|
||
|
||
sections[sectix].vma_offset
|
||
= bfd_section_vma (sectp) - sections[sectix].rva_start;
|
||
}
|
||
}
|
||
|
||
/* Create a minimal symbol entry for an exported symbol.
|
||
SYM_NAME contains the exported name or NULL if exported by ordinal,
|
||
FUNC_RVA contains the Relative Virtual Address of the symbol,
|
||
ORDINAL is the ordinal index value of the symbol,
|
||
SECTION_DATA contains information about the section in which the
|
||
symbol is declared,
|
||
DLL_NAME is the internal name of the DLL file,
|
||
OBJFILE is the objfile struct of DLL_NAME. */
|
||
|
||
static void
|
||
add_pe_exported_sym (minimal_symbol_reader &reader,
|
||
const char *sym_name,
|
||
unsigned long func_rva,
|
||
int ordinal,
|
||
const struct read_pe_section_data *section_data,
|
||
const char *dll_name, struct objfile *objfile)
|
||
{
|
||
/* Add the stored offset to get the loaded address of the symbol. */
|
||
CORE_ADDR vma = func_rva + section_data->vma_offset;
|
||
|
||
/* Generate a (hopefully unique) qualified name using the first part
|
||
of the dll name, e.g. KERNEL32!AddAtomA. This matches the style
|
||
used by windbg from the "Microsoft Debugging Tools for Windows". */
|
||
|
||
std::string bare_name;
|
||
if (sym_name == NULL || *sym_name == '\0')
|
||
bare_name = string_printf ("#%d", ordinal);
|
||
else
|
||
bare_name = sym_name;
|
||
|
||
std::string qualified_name
|
||
= string_printf ("%s!%s", dll_name, bare_name.c_str ());
|
||
|
||
if ((section_data->ms_type == mst_unknown) && debug_coff_pe_read)
|
||
fprintf_unfiltered (gdb_stdlog , _("Unknown section type for \"%s\""
|
||
" for entry \"%s\" in dll \"%s\"\n"),
|
||
section_data->section_name.c_str (), sym_name,
|
||
dll_name);
|
||
|
||
reader.record_with_info (qualified_name.c_str (), vma, section_data->ms_type,
|
||
section_data->index);
|
||
|
||
/* Enter the plain name as well, which might not be unique. */
|
||
reader.record_with_info (bare_name.c_str (), vma, section_data->ms_type,
|
||
section_data->index);
|
||
if (debug_coff_pe_read > 1)
|
||
fprintf_unfiltered (gdb_stdlog, _("Adding exported symbol \"%s\""
|
||
" in dll \"%s\"\n"), sym_name, dll_name);
|
||
}
|
||
|
||
/* Create a minimal symbol entry for an exported forward symbol.
|
||
Return 1 if the forwarded function was found 0 otherwise.
|
||
SYM_NAME contains the exported name or NULL if exported by ordinal,
|
||
FORWARD_DLL_NAME is the name of the DLL in which the target symobl resides,
|
||
FORWARD_FUNC_NAME is the name of the target symbol in that DLL,
|
||
ORDINAL is the ordinal index value of the symbol,
|
||
DLL_NAME is the internal name of the DLL file,
|
||
OBJFILE is the objfile struct of DLL_NAME. */
|
||
|
||
static int
|
||
add_pe_forwarded_sym (minimal_symbol_reader &reader,
|
||
const char *sym_name, const char *forward_dll_name,
|
||
const char *forward_func_name, int ordinal,
|
||
const char *dll_name, struct objfile *objfile)
|
||
{
|
||
CORE_ADDR vma, baseaddr;
|
||
struct bound_minimal_symbol msymbol;
|
||
enum minimal_symbol_type msymtype;
|
||
int forward_dll_name_len = strlen (forward_dll_name);
|
||
int forward_func_name_len = strlen (forward_func_name);
|
||
int forward_len = forward_dll_name_len + forward_func_name_len + 2;
|
||
char *forward_qualified_name = (char *) alloca (forward_len);
|
||
short section;
|
||
|
||
xsnprintf (forward_qualified_name, forward_len, "%s!%s", forward_dll_name,
|
||
forward_func_name);
|
||
|
||
|
||
msymbol = lookup_bound_minimal_symbol (forward_qualified_name);
|
||
|
||
if (!msymbol.minsym)
|
||
{
|
||
int i;
|
||
|
||
for (i = 0; i < forward_dll_name_len; i++)
|
||
forward_qualified_name[i] = tolower (forward_qualified_name[i]);
|
||
msymbol = lookup_bound_minimal_symbol (forward_qualified_name);
|
||
}
|
||
|
||
if (!msymbol.minsym)
|
||
{
|
||
if (debug_coff_pe_read)
|
||
fprintf_unfiltered (gdb_stdlog, _("Unable to find function \"%s\" in"
|
||
" dll \"%s\", forward of \"%s\" in dll \"%s\"\n"),
|
||
forward_func_name, forward_dll_name, sym_name,
|
||
dll_name);
|
||
return 0;
|
||
}
|
||
|
||
if (debug_coff_pe_read > 1)
|
||
fprintf_unfiltered (gdb_stdlog, _("Adding forwarded exported symbol"
|
||
" \"%s\" in dll \"%s\", pointing to \"%s\"\n"),
|
||
sym_name, dll_name, forward_qualified_name);
|
||
|
||
vma = BMSYMBOL_VALUE_ADDRESS (msymbol);
|
||
msymtype = MSYMBOL_TYPE (msymbol.minsym);
|
||
section = MSYMBOL_SECTION (msymbol.minsym);
|
||
|
||
/* Generate a (hopefully unique) qualified name using the first part
|
||
of the dll name, e.g. KERNEL32!AddAtomA. This matches the style
|
||
used by windbg from the "Microsoft Debugging Tools for Windows". */
|
||
|
||
std::string bare_name;
|
||
if (sym_name == NULL || *sym_name == '\0')
|
||
bare_name = string_printf ("#%d", ordinal);
|
||
else
|
||
bare_name = sym_name;
|
||
|
||
std::string qualified_name
|
||
= string_printf ("%s!%s", dll_name, bare_name.c_str ());
|
||
|
||
/* Note that this code makes a minimal symbol whose value may point
|
||
outside of any section in this objfile. These symbols can't
|
||
really be relocated properly, but nevertheless we make a stab at
|
||
it, choosing an approach consistent with the history of this
|
||
code. */
|
||
baseaddr = objfile->text_section_offset ();
|
||
|
||
reader.record_with_info (qualified_name.c_str (), vma - baseaddr, msymtype,
|
||
section);
|
||
|
||
/* Enter the plain name as well, which might not be unique. */
|
||
reader.record_with_info (bare_name.c_str(), vma - baseaddr, msymtype,
|
||
section);
|
||
|
||
return 1;
|
||
}
|
||
|
||
/* Truncate a dll_name at the last dot character. */
|
||
|
||
static void
|
||
read_pe_truncate_name (char *dll_name)
|
||
{
|
||
char *last_point = strrchr (dll_name, '.');
|
||
|
||
if (last_point != NULL)
|
||
*last_point = '\0';
|
||
}
|
||
|
||
/* Low-level support functions, direct from the ld module pe-dll.c. */
|
||
static unsigned int
|
||
pe_get16 (bfd *abfd, int where)
|
||
{
|
||
unsigned char b[2];
|
||
|
||
bfd_seek (abfd, (file_ptr) where, SEEK_SET);
|
||
bfd_bread (b, (bfd_size_type) 2, abfd);
|
||
return b[0] + (b[1] << 8);
|
||
}
|
||
|
||
static unsigned int
|
||
pe_get32 (bfd *abfd, int where)
|
||
{
|
||
unsigned char b[4];
|
||
|
||
bfd_seek (abfd, (file_ptr) where, SEEK_SET);
|
||
bfd_bread (b, (bfd_size_type) 4, abfd);
|
||
return b[0] + (b[1] << 8) + (b[2] << 16) + (b[3] << 24);
|
||
}
|
||
|
||
static unsigned int
|
||
pe_as16 (void *ptr)
|
||
{
|
||
unsigned char *b = (unsigned char *) ptr;
|
||
|
||
return b[0] + (b[1] << 8);
|
||
}
|
||
|
||
static unsigned int
|
||
pe_as32 (void *ptr)
|
||
{
|
||
unsigned char *b = (unsigned char *) ptr;
|
||
|
||
return b[0] + (b[1] << 8) + (b[2] << 16) + (b[3] << 24);
|
||
}
|
||
|
||
/* Read the (non-debug) export symbol table from a portable
|
||
executable. Code originally lifted from the ld function
|
||
pe_implied_import_dll in pe-dll.c. */
|
||
|
||
void
|
||
read_pe_exported_syms (minimal_symbol_reader &reader,
|
||
struct objfile *objfile)
|
||
{
|
||
bfd *dll = objfile->obfd;
|
||
unsigned long nbnormal, nbforward;
|
||
unsigned long pe_header_offset, opthdr_ofs, num_entries, i;
|
||
unsigned long export_opthdrrva, export_opthdrsize;
|
||
unsigned long export_rva, export_size, nsections, secptr, expptr;
|
||
unsigned long exp_funcbase;
|
||
unsigned char *expdata, *erva;
|
||
unsigned long name_rvas, ordinals, nexp, ordbase;
|
||
char *dll_name = (char *) bfd_get_filename (dll);
|
||
int otherix = PE_SECTION_TABLE_SIZE;
|
||
int is_pe64 = 0;
|
||
int is_pe32 = 0;
|
||
|
||
/* Array elements are for text, data and bss in that order
|
||
Initialization with RVA_START > RVA_END guarantees that
|
||
unused sections won't be matched. */
|
||
struct pe_sections_info pe_sections_info;
|
||
|
||
char const *target = bfd_get_target (objfile->obfd);
|
||
|
||
std::vector<struct read_pe_section_data> section_data
|
||
(PE_SECTION_TABLE_SIZE);
|
||
|
||
for (i=0; i < PE_SECTION_TABLE_SIZE; i++)
|
||
{
|
||
section_data[i].vma_offset = 0;
|
||
section_data[i].rva_start = 1;
|
||
section_data[i].rva_end = 0;
|
||
};
|
||
section_data[PE_SECTION_INDEX_TEXT].ms_type = mst_text;
|
||
section_data[PE_SECTION_INDEX_TEXT].section_name = ".text";
|
||
section_data[PE_SECTION_INDEX_DATA].ms_type = mst_data;
|
||
section_data[PE_SECTION_INDEX_DATA].section_name = ".data";
|
||
section_data[PE_SECTION_INDEX_BSS].ms_type = mst_bss;
|
||
section_data[PE_SECTION_INDEX_BSS].section_name = ".bss";
|
||
|
||
is_pe64 = (strcmp (target, "pe-x86-64") == 0
|
||
|| strcmp (target, "pei-x86-64") == 0);
|
||
is_pe32 = (strcmp (target, "pe-i386") == 0
|
||
|| strcmp (target, "pei-i386") == 0
|
||
|| strcmp (target, "pe-arm-wince-little") == 0
|
||
|| strcmp (target, "pei-arm-wince-little") == 0);
|
||
if (!is_pe32 && !is_pe64)
|
||
{
|
||
/* This is not a recognized PE format file. Abort now, because
|
||
the code is untested on anything else. *FIXME* test on
|
||
further architectures and loosen or remove this test. */
|
||
return;
|
||
}
|
||
|
||
/* Get pe_header, optional header and numbers of export entries. */
|
||
pe_header_offset = pe_get32 (dll, 0x3c);
|
||
opthdr_ofs = pe_header_offset + 4 + 20;
|
||
if (is_pe64)
|
||
num_entries = pe_get32 (dll, opthdr_ofs + 108);
|
||
else
|
||
num_entries = pe_get32 (dll, opthdr_ofs + 92);
|
||
|
||
if (num_entries < 1) /* No exports. */
|
||
return;
|
||
if (is_pe64)
|
||
{
|
||
export_opthdrrva = pe_get32 (dll, opthdr_ofs + 112);
|
||
export_opthdrsize = pe_get32 (dll, opthdr_ofs + 116);
|
||
}
|
||
else
|
||
{
|
||
export_opthdrrva = pe_get32 (dll, opthdr_ofs + 96);
|
||
export_opthdrsize = pe_get32 (dll, opthdr_ofs + 100);
|
||
}
|
||
nsections = pe_get16 (dll, pe_header_offset + 4 + 2);
|
||
secptr = (pe_header_offset + 4 + 20 +
|
||
pe_get16 (dll, pe_header_offset + 4 + 16));
|
||
expptr = 0;
|
||
export_size = 0;
|
||
|
||
/* Get the rva and size of the export section. */
|
||
for (i = 0; i < nsections; i++)
|
||
{
|
||
char sname[8];
|
||
unsigned long secptr1 = secptr + 40 * i;
|
||
unsigned long vaddr = pe_get32 (dll, secptr1 + 12);
|
||
unsigned long vsize = pe_get32 (dll, secptr1 + 16);
|
||
unsigned long fptr = pe_get32 (dll, secptr1 + 20);
|
||
|
||
bfd_seek (dll, (file_ptr) secptr1, SEEK_SET);
|
||
bfd_bread (sname, (bfd_size_type) sizeof (sname), dll);
|
||
|
||
if ((strcmp (sname, ".edata") == 0)
|
||
|| (vaddr <= export_opthdrrva && export_opthdrrva < vaddr + vsize))
|
||
{
|
||
if (strcmp (sname, ".edata") != 0)
|
||
{
|
||
if (debug_coff_pe_read)
|
||
fprintf_unfiltered (gdb_stdlog, _("Export RVA for dll "
|
||
"\"%s\" is in section \"%s\"\n"),
|
||
dll_name, sname);
|
||
}
|
||
else if (export_opthdrrva != vaddr && debug_coff_pe_read)
|
||
fprintf_unfiltered (gdb_stdlog, _("Wrong value of export RVA"
|
||
" for dll \"%s\": 0x%lx instead of 0x%lx\n"),
|
||
dll_name, export_opthdrrva, vaddr);
|
||
expptr = fptr + (export_opthdrrva - vaddr);
|
||
break;
|
||
}
|
||
}
|
||
|
||
if (expptr == 0)
|
||
{
|
||
/* no section contains export table rva */
|
||
return;
|
||
}
|
||
|
||
export_rva = export_opthdrrva;
|
||
export_size = export_opthdrsize;
|
||
|
||
if (export_size == 0)
|
||
{
|
||
/* Empty export table. */
|
||
return;
|
||
}
|
||
|
||
/* Scan sections and store the base and size of the relevant
|
||
sections. */
|
||
for (i = 0; i < nsections; i++)
|
||
{
|
||
unsigned long secptr1 = secptr + 40 * i;
|
||
unsigned long vsize = pe_get32 (dll, secptr1 + 8);
|
||
unsigned long vaddr = pe_get32 (dll, secptr1 + 12);
|
||
unsigned long characteristics = pe_get32 (dll, secptr1 + 36);
|
||
char sec_name[SCNNMLEN + 1];
|
||
int sectix;
|
||
unsigned int bfd_section_index;
|
||
asection *section;
|
||
|
||
bfd_seek (dll, (file_ptr) secptr1 + 0, SEEK_SET);
|
||
bfd_bread (sec_name, (bfd_size_type) SCNNMLEN, dll);
|
||
sec_name[SCNNMLEN] = '\0';
|
||
|
||
sectix = read_pe_section_index (sec_name);
|
||
section = bfd_get_section_by_name (dll, sec_name);
|
||
if (section)
|
||
bfd_section_index = section->index;
|
||
else
|
||
bfd_section_index = -1;
|
||
|
||
if (sectix != PE_SECTION_INDEX_INVALID)
|
||
{
|
||
section_data[sectix].rva_start = vaddr;
|
||
section_data[sectix].rva_end = vaddr + vsize;
|
||
section_data[sectix].index = bfd_section_index;
|
||
}
|
||
else
|
||
{
|
||
section_data.resize (otherix + 1);
|
||
section_data[otherix].section_name = sec_name;
|
||
section_data[otherix].rva_start = vaddr;
|
||
section_data[otherix].rva_end = vaddr + vsize;
|
||
section_data[otherix].vma_offset = 0;
|
||
section_data[otherix].index = bfd_section_index;
|
||
if (characteristics & IMAGE_SCN_CNT_CODE)
|
||
section_data[otherix].ms_type = mst_text;
|
||
else if (characteristics & IMAGE_SCN_CNT_INITIALIZED_DATA)
|
||
section_data[otherix].ms_type = mst_data;
|
||
else if (characteristics & IMAGE_SCN_CNT_UNINITIALIZED_DATA)
|
||
section_data[otherix].ms_type = mst_bss;
|
||
else
|
||
section_data[otherix].ms_type = mst_unknown;
|
||
otherix++;
|
||
}
|
||
}
|
||
|
||
gdb::def_vector<unsigned char> expdata_storage (export_size);
|
||
expdata = expdata_storage.data ();
|
||
|
||
bfd_seek (dll, (file_ptr) expptr, SEEK_SET);
|
||
bfd_bread (expdata, (bfd_size_type) export_size, dll);
|
||
erva = expdata - export_rva;
|
||
|
||
nexp = pe_as32 (expdata + 24);
|
||
name_rvas = pe_as32 (expdata + 32);
|
||
ordinals = pe_as32 (expdata + 36);
|
||
ordbase = pe_as32 (expdata + 16);
|
||
exp_funcbase = pe_as32 (expdata + 28);
|
||
|
||
/* Use internal dll name instead of full pathname. */
|
||
dll_name = (char *) (pe_as32 (expdata + 12) + erva);
|
||
|
||
pe_sections_info.nb_sections = otherix;
|
||
pe_sections_info.sections = section_data.data ();
|
||
|
||
bfd_map_over_sections (dll, get_section_vmas, &pe_sections_info);
|
||
|
||
/* Truncate name at first dot. Should maybe also convert to all
|
||
lower case for convenience on Windows. */
|
||
read_pe_truncate_name (dll_name);
|
||
|
||
if (debug_coff_pe_read)
|
||
fprintf_unfiltered (gdb_stdlog, _("DLL \"%s\" has %ld export entries,"
|
||
" base=%ld\n"), dll_name, nexp, ordbase);
|
||
nbforward = 0;
|
||
nbnormal = 0;
|
||
/* Iterate through the list of symbols. */
|
||
for (i = 0; i < nexp; i++)
|
||
{
|
||
/* Pointer to the names vector. */
|
||
unsigned long name_rva = pe_as32 (erva + name_rvas + i * 4);
|
||
/* Retrieve ordinal value. */
|
||
|
||
unsigned long ordinal = pe_as16 (erva + ordinals + i * 2);
|
||
|
||
|
||
/* Pointer to the function address vector. */
|
||
/* This is relative to ordinal value. */
|
||
unsigned long func_rva = pe_as32 (erva + exp_funcbase +
|
||
ordinal * 4);
|
||
|
||
/* Find this symbol's section in our own array. */
|
||
int sectix = 0;
|
||
int section_found = 0;
|
||
|
||
/* First handle forward cases. */
|
||
if (func_rva >= export_rva && func_rva < export_rva + export_size)
|
||
{
|
||
char *forward_name = (char *) (erva + func_rva);
|
||
char *funcname = (char *) (erva + name_rva);
|
||
char *forward_dll_name = forward_name;
|
||
char *forward_func_name = forward_name;
|
||
char *sep = strrchr (forward_name, '.');
|
||
|
||
if (sep)
|
||
{
|
||
int len = (int) (sep - forward_name);
|
||
|
||
forward_dll_name = (char *) alloca (len + 1);
|
||
strncpy (forward_dll_name, forward_name, len);
|
||
forward_dll_name[len] = '\0';
|
||
forward_func_name = ++sep;
|
||
}
|
||
if (add_pe_forwarded_sym (reader, funcname, forward_dll_name,
|
||
forward_func_name, ordinal,
|
||
dll_name, objfile) != 0)
|
||
++nbforward;
|
||
continue;
|
||
}
|
||
|
||
for (sectix = 0; sectix < otherix; ++sectix)
|
||
{
|
||
if ((func_rva >= section_data[sectix].rva_start)
|
||
&& (func_rva < section_data[sectix].rva_end))
|
||
{
|
||
char *sym_name = (char *) (erva + name_rva);
|
||
|
||
section_found = 1;
|
||
add_pe_exported_sym (reader, sym_name, func_rva, ordinal,
|
||
§ion_data[sectix], dll_name, objfile);
|
||
++nbnormal;
|
||
break;
|
||
}
|
||
}
|
||
if (!section_found)
|
||
{
|
||
char *funcname = (char *) (erva + name_rva);
|
||
|
||
if (name_rva == 0)
|
||
{
|
||
add_pe_exported_sym (reader, NULL, func_rva, ordinal,
|
||
§ion_data[0], dll_name, objfile);
|
||
++nbnormal;
|
||
}
|
||
else if (debug_coff_pe_read)
|
||
fprintf_unfiltered (gdb_stdlog, _("Export name \"%s\" ord. %lu,"
|
||
" RVA 0x%lx in dll \"%s\" not handled\n"),
|
||
funcname, ordinal, func_rva, dll_name);
|
||
}
|
||
}
|
||
|
||
if (debug_coff_pe_read)
|
||
fprintf_unfiltered (gdb_stdlog, _("Finished reading \"%s\", exports %ld,"
|
||
" forwards %ld, total %ld/%ld.\n"), dll_name, nbnormal,
|
||
nbforward, nbnormal + nbforward, nexp);
|
||
}
|
||
|
||
/* Extract from ABFD the offset of the .text section.
|
||
This offset is mainly related to the offset within the file.
|
||
The value was previously expected to be 0x1000 for all files,
|
||
but some Windows OS core DLLs seem to use 0x10000 section alignment
|
||
which modified the return value of that function.
|
||
Still return default 0x1000 value if ABFD is NULL or
|
||
if '.text' section is not found, but that should not happen... */
|
||
|
||
#define DEFAULT_COFF_PE_TEXT_SECTION_OFFSET 0x1000
|
||
|
||
CORE_ADDR
|
||
pe_text_section_offset (struct bfd *abfd)
|
||
|
||
{
|
||
unsigned long pe_header_offset, i;
|
||
unsigned long nsections, secptr;
|
||
int is_pe64 = 0;
|
||
int is_pe32 = 0;
|
||
char const *target;
|
||
|
||
if (!abfd)
|
||
return DEFAULT_COFF_PE_TEXT_SECTION_OFFSET;
|
||
|
||
target = bfd_get_target (abfd);
|
||
|
||
is_pe64 = (strcmp (target, "pe-x86-64") == 0
|
||
|| strcmp (target, "pei-x86-64") == 0);
|
||
is_pe32 = (strcmp (target, "pe-i386") == 0
|
||
|| strcmp (target, "pei-i386") == 0
|
||
|| strcmp (target, "pe-arm-wince-little") == 0
|
||
|| strcmp (target, "pei-arm-wince-little") == 0);
|
||
|
||
if (!is_pe32 && !is_pe64)
|
||
{
|
||
/* This is not a recognized PE format file. Abort now, because
|
||
the code is untested on anything else. *FIXME* test on
|
||
further architectures and loosen or remove this test. */
|
||
return DEFAULT_COFF_PE_TEXT_SECTION_OFFSET;
|
||
}
|
||
|
||
/* Get pe_header, optional header and numbers of sections. */
|
||
pe_header_offset = pe_get32 (abfd, 0x3c);
|
||
nsections = pe_get16 (abfd, pe_header_offset + 4 + 2);
|
||
secptr = (pe_header_offset + 4 + 20 +
|
||
pe_get16 (abfd, pe_header_offset + 4 + 16));
|
||
|
||
/* Get the rva and size of the export section. */
|
||
for (i = 0; i < nsections; i++)
|
||
{
|
||
char sname[SCNNMLEN + 1];
|
||
unsigned long secptr1 = secptr + 40 * i;
|
||
unsigned long vaddr = pe_get32 (abfd, secptr1 + 12);
|
||
|
||
bfd_seek (abfd, (file_ptr) secptr1, SEEK_SET);
|
||
bfd_bread (sname, (bfd_size_type) SCNNMLEN, abfd);
|
||
sname[SCNNMLEN] = '\0';
|
||
if (strcmp (sname, ".text") == 0)
|
||
return vaddr;
|
||
}
|
||
|
||
return DEFAULT_COFF_PE_TEXT_SECTION_OFFSET;
|
||
}
|
||
|
||
/* Implements "show debug coff_pe_read" command. */
|
||
|
||
static void
|
||
show_debug_coff_pe_read (struct ui_file *file, int from_tty,
|
||
struct cmd_list_element *c, const char *value)
|
||
{
|
||
fprintf_filtered (file, _("Coff PE read debugging is %s.\n"), value);
|
||
}
|
||
|
||
/* Adds "Set/show debug coff_pe_read" commands. */
|
||
|
||
void _initialize_coff_pe_read ();
|
||
void
|
||
_initialize_coff_pe_read ()
|
||
{
|
||
add_setshow_zuinteger_cmd ("coff-pe-read", class_maintenance,
|
||
&debug_coff_pe_read,
|
||
_("Set coff PE read debugging."),
|
||
_("Show coff PE read debugging."),
|
||
_("When set, debugging messages for coff reading "
|
||
"of exported symbols are displayed."),
|
||
NULL, show_debug_coff_pe_read,
|
||
&setdebuglist, &showdebuglist);
|
||
}
|