mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-03-13 13:49:00 +08:00
Code Issues Packages Projects Releases Wiki Activity
binutils-gdb/gdbsupport
History
Andrew Burgess 7d18eb9983 gdb: use static_cast in gdb::checked_static_cast 
This commit:

  commit 6fe4779ac4b1874c995345e3eabd89cb1a05fbdf
  Date:   Sat Feb 24 11:00:20 2024 +0100

      [gdb/build] Fix static cast of virtual base

addressed an issue where GDB would not compile in production mode due
to a use of gdb::checked_static_cast.  The problem was that we were
asking GDB to cast from a virtual base class to a sub-class, this
works fine when using dynamic_cast, but does not work with
static_cast.

The gdb::checked_static_cast actually uses dynamic_cast under the hood
in development mode in order to ensure that the cast is valid, while
in a production build we use static_cast as this is more efficient.

What this meant however, was that when gdb::checked_static_cast was
used to cast from a virtual base class, the dynamic_cast of a
non-production build worked fine, while the production build's
static_cast caused a build failure.

However, the gdb::checked_static_cast function already contains some
static_assert calls that are intended to catch any issues with invalid
type casting, the goal of these asserts was to prevent issues like
this: the build only failing in production mode.  Clearly the current
asserts are not enough.

I don't think there is a std::is_virtual_base type trait check, so
what I propose instead is that in non-production mode we also make use
of static_cast.  This will ensure that any errors that crop up in
production mode should also be revealed in non-production mode, and
should catch issues like this in the future.

There should be no user visible changes after this commit.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31399

Co-Authored-By: Simon Marchi <simon.marchi@polymtl.ca>
2024-03-19 14:41:42 +00:00
..
.dir-locals.el
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
.gitattributes
…
acinclude.m4
gdb: move libiberty.m4 to gdbsupport
2024-01-10 19:52:52 -05:00
aclocal.m4
Finalized intl-update patches
2023-11-15 12:53:04 +00:00
agent.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
agent.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
alt-stack.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
array-view.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
ax.def
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
block-signals.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
break-common.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
btrace-common.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
btrace-common.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
buildargv.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
byte-vector.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
ChangeLog-2020-2021
…
check-defines.el
gdbsupport: assume that compiler supports std::{is_trivially_constructible,is_trivially_copyable}
2024-02-21 13:30:19 -05:00
cleanups.cc
Rewrite final cleanups
2024-02-27 10:30:29 -07:00
cleanups.h
Rewrite final cleanups
2024-02-27 10:30:29 -07:00
common-debug.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
common-debug.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
common-defs.h
gdb: remove some GCC version checks
2024-02-21 13:30:17 -05:00
common-exceptions.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
common-exceptions.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
common-gdbthread.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
common-inferior.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
common-inferior.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
common-regcache.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
common-regcache.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
common-types.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
common-utils.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
common-utils.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
common.m4
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
compiler-type.m4
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
config.in
Finalized intl-update patches
2023-11-15 12:53:04 +00:00
configure
gdbsupport: tighten up libiberty code a bit with dnl
2024-01-10 19:53:14 -05:00
configure.ac
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
create-version.sh
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
def-vector.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
default-init-alloc.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
eintr.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
enum-flags.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
environ.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
environ.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
errors.cc
Fix throw_winerror_with_name build error on x86-64 Cygwin
2024-02-23 17:24:17 +00:00
errors.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
event-loop.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
event-loop.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
event-pipe.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
event-pipe.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
fileio.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
fileio.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
filestuff.cc
Introduce read_remainder_of_file
2024-02-27 09:46:31 -07:00
filestuff.h
Introduce read_remainder_of_file
2024-02-27 09:46:31 -07:00
filtered-iterator.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
format.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
format.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
forward-scope-exit.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
function-view.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb_assert.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb_binary_search.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb_file.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb_locale.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb_obstack.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb_obstack.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb_proc_service.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb_ref_ptr.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb_regex.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb_regex.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb_select.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb_setjmp.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb_signals.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb_splay_tree.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb_sys_time.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb_tilde_expand.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb_tilde_expand.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb_unique_ptr.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb_unlinker.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb_vecs.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb_vecs.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb_wait.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb_wait.h
[gdb/build] Fix build on postmarketos
2024-03-14 21:28:44 +01:00
gdb-checked-static-cast.h
gdb: use static_cast in gdb::checked_static_cast
2024-03-19 14:41:42 +00:00
gdb-dlfcn.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb-dlfcn.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb-hashtab.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb-hashtab.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb-safe-ctype.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb-sigmask.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
gdb-xfree.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
hash_enum.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
host-defs.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
intrusive_list.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
iterator-range.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
job-control.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
job-control.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
libiberty.m4
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
Makefile.am
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
Makefile.in
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
netstuff.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
netstuff.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
new-op.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
next-iterator.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
observable.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
offset-type.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
packed.h
gdbsupport: assume that compiler supports std::{is_trivially_constructible,is_trivially_copyable}
2024-02-21 13:30:19 -05:00
parallel-for.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
pathstuff.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
pathstuff.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
poison.h
gdbsupport: assume that compiler supports std::{is_trivially_constructible,is_trivially_copyable}
2024-02-21 13:30:19 -05:00
preprocessor.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
print-utils.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
print-utils.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
ptid.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
ptid.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
ptrace.m4
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
range-chain.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
README
…
refcounted-object.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
reference-to-pointer-iterator.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
rsp-low.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
rsp-low.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
run-time-clock.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
run-time-clock.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
safe-iterator.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
safe-strerror.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
scope-exit.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
scoped_fd.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
scoped_ignore_signal.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
scoped_ignore_sigttou.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
scoped_mmap.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
scoped_mmap.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
scoped_restore.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
search.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
search.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
selftest.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
selftest.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
selftest.m4
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
signals-state-save-restore.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
signals-state-save-restore.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
signals.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
symbol.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
task-group.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
task-group.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
tdesc.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
tdesc.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
thread-pool.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
thread-pool.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
traits.h
gdbsupport: assume that compiler supports std::{is_trivially_constructible,is_trivially_copyable}
2024-02-21 13:30:19 -05:00
underlying.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
valid-expr.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
version.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
warning.m4
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
x86-xstate.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
xml-utils.cc
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00
xml-utils.h
Update copyright year range in header of all files managed by GDB
2024-01-12 15:49:57 +00:00

README 

This is a helper library that is used by gdb and gdbserver.

To send patches, follow the gdb patch submission instructions in
../gdb/CONTRIBUTE.  For maintainers, see ../gdb/MAINTAINERS.