mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-02-05 12:53:16 +08:00
7ba71655a4
This came up because I was looking at ld/tmpdir/addpcis.o and noticed the odd addends on REL16DX_HA. They ought to both be -4. The error crept in due REL16DX_HA howto being pc-relative (as indeed it should be), and code at gas/write.c:1001 after this comment /* Make it pc-relative. If the back-end code has not selected a pc-relative reloc, cancel the adjustment we do later on all pc-relative relocs. */ *not* cancelling the pc-relative adjustment. So I've made a dummy non-relative split reloc so that the generic code handles this, rather than attempting to add hacks later in md_apply_fix which would not be very robust. Having the new internal reloc also makes it easy to support addpcis rx,sym@ha as an equivalent to addpcis rx,(sym-0f)@ha 0: The patch also fixes overflow checking, which must test whether the addi will overflow too since @l relocs don't have any overflow check. Lastly, since I was poking at md_apply_fix, I arranged to have the generic gas/write.c code emit errors for subtraction expressions where we lack reloc support. include/ * elf/ppc64.h (R_PPC64_16DX_HA): New. Expand fake reloc comment. * elf/ppc.h (R_PPC_16DX_HA): Likewise. bfd/ * reloc.c (BFD_RELOC_PPC_16DX_HA): New. * elf64-ppc.c (ppc64_elf_howto_raw <R_PPC64_16DX_HA>): New howto. (ppc64_elf_reloc_type_lookup): Translate new bfd reloc. (ppc64_elf_ha_reloc): Correct overflow test on REL16DX_HA. (ppc64_elf_relocate_section): Likewise. * elf32-ppc.c (ppc_elf_howto_raw <R_PPC_16DX_HA>): New howto. (ppc_elf_reloc_type_lookup): Translate new bfd reloc. (ppc_elf_check_relocs): Handle R_PPC_16DX_HA to pacify gcc. * libbfd.h: Regenerate. * bfd-in2.h: Regenerate. gas/ * config/tc-ppc.c (md_assemble): Use BFD_RELOC_PPC_16DX_HA for addpcis. (md_apply_fix): Remove fx_subsy check. Move code converting to pcrel reloc earlier and handle BFD_RELOC_PPC_16DX_HA. Remove code emiiting errors on seeing fx_pcrel set on unexpected relocs, as that is done now by the generic code via.. * config/tc-ppc.h (TC_FORCE_RELOCATION_SUB_LOCAL): ..this. Define. (TC_VALIDATE_FIX_SUB): Define. ld/ * testsuite/ld-powerpc/addpcis.d: Define ext1 and ext2 at limits of addpcis range. |
||
|---|---|---|
| .. | ||
| config | ||
| ld-aarch64 | ||
| ld-alpha | ||
| ld-arc | ||
| ld-arm | ||
| ld-auto-import | ||
| ld-avr | ||
| ld-bootstrap | ||
| ld-cdtest | ||
| ld-checks | ||
| ld-cris | ||
| ld-crx | ||
| ld-cygwin | ||
| ld-d10v | ||
| ld-discard | ||
| ld-elf | ||
| ld-elfcomm | ||
| ld-elfvers | ||
| ld-elfvsb | ||
| ld-elfweak | ||
| ld-fastcall | ||
| ld-frv | ||
| ld-gc | ||
| ld-h8300 | ||
| ld-i386 | ||
| ld-ia64 | ||
| ld-ifunc | ||
| ld-libs | ||
| ld-linkonce | ||
| ld-m68hc11 | ||
| ld-m68k | ||
| ld-mep | ||
| ld-metag | ||
| ld-mips-elf | ||
| ld-misc | ||
| ld-mmix | ||
| ld-mn10300 | ||
| ld-nds32 | ||
| ld-nios2 | ||
| ld-pe | ||
| ld-pie | ||
| ld-plugin | ||
| ld-powerpc | ||
| ld-pru | ||
| ld-s390 | ||
| ld-scripts | ||
| ld-selective | ||
| ld-sh | ||
| ld-shared | ||
| ld-size | ||
| ld-sparc | ||
| ld-spu | ||
| ld-srec | ||
| ld-tic6x | ||
| ld-tilegx | ||
| ld-tilepro | ||
| ld-undefined | ||
| ld-unique | ||
| ld-v850 | ||
| ld-vax-elf | ||
| ld-versados | ||
| ld-visium | ||
| ld-vxworks | ||
| ld-x86-64 | ||
| ld-xc16x | ||
| ld-xstormy16 | ||
| ld-xtensa | ||
| ld-z8k | ||
| lib | ||
| ChangeLog-2004 | ||
| ChangeLog-2005 | ||
| ChangeLog-2006 | ||
| ChangeLog-2007 | ||
| ChangeLog-2008 | ||
| ChangeLog-2009 | ||
| ChangeLog-2010 | ||
| ChangeLog-2011 | ||
| ChangeLog-2012 | ||
| ChangeLog-2013 | ||
| ChangeLog-2014 | ||
| ChangeLog-2015 | ||
| ChangeLog-9303 | ||