mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-02-17 13:10:12 +08:00
This came up because I was looking at ld/tmpdir/addpcis.o and noticed the odd addends on REL16DX_HA. They ought to both be -4. The error crept in due REL16DX_HA howto being pc-relative (as indeed it should be), and code at gas/write.c:1001 after this comment /* Make it pc-relative. If the back-end code has not selected a pc-relative reloc, cancel the adjustment we do later on all pc-relative relocs. */ *not* cancelling the pc-relative adjustment. So I've made a dummy non-relative split reloc so that the generic code handles this, rather than attempting to add hacks later in md_apply_fix which would not be very robust. Having the new internal reloc also makes it easy to support addpcis rx,sym@ha as an equivalent to addpcis rx,(sym-0f)@ha 0: The patch also fixes overflow checking, which must test whether the addi will overflow too since @l relocs don't have any overflow check. Lastly, since I was poking at md_apply_fix, I arranged to have the generic gas/write.c code emit errors for subtraction expressions where we lack reloc support. include/ * elf/ppc64.h (R_PPC64_16DX_HA): New. Expand fake reloc comment. * elf/ppc.h (R_PPC_16DX_HA): Likewise. bfd/ * reloc.c (BFD_RELOC_PPC_16DX_HA): New. * elf64-ppc.c (ppc64_elf_howto_raw <R_PPC64_16DX_HA>): New howto. (ppc64_elf_reloc_type_lookup): Translate new bfd reloc. (ppc64_elf_ha_reloc): Correct overflow test on REL16DX_HA. (ppc64_elf_relocate_section): Likewise. * elf32-ppc.c (ppc_elf_howto_raw <R_PPC_16DX_HA>): New howto. (ppc_elf_reloc_type_lookup): Translate new bfd reloc. (ppc_elf_check_relocs): Handle R_PPC_16DX_HA to pacify gcc. * libbfd.h: Regenerate. * bfd-in2.h: Regenerate. gas/ * config/tc-ppc.c (md_assemble): Use BFD_RELOC_PPC_16DX_HA for addpcis. (md_apply_fix): Remove fx_subsy check. Move code converting to pcrel reloc earlier and handle BFD_RELOC_PPC_16DX_HA. Remove code emiiting errors on seeing fx_pcrel set on unexpected relocs, as that is done now by the generic code via.. * config/tc-ppc.h (TC_FORCE_RELOCATION_SUB_LOCAL): ..this. Define. (TC_VALIDATE_FIX_SUB): Define. ld/ * testsuite/ld-powerpc/addpcis.d: Define ext1 and ext2 at limits of addpcis range. |
||
---|---|---|
.. | ||
aout_gnu.h | ||
atof-ieee.c | ||
atof-vax.c | ||
bfin-aux.h | ||
bfin-defs.h | ||
bfin-lex-wrapper.c | ||
bfin-lex.l | ||
bfin-parse.y | ||
e-crisaout.c | ||
e-criself.c | ||
e-i386aout.c | ||
e-i386coff.c | ||
e-i386elf.c | ||
e-mipself.c | ||
itbl-mips.h | ||
m68k-parse.h | ||
m68k-parse.y | ||
obj-aout.c | ||
obj-aout.h | ||
obj-coff-seh.c | ||
obj-coff-seh.h | ||
obj-coff.c | ||
obj-coff.h | ||
obj-ecoff.c | ||
obj-ecoff.h | ||
obj-elf.c | ||
obj-elf.h | ||
obj-evax.c | ||
obj-evax.h | ||
obj-fdpicelf.c | ||
obj-fdpicelf.h | ||
obj-macho.c | ||
obj-macho.h | ||
obj-multi.c | ||
obj-multi.h | ||
obj-som.c | ||
obj-som.h | ||
rl78-defs.h | ||
rl78-parse.y | ||
rx-defs.h | ||
rx-parse.y | ||
tc-aarch64.c | ||
tc-aarch64.h | ||
tc-alpha.c | ||
tc-alpha.h | ||
tc-arc.c | ||
tc-arc.h | ||
tc-arm.c | ||
tc-arm.h | ||
tc-avr.c | ||
tc-avr.h | ||
tc-bfin.c | ||
tc-bfin.h | ||
tc-cr16.c | ||
tc-cr16.h | ||
tc-cris.c | ||
tc-cris.h | ||
tc-crx.c | ||
tc-crx.h | ||
tc-d10v.c | ||
tc-d10v.h | ||
tc-d30v.c | ||
tc-d30v.h | ||
tc-dlx.c | ||
tc-dlx.h | ||
tc-epiphany.c | ||
tc-epiphany.h | ||
tc-fr30.c | ||
tc-fr30.h | ||
tc-frv.c | ||
tc-frv.h | ||
tc-ft32.c | ||
tc-ft32.h | ||
tc-generic.c | ||
tc-generic.h | ||
tc-h8300.c | ||
tc-h8300.h | ||
tc-hppa.c | ||
tc-hppa.h | ||
tc-i370.c | ||
tc-i370.h | ||
tc-i386-intel.c | ||
tc-i386.c | ||
tc-i386.h | ||
tc-i860.c | ||
tc-i860.h | ||
tc-i960.c | ||
tc-i960.h | ||
tc-ia64.c | ||
tc-ia64.h | ||
tc-ip2k.c | ||
tc-ip2k.h | ||
tc-iq2000.c | ||
tc-iq2000.h | ||
tc-lm32.c | ||
tc-lm32.h | ||
tc-m32c.c | ||
tc-m32c.h | ||
tc-m32r.c | ||
tc-m32r.h | ||
tc-m68hc11.c | ||
tc-m68hc11.h | ||
tc-m68k.c | ||
tc-m68k.h | ||
tc-m68851.h | ||
tc-mcore.c | ||
tc-mcore.h | ||
tc-mep.c | ||
tc-mep.h | ||
tc-metag.c | ||
tc-metag.h | ||
tc-microblaze.c | ||
tc-microblaze.h | ||
tc-mips.c | ||
tc-mips.h | ||
tc-mmix.c | ||
tc-mmix.h | ||
tc-mn10200.c | ||
tc-mn10200.h | ||
tc-mn10300.c | ||
tc-mn10300.h | ||
tc-moxie.c | ||
tc-moxie.h | ||
tc-msp430.c | ||
tc-msp430.h | ||
tc-mt.c | ||
tc-mt.h | ||
tc-nds32.c | ||
tc-nds32.h | ||
tc-nios2.c | ||
tc-nios2.h | ||
tc-ns32k.c | ||
tc-ns32k.h | ||
tc-or1k.c | ||
tc-or1k.h | ||
tc-pdp11.c | ||
tc-pdp11.h | ||
tc-pj.c | ||
tc-pj.h | ||
tc-ppc.c | ||
tc-ppc.h | ||
tc-pru.c | ||
tc-pru.h | ||
tc-riscv.c | ||
tc-riscv.h | ||
tc-rl78.c | ||
tc-rl78.h | ||
tc-rx.c | ||
tc-rx.h | ||
tc-s390.c | ||
tc-s390.h | ||
tc-score7.c | ||
tc-score.c | ||
tc-score.h | ||
tc-sh64.c | ||
tc-sh64.h | ||
tc-sh.c | ||
tc-sh.h | ||
tc-sparc.c | ||
tc-sparc.h | ||
tc-spu.c | ||
tc-spu.h | ||
tc-tic4x.c | ||
tc-tic4x.h | ||
tc-tic6x.c | ||
tc-tic6x.h | ||
tc-tic30.c | ||
tc-tic30.h | ||
tc-tic54x.c | ||
tc-tic54x.h | ||
tc-tilegx.c | ||
tc-tilegx.h | ||
tc-tilepro.c | ||
tc-tilepro.h | ||
tc-v850.c | ||
tc-v850.h | ||
tc-vax.c | ||
tc-vax.h | ||
tc-visium.c | ||
tc-visium.h | ||
tc-xc16x.c | ||
tc-xc16x.h | ||
tc-xgate.c | ||
tc-xgate.h | ||
tc-xstormy16.c | ||
tc-xstormy16.h | ||
tc-xtensa.c | ||
tc-xtensa.h | ||
tc-z8k.c | ||
tc-z8k.h | ||
tc-z80.c | ||
tc-z80.h | ||
te-386bsd.h | ||
te-aix5.h | ||
te-aix.h | ||
te-armeabi.h | ||
te-armfbsdeabi.h | ||
te-armfbsdvfp.h | ||
te-armlinuxeabi.h | ||
te-dragonfly.h | ||
te-dynix.h | ||
te-epoc-pe.h | ||
te-freebsd.h | ||
te-generic.h | ||
te-gnu.h | ||
te-go32.h | ||
te-hppa64.h | ||
te-hppa.h | ||
te-hppalinux64.h | ||
te-hpux.h | ||
te-i386aix.h | ||
te-ia64aix.h | ||
te-interix.h | ||
te-irix.h | ||
te-linux.h | ||
te-lynx.h | ||
te-mach.h | ||
te-macos.h | ||
te-nacl.h | ||
te-nbsd532.h | ||
te-nbsd.h | ||
te-netware.h | ||
te-pc532mach.h | ||
te-pe.h | ||
te-pep.h | ||
te-psos.h | ||
te-riscix.h | ||
te-solaris.h | ||
te-sparcaout.h | ||
te-sun3.h | ||
te-svr4.h | ||
te-symbian.h | ||
te-tmips.h | ||
te-uclinux.h | ||
te-vms.c | ||
te-vms.h | ||
te-vxworks.h | ||
te-wince-pe.h | ||
vax-inst.h | ||
xtensa-istack.h | ||
xtensa-relax.c | ||
xtensa-relax.h |