mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
d1e93af64a
PR 27147 shows that on sparc64, GDB is unable to properly unwind:
Expected result (from GDB 9.2):
#0 0x0000000000108de4 in puts ()
#1 0x0000000000100950 in hello () at gdb-test.c:4
#2 0x0000000000100968 in main () at gdb-test.c:8
Actual result (from GDB latest git):
#0 0x0000000000108de4 in puts ()
#1 0x0000000000100950 in hello () at gdb-test.c:4
Backtrace stopped: previous frame inner to this frame (corrupt stack?)
The first failing commit is 5b6d1e4fa4
("Multi-target support"). The cause
of the change in behavior is due to (thanks for Andrew Burgess for finding
this):
- inferior_ptid is no longer set on entry of target_ops::wait, whereas
it was set to something valid previously
- deep down in linux_nat_target::wait (see stack trace below), we fetch
the registers of the event thread
- on sparc64, fetching registers involves reading memory (in
sparc_supply_rwindow, see stack trace below)
- reading memory (target_ops::xfer_partial) relies on inferior_ptid
being set to the thread from which we want to read memory
This is where things go wrong:
#0 linux_nat_target::xfer_partial (this=0x10000fa2c40 <the_sparc64_linux_nat_target>, object=TARGET_OBJECT_MEMORY, annex=0x0, readbuf=0x7feffe3b000 "", writebuf=0x0, offset=8791798050744, len=8, xfered_len=0x7feffe3ae88) at /home/simark/src/binutils-gdb/gdb/linux-nat.c:3697
#1 0x00000100007f5b10 in raw_memory_xfer_partial (ops=0x10000fa2c40 <the_sparc64_linux_nat_target>, readbuf=0x7feffe3b000 "", writebuf=0x0, memaddr=8791798050744, len=8, xfered_len=0x7feffe3ae88) at /home/simark/src/binutils-gdb/gdb/target.c:912
#2 0x00000100007f60e8 in memory_xfer_partial_1 (ops=0x10000fa2c40 <the_sparc64_linux_nat_target>, object=TARGET_OBJECT_MEMORY, readbuf=0x7feffe3b000 "", writebuf=0x0, memaddr=8791798050744, len=8, xfered_len=0x7feffe3ae88) at /home/simark/src/binutils-gdb/gdb/target.c:1043
#3 0x00000100007f61b4 in memory_xfer_partial (ops=0x10000fa2c40 <the_sparc64_linux_nat_target>, object=TARGET_OBJECT_MEMORY, readbuf=0x7feffe3b000 "", writebuf=0x0, memaddr=8791798050744, len=8, xfered_len=0x7feffe3ae88) at /home/simark/src/binutils-gdb/gdb/target.c:1072
#4 0x00000100007f6538 in target_xfer_partial (ops=0x10000fa2c40 <the_sparc64_linux_nat_target>, object=TARGET_OBJECT_MEMORY, annex=0x0, readbuf=0x7feffe3b000 "", writebuf=0x0, offset=8791798050744, len=8, xfered_len=0x7feffe3ae88) at /home/simark/src/binutils-gdb/gdb/target.c:1129
#5 0x00000100007f7094 in target_read_partial (ops=0x10000fa2c40 <the_sparc64_linux_nat_target>, object=TARGET_OBJECT_MEMORY, annex=0x0, buf=0x7feffe3b000 "", offset=8791798050744, len=8, xfered_len=0x7feffe3ae88) at /home/simark/src/binutils-gdb/gdb/target.c:1375
#6 0x00000100007f721c in target_read (ops=0x10000fa2c40 <the_sparc64_linux_nat_target>, object=TARGET_OBJECT_MEMORY, annex=0x0, buf=0x7feffe3b000 "", offset=8791798050744, len=8) at /home/simark/src/binutils-gdb/gdb/target.c:1415
#7 0x00000100007f69d4 in target_read_memory (memaddr=8791798050744, myaddr=0x7feffe3b000 "", len=8) at /home/simark/src/binutils-gdb/gdb/target.c:1218
#8 0x0000010000758520 in sparc_supply_rwindow (regcache=0x10000fea4f0, sp=8791798050736, regnum=-1) at /home/simark/src/binutils-gdb/gdb/sparc-tdep.c:1960
#9 0x000001000076208c in sparc64_supply_gregset (gregmap=0x10000be3190 <sparc64_linux_ptrace_gregmap>, regcache=0x10000fea4f0, regnum=-1, gregs=0x7feffe3b230) at /home/simark/src/binutils-gdb/gdb/sparc64-tdep.c:1974
#10 0x0000010000751b64 in sparc_fetch_inferior_registers (regcache=0x10000fea4f0, regnum=80) at /home/simark/src/binutils-gdb/gdb/sparc-nat.c:170
#11 0x0000010000759d68 in sparc64_linux_nat_target::fetch_registers (this=0x10000fa2c40 <the_sparc64_linux_nat_target>, regcache=0x10000fea4f0, regnum=80) at /home/simark/src/binutils-gdb/gdb/sparc64-linux-nat.c:38
#12 0x00000100008146ec in target_fetch_registers (regcache=0x10000fea4f0, regno=80) at /home/simark/src/binutils-gdb/gdb/target.c:3287
#13 0x00000100006a8c5c in regcache::raw_update (this=0x10000fea4f0, regnum=80) at /home/simark/src/binutils-gdb/gdb/regcache.c:584
#14 0x00000100006a8d94 in readable_regcache::raw_read (this=0x10000fea4f0, regnum=80, buf=0x7feffe3b7c0 "") at /home/simark/src/binutils-gdb/gdb/regcache.c:598
#15 0x00000100006a93b8 in readable_regcache::cooked_read (this=0x10000fea4f0, regnum=80, buf=0x7feffe3b7c0 "") at /home/simark/src/binutils-gdb/gdb/regcache.c:690
#16 0x00000100006b288c in readable_regcache::cooked_read<unsigned long, void> (this=0x10000fea4f0, regnum=80, val=0x7feffe3b948) at /home/simark/src/binutils-gdb/gdb/regcache.c:777
#17 0x00000100006a9b44 in regcache_cooked_read_unsigned (regcache=0x10000fea4f0, regnum=80, val=0x7feffe3b948) at /home/simark/src/binutils-gdb/gdb/regcache.c:791
#18 0x00000100006abf3c in regcache_read_pc (regcache=0x10000fea4f0) at /home/simark/src/binutils-gdb/gdb/regcache.c:1295
#19 0x0000010000507920 in save_stop_reason (lp=0x10000fc5b10) at /home/simark/src/binutils-gdb/gdb/linux-nat.c:2612
#20 0x00000100005095a4 in linux_nat_filter_event (lwpid=520983, status=1407) at /home/simark/src/binutils-gdb/gdb/linux-nat.c:3050
#21 0x0000010000509f9c in linux_nat_wait_1 (ptid=..., ourstatus=0x7feffe3c8f0, target_options=...) at /home/simark/src/binutils-gdb/gdb/linux-nat.c:3194
#22 0x000001000050b1d0 in linux_nat_target::wait (this=0x10000fa2c40 <the_sparc64_linux_nat_target>, ptid=..., ourstatus=0x7feffe3c8f0, target_options=...) at /home/simark/src/binutils-gdb/gdb/linux-nat.c:3432
#23 0x00000100007f8ac0 in target_wait (ptid=..., status=0x7feffe3c8f0, options=...) at /home/simark/src/binutils-gdb/gdb/target.c:2000
#24 0x00000100004ac17c in do_target_wait_1 (inf=0x1000116d280, ptid=..., status=0x7feffe3c8f0, options=...) at /home/simark/src/binutils-gdb/gdb/infrun.c:3464
#25 0x00000100004ac3b8 in operator() (__closure=0x7feffe3c678, inf=0x1000116d280) at /home/simark/src/binutils-gdb/gdb/infrun.c:3527
#26 0x00000100004ac7cc in do_target_wait (wait_ptid=..., ecs=0x7feffe3c8c8, options=...) at /home/simark/src/binutils-gdb/gdb/infrun.c:3540
#27 0x00000100004ad8c4 in fetch_inferior_event () at /home/simark/src/binutils-gdb/gdb/infrun.c:3880
#28 0x0000010000485568 in inferior_event_handler (event_type=INF_REG_EVENT) at /home/simark/src/binutils-gdb/gdb/inf-loop.c:42
#29 0x000001000050d394 in handle_target_event (error=0, client_data=0x0) at /home/simark/src/binutils-gdb/gdb/linux-nat.c:4060
#30 0x0000010000ab5c8c in handle_file_event (file_ptr=0x10001207270, ready_mask=1) at /home/simark/src/binutils-gdb/gdbsupport/event-loop.cc:575
#31 0x0000010000ab6334 in gdb_wait_for_event (block=0) at /home/simark/src/binutils-gdb/gdbsupport/event-loop.cc:701
#32 0x0000010000ab487c in gdb_do_one_event () at /home/simark/src/binutils-gdb/gdbsupport/event-loop.cc:212
#33 0x0000010000542668 in start_event_loop () at /home/simark/src/binutils-gdb/gdb/main.c:348
#34 0x000001000054287c in captured_command_loop () at /home/simark/src/binutils-gdb/gdb/main.c:408
#35 0x0000010000544e84 in captured_main (data=0x7feffe3d188) at /home/simark/src/binutils-gdb/gdb/main.c:1242
#36 0x0000010000544f2c in gdb_main (args=0x7feffe3d188) at /home/simark/src/binutils-gdb/gdb/main.c:1257
#37 0x00000100000c1f14 in main (argc=4, argv=0x7feffe3d548) at /home/simark/src/binutils-gdb/gdb/gdb.c:32
There is a target_read_memory call in sparc_supply_rwindow, whose return
value is not checked. That call fails, because inferior_ptid does not
contain a valid ptid, and uninitialized buffer contents is used.
Ultimately it results in a corrupt stop_pc.
target_ops::fetch_registers can be (and should remain, in my opinion)
independent of inferior_ptid, because the ptid of the thread from which
to fetch registers can be obtained from the regcache. In other words,
implementations of target_ops::fetch_registers should not rely on
inferior_ptid having a sensible value on entry.
The sparc64_linux_nat_target::fetch_registers case is special, because it calls
a target method that is dependent on the inferior_ptid value
(target_read_inferior, and ultimately target_ops::xfer_partial). So I would
say it's the responsibility of sparc64_linux_nat_target::fetch_registers to set
up inferior_ptid correctly prior to calling target_read_inferior.
This patch makes sparc64_linux_nat_target::fetch_registers (and
store_registers, since it works the same) temporarily set inferior_ptid. If we
ever make target_ops::xfer_partial independent of inferior_ptid, setting
inferior_ptid won't be necessary, we'll simply pass down the ptid as a
parameter in some way.
I chose to set/restore inferior_ptid in sparc_fetch_inferior_registers, because
I am not convinced that doing so in an inner location (in sparc_supply_rwindow
for instance) would always be correct. We have access to the ptid in
sparc_supply_rwindow (from the regcache), so we _could_ set inferior_ptid
there. However, I don't want to just set inferior_ptid, as that would make it
not desync'ed with `current_thread ()` and `current_inferior ()`. It's
preferable to use switch_to_thread instead, as that switches all the global
"current" stuff in a coherent way. But doing so requires a `thread_info *`,
and getting a `thread_info *` from a ptid requires a `process_stratum_target
*`. We could use `current_inferior()->process_target()` in
sparc_supply_rwindow for this (using target_read_memory uses the current
inferior's target stack anyway). However, sparc_supply_rwindow is also used in
the context of BSD uthreads, where a thread stratum target defines threads. I
presume the ptid in the regcache would be the ptid of the uthread, defined by
the thread stratum target (bsd_uthread_target). Using
`current_inferior()->process_target()` would look up a ptid defined by the
thread stratum target using the process stratum target. I don't think it would
give good results. So I prefer playing it safe and looking up the thread
earlier, in sparc_fetch_inferior_registers.
I added some assertions (in sparc_supply_rwindow and others) to verify
that the regcache's ptid matches inferior_ptid. That verifies that the
caller has properly set the correct global context. This would have
caught (though a failed assertion) the current problem.
gdb/ChangeLog:
PR gdb/27147
* sparc-nat.h (sparc_fetch_inferior_registers): Add
process_stratum_target parameter,
sparc_store_inferior_registers): update callers.
* sparc-nat.c (sparc_fetch_inferior_registers,
sparc_store_inferior_registers): Add process_stratum_target
parameter. Switch current thread before calling
sparc_supply_gregset / sparc_collect_rwindow.
(sparc_store_inferior_registers): Likewise.
* sparc-obsd-tdep.c (sparc32obsd_supply_uthread): Add assertion.
(sparc32obsd_collect_uthread): Likewise.
* sparc-tdep.c (sparc_supply_rwindow, sparc_collect_rwindow):
Add assertion.
* sparc64-obsd-tdep.c (sparc64obsd_collect_uthread,
sparc64obsd_supply_uthread): Add assertion.
Change-Id: I16c658cd70896cea604516714f7e2428fbaf4301
263 lines
7.4 KiB
C
263 lines
7.4 KiB
C
/* Target-dependent code for OpenBSD/sparc.
|
||
|
||
Copyright (C) 2004-2021 Free Software Foundation, Inc.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
#include "defs.h"
|
||
#include "frame.h"
|
||
#include "frame-unwind.h"
|
||
#include "gdbcore.h"
|
||
#include "osabi.h"
|
||
#include "regcache.h"
|
||
#include "symtab.h"
|
||
#include "trad-frame.h"
|
||
#include "inferior.h"
|
||
|
||
#include "obsd-tdep.h"
|
||
#include "sparc-tdep.h"
|
||
#include "solib-svr4.h"
|
||
#include "bsd-uthread.h"
|
||
#include "gdbarch.h"
|
||
|
||
/* Signal trampolines. */
|
||
|
||
/* The OpenBSD kernel maps the signal trampoline at some random
|
||
location in user space, which means that the traditional BSD way of
|
||
detecting it won't work.
|
||
|
||
The signal trampoline will be mapped at an address that is page
|
||
aligned. We recognize the signal trampoline by looking for the
|
||
sigreturn system call. */
|
||
|
||
static const int sparc32obsd_page_size = 4096;
|
||
|
||
static int
|
||
sparc32obsd_pc_in_sigtramp (CORE_ADDR pc, const char *name)
|
||
{
|
||
CORE_ADDR start_pc = (pc & ~(sparc32obsd_page_size - 1));
|
||
unsigned long insn;
|
||
|
||
if (name)
|
||
return 0;
|
||
|
||
/* Check for "restore %g0, SYS_sigreturn, %g1". */
|
||
insn = sparc_fetch_instruction (start_pc + 0xec);
|
||
if (insn != 0x83e82067)
|
||
return 0;
|
||
|
||
/* Check for "t ST_SYSCALL". */
|
||
insn = sparc_fetch_instruction (start_pc + 0xf4);
|
||
if (insn != 0x91d02000)
|
||
return 0;
|
||
|
||
return 1;
|
||
}
|
||
|
||
static struct sparc_frame_cache *
|
||
sparc32obsd_sigtramp_frame_cache (struct frame_info *this_frame,
|
||
void **this_cache)
|
||
{
|
||
struct sparc_frame_cache *cache;
|
||
CORE_ADDR addr;
|
||
|
||
if (*this_cache)
|
||
return (struct sparc_frame_cache *) *this_cache;
|
||
|
||
cache = sparc_frame_cache (this_frame, this_cache);
|
||
gdb_assert (cache == *this_cache);
|
||
|
||
/* If we couldn't find the frame's function, we're probably dealing
|
||
with an on-stack signal trampoline. */
|
||
if (cache->pc == 0)
|
||
{
|
||
cache->pc = get_frame_pc (this_frame);
|
||
cache->pc &= ~(sparc32obsd_page_size - 1);
|
||
|
||
/* Since we couldn't find the frame's function, the cache was
|
||
initialized under the assumption that we're frameless. */
|
||
sparc_record_save_insn (cache);
|
||
addr = get_frame_register_unsigned (this_frame, SPARC_FP_REGNUM);
|
||
cache->base = addr;
|
||
}
|
||
|
||
cache->saved_regs = sparc32nbsd_sigcontext_saved_regs (this_frame);
|
||
|
||
return cache;
|
||
}
|
||
|
||
static void
|
||
sparc32obsd_sigtramp_frame_this_id (struct frame_info *this_frame,
|
||
void **this_cache,
|
||
struct frame_id *this_id)
|
||
{
|
||
struct sparc_frame_cache *cache =
|
||
sparc32obsd_sigtramp_frame_cache (this_frame, this_cache);
|
||
|
||
(*this_id) = frame_id_build (cache->base, cache->pc);
|
||
}
|
||
|
||
static struct value *
|
||
sparc32obsd_sigtramp_frame_prev_register (struct frame_info *this_frame,
|
||
void **this_cache, int regnum)
|
||
{
|
||
struct sparc_frame_cache *cache =
|
||
sparc32obsd_sigtramp_frame_cache (this_frame, this_cache);
|
||
|
||
return trad_frame_get_prev_register (this_frame, cache->saved_regs, regnum);
|
||
}
|
||
|
||
static int
|
||
sparc32obsd_sigtramp_frame_sniffer (const struct frame_unwind *self,
|
||
struct frame_info *this_frame,
|
||
void **this_cache)
|
||
{
|
||
CORE_ADDR pc = get_frame_pc (this_frame);
|
||
const char *name;
|
||
|
||
find_pc_partial_function (pc, &name, NULL, NULL);
|
||
if (sparc32obsd_pc_in_sigtramp (pc, name))
|
||
return 1;
|
||
|
||
return 0;
|
||
}
|
||
static const struct frame_unwind sparc32obsd_sigtramp_frame_unwind =
|
||
{
|
||
SIGTRAMP_FRAME,
|
||
default_frame_unwind_stop_reason,
|
||
sparc32obsd_sigtramp_frame_this_id,
|
||
sparc32obsd_sigtramp_frame_prev_register,
|
||
NULL,
|
||
sparc32obsd_sigtramp_frame_sniffer
|
||
};
|
||
|
||
|
||
|
||
/* Offset wthin the thread structure where we can find %fp and %i7. */
|
||
#define SPARC32OBSD_UTHREAD_FP_OFFSET 128
|
||
#define SPARC32OBSD_UTHREAD_PC_OFFSET 132
|
||
|
||
static void
|
||
sparc32obsd_supply_uthread (struct regcache *regcache,
|
||
int regnum, CORE_ADDR addr)
|
||
{
|
||
struct gdbarch *gdbarch = regcache->arch ();
|
||
enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
|
||
CORE_ADDR fp, fp_addr = addr + SPARC32OBSD_UTHREAD_FP_OFFSET;
|
||
gdb_byte buf[4];
|
||
|
||
/* This function calls functions that depend on the global current thread. */
|
||
gdb_assert (regcache->ptid () == inferior_ptid);
|
||
|
||
gdb_assert (regnum >= -1);
|
||
|
||
fp = read_memory_unsigned_integer (fp_addr, 4, byte_order);
|
||
if (regnum == SPARC_SP_REGNUM || regnum == -1)
|
||
{
|
||
store_unsigned_integer (buf, 4, byte_order, fp);
|
||
regcache->raw_supply (SPARC_SP_REGNUM, buf);
|
||
|
||
if (regnum == SPARC_SP_REGNUM)
|
||
return;
|
||
}
|
||
|
||
if (regnum == SPARC32_PC_REGNUM || regnum == SPARC32_NPC_REGNUM
|
||
|| regnum == -1)
|
||
{
|
||
CORE_ADDR i7, i7_addr = addr + SPARC32OBSD_UTHREAD_PC_OFFSET;
|
||
|
||
i7 = read_memory_unsigned_integer (i7_addr, 4, byte_order);
|
||
if (regnum == SPARC32_PC_REGNUM || regnum == -1)
|
||
{
|
||
store_unsigned_integer (buf, 4, byte_order, i7 + 8);
|
||
regcache->raw_supply (SPARC32_PC_REGNUM, buf);
|
||
}
|
||
if (regnum == SPARC32_NPC_REGNUM || regnum == -1)
|
||
{
|
||
store_unsigned_integer (buf, 4, byte_order, i7 + 12);
|
||
regcache->raw_supply (SPARC32_NPC_REGNUM, buf);
|
||
}
|
||
|
||
if (regnum == SPARC32_PC_REGNUM || regnum == SPARC32_NPC_REGNUM)
|
||
return;
|
||
}
|
||
|
||
sparc_supply_rwindow (regcache, fp, regnum);
|
||
}
|
||
|
||
static void
|
||
sparc32obsd_collect_uthread(const struct regcache *regcache,
|
||
int regnum, CORE_ADDR addr)
|
||
{
|
||
struct gdbarch *gdbarch = regcache->arch ();
|
||
enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
|
||
CORE_ADDR sp;
|
||
gdb_byte buf[4];
|
||
|
||
/* This function calls functions that depend on the global current thread. */
|
||
gdb_assert (regcache->ptid () == inferior_ptid);
|
||
|
||
gdb_assert (regnum >= -1);
|
||
|
||
if (regnum == SPARC_SP_REGNUM || regnum == -1)
|
||
{
|
||
CORE_ADDR fp_addr = addr + SPARC32OBSD_UTHREAD_FP_OFFSET;
|
||
|
||
regcache->raw_collect (SPARC_SP_REGNUM, buf);
|
||
write_memory (fp_addr,buf, 4);
|
||
}
|
||
|
||
if (regnum == SPARC32_PC_REGNUM || regnum == -1)
|
||
{
|
||
CORE_ADDR i7, i7_addr = addr + SPARC32OBSD_UTHREAD_PC_OFFSET;
|
||
|
||
regcache->raw_collect (SPARC32_PC_REGNUM, buf);
|
||
i7 = extract_unsigned_integer (buf, 4, byte_order) - 8;
|
||
write_memory_unsigned_integer (i7_addr, 4, byte_order, i7);
|
||
|
||
if (regnum == SPARC32_PC_REGNUM)
|
||
return;
|
||
}
|
||
|
||
regcache->raw_collect (SPARC_SP_REGNUM, buf);
|
||
sp = extract_unsigned_integer (buf, 4, byte_order);
|
||
sparc_collect_rwindow (regcache, sp, regnum);
|
||
}
|
||
|
||
|
||
static void
|
||
sparc32obsd_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
|
||
{
|
||
/* OpenBSD/sparc is very similar to NetBSD/sparc ELF. */
|
||
sparc32nbsd_init_abi (info, gdbarch);
|
||
|
||
set_gdbarch_skip_solib_resolver (gdbarch, obsd_skip_solib_resolver);
|
||
|
||
frame_unwind_append_unwinder (gdbarch, &sparc32obsd_sigtramp_frame_unwind);
|
||
|
||
/* OpenBSD provides a user-level threads implementation. */
|
||
bsd_uthread_set_supply_uthread (gdbarch, sparc32obsd_supply_uthread);
|
||
bsd_uthread_set_collect_uthread (gdbarch, sparc32obsd_collect_uthread);
|
||
}
|
||
|
||
void _initialize_sparc32obsd_tdep ();
|
||
void
|
||
_initialize_sparc32obsd_tdep ()
|
||
{
|
||
gdbarch_register_osabi (bfd_arch_sparc, 0, GDB_OSABI_OPENBSD,
|
||
sparc32obsd_init_abi);
|
||
}
|