mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-24 12:35:55 +08:00
ee87f50b8d
The ctf_type_name_raw and ctf_type_aname_raw functions, which return the raw, unadorned name of CTF types, have one unfortunate wrinkle: they return NULL not only on error but when returning the name of types without a name in writable dicts. This was unintended: it not only makes it impossible to reliably tell if a given call to ctf_type_name_raw failed (due to a bad string offset say), but also complicates all its callers, who now have to check for both NULL and "". The written-out form of CTF has no concept of a NULL pointer instead of a string: all null strings are strtab offset 0, "". So the more we can do to remove this distinction from the writable form, the less complex the rest of our code needs to be. Armour against NULL in multiple places, arranging to return "" from ctf_type_name_raw if offset 0 is passed in, and removing a risky optimization from ctf_str_add* that avoided doing anything if a NULL was passed in: this added needless irregularity to the functions' API surface, since "" and NULL should be treated identically, and in the case of ctf_str_add_ref, we shouldn't skip adding the passed-in REF to the list of references to be updated no matter what the content of the string happens to be. This means we can simplify the deduplicator a tiny bit, also fixing a bug (latent when used by ld) where if the input dict was writable, we failed to realise when types were nameless and could end up creating deeply unhelpful synthetic forwards with no name, which we just banned a few commits ago, so the link failed. libctf/ChangeLog 2021-01-27 Nick Alcock <nick.alcock@oracle.com> * ctf-string.c (ctf_str_add): Treat adding a NULL as adding "". (ctf_str_add_ref): Likewise. (ctf_str_add_external): Likewise. * ctf-types.c (ctf_type_name_raw): Always return "" for offset 0. * ctf-dedup.c (ctf_dedup_multiple_input_dicts): Don't armour against NULL name. (ctf_dedup_maybe_synthesize_forward): Likewise.
308 lines
11 KiB
Plaintext
308 lines
11 KiB
Plaintext
2021-01-27 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-string.c (ctf_str_add): Treat adding a NULL as adding "".
|
||
(ctf_str_add_ref): Likewise.
|
||
(ctf_str_add_external): Likewise.
|
||
* ctf-types.c (ctf_type_name_raw): Always return "" for offset 0.
|
||
* ctf-dedup.c (ctf_dedup_multiple_input_dicts): Don't armour
|
||
against NULL name.
|
||
(ctf_dedup_maybe_synthesize_forward): Likewise.
|
||
|
||
2021-01-27 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-create.c (ctf_serialize): Fix shadowing.
|
||
|
||
2021-01-27 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-create.c (ctf_add_encoded): Add check for non-empty name.
|
||
(ctf_add_forward): Likewise.
|
||
(ctf_add_typedef): Likewise.
|
||
|
||
2021-01-27 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-open.c (init_types): Rip out code to check anonymous typedef
|
||
nodes.
|
||
* ctf-create.c (ctf_add_reftype): Likewise.
|
||
* ctf-lookup.c (refresh_pptrtab): Likewise.
|
||
|
||
2021-01-27 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-impl.c (_libctf_nonnull_): Add parameters.
|
||
(LCTF_LINKING): New flag.
|
||
(ctf_dict_t) <ctf_link_flags>: Mention it.
|
||
* ctf-link.c (ctf_link): Keep LCTF_LINKING set across call.
|
||
(ctf_write): Likewise, including in child dictionaries.
|
||
(ctf_link_shuffle_syms): Make sure ctf_dynsyms is NULL if there
|
||
are no reported symbols.
|
||
* ctf-create.c (symtypetab_delete_nonstatic_vars): Make sure
|
||
the variable has been reported as a symbol by the linker.
|
||
(symtypetab_skippable): Mention relationship between SYMFP and the
|
||
flags.
|
||
(symtypetab_density): Adjust nonnullity. Exit early if no symbols
|
||
were reported and force-indexing is off (i.e., we are doing a
|
||
final link).
|
||
(ctf_serialize): Handle the !LCTF_LINKING case by writing out an
|
||
indexed, sorted symtypetab (and allow SYMFP to be NULL in this
|
||
case). Turn sorting off if this is a non-final link. Only delete
|
||
nonstatic vars if we are filtering symbols and the linker has
|
||
reported some.
|
||
* testsuite/libctf-regression/nonstatic-var-section-ld-r*:
|
||
New test of variable and symtypetab section population when
|
||
ld -r is used.
|
||
* testsuite/libctf-regression/nonstatic-var-section-ld-executable.lk:
|
||
Likewise, when ld of an executable is used.
|
||
* testsuite/libctf-regression/nonstatic-var-section-ld.lk:
|
||
Likewise, when ld -shared alone is used.
|
||
* testsuite/libctf-regression/nonstatic-var-section-ld*.c:
|
||
Lookup programs for the above.
|
||
* testsuite/libctf-writable/symtypetab-nonlinker-writeout.*: New
|
||
test, testing survival of symbols across ctf_write paths.
|
||
* testsuite/lib/ctf-lib.exp (run_lookup_test): New option,
|
||
nonshared, suppressing linking of the SOURCE with -shared.
|
||
|
||
2021-01-19 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-create.c (membadd): Transform ""-named members into
|
||
NULL-named ones.
|
||
* testsuite/libctf-regression/type-add-unnamed-struct*: New test.
|
||
|
||
2021-01-19 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-lookup.c (ctf_lookup_by_name_internal): Do not return the
|
||
base type if looking up a nonexistent pointer type.
|
||
* testsuite/libctf-regression/pptrtab*: Test it.
|
||
|
||
2021-01-13 Alan Modra <amodra@gmail.com>
|
||
|
||
* Makefile.in: Regenerate.
|
||
|
||
2021-01-12 H.J. Lu <hongjiu.lu@intel.com>
|
||
|
||
PR binutils/26792
|
||
* configure.ac: Use GNU_MAKE_JOBSERVER.
|
||
* aclocal.m4: Regenerated.
|
||
* configure: Likewise.
|
||
|
||
2021-01-11 H.J. Lu <hongjiu.lu@intel.com>
|
||
|
||
PR ld/27173
|
||
* configure: Regenerated.
|
||
|
||
2021-01-09 H.J. Lu <hongjiu.lu@intel.com>
|
||
|
||
* configure: Regenerated.
|
||
|
||
2021-01-09 Nick Clifton <nickc@redhat.com>
|
||
|
||
* 2.36 release branch crated.
|
||
|
||
2021-01-09 Alan Modra <amodra@gmail.com>
|
||
|
||
* configure: Regenerate.
|
||
|
||
2021-01-07 Samuel Thibault <samuel.thibault@gnu.org>
|
||
|
||
* configure: Regenerate.
|
||
|
||
2021-01-05 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* testsuite/libctf-lookup/struct-iteration.c (main):
|
||
ctf_member_count returns an int.
|
||
|
||
2021-01-05 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* Makefile.am (BASEDIR): New.
|
||
(BFDDIR): Likewise.
|
||
(check-DEJAGNU): Add development.exp to prerequisites.
|
||
(development.exp): New.
|
||
(CONFIG_STATUS_DEPENDENCIES): New.
|
||
(EXTRA_DEJAGNU_SITE_CONFIG): Likewise.
|
||
(DISTCLEANFILES): Likewise.
|
||
* Makefile.in: Regenerated.
|
||
* testsuite/lib/ctf-lib.exp (check_ctf_available): Return boolean.
|
||
* testsuite/libctf-lookup/lookup.exp: Call check_ctf_available.
|
||
* testsuite/libctf-regression/regression.exp: Likewise.
|
||
|
||
2021-01-05 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-types.c (ctf_type_aname): Print forwards to unions and enums
|
||
properly.
|
||
|
||
2021-01-05 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-impl.h (ctf_dict_t) <ctf_pptrtab>: New.
|
||
<ctf_pptrtab_len>: New.
|
||
<ctf_pptrtab_typemax>: New.
|
||
* ctf-create.c (ctf_serialize): Update accordingly.
|
||
(ctf_add_reftype): Note that we don't need to update pptrtab here,
|
||
despite updating ptrtab.
|
||
* ctf-open.c (ctf_dict_close): Destroy the pptrtab.
|
||
(ctf_import): Likewise.
|
||
(ctf_import_unref): Likewise.
|
||
* ctf-lookup.c (grow_pptrtab): New.
|
||
(refresh_pptrtab): New, update a pptrtab.
|
||
(ctf_lookup_by_name): Turn into a wrapper around (and rename to)...
|
||
(ctf_lookup_by_name_internal): ... this: construct the pptrtab, and
|
||
use it in addition to the parent's ptrtab when parent dicts are
|
||
searched.
|
||
* testsuite/libctf-regression/regression.exp: New testsuite for
|
||
regression tests.
|
||
* testsuite/libctf-regression/pptrtab*: New test.
|
||
* testsuite/libctf-writable/writable.exp: New testsuite for tests of
|
||
writable CTF dicts.
|
||
* testsuite/libctf-writable/pptrtab*: New test.
|
||
|
||
2021-01-05 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-archive.c (ctf_archive_iter): Remove outdated comment.
|
||
|
||
2021-01-05 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-impl.h (struct ctf_next) <u.ctn_next>: Move to...
|
||
<ctn_next>: ... here.
|
||
* ctf-util.c (ctf_next_destroy): Unconditionally destroy it.
|
||
* ctf-lookup.c (ctf_symbol_next): Adjust accordingly.
|
||
* ctf-types.c (ctf_member_iter): Reimplement in terms of...
|
||
(ctf_member_next): ... this. Support recursive unnamed member
|
||
iteration (off by default).
|
||
(ctf_member_info): Look up members in unnamed sub-structs.
|
||
* ctf-dedup.c (ctf_dedup_rhash_type): Adjust ctf_member_next call.
|
||
(ctf_dedup_emit_struct_members): Likewise.
|
||
* testsuite/libctf-lookup/struct-iteration-ctf.c: Test empty unnamed
|
||
members, and a normal member after the end.
|
||
* testsuite/libctf-lookup/struct-iteration.c: Verify that
|
||
ctf_member_count is consistent with the number of successful returns
|
||
from a non-recursive ctf_member_next.
|
||
* testsuite/libctf-lookup/struct-iteration-*: New, test iteration
|
||
over struct members.
|
||
* testsuite/libctf-lookup/struct-lookup.c: New test.
|
||
* testsuite/libctf-lookup/struct-lookup.lk: New test.
|
||
|
||
2021-01-05 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-link.c (ctf_link_warn_outdated_inputs): New.
|
||
(ctf_link_write): Call it.
|
||
|
||
2021-01-05 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* testsuite/libctf-lookup/enum-symbol.lk: New symbol-lookup test.
|
||
* testsuite/libctf-lookup/enum-symbol-ctf.c: New CTF input.
|
||
* testsuite/libctf-lookup/enum-symbol.c: New lookup test.
|
||
|
||
2021-01-05 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* Makefile.am (EXPECT): New.
|
||
(RUNTEST): Likewise.
|
||
(RUNTESTFLAGS): Likewise.
|
||
(CC_FOR_TARGET): Likewise.
|
||
(check-DEJAGNU): Likewise.
|
||
(AUTOMAKE_OPTIONS): Add dejagnu.
|
||
* Makefile.in: Regenerated.
|
||
* testsuite/config/default.exp: New.
|
||
* testsuite/lib/ctf-lib.exp: Likewise.
|
||
* testsuite/libctf-lookup/enum.lk: New test.
|
||
* testsuite/libctf-lookup/enum-ctf.c: New CTF input.
|
||
* testsuite/libctf-lookup/enum.c: New lookup test.
|
||
* testsuite/libctf-lookup/ambiguous-struct*.c: New test.
|
||
* testsuite/libctf-lookup/lookup.exp: New.
|
||
|
||
2021-01-05 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* configure.ac (BFD_LIBADD): Remove.
|
||
(BFD_DEPENDENCIES): Likewise. Remove associated cases.
|
||
(SHARED_LIBADD): Rename to...
|
||
(CTF_LIBADD): ... this. Stick in a suitable libiberty even when
|
||
linking statically.
|
||
* Makefile.am (libctf_nobfd_la_LIBADD): Adjust accordingly.
|
||
libctf uses libintl.
|
||
(libctf_la_LIBADD): Reference libbfd.la directly, not via
|
||
BFD_LIBADD.
|
||
(libctf_la_DEPENDENCIES): Remove.
|
||
* Makefile.in: Regenerate.
|
||
* configure: Likewise.
|
||
|
||
2021-01-05 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-decl.c (ctf_decl_push): Exclude slices from the decl stack.
|
||
* ctf-types.c (ctf_type_aname): No longer deal with slices here.
|
||
* ctf-dump.c (ctf_dump_membstate_t) <cdm_toplevel_indent>: Constify.
|
||
(CTF_FT_REFS): New.
|
||
(CTF_FT_BITFIELD): Likewise.
|
||
(CTF_FT_ID): Likewise.
|
||
(ctf_dump_member): Do not do indentation here. Migrate the
|
||
type-printing parts of this into...
|
||
(ctf_dump_format_type): ... here, to be shared by all type printers.
|
||
Get the errno value for non-representable types right. Do not print
|
||
bitfield info for non-bitfields. Improve the format and indentation
|
||
of other type output. Shuffle spacing around to make all indentation
|
||
either 'width of column' or 4 chars.
|
||
(ctf_dump_label): Pass CTF_FT_REFS to ctf_dump_format_type.
|
||
(ctf_dump_objts): Likewise. Spacing shuffle.
|
||
(ctf_dump_var): Likewise.
|
||
(type_hex_digits): Migrate down in the file, to above its new user.
|
||
(ctf_dump_type): Indent here instead. Pass CTF_FT_REFS to
|
||
ctf_dump_format_type. Don't trim off excess linefeeds now we no
|
||
longer generate them. Dump enumerated types.
|
||
|
||
2021-01-05 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-types.c (ctf_type_resolve): Improve comment.
|
||
(ctf_type_size): Yield ECTF_INCOMPLETE when applied to forwards.
|
||
Emit errors into the right dict.
|
||
(ctf_type_align): Likewise.
|
||
* ctf-create.c (ctf_add_member_offset): Yield ECTF_INCOMPLETE
|
||
when adding a member without explicit offset when this member, or
|
||
the previous member, is incomplete.
|
||
* ctf-dump.c (ctf_dump_format_type): Do not try to print the size of
|
||
forwards.
|
||
(ctf_dump_member): Do not try to print their alignment.
|
||
|
||
2021-01-05 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-dump.c (ctf_dump_objts): Dump by calling ctf_dump_format_type.
|
||
(ctf_dump_format_type): Don't emit the size for function objects.
|
||
Dump the element type of arrays like we dump the pointed-to type of
|
||
pointers, etc.
|
||
|
||
2021-01-05 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-dump.c (ctf_dump_format_type): Add 0x to hex type IDs.
|
||
(ctf_dump_header): Add 0x to the hex magic number.
|
||
(ctf_dump_str): Add 0x to the hex string offsets.
|
||
(ctf_dump_membstate_t) <cdm_toplevel_indent>: New.
|
||
(ctf_dump_type): Adjust. Free it when we're done.
|
||
(type_hex_digits): New.
|
||
(ctf_dump_member): Align output depending on the width of the type
|
||
ID being generated. Use printf padding, not a loop, to generate
|
||
indentation.
|
||
|
||
2021-01-05 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-decl.c (ctf_decl_push): Don't print array decls backwards.
|
||
|
||
2021-01-04 Nicolas Boulenguez <nicolas@debian.org>
|
||
|
||
PR 27117
|
||
* configure.ac: Make AC_CONFIG_MACRO_DIR consistent with
|
||
ACLOCAL_AMFLAGS -I dirs.
|
||
* configure: Regenerate.
|
||
|
||
2021-01-01 Alan Modra <amodra@gmail.com>
|
||
|
||
Update year range in copyright notice of all files.
|
||
|
||
For older changes see ChangeLog-2020
|
||
|
||
Copyright (C) 2021 Free Software Foundation, Inc.
|
||
|
||
Copying and distribution of this file, with or without modification,
|
||
are permitted in any medium without royalty provided the copyright
|
||
notice and this notice are preserved.
|
||
|
||
Local Variables:
|
||
mode: change-log
|
||
left-margin: 8
|
||
fill-column: 74
|
||
version-control: never
|
||
End:
|