binutils-gdb/gdbserver
Pedro Alves e8a625d126 Report thread exit event for leader if reporting thread exit events
If GDB sets the GDB_THREAD_OPTION_EXIT option on a thread, then if the
thread disappears from the thread list, GDB expects to shortly see a
thread exit event for it.  See e.g., here, in
remote_target::update_thread_list():

    /* Do not remove the thread if we've requested to be
       notified of its exit.  For example, the thread may be
       displaced stepping, infrun will need to handle the
       exit event, and displaced stepping info is recorded
       in the thread object.  If we deleted the thread now,
       we'd lose that info.  */
    if ((tp->thread_options () & GDB_THREAD_OPTION_EXIT) != 0)
      continue;

There's one scenario that is deleting a thread from the
remote/gdbserver thread list without ever reporting a corresponding
thread exit event though -- check_zombie_leaders.  This can lead to
GDB getting confused.  For example, with a following patch that
enables GDB_THREAD_OPTION_EXIT whenever schedlock is enabled, we'd see
this regression:

 $ make check RUNTESTFLAGS="--target_board=native-extended-gdbserver" TESTS="gdb.threads/no-unwaited-for-left.exp"
 ...
 Running src/gdb/testsuite/gdb.threads/no-unwaited-for-left.exp ...
 FAIL: gdb.threads/no-unwaited-for-left.exp: continue stops when the main thread exits (timeout)
 ... some more cascading FAILs ...

gdb.log shows:

 (gdb) continue
 Continuing.
 FAIL: gdb.threads/no-unwaited-for-left.exp: continue stops when the main thread exits (timeout)

A passing run would have resulted in:

 (gdb) continue
 Continuing.
 No unwaited-for children left.
 (gdb) PASS: gdb.threads/no-unwaited-for-left.exp: continue stops when the main thread exits

note how the leader thread is not listed in the remote-reported XML
thread list below:

 (gdb) set debug remote 1
 (gdb) set debug infrun 1
 (gdb) info threads
   Id   Target Id                                Frame
 * 1    Thread 1163850.1163850 "no-unwaited-for" main () at /home/pedro/rocm/gdb/build/gdb/testsuite/../../../src/gdb/testsuite/gdb.threads/no-unwaited-for-left.c:65
   3    Thread 1163850.1164130 "no-unwaited-for" [remote] Sending packet: $Hgp11c24a.11c362#39
 (gdb) c
 Continuing.
 [infrun] clear_proceed_status_thread: 1163850.1163850.0
 ...
     [infrun] resume_1: step=1, signal=GDB_SIGNAL_0, trap_expected=1, current thread [1163850.1163850.0] at 0x55555555534f
     [remote] Sending packet: $QPassSignals:#f3
     [remote] Packet received: OK
     [remote] Sending packet: $QThreadOptions;3:p11c24a.11c24a#f3
     [remote] Packet received: OK
 ...
     [infrun] target_set_thread_options: [options for Thread 1163850.1163850 are now 0x3]
 ...
   [infrun] do_target_resume: resume_ptid=1163850.1163850.0, step=0, sig=GDB_SIGNAL_0
   [remote] Sending packet: $vCont;c:p11c24a.11c24a#98
   [infrun] prepare_to_wait: prepare_to_wait
   [infrun] reset: reason=handling event
   [infrun] maybe_set_commit_resumed_all_targets: enabling commit-resumed for target extended-remote
   [infrun] maybe_call_commit_resumed_all_targets: calling commit_resumed for target extended-remote
 [infrun] fetch_inferior_event: exit
 [infrun] fetch_inferior_event: enter
   [infrun] scoped_disable_commit_resumed: reason=handling event
   [infrun] random_pending_event_thread: None found.
   [remote] wait: enter
     [remote] Packet received: N
   [remote] wait: exit
   [infrun] print_target_wait_results: target_wait (-1.0.0 [process -1], status) =
   [infrun] print_target_wait_results:   -1.0.0 [process -1],
   [infrun] print_target_wait_results:   status->kind = NO_RESUMED
   [infrun] handle_inferior_event: status->kind = NO_RESUMED
   [remote] Sending packet: $Hgp0.0#ad
   [remote] Packet received: OK
   [remote] Sending packet: $qXfer:threads:read::0,1000#92
   [remote] Packet received: l<threads>\n<thread id="p11c24a.11c362" core="0" name="no-unwaited-for" handle="0097d8f7ff7f0000"/>\n</threads>\n
   [infrun] handle_no_resumed: TARGET_WAITKIND_NO_RESUMED (ignoring: found resumed)
 ...

... however, infrun decided there was a resumed thread still, so
ignored the TARGET_WAITKIND_NO_RESUMED event.  Debugging GDB, we see
that the "found resumed" thread that GDB finds, is the leader thread.
Even though that thread is not on the remote-reported thread list, it
is still on the GDB thread list, due to the special case in remote.c
mentioned above.

This commit addresses the issue by fixing GDBserver to report a thread
exit event for the zombie leader too, i.e., making GDBserver respect
the "if thread has GDB_THREAD_OPTION_EXIT set, report a thread exit"
invariant.  To do that, it takes a bit more code than one would
imagine off hand, due to the fact that we currently always report LWP
exit pending events as TARGET_WAITKIND_EXITED, and then decide whether
to convert it to TARGET_WAITKIND_THREAD_EXITED just before reporting
the event to GDBserver core.  For the zombie leader scenario
described, we need to record early on that we want to report a
THREAD_EXITED event, and then make sure that decision isn't lost along
the way to reporting the event to GDBserver core.

Reviewed-By: Andrew Burgess <aburgess@redhat.com>
Change-Id: I1e68fccdbc9534434dee07163d3fd19744c8403b
2023-11-13 14:16:11 +00:00
..
.dir-locals.el
.gitattributes
.gitignore
acinclude.m4
aclocal.m4
ax-result-types.def gdbserver: handle all eval_result_type values in tracepoint.cc 2023-07-10 14:42:54 +01:00
ax.cc [gdb] Fix typos 2023-06-03 22:43:57 +02:00
ax.h gdbserver: handle all eval_result_type values in tracepoint.cc 2023-07-10 14:42:54 +01:00
ChangeLog-2002-2021
config.in gdb/gdbsupport/gdbserver: Require c++17 2023-10-28 19:25:34 +00:00
configure gdb/gdbsupport/gdbserver: Require c++17 2023-10-28 19:25:34 +00:00
configure.ac gdb/gdbsupport/gdbserver: Require c++17 2023-10-28 19:25:34 +00:00
configure.srv sme: Enable SME registers and pseudo-registers 2023-10-04 16:23:39 +01:00
debug.cc
debug.h
dll.cc
dll.h
fork-child.cc
gdb_proc_service.h
gdbreplay.cc
gdbthread.h Thread options & clone events (core + remote) 2023-11-13 14:16:09 +00:00
hostio.cc
hostio.h
i387-fp.cc gdbserver: i387_cache_to_xsave: fix copy dest of zmm registers 2023-09-01 22:13:01 -04:00
i387-fp.h gdbserver: Add a function to set the XSAVE mask and size. 2023-08-28 14:18:19 -07:00
inferiors.cc
inferiors.h [gdb] Fix typos 2023-06-03 22:43:57 +02:00
linux-aarch32-low.cc
linux-aarch32-low.h
linux-aarch32-tdesc.cc
linux-aarch32-tdesc.h
linux-aarch64-ipa.cc
linux-aarch64-low.cc sme2: Enable SME2 support in gdbserver 2023-10-04 16:23:40 +01:00
linux-aarch64-tdesc.cc sme: Add support for SME 2023-10-04 16:23:40 +01:00
linux-aarch64-tdesc.h
linux-amd64-ipa.cc
linux-arc-low.cc [gdb] Fix typos 2023-06-03 22:43:57 +02:00
linux-arm-low.cc
linux-arm-tdesc.cc
linux-arm-tdesc.h
linux-csky-low.cc gdbserver: fix gdbserver builds after expedite_regs changes 2023-10-06 13:16:16 +01:00
linux-i386-ipa.cc
linux-ia64-low.cc
linux-loongarch-low.cc gdbserver: fix gdbserver builds after expedite_regs changes 2023-10-06 13:16:16 +01:00
linux-low.cc Report thread exit event for leader if reporting thread exit events 2023-11-13 14:16:11 +00:00
linux-low.h Report thread exit event for leader if reporting thread exit events 2023-11-13 14:16:11 +00:00
linux-m68k-low.cc
linux-mips-low.cc
linux-nios2-low.cc
linux-or1k-low.cc
linux-ppc-ipa.cc
linux-ppc-low.cc [gdb] Fix typos 2023-06-03 22:43:57 +02:00
linux-ppc-tdesc-init.h
linux-riscv-low.cc gdbserver: fix gdbserver builds after expedite_regs changes 2023-10-06 13:16:16 +01:00
linux-s390-ipa.cc
linux-s390-low.cc
linux-s390-tdesc.h
linux-sh-low.cc
linux-sparc-low.cc
linux-tic6x-low.cc
linux-x86-low.cc gdbserver: Add a function to set the XSAVE mask and size. 2023-08-28 14:18:19 -07:00
linux-x86-tdesc.cc
linux-x86-tdesc.h
linux-xtensa-low.cc
Makefile.in refactor: Rename SVE-specific files 2023-10-04 16:23:39 +01:00
mem-break.cc gdb: handle main thread exiting during detach 2023-10-26 18:11:54 +01:00
mem-break.h
netbsd-aarch64-low.cc
netbsd-amd64-low.cc
netbsd-i386-low.cc
netbsd-low.cc
netbsd-low.h
notif.cc
notif.h
proc-service.cc
proc-service.list
README
regcache.cc
regcache.h
remote-utils.cc Support clone events in the remote protocol 2023-11-13 14:16:09 +00:00
remote-utils.h
server.cc gdbserver: Queue no-resumed event after thread exit 2023-11-13 14:16:11 +00:00
server.h sme: Add support for SME 2023-10-04 16:23:40 +01:00
symbol.cc
target.cc gdbserver: Queue no-resumed event after thread exit 2023-11-13 14:16:11 +00:00
target.h gdbserver: Queue no-resumed event after thread exit 2023-11-13 14:16:11 +00:00
tdesc.cc Convert tdesc's expedite_regs to a string vector 2023-10-04 16:23:39 +01:00
tdesc.h Convert tdesc's expedite_regs to a string vector 2023-10-04 16:23:39 +01:00
thread-db.cc
tracepoint.cc Remove EXTERN_C and related defines 2023-11-06 20:31:12 -07:00
tracepoint.h Remove EXTERN_C and related defines 2023-11-06 20:31:12 -07:00
utils.cc
utils.h
win32-i386-low.cc
win32-low.cc [gdb] Fix typos 2023-06-03 22:43:57 +02:00
win32-low.h
x86-low.cc
x86-low.h
x86-tdesc.h
xtensa-xtregs.cc

		   README for GDBserver & GDBreplay
		    by Stu Grossman and Fred Fish

Introduction:

This is GDBserver, a remote server for Un*x-like systems.  It can be used to
control the execution of a program on a target system from a GDB on a different
host.  GDB and GDBserver communicate using the standard remote serial protocol.
They communicate via either a serial line or a TCP connection.

For more information about GDBserver, see the GDB manual:

    https://sourceware.org/gdb/current/onlinedocs/gdb/Remote-Protocol.html

Usage (server (target) side):

First, you need to have a copy of the program you want to debug put onto
the target system.  The program can be stripped to save space if needed, as
GDBserver doesn't care about symbols.  All symbol handling is taken care of by
the GDB running on the host system.

To use the server, you log on to the target system, and run the `gdbserver'
program.  You must tell it (a) how to communicate with GDB, (b) the name of
your program, and (c) its arguments.  The general syntax is:

	target> gdbserver COMM PROGRAM [ARGS ...]

For example, using a serial port, you might say:

	target> gdbserver /dev/com1 emacs foo.txt

This tells GDBserver to debug emacs with an argument of foo.txt, and to
communicate with GDB via /dev/com1.  GDBserver now waits patiently for the
host GDB to communicate with it.

To use a TCP connection, you could say:

	target> gdbserver host:2345 emacs foo.txt

This says pretty much the same thing as the last example, except that we are
going to communicate with the host GDB via TCP.  The `host:2345' argument means
that we are expecting to see a TCP connection to local TCP port 2345.
(Currently, the `host' part is ignored.)  You can choose any number you want for
the port number as long as it does not conflict with any existing TCP ports on
the target system.  This same port number must be used in the host GDB's
`target remote' command, which will be described shortly. Note that if you chose
a port number that conflicts with another service, GDBserver will print an error
message and exit.

On some targets, GDBserver can also attach to running programs.  This is
accomplished via the --attach argument.  The syntax is:

	target> gdbserver --attach COMM PID

PID is the process ID of a currently running process.  It isn't necessary
to point GDBserver at a binary for the running process.

Usage (host side):

You need an unstripped copy of the target program on your host system, since
GDB needs to examine it's symbol tables and such.  Start up GDB as you normally
would, with the target program as the first argument.  (You may need to use the
--baud option if the serial line is running at anything except 9600 baud.)
Ie: `gdb TARGET-PROG', or `gdb --baud BAUD TARGET-PROG'.  After that, the only
new command you need to know about is `target remote'.  It's argument is either
a device name (usually a serial device, like `/dev/ttyb'), or a HOST:PORT
descriptor.  For example:

	(gdb) target remote /dev/ttyb

communicates with the server via serial line /dev/ttyb, and:

	(gdb) target remote the-target:2345

communicates via a TCP connection to port 2345 on host `the-target', where
you previously started up GDBserver with the same port number.  Note that for
TCP connections, you must start up GDBserver prior to using the `target remote'
command, otherwise you may get an error that looks something like
`Connection refused'.

Building GDBserver:

See the `configure.srv` file for the list of host triplets you can build
GDBserver for.

Building GDBserver for your host is very straightforward.  If you build
GDB natively on a host which GDBserver supports, it will be built
automatically when you build GDB.  You can also build just GDBserver:

	% mkdir obj
	% cd obj
	% path-to-toplevel-sources/configure --disable-gdb
	% make all-gdbserver

(If you have a combined binutils+gdb tree, you may want to also
disable other directories when configuring, e.g., binutils, gas, gold,
gprof, and ld.)

If you prefer to cross-compile to your target, then you can also build
GDBserver that way.  For example:

	% export CC=your-cross-compiler
	% path-to-topevel-sources/configure --disable-gdb
	% make all-gdbserver

Using GDBreplay:

A special hacked down version of GDBserver can be used to replay remote
debug log files created by GDB.  Before using the GDB "target" command to
initiate a remote debug session, use "set remotelogfile <filename>" to tell
GDB that you want to make a recording of the serial or tcp session.  Note
that when replaying the session, GDB communicates with GDBreplay via tcp,
regardless of whether the original session was via a serial link or tcp.

Once you are done with the remote debug session, start GDBreplay and
tell it the name of the log file and the host and port number that GDB
should connect to (typically the same as the host running GDB):

	$ gdbreplay logfile host:port

Then start GDB (preferably in a different screen or window) and use the
"target" command to connect to GDBreplay:

	(gdb) target remote host:port

Repeat the same sequence of user commands to GDB that you gave in the
original debug session.  GDB should not be able to tell that it is talking
to GDBreplay rather than a real target, all other things being equal.  Note
that GDBreplay echos the command lines to stderr, as well as the contents of
the packets it sends and receives.  The last command echoed by GDBreplay is
the next command that needs to be typed to GDB to continue the session in
sync with the original session.