mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-06 12:09:26 +08:00
40310f30a5
The test gdb.arch/amd64-disp-step-avx.exp is meant to test that doing a displaced step of an AVX instruction works correctly. However, I found (by pure coincidence) that the test instructions are not actually displaced stepped. Rather, they are inline-stepped, so the test is not actually testing what it's meant to test. This is what a portion of the test binary looks like: 0000000000400180 <_start>: 400180: 90 nop 0000000000400181 <main>: 400181: 90 nop 0000000000400182 <test_rip_vex2>: 400182: c5 fb 10 05 0e 00 00 vmovsd 0xe(%rip),%xmm0 # 400198 <ro_var> 400189: 00 000000000040018a <test_rip_vex2_end>: 40018a: 90 nop The instruction at 0x400182 is the one we want to test a displaced step for. A breakpoint is placed at 0x400182 and ran to. The execution is then resumed from there, forcing a step-over (which should normally be a displaced step) of the breakpoint. However, the displaced stepping buffer is at the _start label, and that means a breakpoint is present in the displaced stepping buffer. The breakpoint_in_range_p check in displaced_step_prepare_throw evaluates to true, which makes displaced_step_prepare_throw fail, forcing GDB to fall back on an in-line step. This can be easily observed by placing a `gdb_assert (false)` inside the breakpoint_in_range_p condition, in displaced_step_prepare_throw, and running gdb.arch/amd64-disp-step-avx.exp. The assertion will make the test fail. The proposed fix is to pad `_start` with a bunch of nops so that the test instruction is out of the displaced step buffer. I also think it would be good to enhance the test to make sure that we are testing displaced stepping as intended. I did that by enabling "set debug displaced on" while we step over the interesting instruction, and matching a message printed only when a displaced step is executed. gdb/testsuite/ChangeLog: * gdb.arch/amd64-disp-step-avx.S: Add nops after _start. * gdb.arch/amd64-disp-step-avx.exp: Enable "set debug displaced on" while stepping over the test instruction, match printed message.
155 lines
4.7 KiB
Plaintext
155 lines
4.7 KiB
Plaintext
# Copyright 2009-2020 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# This file is part of the gdb testsuite.
|
|
|
|
# Test displaced stepping over VEX-encoded RIP-relative AVX
|
|
# instructions.
|
|
|
|
if { ![istarget x86_64-*-* ] || ![is_lp64_target] } {
|
|
verbose "Skipping x86_64 displaced stepping tests."
|
|
return
|
|
}
|
|
|
|
standard_testfile .S
|
|
|
|
set options [list debug \
|
|
additional_flags=-static \
|
|
additional_flags=-nostartfiles]
|
|
if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} $options] } {
|
|
return -1
|
|
}
|
|
|
|
# Get things started.
|
|
|
|
gdb_test "set displaced-stepping on" ""
|
|
gdb_test "show displaced-stepping" ".* displaced stepping .* is on.*"
|
|
|
|
if ![runto_main] then {
|
|
fail "can't run to main"
|
|
return 0
|
|
}
|
|
|
|
# GDB picks a spare register from this list to hold the RIP-relative
|
|
# address.
|
|
set rip_regs { "rax" "rbx" "rcx" "rdx" "rbp" "rsi" "rdi" }
|
|
|
|
# Assign VAL to all the RIP_REGS.
|
|
|
|
proc set_regs { val } {
|
|
global gdb_prompt
|
|
global rip_regs
|
|
|
|
foreach reg ${rip_regs} {
|
|
gdb_test_no_output "set \$${reg} = ${val}"
|
|
}
|
|
}
|
|
|
|
# Verify all RIP_REGS print as HEX_VAL_RE in hex.
|
|
|
|
proc verify_regs { hex_val_re } {
|
|
global rip_regs
|
|
|
|
foreach reg ${rip_regs} {
|
|
gdb_test "p /x \$${reg}" " = ${hex_val_re}" "${reg} expected value"
|
|
}
|
|
}
|
|
|
|
# Set a break at FUNC, which starts with a RIP-relative instruction
|
|
# that we want to displaced-step over, and then continue over the
|
|
# breakpoint, forcing a displaced-stepping sequence.
|
|
|
|
proc disp_step_func { func } {
|
|
global srcfile
|
|
|
|
set test_start_label "${func}"
|
|
set test_end_label "${func}_end"
|
|
|
|
gdb_test "break ${test_start_label}" \
|
|
"Breakpoint.*at.* file .*$srcfile, line.*"
|
|
gdb_test "break ${test_end_label}" \
|
|
"Breakpoint.*at.* file .*$srcfile, line.*"
|
|
|
|
gdb_test "continue" \
|
|
"Continuing.*Breakpoint.*, ${test_start_label} ().*" \
|
|
"continue to ${test_start_label}"
|
|
|
|
# GDB picks a spare register to hold the RIP-relative address.
|
|
# Ensure the spare register value is restored properly (rax-rdi,
|
|
# sans rsp).
|
|
set value "0xdeadbeefd3adb33f"
|
|
set_regs $value
|
|
|
|
# Turn "debug displaced" on to make sure a displaced step is actually
|
|
# executed, not an inline step.
|
|
gdb_test_no_output "set debug displaced on"
|
|
|
|
gdb_test "continue" \
|
|
"Continuing.*displaced: displaced pc to.*Breakpoint.*, ${test_end_label} ().*" \
|
|
"continue to ${test_end_label}"
|
|
|
|
gdb_test_no_output "set debug displaced off"
|
|
|
|
verify_regs $value
|
|
}
|
|
|
|
# Test a VEX2-encoded RIP-relative instruction.
|
|
with_test_prefix "vex2" {
|
|
# This test writes to the 'xmm0' register. As the test is
|
|
# statically linked, we know that the XMM registers should all
|
|
# have the default value of 0 at this point in time. We're about
|
|
# to run an AVX instruction that will modify $xmm0, but lets first
|
|
# confirm that all XMM registers are 0.
|
|
for {set i 0 } { $i < 16 } { incr i } {
|
|
gdb_test "p /x \$xmm${i}.uint128" " = 0x0" \
|
|
"xmm${i} has expected value before"
|
|
}
|
|
|
|
disp_step_func "test_rip_vex2"
|
|
|
|
# Confirm the instruction's expected side effects. It should have
|
|
# modified xmm0.
|
|
gdb_test "p /x \$xmm0.uint128" " = 0x1122334455667788" \
|
|
"xmm0 has expected value after"
|
|
|
|
# And all of the other XMM register should still be 0.
|
|
for {set i 1 } { $i < 16 } { incr i } {
|
|
gdb_test "p /x \$xmm${i}.uint128" " = 0x0" \
|
|
"xmm${i} has expected value after"
|
|
}
|
|
}
|
|
|
|
# Test a VEX3-encoded RIP-relative instruction.
|
|
with_test_prefix "vex3" {
|
|
# This case writes to the 'var128' variable. Confirm the
|
|
# variable's value is what we believe it is before the AVX
|
|
# instruction runs.
|
|
gdb_test "p /x (unsigned long long \[2\]) var128" \
|
|
" = \\{0xaa55aa55aa55aa55, 0x55aa55aa55aa55aa\\}" \
|
|
"var128 has expected value before"
|
|
|
|
# Run the AVX instruction.
|
|
disp_step_func "test_rip_vex3"
|
|
|
|
# Confirm the instruction's expected side effects. It should have
|
|
# modifed the 'var128' variable.
|
|
gdb_test "p /x (unsigned long long \[2\]) var128" \
|
|
" = \\{0x1122334455667788, 0x0\\}" \
|
|
"var128 has expected value after"
|
|
}
|
|
|
|
# Done, run program to exit.
|
|
gdb_continue_to_end "amd64-disp-step-avx"
|