mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
4ee89e903d
This patch addresses slowness when setting breakpoints, especially in
heavily templatized code. Profiling showed that find_pc_sect_line in
symtab.c was the performance bottleneck. The original logic performed a
linear search over ordered data. This patch uses a binary search, as
suggested by comments around the function. There are no behavioural
changes, but gdb is now faster at setting breakpoints in template code.
Tested using on make check on an x86 target. The optimisation speeds up
the included template-breakpoints.py performance test by a factor of 7
on my machine.
ChangeLog:
2018-03-20 Stephen Roberts <stephen.roberts@arm.com>
* gdb/symtab.c (find_pc_sect_line): now uses binary search.
gdb/testsuite/
* gdb.perf/template-breakpoints.cc: New file.
* gdb.perf/template-breakpoints.exp: New file.
* gdb.perf/template-breakpoints.py: New file.
66 lines
1.6 KiB
Plaintext
66 lines
1.6 KiB
Plaintext
# Copyright (C) 2018 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# This test case is to test the performance of GDB when setting breakpoints
|
|
# on heavily temlatized C++ code.
|
|
|
|
# Parameters:
|
|
# EXPANSION_DEPTH: knob to control how many times template expansions occur
|
|
|
|
load_lib perftest.exp
|
|
|
|
if [skip_perf_tests] {
|
|
return 0
|
|
}
|
|
|
|
standard_testfile .cc
|
|
set executable $testfile
|
|
set expfile $testfile.exp
|
|
|
|
# make check-perf RUNTESTFLAGS='template-breakpoints.exp EXPANSION_DEPTH=40'
|
|
if ![info exists EXPANSION_DEPTH] {
|
|
set EXPANSION_DEPTH 40
|
|
}
|
|
|
|
PerfTest::assemble {
|
|
global EXPANSION_DEPTH
|
|
global srcdir subdir srcfile
|
|
|
|
set compile_flags {c++ debug}
|
|
lappend compile_flags "additional_flags=-DEXPANSION_DEPTH=${EXPANSION_DEPTH}"
|
|
|
|
if { [gdb_compile "$srcdir/$subdir/$srcfile" ${binfile} executable $compile_flags] != ""} {
|
|
return -1
|
|
}
|
|
|
|
return 0
|
|
} {
|
|
global binfile
|
|
|
|
clean_restart $binfile
|
|
|
|
if ![runto_main] {
|
|
fail "can't run to main"
|
|
return -1
|
|
}
|
|
|
|
return 0
|
|
} {
|
|
|
|
gdb_test "python TemplateBreakpoints().run()"
|
|
|
|
return 0
|
|
}
|