binutils-gdb/gdbserver
Andrew Burgess 0e26741636 gdb/riscv: delete target descriptions when gdb exits
It was pointed out on IRC that the RISC-V target allocates target
descriptions and stores them in a global map, and doesn't delete these
target descriptions when GDB shuts down.

This isn't a particular problem, the total number of target
descriptions we can create is very limited so creating these on demand
and holding them for the entire run on GDB seems reasonable.

However, not deleting these objects on GDB exit means extra warnings
are printed from tools like valgrind, and the address sanitiser,
making it harder to spot real issues.  As it's reasonably easy to have
GDB correctly delete these objects on exit, lets just do that.

I started by noticing that we already have a target_desc_up type, a
wrapper around unique_ptr that calls a function that will correctly
delete target descriptions, so I want to use that, but....

...that type is declared in gdb/target-descriptions.h.  If I try to
include that file in gdb/arch/riscv.c I run into a problem, that file
is compiled into both GDB and GDBServer.

OK, I could guard the include with #ifdef, but surely we can do
better.

So then I decided to move the target_desc_up type into
gdbsupport/tdesc.h, this is the interface file for generic code shared
between GDB and GDBserver (relating to target descriptions).  The
actual implementation for the delete function still lives in
gdb/target-description.c, but now gdb/arch/riscv.c can see the
declaration.  Problem solved....

... but, though RISC-V doesn't use it I've now exposed the
target_desc_up type to gdbserver, so in future someone _might_ start
using it, which is fine, except right now there's no definition of the
delete function - remember the delete I used is only defined in GDB
code.

No problem, I add an implementation of the delete operator into
gdbserver/tdesc.cc, and all is good..... except....

I start getting this error from GCC:

  tdesc.cc:109:10: error: deleting object of polymorphic class type ‘target_desc’ which has non-virtual destructor might cause undefined behavior [-Werror=delete-non-virtual-dtor]

Which is caused because gdbserver's target_desc type inherits from
tdesc_element which has a virtual method, and so GCC worries that
target_desc might be used as a base class.

The solution is to declare gdbserver's target_desc class as final.
This is fine so long as we never intent to inherit from
target_desc (in gdbserver).  But if we did then we'd want to make
target_desc's destructor virtual anyway, so the error above would be
resolved, and there wouldn't be an issue.

gdb/ChangeLog:

	* arch/riscv.c (riscv_tdesc_cache): Change map type.
	(riscv_lookup_target_description): Return pointer out of
	unique_ptr.
	* target-descriptions.c (allocate_target_description): Add
	comment.
	(target_desc_deleter::operator()): Likewise.
	* target-descriptions.h (struct target_desc_deleter): Moved to
	gdbsupport/tdesc.h.
	(target_desc_up): Likewise.

gdbserver/ChangeLog:

	* tdesc.cc (allocate_target_description): Add header comment.
	(target_desc_deleter::operator()): New function.
	* tdesc.h (struct target_desc): Declare as final.

gdbsupport/ChangeLog:

	* tdesc.h (struct target_desc_deleter): Moved here
	from gdb/target-descriptions.h, extend comment.
	(target_desc_up): Likewise.
2020-07-17 21:15:32 +01:00
..
.dir-locals.el gdbserver/gdbsupport: Add .dir-locals.el file 2020-03-06 11:29:46 +00:00
.gitattributes gdb, gdbserver, gdbsupport: add .gitattributes files 2020-03-05 15:59:22 +01:00
.gitignore
acinclude.m4 Fix gdbserver build when intl already built 2020-03-12 13:32:15 -06:00
aclocal.m4
ax.cc [gdbserver] Fix Wlto-type-mismatch for debug_agent 2020-06-12 18:36:56 +02:00
ax.h [gdbserver] Add missing include of gdbsupport/agent.h 2020-06-29 12:14:10 +02:00
ChangeLog gdb/riscv: delete target descriptions when gdb exits 2020-07-17 21:15:32 +01:00
config.in gdb, gdbserver: remove configure check for fs_base/gs_base in user_regs_struct 2020-04-27 10:47:50 -04:00
configure gdbserver: remove support for Neutrino 2020-06-12 16:06:41 -04:00
configure.ac gdbserver: remove support for Neutrino 2020-06-12 16:06:41 -04:00
configure.srv gdbserver: remove support for ARM/WinCE 2020-06-12 16:06:45 -04:00
debug.cc gdbserver: rename source files to .cc 2020-02-13 16:27:51 -05:00
debug.h
dll.cc gdbserver: rename source files to .cc 2020-02-13 16:27:51 -05:00
dll.h
fork-child.cc gdbserver: rename source files to .cc 2020-02-13 16:27:51 -05:00
gdb_proc_service.h
gdbreplay.cc gdbserver: rename source files to .cc 2020-02-13 16:27:51 -05:00
gdbthread.h
hostio-errno.cc gdbserver: rename source files to .cc 2020-02-13 16:27:51 -05:00
hostio.cc gdbserver: finish turning the target ops vector into a class 2020-02-20 17:35:20 +01:00
hostio.h
i387-fp.cc gdbserver: rename source files to .cc 2020-02-13 16:27:51 -05:00
i387-fp.h
inferiors.cc gdbserver: rename source files to .cc 2020-02-13 16:27:51 -05:00
inferiors.h
linux-aarch32-low.cc gdbserver: finish turning the target ops vector into a class 2020-02-20 17:35:20 +01:00
linux-aarch32-low.h
linux-aarch32-tdesc.cc gdbserver: rename source files to .cc 2020-02-13 16:27:51 -05:00
linux-aarch32-tdesc.h
linux-aarch64-ipa.cc gdbserver: rename source files to .cc 2020-02-13 16:27:51 -05:00
linux-aarch64-low.cc gdbserver/linux-low: delete 'linux_target_ops' and 'the_low_target' 2020-04-02 15:11:32 +02:00
linux-aarch64-tdesc.cc gdbserver: rename source files to .cc 2020-02-13 16:27:51 -05:00
linux-aarch64-tdesc.h
linux-amd64-ipa.cc gdbserver: rename source files to .cc 2020-02-13 16:27:51 -05:00
linux-arm-low.cc gdbserver/linux-low: delete 'linux_target_ops' and 'the_low_target' 2020-04-02 15:11:32 +02:00
linux-arm-tdesc.cc gdbserver: rename source files to .cc 2020-02-13 16:27:51 -05:00
linux-arm-tdesc.h
linux-i386-ipa.cc gdbserver: rename source files to .cc 2020-02-13 16:27:51 -05:00
linux-ia64-low.cc gdbserver/linux-ia64-low: fix a build-breaking typo 2020-05-16 10:45:40 +02:00
linux-low.cc gdbserver/linux-low: use std::list to store pending signals 2020-06-22 14:13:48 +02:00
linux-low.h gdbserver/linux-low: use std::list to store pending signals 2020-06-22 14:13:48 +02:00
linux-m68k-low.cc gdbserver/linux-low: delete 'linux_target_ops' and 'the_low_target' 2020-04-02 15:11:32 +02:00
linux-mips-low.cc gdbserver/linux-low: delete 'linux_target_ops' and 'the_low_target' 2020-04-02 15:11:32 +02:00
linux-nios2-low.cc gdbserver/linux-low: delete 'linux_target_ops' and 'the_low_target' 2020-04-02 15:11:32 +02:00
linux-ppc-ipa.cc gdbserver: rename source files to .cc 2020-02-13 16:27:51 -05:00
linux-ppc-low.cc gdbserver/linux-low: delete 'linux_target_ops' and 'the_low_target' 2020-04-02 15:11:32 +02:00
linux-ppc-tdesc-init.h
linux-riscv-low.cc gdbserver/linux-low: delete 'linux_target_ops' and 'the_low_target' 2020-04-02 15:11:32 +02:00
linux-s390-ipa.cc gdbserver: rename source files to .cc 2020-02-13 16:27:51 -05:00
linux-s390-low.cc gdbserver/linux-low: delete 'linux_target_ops' and 'the_low_target' 2020-04-02 15:11:32 +02:00
linux-s390-tdesc.h
linux-sh-low.cc gdbserver/linux-low: delete 'linux_target_ops' and 'the_low_target' 2020-04-02 15:11:32 +02:00
linux-sparc-low.cc gdbserver/linux-low: delete 'linux_target_ops' and 'the_low_target' 2020-04-02 15:11:32 +02:00
linux-tic6x-low.cc gdbserver/linux-low: delete 'linux_target_ops' and 'the_low_target' 2020-04-02 15:11:32 +02:00
linux-x86-low.cc gdbserver: fix memory leak when handling qsupported packet 2020-07-13 22:27:01 -04:00
linux-x86-tdesc.cc gdbserver: rename source files to .cc 2020-02-13 16:27:51 -05:00
linux-x86-tdesc.h
linux-xtensa-low.cc gdbserver/linux-low: delete 'linux_target_ops' and 'the_low_target' 2020-04-02 15:11:32 +02:00
Makefile.in gdb, gdbserver: remove ARM regdat files 2020-06-17 14:42:53 -04:00
mem-break.cc gdbserver: finish turning the target ops vector into a class 2020-02-20 17:35:20 +01:00
mem-break.h
notif.cc gdbserver: rename source files to .cc 2020-02-13 16:27:51 -05:00
notif.h
proc-service.cc gdbserver/linux-low: turn 'regs_info' into a method 2020-04-02 15:11:23 +02:00
proc-service.list
README gdbserver: small cleanup of README file 2020-06-12 16:01:35 -04:00
regcache.cc Namespace the reg class to avoid clashes with OS headers 2020-03-18 03:36:25 +01:00
regcache.h
remote-utils.cc gdbserver: remove support for Neutrino 2020-06-12 16:06:41 -04:00
remote-utils.h
server.cc gdbserver: fix memory leak when handling qsupported packet 2020-07-13 22:27:01 -04:00
server.h gdbserver: remove support for ARM/WinCE 2020-06-12 16:06:45 -04:00
symbol.cc gdbserver: rename source files to .cc 2020-02-13 16:27:51 -05:00
target.cc gdbserver: fix memory leak when handling qsupported packet 2020-07-13 22:27:01 -04:00
target.h gdbserver: fix memory leak when handling qsupported packet 2020-07-13 22:27:01 -04:00
tdesc.cc gdb/riscv: delete target descriptions when gdb exits 2020-07-17 21:15:32 +01:00
tdesc.h gdb/riscv: delete target descriptions when gdb exits 2020-07-17 21:15:32 +01:00
thread-db.cc gdbserver/linux-low: turn process/thread addition/deletion ops into methods 2020-04-02 15:11:28 +02:00
tracepoint.cc gdbserver: turn fast tracepoint target ops into methods 2020-02-20 17:35:15 +01:00
tracepoint.h
utils.cc Remove gdb_fildes_t 2020-04-13 14:10:04 -06:00
utils.h Remove gdb_fildes_t 2020-04-13 14:10:04 -06:00
win32-i386-low.cc Enable hardware breakpoints for gdbserver on Windows 2020-05-15 10:55:21 +02:00
win32-low.cc gdbserver: remove support for ARM/WinCE 2020-06-12 16:06:45 -04:00
win32-low.h gdbserver: remove support for ARM/WinCE 2020-06-12 16:06:45 -04:00
x86-low.cc gdbserver: rename source files to .cc 2020-02-13 16:27:51 -05:00
x86-low.h
x86-tdesc.h
xtensa-xtregs.cc gdbserver: rename source files to .cc 2020-02-13 16:27:51 -05:00

		   README for GDBserver & GDBreplay
		    by Stu Grossman and Fred Fish

Introduction:

This is GDBserver, a remote server for Un*x-like systems.  It can be used to
control the execution of a program on a target system from a GDB on a different
host.  GDB and GDBserver communicate using the standard remote serial protocol.
They communicate via either a serial line or a TCP connection.

For more information about GDBserver, see the GDB manual:

    https://sourceware.org/gdb/current/onlinedocs/gdb/Remote-Protocol.html

Usage (server (target) side):

First, you need to have a copy of the program you want to debug put onto
the target system.  The program can be stripped to save space if needed, as
GDBserver doesn't care about symbols.  All symbol handling is taken care of by
the GDB running on the host system.

To use the server, you log on to the target system, and run the `gdbserver'
program.  You must tell it (a) how to communicate with GDB, (b) the name of
your program, and (c) its arguments.  The general syntax is:

	target> gdbserver COMM PROGRAM [ARGS ...]

For example, using a serial port, you might say:

	target> gdbserver /dev/com1 emacs foo.txt

This tells GDBserver to debug emacs with an argument of foo.txt, and to
communicate with GDB via /dev/com1.  GDBserver now waits patiently for the
host GDB to communicate with it.

To use a TCP connection, you could say:

	target> gdbserver host:2345 emacs foo.txt

This says pretty much the same thing as the last example, except that we are
going to communicate with the host GDB via TCP.  The `host:2345' argument means
that we are expecting to see a TCP connection to local TCP port 2345.
(Currently, the `host' part is ignored.)  You can choose any number you want for
the port number as long as it does not conflict with any existing TCP ports on
the target system.  This same port number must be used in the host GDB's
`target remote' command, which will be described shortly. Note that if you chose
a port number that conflicts with another service, GDBserver will print an error
message and exit.

On some targets, GDBserver can also attach to running programs.  This is
accomplished via the --attach argument.  The syntax is:

	target> gdbserver --attach COMM PID

PID is the process ID of a currently running process.  It isn't necessary
to point GDBserver at a binary for the running process.

Usage (host side):

You need an unstripped copy of the target program on your host system, since
GDB needs to examine it's symbol tables and such.  Start up GDB as you normally
would, with the target program as the first argument.  (You may need to use the
--baud option if the serial line is running at anything except 9600 baud.)
Ie: `gdb TARGET-PROG', or `gdb --baud BAUD TARGET-PROG'.  After that, the only
new command you need to know about is `target remote'.  It's argument is either
a device name (usually a serial device, like `/dev/ttyb'), or a HOST:PORT
descriptor.  For example:

	(gdb) target remote /dev/ttyb

communicates with the server via serial line /dev/ttyb, and:

	(gdb) target remote the-target:2345

communicates via a TCP connection to port 2345 on host `the-target', where
you previously started up GDBserver with the same port number.  Note that for
TCP connections, you must start up GDBserver prior to using the `target remote'
command, otherwise you may get an error that looks something like
`Connection refused'.

Building GDBserver:

See the `configure.srv` file for the list of host triplets you can build
GDBserver for.

Building GDBserver for your host is very straightforward.  If you build
GDB natively on a host which GDBserver supports, it will be built
automatically when you build GDB.  You can also build just GDBserver:

	% mkdir obj
	% cd obj
	% path-to-toplevel-sources/configure --disable-gdb
	% make all-gdbserver

(If you have a combined binutils+gdb tree, you may want to also
disable other directories when configuring, e.g., binutils, gas, gold,
gprof, and ld.)

If you prefer to cross-compile to your target, then you can also build
GDBserver that way.  For example:

	% export CC=your-cross-compiler
	% path-to-topevel-sources/configure --disable-gdb
	% make all-gdbserver

Using GDBreplay:

A special hacked down version of GDBserver can be used to replay remote
debug log files created by GDB.  Before using the GDB "target" command to
initiate a remote debug session, use "set remotelogfile <filename>" to tell
GDB that you want to make a recording of the serial or tcp session.  Note
that when replaying the session, GDB communicates with GDBreplay via tcp,
regardless of whether the original session was via a serial link or tcp.

Once you are done with the remote debug session, start GDBreplay and
tell it the name of the log file and the host and port number that GDB
should connect to (typically the same as the host running GDB):

	$ gdbreplay logfile host:port

Then start GDB (preferably in a different screen or window) and use the
"target" command to connect to GDBreplay:

	(gdb) target remote host:port

Repeat the same sequence of user commands to GDB that you gave in the
original debug session.  GDB should not be able to tell that it is talking
to GDBreplay rather than a real target, all other things being equal.  Note
that GDBreplay echos the command lines to stderr, as well as the contents of
the packets it sends and receives.  The last command echoed by GDBreplay is
the next command that needs to be typed to GDB to continue the session in
sync with the original session.