binutils-gdb/ld/testsuite/ld-selective/selective.exp
Alan Modra ad77db1c02 CC_FOR_TARGET et al
The top level Makefile, the ld Makefile and others, define
CC_FOR_TARGET to be a compiler for the binutils target machine.  This
is the compiler that should be used for almost all tests with C
source.  There are _FOR_TARGET versions of CFLAGS, CXX, and CXXFLAGS
too.  This was all supposed to work with the testsuite .exp files
using CC for the target compiler, and CC_FOR_HOST for the host
compiler, with the makefiles passing CC=$CC_FOR_TARGET and
CC_FOR_HOST=$CC to the runtest invocation.

One exception to the rule of using CC_FOR_TARGET is the native-only ld
bootstrap test, which uses the newly built ld to link a copy of
itself.  Since the files being linked were created with the host
compiler, the boostrap test should use CC and CFLAGS, in case some
host compiler option provides needed libraries automatically.
However, bootstrap.exp used CC where it should have used CC_FOR_HOST.
I set about fixing that problem, then decided that playing games in
the makefiles with CC was a bad idea.  Not only is it confusing, but
other dejagnu code knows about CC_FOR_TARGET.  See dejagnu/target.exp.

So this patch gets rid of the makefile variable renaming and changes
all the .exp files to use the correct _FOR_TARGET variables.
CC_FOR_HOST and CFLAGS_FOR_HOST disappear.  A followup patch will
correct bootstrap.exp to use CFLAGS, and a number of other things I
noticed.

binutils/
	* testsuite/lib/binutils-common.exp (run_dump_test): Use
	CC_FOR_TARGET and CFLAGS_FOR_TARGET rather than CC and CFLAGS.
ld/
	* Makefile.am (check-DEJAGNU): Don't set CC to CC_FOR_TARGET
	and similar.  Pass variables with unchanged names.  Don't set
	CC_FOR_HOST or CFLAGS_FOR_HOST.
	* Makefile.in: Regenerate.
	* testsuite/config/default.exp: Update default CC and similar.
	(compiler_supports, plug_opt): Use CC_FOR_TARGET.
	* testsuite/ld-cdtest/cdtest.exp: Replace all uses of CC with
	CC_FOR_TARGET, and similarly for CFLAGS, CXX and CXXFLAGS.
	* testsuite/ld-auto-import/auto-import.exp: Likewise.
	* testsuite/ld-cygwin/exe-export.exp: Likewise.
	* testsuite/ld-elf/dwarf.exp: Likewise.
	* testsuite/ld-elf/indirect.exp: Likewise.
	* testsuite/ld-elf/shared.exp: Likewise.
	* testsuite/ld-elfcomm/elfcomm.exp: Likewise.
	* testsuite/ld-elfvers/vers.exp: Likewise.
	* testsuite/ld-elfvsb/elfvsb.exp: Likewise.
	* testsuite/ld-elfweak/elfweak.exp: Likewise.
	* testsuite/ld-gc/gc.exp: Likewise.
	* testsuite/ld-ifunc/ifunc.exp: Likewise.
	* testsuite/ld-mn10300/mn10300.exp: Likewise.
	* testsuite/ld-pe/pe-compile.exp: Likewise.
	* testsuite/ld-pe/pe-run.exp: Likewise.
	* testsuite/ld-pe/pe-run2.exp: Likewise.
	* testsuite/ld-pie/pie.exp: Likewise.
	* testsuite/ld-plugin/lto.exp: Likewise.
	* testsuite/ld-plugin/plugin.exp: Likewise.
	* testsuite/ld-scripts/crossref.exp: Likewise.
	* testsuite/ld-selective/selective.exp: Likewise.
	* testsuite/ld-sh/sh.exp: Likewise.
	* testsuite/ld-shared/shared.exp: Likewise.
	* testsuite/ld-srec/srec.exp: Likewise.
	* testsuite/ld-undefined/undefined.exp: Likewise.
	* testsuite/ld-unique/unique.exp: Likewise.
	* testsuite/ld-x86-64/tls.exp: Likewise.
	* testsuite/lib/ld-lib.exp: Likewise.
libctf/
	* Makefile.am (check-DEJAGNU): Don't set CC to CC_FOR_TARGET.
	Pass CC and CC_FOR_TARGET.  Don't set CC_FOR_HOST.
	* Makefile.in: Regenerate.
	* testsuite/config/default.exp: Update default CC and similar.
	* testsuite/lib/ctf-lib.exp (run_native_host_cmd): Use CC rather
	than CC_FOR_HOST.
	(run_lookup_test): Use CC_FOR_TARGET and CFLAGS_FOR_TARGET.
2021-09-03 16:26:09 +09:30

225 lines
7.1 KiB
Plaintext

# Expect script for LD selective linking tests
# Copyright (C) 1998-2021 Free Software Foundation, Inc.
#
# This file is part of the GNU Binutils.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
# MA 02110-1301, USA.
#
# Written by Catherine Moore (clm@cygnus.com)
# Make sure that constructors are handled correctly.
# Only ELF based ports support selective linking
if { ![is_elf_format] || ![check_gc_sections_available] } {
return
}
# List contains test-items with three items followed by four lists:
# 1:name 2:test-type (CC or C++; add as needed) 3:filename 4:ld-flags
# 5:must-have-symbols 6:must-not-have-symbols 7:xfail-targets.
#
# If a must(-not)-have symbol is a list, then that list must have two
# items; the symbol name and a value the symbol must (not) have.
#
# Note: ld_nm trims leading `_' from _start
#
# FIXME: Instead of table, read settings from each source-file.
set seltests {
{selective1 C 1.c {} {} {dropme1 dropme2} {}}
{selective2 C 2.c {} {} {foo} {}}
{selective3 C 2.c {-u foo} {foo} {{foo 0}} {}}
{selective4 C++ 3.cc {} {start a A::foo() B::foo()} {A::bar()} {mips*-*}}
{selective5 C++ 4.cc {} {start a A::bar()} {A::foo() B::foo()} {mips*-*}}
{selective6 C++ 5.cc {} {start a A::bar()}
{A::foo() B::foo() dropme1() dropme2()} {*-*-*}}
}
set cflags "-w -O -ffunction-sections -fdata-sections $NOSANITIZE_CFLAGS $NOLTO_CFLAGS"
set cxxflags "-fno-exceptions -fno-rtti $NOSANITIZE_CFLAGS $NOLTO_CFLAGS"
set ldflags "--gc-sections -Bstatic"
if [istarget mips*-*] {
# MIPS16 doesn't support PIC code.
set cflags "-mno-abicalls $cflags"
# MIPS ELF uses __start by default, we override it.
set ldflags "-e _start $ldflags"
}
if [istarget avr-*-*] {
# Make .text start at a non-zero address, as some tests expect
# valid symbols to have non-zero values.
set ldflags "--section-start=.text=0x2 $ldflags"
}
# If we don't have g++ for the target, mark all tests as untested.
if { ![is_remote host] && [which $CXX_FOR_TARGET] == 0 } {
foreach testitem $seltests {
untested "[lindex $testitem 0]"
}
return
}
foreach testitem $seltests {
set testname [lindex $testitem 0]
set testtype [lindex $testitem 1]
set testfile [lindex $testitem 2]
set objfile "tmpdir/[file rootname $testfile].o"
set ldfile "tmpdir/[file rootname $testfile].x"
set failed 0
set ldargs [lindex $testitem 3]
set mustsyms [lindex $testitem 4]
set mustnotsyms [lindex $testitem 5]
set xfails [lindex $testitem 6]
foreach xfail_target $xfails {
setup_xfail $xfail_target
}
# It's either C or C++ at the moment.
if { $testtype == "C++" } {
set compiler "$CXX_FOR_TARGET"
# Starting with 3.4.0, -fvtable-gc is no longer supported and thus
# the functionality we try to test for cannot be expected to work.
set version [remote_exec host "$CXX_FOR_TARGET -dumpversion"]
set version [lindex $version 1]
if { [regexp "^(\[1-9\]\[0-9\]+|\[4-9\]|3.(\[1-9\]\[0-9\]+))\\." $version] \
|| [regexp "^(\[1-9\]\[0-9\]+|\[4-9\])" $version] } {
set testflags "$cflags $cxxflags"
setup_xfail {*-*-*}
} else {
set testflags "$cflags $cxxflags -fvtable-gc"
}
} else {
set testflags "$cflags"
set compiler "$CC_FOR_TARGET"
}
# Note that we do not actually *use* CXX; we just add cxxflags for C++
# tests. It might have been a buglet originally; now I think better
# leave as is.
if { ![ld_compile "$compiler $testflags" $srcdir/$subdir/$testfile $objfile] } {
unsupported $testname
continue
}
# V850 targets need libgcc.a
if [istarget v850*-*-elf] {
set libgcc [remote_exec host "$compiler -print-libgcc-file-name"]
set libgcc [lindex $libgcc 1]
regsub -all "\[\r\n\]" $libgcc "" libgcc
set objfile "$objfile $libgcc"
}
# ARM targets need libgcc.a in THUMB mode so that __call_via_r3 is provided
if {[istarget arm-*-*]} {
set libgcc [remote_exec host "$compiler -print-libgcc-file-name"]
set libgcc [lindex $libgcc 1]
regsub -all "\[\r\n\]" $libgcc "" libgcc
set objfile "$objfile $libgcc"
}
# HPPA linux targets need libgcc.a for millicode routines ($$dyncall).
if [istarget hppa*-*-linux*] {
set libgcc [remote_exec host "$compiler -print-libgcc-file-name"]
set libgcc [lindex $libgcc 1]
regsub -all "\[\r\n\]" $libgcc "" libgcc
set objfile "$objfile $libgcc"
}
# m6811/m6812 code has references to soft registers.
if {[istarget m6811-*-*] || [istarget m6812-*-*] || [istarget m68hc1*-*-*]} {
set objfile "$objfile --defsym _.frame=0 --defsym _.d1=0"
set objfile "$objfile --defsym _.d2=0"
}
if ![ld_link $ld $ldfile "$ldflags [join $ldargs] $objfile"] {
fail $testname
continue
}
if ![ld_nm $nm --demangle $ldfile] {
fail $testname
continue
}
# Must make V2 demangled names look like V3
foreach nm_output_key [array names nm_output] {
if [regsub \\(void\\) $nm_output_key () new_nm_output_key] {
set nm_output($new_nm_output_key) nm_output($nm_output_key)
}
}
# Check each mandated symbol and optionally mandated values.
foreach mustsym $mustsyms {
if { [llength [concat $mustsym]] == 1 } {
if { ![info exists nm_output($mustsym)] } {
verbose -log "$testname: missing $mustsym"
fail $testname
set failed 1
break
}
} {
set mustsymname [lindex $mustsym 0]
set mustsymvalue [lindex $mustsym 1]
if { ![info exists nm_output($mustsymname)] } {
verbose -log "$testname: missing $mustsymname"
fail $testname
set failed 1
break
} {
if { $nm_output($mustsymname) != $mustsymvalue } {
verbose -log "$testname: $mustsymname != $mustsymvalue"
verbose -log "is instead $nm_output($mustsymname)"
fail $testname
set failed 1
break
}
}
}
}
if { $failed != 0 } {
continue
}
# Check each unwanted symbol, or that symbols do not have specific
# values.
foreach mustnotsym $mustnotsyms {
if { [llength [concat $mustnotsym]] == 1 } {
if { [info exists nm_output($mustnotsym)] } {
verbose -log "$testname: $mustnotsym == $nm_output($mustnotsym)"
fail $testname
set failed 1
break
}
} {
set mustnotsymname [lindex $mustnotsym 0]
set mustnotsymvalue [lindex $mustnotsym 1]
if { [info exists nm_output($mustnotsymname)] \
&& $nm_output($mustnotsymname) == $mustnotsymvalue} {
verbose -log "$testname: $mustnotsymname == $mustnotsymvalue"
fail $testname
set failed 1
break
}
}
}
if { $failed == 0 } {
pass $testname
}
}