binutils-gdb/gdb/thread-iter.h
Simon Marchi 0618ae4149 gdb: optimize all_matching_threads_iterator
all_matching_threads_iterator is used extensively in some pretty fast
paths, often under the all_non_exited_threads function.

If a filter target and thread-specific ptid are given, it iterates on
all threads of all inferiors of that target, to ultimately yield exactly
on thread.  And this happens quite often, which means we unnecessarily
spend time iterating on threads to find the one we are looking for.  The
same thing happens if an inferior-specific ptid is given, although there
the iterator yields all the threads of that inferior.

In those cases, the callers of all_non_exited_threads could have
different behaviors depending on the kind of ptid, to avoid this
inefficiency, but that would be very tedious.  Using
all_non_exited_threads has the advantage that one simple implementation
can work seamlessly on multiple threads or on one specific thread, just
by playing with the ptid.

Instead, optimize all_matching_threads_iterator directly to detect these
different cases and limiting what we iterate on to just what we need.

 - if filter_ptid is minus_one_ptid, do as we do now: filter inferiors
   based on filter_target, iterate on all of the matching inferiors'
   threads
 - if filter_ptid is a pid-only ptid (then a filter_target must
   necessarily be given), look up that inferior and iterate on all its
   threads
 - otherwise, filter_ptid is a thread-specific ptid, so look up that
   specific thread and "iterate" only on it

For the last case, what was an iteration on all threads of the filter
target now becomes a call to find_thread_ptid, which is quite efficient
now thanks to inferior::ptid_thread_map.

gdb/ChangeLog:

	* thread-iter.h (class all_matching_threads_iterator)
	<all_matching_threads_iterator>: Use default.
	<enum class mode>: New.
	<m_inf, m_thr>: Initialize.
	<m_filter_ptid>: Remove.
	* thread-iter.c (all_matching_threads_iterator::m_inf_matches):
	Don't filter on m_filter_ptid.
	(all_matching_threads_iterator::all_matching_threads_iterator):
	Choose path based on filter_ptid (all threads, all threads of
	inferior, single thread).
	(all_matching_threads_iterator::advance): Likewise.

Change-Id: Ic6a19845f5f760fa1b8eac8145793c0ff431bbc9
2021-07-12 20:46:53 -04:00

253 lines
7.2 KiB
C++

/* Thread iterators and ranges for GDB, the GNU debugger.
Copyright (C) 2018-2021 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#ifndef THREAD_ITER_H
#define THREAD_ITER_H
#include "gdbsupport/filtered-iterator.h"
#include "gdbsupport/iterator-range.h"
#include "gdbsupport/next-iterator.h"
#include "gdbsupport/reference-to-pointer-iterator.h"
#include "gdbsupport/safe-iterator.h"
/* A forward iterator that iterates over a given inferior's
threads. */
using inf_threads_iterator
= reference_to_pointer_iterator<intrusive_list<thread_info>::iterator>;
/* A forward iterator that iterates over all threads of all
inferiors. */
class all_threads_iterator
{
public:
typedef all_threads_iterator self_type;
typedef struct thread_info *value_type;
typedef struct thread_info *&reference;
typedef struct thread_info **pointer;
typedef std::forward_iterator_tag iterator_category;
typedef int difference_type;
/* Tag type. */
struct begin_t {};
/* Create an iterator that points to the first thread of the first
inferior. */
explicit all_threads_iterator (begin_t);
/* Create a one-past-end iterator. */
all_threads_iterator ()
: m_thr (nullptr)
{}
thread_info *operator* () const { return m_thr; }
all_threads_iterator &operator++ ()
{
advance ();
return *this;
}
bool operator== (const all_threads_iterator &other) const
{ return m_thr == other.m_thr; }
bool operator!= (const all_threads_iterator &other) const
{ return m_thr != other.m_thr; }
private:
/* Advance to the next thread. */
void advance ();
private:
/* The current inferior and thread. M_THR is NULL if we reached the
end of the threads list of the last inferior. */
inferior *m_inf;
thread_info *m_thr;
};
/* Iterate over all threads that match a given PTID. */
class all_matching_threads_iterator
{
public:
typedef all_matching_threads_iterator self_type;
typedef struct thread_info *value_type;
typedef struct thread_info *&reference;
typedef struct thread_info **pointer;
typedef std::forward_iterator_tag iterator_category;
typedef int difference_type;
/* Creates an iterator that iterates over all threads that match
FILTER_PTID. */
all_matching_threads_iterator (process_stratum_target *filter_target,
ptid_t filter_ptid);
/* Create a one-past-end iterator. */
all_matching_threads_iterator () = default;
thread_info *operator* () const { return m_thr; }
all_matching_threads_iterator &operator++ ()
{
advance ();
return *this;
}
bool operator== (const all_matching_threads_iterator &other) const
{ return m_thr == other.m_thr; }
bool operator!= (const all_matching_threads_iterator &other) const
{ return m_thr != other.m_thr; }
private:
/* Advance to next thread, skipping filtered threads. */
void advance ();
/* True if M_INF has the process target M_FILTER_TARGET. */
bool m_inf_matches ();
private:
enum class mode
{
/* All threads, possibly filtered down to a single target. */
ALL_THREADS,
/* All threads of the given inferior. */
ALL_THREADS_OF_INFERIOR,
/* A specific thread. */
SINGLE_THREAD,
} m_mode;
/* The current inferior. */
inferior *m_inf = nullptr;
/* The current thread. */
thread_info *m_thr = nullptr;
/* The target we filter on (may be nullptr). */
process_stratum_target *m_filter_target;
};
/* Filter for filtered_iterator. Filters out exited threads. */
struct non_exited_thread_filter
{
bool operator() (struct thread_info *thr) const
{
return thr->state != THREAD_EXITED;
}
};
/* Iterate over all non-exited threads that match a given PTID. */
using all_non_exited_threads_iterator
= filtered_iterator<all_matching_threads_iterator, non_exited_thread_filter>;
/* Iterate over all non-exited threads of an inferior. */
using inf_non_exited_threads_iterator
= filtered_iterator<inf_threads_iterator, non_exited_thread_filter>;
/* Iterate over all threads of all inferiors, safely. */
using all_threads_safe_iterator
= basic_safe_iterator<all_threads_iterator>;
/* Iterate over all threads of an inferior, safely. */
using safe_inf_threads_iterator
= basic_safe_iterator<inf_threads_iterator>;
/* A range adapter that makes it possible to iterate over all threads
of an inferior with range-for. */
using inf_threads_range = iterator_range<inf_threads_iterator>;
/* A range adapter that makes it possible to iterate over all
non-exited threads of an inferior with range-for. */
using inf_non_exited_threads_range
= iterator_range<inf_non_exited_threads_iterator>;
/* A range adapter that makes it possible to iterate over all threads
of an inferior with range-for, safely. */
using safe_inf_threads_range = iterator_range<safe_inf_threads_iterator>;
/* A range adapter that makes it possible to iterate over all threads
with range-for "safely". I.e., it is safe to delete the
currently-iterated thread. */
using all_threads_safe_range = iterator_range<all_threads_safe_iterator>;
/* A range adapter that makes it possible to iterate over all threads
that match a PTID filter with range-for. */
struct all_matching_threads_range
{
public:
all_matching_threads_range (process_stratum_target *filter_target,
ptid_t filter_ptid)
: m_filter_target (filter_target), m_filter_ptid (filter_ptid)
{}
all_matching_threads_range ()
: m_filter_target (nullptr), m_filter_ptid (minus_one_ptid)
{}
all_matching_threads_iterator begin () const
{ return all_matching_threads_iterator (m_filter_target, m_filter_ptid); }
all_matching_threads_iterator end () const
{ return all_matching_threads_iterator (); }
private:
/* The filter. */
process_stratum_target *m_filter_target;
ptid_t m_filter_ptid;
};
/* A range adapter that makes it possible to iterate over all
non-exited threads of all inferiors, with range-for.
Threads/inferiors that do not match FILTER_PTID are filtered
out. */
class all_non_exited_threads_range
{
public:
all_non_exited_threads_range (process_stratum_target *filter_target,
ptid_t filter_ptid)
: m_filter_target (filter_target), m_filter_ptid (filter_ptid)
{}
all_non_exited_threads_range ()
: m_filter_target (nullptr), m_filter_ptid (minus_one_ptid)
{}
all_non_exited_threads_iterator begin () const
{ return all_non_exited_threads_iterator (m_filter_target, m_filter_ptid); }
all_non_exited_threads_iterator end () const
{ return all_non_exited_threads_iterator (); }
private:
process_stratum_target *m_filter_target;
ptid_t m_filter_ptid;
};
#endif /* THREAD_ITER_H */