mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-24 12:35:55 +08:00
a2c7ca15a5
long is a poor choice of type to store 32-bit values read from objects files by H_GET_32. H_GET_32 doesn't sign extend so tests like that in gdb/coffread.c for "negative" values won't work if long is larger than 32 bits. If long is 32-bit then code needs to be careful to not accidentally index negative array elements. (I'd rather see a segfault on an unmapped 4G array index than silently reading bogus data.) long is also a poor choice for x_sect.s_scnlen, which might have 64-bit values. It's better to use unsigned exact width types to avoid surprises. I decided to change the field names too, which makes most of this patch simply renaming. Besides that there are a few places where casts are no longer needed, and where printf format strings or tests need adjusting. include/ * coff/internal.h (union internal_auxent): Use unsigned stdint types. Rename l fields to u32 and u64 as appropriate. bfd/ * coff-bfd.c, * coff-rs6000.c, * coff64-rs6000.c, * coffcode.h, * coffgen.c, * cofflink.c, * coffswap.h, * peXXigen.c, * xcofflink.c: Adjust to suit internal_auxent changes. binutils/ * rdcoff.c: Adjust to suit internal_auxent changes. gas/ * config/obj-coff.h, * config/tc-ppc.c: Adjust to suit internal_auxent changes. gdb/ * coffread.c, * xcoffread.c: Adjust to suit internal_auxent changes. ld/ * pe-dll.c: Adjust to suit internal_auxent changes.
110 lines
2.7 KiB
C
110 lines
2.7 KiB
C
/* BFD COFF interfaces used outside of BFD.
|
|
Copyright (C) 1990-2023 Free Software Foundation, Inc.
|
|
Written by Cygnus Support.
|
|
|
|
This file is part of BFD, the Binary File Descriptor library.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
|
|
MA 02110-1301, USA. */
|
|
|
|
#include "sysdep.h"
|
|
#include "bfd.h"
|
|
#include "libbfd.h"
|
|
#include "coff/internal.h"
|
|
#include "libcoff.h"
|
|
|
|
/* Return the COFF syment for a symbol. */
|
|
|
|
bool
|
|
bfd_coff_get_syment (bfd *abfd,
|
|
asymbol *symbol,
|
|
struct internal_syment *psyment)
|
|
{
|
|
coff_symbol_type *csym;
|
|
|
|
csym = coff_symbol_from (symbol);
|
|
if (csym == NULL || csym->native == NULL
|
|
|| ! csym->native->is_sym)
|
|
{
|
|
bfd_set_error (bfd_error_invalid_operation);
|
|
return false;
|
|
}
|
|
|
|
*psyment = csym->native->u.syment;
|
|
|
|
if (csym->native->fix_value)
|
|
psyment->n_value =
|
|
((psyment->n_value - (uintptr_t) obj_raw_syments (abfd))
|
|
/ sizeof (combined_entry_type));
|
|
|
|
/* FIXME: We should handle fix_line here. */
|
|
|
|
return true;
|
|
}
|
|
|
|
/* Return the COFF auxent for a symbol. */
|
|
|
|
bool
|
|
bfd_coff_get_auxent (bfd *abfd,
|
|
asymbol *symbol,
|
|
int indx,
|
|
union internal_auxent *pauxent)
|
|
{
|
|
coff_symbol_type *csym;
|
|
combined_entry_type *ent;
|
|
|
|
csym = coff_symbol_from (symbol);
|
|
|
|
if (csym == NULL
|
|
|| csym->native == NULL
|
|
|| ! csym->native->is_sym
|
|
|| indx >= csym->native->u.syment.n_numaux)
|
|
{
|
|
bfd_set_error (bfd_error_invalid_operation);
|
|
return false;
|
|
}
|
|
|
|
ent = csym->native + indx + 1;
|
|
|
|
BFD_ASSERT (! ent->is_sym);
|
|
*pauxent = ent->u.auxent;
|
|
|
|
if (ent->fix_tag)
|
|
{
|
|
pauxent->x_sym.x_tagndx.u32 =
|
|
((combined_entry_type *) pauxent->x_sym.x_tagndx.p
|
|
- obj_raw_syments (abfd));
|
|
ent->fix_tag = 0;
|
|
}
|
|
|
|
if (ent->fix_end)
|
|
{
|
|
pauxent->x_sym.x_fcnary.x_fcn.x_endndx.u32 =
|
|
((combined_entry_type *) pauxent->x_sym.x_fcnary.x_fcn.x_endndx.p
|
|
- obj_raw_syments (abfd));
|
|
ent->fix_end = 0;
|
|
}
|
|
|
|
if (ent->fix_scnlen)
|
|
{
|
|
pauxent->x_csect.x_scnlen.u64 =
|
|
((combined_entry_type *) pauxent->x_csect.x_scnlen.p
|
|
- obj_raw_syments (abfd));
|
|
ent->fix_scnlen = 0;
|
|
}
|
|
|
|
return true;
|
|
}
|