mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
dda83cd783
Many spots incorrectly use only spaces for indentation (for example, there are a lot of spots in ada-lang.c). I've always found it awkward when I needed to edit one of these spots: do I keep the original wrong indentation, or do I fix it? What if the lines around it are also wrong, do I fix them too? I probably don't want to fix them in the same patch, to avoid adding noise to my patch. So I propose to fix as much as possible once and for all (hopefully). One typical counter argument for this is that it makes code archeology more difficult, because git-blame will show this commit as the last change for these lines. My counter counter argument is: when git-blaming, you often need to do "blame the file at the parent commit" anyway, to go past some other refactor that touched the line you are interested in, but is not the change you are looking for. So you already need a somewhat efficient way to do this. Using some interactive tool, rather than plain git-blame, makes this trivial. For example, I use "tig blame <file>", where going back past the commit that changed the currently selected line is one keystroke. It looks like Magit in Emacs does it too (though I've never used it). Web viewers of Github and Gitlab do it too. My point is that it won't really make archeology more difficult. The other typical counter argument is that it will cause conflicts with existing patches. That's true... but it's a one time cost, and those are not conflicts that are difficult to resolve. I have also tried "git rebase --ignore-whitespace", it seems to work well. Although that will re-introduce the faulty indentation, so one needs to take care of fixing the indentation in the patch after that (which is easy). gdb/ChangeLog: * aarch64-linux-tdep.c: Fix indentation. * aarch64-ravenscar-thread.c: Fix indentation. * aarch64-tdep.c: Fix indentation. * aarch64-tdep.h: Fix indentation. * ada-lang.c: Fix indentation. * ada-lang.h: Fix indentation. * ada-tasks.c: Fix indentation. * ada-typeprint.c: Fix indentation. * ada-valprint.c: Fix indentation. * ada-varobj.c: Fix indentation. * addrmap.c: Fix indentation. * addrmap.h: Fix indentation. * agent.c: Fix indentation. * aix-thread.c: Fix indentation. * alpha-bsd-nat.c: Fix indentation. * alpha-linux-tdep.c: Fix indentation. * alpha-mdebug-tdep.c: Fix indentation. * alpha-nbsd-tdep.c: Fix indentation. * alpha-obsd-tdep.c: Fix indentation. * alpha-tdep.c: Fix indentation. * amd64-bsd-nat.c: Fix indentation. * amd64-darwin-tdep.c: Fix indentation. * amd64-linux-nat.c: Fix indentation. * amd64-linux-tdep.c: Fix indentation. * amd64-nat.c: Fix indentation. * amd64-obsd-tdep.c: Fix indentation. * amd64-tdep.c: Fix indentation. * amd64-windows-tdep.c: Fix indentation. * annotate.c: Fix indentation. * arc-tdep.c: Fix indentation. * arch-utils.c: Fix indentation. * arch/arm-get-next-pcs.c: Fix indentation. * arch/arm.c: Fix indentation. * arm-linux-nat.c: Fix indentation. * arm-linux-tdep.c: Fix indentation. * arm-nbsd-tdep.c: Fix indentation. * arm-pikeos-tdep.c: Fix indentation. * arm-tdep.c: Fix indentation. * arm-tdep.h: Fix indentation. * arm-wince-tdep.c: Fix indentation. * auto-load.c: Fix indentation. * auxv.c: Fix indentation. * avr-tdep.c: Fix indentation. * ax-gdb.c: Fix indentation. * ax-general.c: Fix indentation. * bfin-linux-tdep.c: Fix indentation. * block.c: Fix indentation. * block.h: Fix indentation. * blockframe.c: Fix indentation. * bpf-tdep.c: Fix indentation. * break-catch-sig.c: Fix indentation. * break-catch-syscall.c: Fix indentation. * break-catch-throw.c: Fix indentation. * breakpoint.c: Fix indentation. * breakpoint.h: Fix indentation. * bsd-uthread.c: Fix indentation. * btrace.c: Fix indentation. * build-id.c: Fix indentation. * buildsym-legacy.h: Fix indentation. * buildsym.c: Fix indentation. * c-typeprint.c: Fix indentation. * c-valprint.c: Fix indentation. * c-varobj.c: Fix indentation. * charset.c: Fix indentation. * cli/cli-cmds.c: Fix indentation. * cli/cli-decode.c: Fix indentation. * cli/cli-decode.h: Fix indentation. * cli/cli-script.c: Fix indentation. * cli/cli-setshow.c: Fix indentation. * coff-pe-read.c: Fix indentation. * coffread.c: Fix indentation. * compile/compile-cplus-types.c: Fix indentation. * compile/compile-object-load.c: Fix indentation. * compile/compile-object-run.c: Fix indentation. * completer.c: Fix indentation. * corefile.c: Fix indentation. * corelow.c: Fix indentation. * cp-abi.h: Fix indentation. * cp-namespace.c: Fix indentation. * cp-support.c: Fix indentation. * cp-valprint.c: Fix indentation. * cris-linux-tdep.c: Fix indentation. * cris-tdep.c: Fix indentation. * darwin-nat-info.c: Fix indentation. * darwin-nat.c: Fix indentation. * darwin-nat.h: Fix indentation. * dbxread.c: Fix indentation. * dcache.c: Fix indentation. * disasm.c: Fix indentation. * dtrace-probe.c: Fix indentation. * dwarf2/abbrev.c: Fix indentation. * dwarf2/attribute.c: Fix indentation. * dwarf2/expr.c: Fix indentation. * dwarf2/frame.c: Fix indentation. * dwarf2/index-cache.c: Fix indentation. * dwarf2/index-write.c: Fix indentation. * dwarf2/line-header.c: Fix indentation. * dwarf2/loc.c: Fix indentation. * dwarf2/macro.c: Fix indentation. * dwarf2/read.c: Fix indentation. * dwarf2/read.h: Fix indentation. * elfread.c: Fix indentation. * eval.c: Fix indentation. * event-top.c: Fix indentation. * exec.c: Fix indentation. * exec.h: Fix indentation. * expprint.c: Fix indentation. * f-lang.c: Fix indentation. * f-typeprint.c: Fix indentation. * f-valprint.c: Fix indentation. * fbsd-nat.c: Fix indentation. * fbsd-tdep.c: Fix indentation. * findvar.c: Fix indentation. * fork-child.c: Fix indentation. * frame-unwind.c: Fix indentation. * frame-unwind.h: Fix indentation. * frame.c: Fix indentation. * frv-linux-tdep.c: Fix indentation. * frv-tdep.c: Fix indentation. * frv-tdep.h: Fix indentation. * ft32-tdep.c: Fix indentation. * gcore.c: Fix indentation. * gdb_bfd.c: Fix indentation. * gdbarch.sh: Fix indentation. * gdbarch.c: Re-generate * gdbarch.h: Re-generate. * gdbcore.h: Fix indentation. * gdbthread.h: Fix indentation. * gdbtypes.c: Fix indentation. * gdbtypes.h: Fix indentation. * glibc-tdep.c: Fix indentation. * gnu-nat.c: Fix indentation. * gnu-nat.h: Fix indentation. * gnu-v2-abi.c: Fix indentation. * gnu-v3-abi.c: Fix indentation. * go32-nat.c: Fix indentation. * guile/guile-internal.h: Fix indentation. * guile/scm-cmd.c: Fix indentation. * guile/scm-frame.c: Fix indentation. * guile/scm-iterator.c: Fix indentation. * guile/scm-math.c: Fix indentation. * guile/scm-ports.c: Fix indentation. * guile/scm-pretty-print.c: Fix indentation. * guile/scm-value.c: Fix indentation. * h8300-tdep.c: Fix indentation. * hppa-linux-nat.c: Fix indentation. * hppa-linux-tdep.c: Fix indentation. * hppa-nbsd-nat.c: Fix indentation. * hppa-nbsd-tdep.c: Fix indentation. * hppa-obsd-nat.c: Fix indentation. * hppa-tdep.c: Fix indentation. * hppa-tdep.h: Fix indentation. * i386-bsd-nat.c: Fix indentation. * i386-darwin-nat.c: Fix indentation. * i386-darwin-tdep.c: Fix indentation. * i386-dicos-tdep.c: Fix indentation. * i386-gnu-nat.c: Fix indentation. * i386-linux-nat.c: Fix indentation. * i386-linux-tdep.c: Fix indentation. * i386-nto-tdep.c: Fix indentation. * i386-obsd-tdep.c: Fix indentation. * i386-sol2-nat.c: Fix indentation. * i386-tdep.c: Fix indentation. * i386-tdep.h: Fix indentation. * i386-windows-tdep.c: Fix indentation. * i387-tdep.c: Fix indentation. * i387-tdep.h: Fix indentation. * ia64-libunwind-tdep.c: Fix indentation. * ia64-libunwind-tdep.h: Fix indentation. * ia64-linux-nat.c: Fix indentation. * ia64-linux-tdep.c: Fix indentation. * ia64-tdep.c: Fix indentation. * ia64-tdep.h: Fix indentation. * ia64-vms-tdep.c: Fix indentation. * infcall.c: Fix indentation. * infcmd.c: Fix indentation. * inferior.c: Fix indentation. * infrun.c: Fix indentation. * iq2000-tdep.c: Fix indentation. * language.c: Fix indentation. * linespec.c: Fix indentation. * linux-fork.c: Fix indentation. * linux-nat.c: Fix indentation. * linux-tdep.c: Fix indentation. * linux-thread-db.c: Fix indentation. * lm32-tdep.c: Fix indentation. * m2-lang.c: Fix indentation. * m2-typeprint.c: Fix indentation. * m2-valprint.c: Fix indentation. * m32c-tdep.c: Fix indentation. * m32r-linux-tdep.c: Fix indentation. * m32r-tdep.c: Fix indentation. * m68hc11-tdep.c: Fix indentation. * m68k-bsd-nat.c: Fix indentation. * m68k-linux-nat.c: Fix indentation. * m68k-linux-tdep.c: Fix indentation. * m68k-tdep.c: Fix indentation. * machoread.c: Fix indentation. * macrocmd.c: Fix indentation. * macroexp.c: Fix indentation. * macroscope.c: Fix indentation. * macrotab.c: Fix indentation. * macrotab.h: Fix indentation. * main.c: Fix indentation. * mdebugread.c: Fix indentation. * mep-tdep.c: Fix indentation. * mi/mi-cmd-catch.c: Fix indentation. * mi/mi-cmd-disas.c: Fix indentation. * mi/mi-cmd-env.c: Fix indentation. * mi/mi-cmd-stack.c: Fix indentation. * mi/mi-cmd-var.c: Fix indentation. * mi/mi-cmds.c: Fix indentation. * mi/mi-main.c: Fix indentation. * mi/mi-parse.c: Fix indentation. * microblaze-tdep.c: Fix indentation. * minidebug.c: Fix indentation. * minsyms.c: Fix indentation. * mips-linux-nat.c: Fix indentation. * mips-linux-tdep.c: Fix indentation. * mips-nbsd-tdep.c: Fix indentation. * mips-tdep.c: Fix indentation. * mn10300-linux-tdep.c: Fix indentation. * mn10300-tdep.c: Fix indentation. * moxie-tdep.c: Fix indentation. * msp430-tdep.c: Fix indentation. * namespace.h: Fix indentation. * nat/fork-inferior.c: Fix indentation. * nat/gdb_ptrace.h: Fix indentation. * nat/linux-namespaces.c: Fix indentation. * nat/linux-osdata.c: Fix indentation. * nat/netbsd-nat.c: Fix indentation. * nat/x86-dregs.c: Fix indentation. * nbsd-nat.c: Fix indentation. * nbsd-tdep.c: Fix indentation. * nios2-linux-tdep.c: Fix indentation. * nios2-tdep.c: Fix indentation. * nto-procfs.c: Fix indentation. * nto-tdep.c: Fix indentation. * objfiles.c: Fix indentation. * objfiles.h: Fix indentation. * opencl-lang.c: Fix indentation. * or1k-tdep.c: Fix indentation. * osabi.c: Fix indentation. * osabi.h: Fix indentation. * osdata.c: Fix indentation. * p-lang.c: Fix indentation. * p-typeprint.c: Fix indentation. * p-valprint.c: Fix indentation. * parse.c: Fix indentation. * ppc-linux-nat.c: Fix indentation. * ppc-linux-tdep.c: Fix indentation. * ppc-nbsd-nat.c: Fix indentation. * ppc-nbsd-tdep.c: Fix indentation. * ppc-obsd-nat.c: Fix indentation. * ppc-ravenscar-thread.c: Fix indentation. * ppc-sysv-tdep.c: Fix indentation. * ppc64-tdep.c: Fix indentation. * printcmd.c: Fix indentation. * proc-api.c: Fix indentation. * producer.c: Fix indentation. * producer.h: Fix indentation. * prologue-value.c: Fix indentation. * prologue-value.h: Fix indentation. * psymtab.c: Fix indentation. * python/py-arch.c: Fix indentation. * python/py-bpevent.c: Fix indentation. * python/py-event.c: Fix indentation. * python/py-event.h: Fix indentation. * python/py-finishbreakpoint.c: Fix indentation. * python/py-frame.c: Fix indentation. * python/py-framefilter.c: Fix indentation. * python/py-inferior.c: Fix indentation. * python/py-infthread.c: Fix indentation. * python/py-objfile.c: Fix indentation. * python/py-prettyprint.c: Fix indentation. * python/py-registers.c: Fix indentation. * python/py-signalevent.c: Fix indentation. * python/py-stopevent.c: Fix indentation. * python/py-stopevent.h: Fix indentation. * python/py-threadevent.c: Fix indentation. * python/py-tui.c: Fix indentation. * python/py-unwind.c: Fix indentation. * python/py-value.c: Fix indentation. * python/py-xmethods.c: Fix indentation. * python/python-internal.h: Fix indentation. * python/python.c: Fix indentation. * ravenscar-thread.c: Fix indentation. * record-btrace.c: Fix indentation. * record-full.c: Fix indentation. * record.c: Fix indentation. * reggroups.c: Fix indentation. * regset.h: Fix indentation. * remote-fileio.c: Fix indentation. * remote.c: Fix indentation. * reverse.c: Fix indentation. * riscv-linux-tdep.c: Fix indentation. * riscv-ravenscar-thread.c: Fix indentation. * riscv-tdep.c: Fix indentation. * rl78-tdep.c: Fix indentation. * rs6000-aix-tdep.c: Fix indentation. * rs6000-lynx178-tdep.c: Fix indentation. * rs6000-nat.c: Fix indentation. * rs6000-tdep.c: Fix indentation. * rust-lang.c: Fix indentation. * rx-tdep.c: Fix indentation. * s12z-tdep.c: Fix indentation. * s390-linux-tdep.c: Fix indentation. * score-tdep.c: Fix indentation. * ser-base.c: Fix indentation. * ser-mingw.c: Fix indentation. * ser-uds.c: Fix indentation. * ser-unix.c: Fix indentation. * serial.c: Fix indentation. * sh-linux-tdep.c: Fix indentation. * sh-nbsd-tdep.c: Fix indentation. * sh-tdep.c: Fix indentation. * skip.c: Fix indentation. * sol-thread.c: Fix indentation. * solib-aix.c: Fix indentation. * solib-darwin.c: Fix indentation. * solib-frv.c: Fix indentation. * solib-svr4.c: Fix indentation. * solib.c: Fix indentation. * source.c: Fix indentation. * sparc-linux-tdep.c: Fix indentation. * sparc-nbsd-tdep.c: Fix indentation. * sparc-obsd-tdep.c: Fix indentation. * sparc-ravenscar-thread.c: Fix indentation. * sparc-tdep.c: Fix indentation. * sparc64-linux-tdep.c: Fix indentation. * sparc64-nbsd-tdep.c: Fix indentation. * sparc64-obsd-tdep.c: Fix indentation. * sparc64-tdep.c: Fix indentation. * stabsread.c: Fix indentation. * stack.c: Fix indentation. * stap-probe.c: Fix indentation. * stubs/ia64vms-stub.c: Fix indentation. * stubs/m32r-stub.c: Fix indentation. * stubs/m68k-stub.c: Fix indentation. * stubs/sh-stub.c: Fix indentation. * stubs/sparc-stub.c: Fix indentation. * symfile-mem.c: Fix indentation. * symfile.c: Fix indentation. * symfile.h: Fix indentation. * symmisc.c: Fix indentation. * symtab.c: Fix indentation. * symtab.h: Fix indentation. * target-float.c: Fix indentation. * target.c: Fix indentation. * target.h: Fix indentation. * tic6x-tdep.c: Fix indentation. * tilegx-linux-tdep.c: Fix indentation. * tilegx-tdep.c: Fix indentation. * top.c: Fix indentation. * tracefile-tfile.c: Fix indentation. * tracepoint.c: Fix indentation. * tui/tui-disasm.c: Fix indentation. * tui/tui-io.c: Fix indentation. * tui/tui-regs.c: Fix indentation. * tui/tui-stack.c: Fix indentation. * tui/tui-win.c: Fix indentation. * tui/tui-winsource.c: Fix indentation. * tui/tui.c: Fix indentation. * typeprint.c: Fix indentation. * ui-out.h: Fix indentation. * unittests/copy_bitwise-selftests.c: Fix indentation. * unittests/memory-map-selftests.c: Fix indentation. * utils.c: Fix indentation. * v850-tdep.c: Fix indentation. * valarith.c: Fix indentation. * valops.c: Fix indentation. * valprint.c: Fix indentation. * valprint.h: Fix indentation. * value.c: Fix indentation. * value.h: Fix indentation. * varobj.c: Fix indentation. * vax-tdep.c: Fix indentation. * windows-nat.c: Fix indentation. * windows-tdep.c: Fix indentation. * xcoffread.c: Fix indentation. * xml-syscall.c: Fix indentation. * xml-tdesc.c: Fix indentation. * xstormy16-tdep.c: Fix indentation. * xtensa-config.c: Fix indentation. * xtensa-linux-nat.c: Fix indentation. * xtensa-linux-tdep.c: Fix indentation. * xtensa-tdep.c: Fix indentation. gdbserver/ChangeLog: * ax.cc: Fix indentation. * dll.cc: Fix indentation. * inferiors.h: Fix indentation. * linux-low.cc: Fix indentation. * linux-nios2-low.cc: Fix indentation. * linux-ppc-ipa.cc: Fix indentation. * linux-ppc-low.cc: Fix indentation. * linux-x86-low.cc: Fix indentation. * linux-xtensa-low.cc: Fix indentation. * regcache.cc: Fix indentation. * server.cc: Fix indentation. * tracepoint.cc: Fix indentation. gdbsupport/ChangeLog: * common-exceptions.h: Fix indentation. * event-loop.cc: Fix indentation. * fileio.cc: Fix indentation. * filestuff.cc: Fix indentation. * gdb-dlfcn.cc: Fix indentation. * gdb_string_view.h: Fix indentation. * job-control.cc: Fix indentation. * signals.cc: Fix indentation. Change-Id: I4bad7ae6be0fbe14168b8ebafb98ffe14964a695
752 lines
23 KiB
C
752 lines
23 KiB
C
/* Copyright (C) 2013-2020 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "solib-aix.h"
|
|
#include "solist.h"
|
|
#include "inferior.h"
|
|
#include "gdb_bfd.h"
|
|
#include "gdbcore.h"
|
|
#include "objfiles.h"
|
|
#include "symtab.h"
|
|
#include "xcoffread.h"
|
|
#include "observable.h"
|
|
#include "gdbcmd.h"
|
|
#include "gdbsupport/scope-exit.h"
|
|
|
|
/* Variable controlling the output of the debugging traces for
|
|
this module. */
|
|
static bool solib_aix_debug;
|
|
|
|
/* Our private data in struct so_list. */
|
|
|
|
struct lm_info_aix : public lm_info_base
|
|
{
|
|
/* The name of the file mapped by the loader. Apart from the entry
|
|
for the main executable, this is usually a shared library (which,
|
|
on AIX, is an archive library file, created using the "ar"
|
|
command). */
|
|
std::string filename;
|
|
|
|
/* The name of the shared object file with the actual dynamic
|
|
loading dependency. This may be empty (Eg. main executable). */
|
|
std::string member_name;
|
|
|
|
/* The address in inferior memory where the text section got mapped. */
|
|
CORE_ADDR text_addr = 0;
|
|
|
|
/* The size of the text section, obtained via the loader data. */
|
|
ULONGEST text_size = 0;
|
|
|
|
/* The address in inferior memory where the data section got mapped. */
|
|
CORE_ADDR data_addr = 0;
|
|
|
|
/* The size of the data section, obtained via the loader data. */
|
|
ULONGEST data_size = 0;
|
|
};
|
|
|
|
/* This module's per-inferior data. */
|
|
|
|
struct solib_aix_inferior_data
|
|
{
|
|
/* The list of shared libraries.
|
|
|
|
Note that the first element of this list is always the main
|
|
executable, which is not technically a shared library. But
|
|
we need that information to perform its relocation, and
|
|
the same principles applied to shared libraries also apply
|
|
to the main executable. So it's simpler to keep it as part
|
|
of this list. */
|
|
gdb::optional<std::vector<lm_info_aix>> library_list;
|
|
};
|
|
|
|
/* Key to our per-inferior data. */
|
|
static inferior_key<solib_aix_inferior_data> solib_aix_inferior_data_handle;
|
|
|
|
/* Return this module's data for the given inferior.
|
|
If none is found, add a zero'ed one now. */
|
|
|
|
static struct solib_aix_inferior_data *
|
|
get_solib_aix_inferior_data (struct inferior *inf)
|
|
{
|
|
struct solib_aix_inferior_data *data;
|
|
|
|
data = solib_aix_inferior_data_handle.get (inf);
|
|
if (data == NULL)
|
|
data = solib_aix_inferior_data_handle.emplace (inf);
|
|
|
|
return data;
|
|
}
|
|
|
|
#if !defined(HAVE_LIBEXPAT)
|
|
|
|
/* Dummy implementation if XML support is not compiled in. */
|
|
|
|
static gdb::optional<std::vector<lm_info_aix>>
|
|
solib_aix_parse_libraries (const char *library)
|
|
{
|
|
static int have_warned;
|
|
|
|
if (!have_warned)
|
|
{
|
|
have_warned = 1;
|
|
warning (_("Can not parse XML library list; XML support was disabled "
|
|
"at compile time"));
|
|
}
|
|
|
|
return {};
|
|
}
|
|
|
|
#else /* HAVE_LIBEXPAT */
|
|
|
|
#include "xml-support.h"
|
|
|
|
/* Handle the start of a <library> element. */
|
|
|
|
static void
|
|
library_list_start_library (struct gdb_xml_parser *parser,
|
|
const struct gdb_xml_element *element,
|
|
void *user_data,
|
|
std::vector<gdb_xml_value> &attributes)
|
|
{
|
|
std::vector<lm_info_aix> *list = (std::vector<lm_info_aix> *) user_data;
|
|
lm_info_aix item;
|
|
struct gdb_xml_value *attr;
|
|
|
|
attr = xml_find_attribute (attributes, "name");
|
|
item.filename = (const char *) attr->value.get ();
|
|
|
|
attr = xml_find_attribute (attributes, "member");
|
|
if (attr != NULL)
|
|
item.member_name = (const char *) attr->value.get ();
|
|
|
|
attr = xml_find_attribute (attributes, "text_addr");
|
|
item.text_addr = * (ULONGEST *) attr->value.get ();
|
|
|
|
attr = xml_find_attribute (attributes, "text_size");
|
|
item.text_size = * (ULONGEST *) attr->value.get ();
|
|
|
|
attr = xml_find_attribute (attributes, "data_addr");
|
|
item.data_addr = * (ULONGEST *) attr->value.get ();
|
|
|
|
attr = xml_find_attribute (attributes, "data_size");
|
|
item.data_size = * (ULONGEST *) attr->value.get ();
|
|
|
|
list->push_back (std::move (item));
|
|
}
|
|
|
|
/* Handle the start of a <library-list-aix> element. */
|
|
|
|
static void
|
|
library_list_start_list (struct gdb_xml_parser *parser,
|
|
const struct gdb_xml_element *element,
|
|
void *user_data,
|
|
std::vector<gdb_xml_value> &attributes)
|
|
{
|
|
char *version
|
|
= (char *) xml_find_attribute (attributes, "version")->value.get ();
|
|
|
|
if (strcmp (version, "1.0") != 0)
|
|
gdb_xml_error (parser,
|
|
_("Library list has unsupported version \"%s\""),
|
|
version);
|
|
}
|
|
|
|
/* The allowed elements and attributes for an AIX library list
|
|
described in XML format. The root element is a <library-list-aix>. */
|
|
|
|
static const struct gdb_xml_attribute library_attributes[] =
|
|
{
|
|
{ "name", GDB_XML_AF_NONE, NULL, NULL },
|
|
{ "member", GDB_XML_AF_OPTIONAL, NULL, NULL },
|
|
{ "text_addr", GDB_XML_AF_NONE, gdb_xml_parse_attr_ulongest, NULL },
|
|
{ "text_size", GDB_XML_AF_NONE, gdb_xml_parse_attr_ulongest, NULL },
|
|
{ "data_addr", GDB_XML_AF_NONE, gdb_xml_parse_attr_ulongest, NULL },
|
|
{ "data_size", GDB_XML_AF_NONE, gdb_xml_parse_attr_ulongest, NULL },
|
|
{ NULL, GDB_XML_AF_NONE, NULL, NULL }
|
|
};
|
|
|
|
static const struct gdb_xml_element library_list_children[] =
|
|
{
|
|
{ "library", library_attributes, NULL,
|
|
GDB_XML_EF_REPEATABLE | GDB_XML_EF_OPTIONAL,
|
|
library_list_start_library, NULL},
|
|
{ NULL, NULL, NULL, GDB_XML_EF_NONE, NULL, NULL }
|
|
};
|
|
|
|
static const struct gdb_xml_attribute library_list_attributes[] =
|
|
{
|
|
{ "version", GDB_XML_AF_NONE, NULL, NULL },
|
|
{ NULL, GDB_XML_AF_NONE, NULL, NULL }
|
|
};
|
|
|
|
static const struct gdb_xml_element library_list_elements[] =
|
|
{
|
|
{ "library-list-aix", library_list_attributes, library_list_children,
|
|
GDB_XML_EF_NONE, library_list_start_list, NULL },
|
|
{ NULL, NULL, NULL, GDB_XML_EF_NONE, NULL, NULL }
|
|
};
|
|
|
|
/* Parse LIBRARY, a string containing the loader info in XML format,
|
|
and return a vector of lm_info_aix objects.
|
|
|
|
Return an empty option if the parsing failed. */
|
|
|
|
static gdb::optional<std::vector<lm_info_aix>>
|
|
solib_aix_parse_libraries (const char *library)
|
|
{
|
|
std::vector<lm_info_aix> result;
|
|
|
|
if (gdb_xml_parse_quick (_("aix library list"), "library-list-aix.dtd",
|
|
library_list_elements, library, &result) == 0)
|
|
return result;
|
|
|
|
return {};
|
|
}
|
|
|
|
#endif /* HAVE_LIBEXPAT */
|
|
|
|
/* Return the loader info for the given inferior (INF), or an empty
|
|
option if the list could not be computed.
|
|
|
|
Cache the result in per-inferior data, so as to avoid recomputing it
|
|
each time this function is called.
|
|
|
|
If an error occurs while computing this list, and WARNING_MSG
|
|
is not NULL, then print a warning including WARNING_MSG and
|
|
a description of the error. */
|
|
|
|
static gdb::optional<std::vector<lm_info_aix>> &
|
|
solib_aix_get_library_list (struct inferior *inf, const char *warning_msg)
|
|
{
|
|
struct solib_aix_inferior_data *data;
|
|
|
|
/* If already computed, return the cached value. */
|
|
data = get_solib_aix_inferior_data (inf);
|
|
if (data->library_list.has_value ())
|
|
return data->library_list;
|
|
|
|
gdb::optional<gdb::char_vector> library_document
|
|
= target_read_stralloc (current_top_target (), TARGET_OBJECT_LIBRARIES_AIX,
|
|
NULL);
|
|
if (!library_document && warning_msg != NULL)
|
|
{
|
|
warning (_("%s (failed to read TARGET_OBJECT_LIBRARIES_AIX)"),
|
|
warning_msg);
|
|
return data->library_list;
|
|
}
|
|
|
|
if (solib_aix_debug)
|
|
fprintf_unfiltered (gdb_stdlog,
|
|
"DEBUG: TARGET_OBJECT_LIBRARIES_AIX = \n%s\n",
|
|
library_document->data ());
|
|
|
|
data->library_list = solib_aix_parse_libraries (library_document->data ());
|
|
if (!data->library_list.has_value () && warning_msg != NULL)
|
|
warning (_("%s (missing XML support?)"), warning_msg);
|
|
|
|
return data->library_list;
|
|
}
|
|
|
|
/* If the .bss section's VMA is set to an address located before
|
|
the end of the .data section, causing the two sections to overlap,
|
|
return the overlap in bytes. Otherwise, return zero.
|
|
|
|
Motivation:
|
|
|
|
The GNU linker sometimes sets the start address of the .bss session
|
|
before the end of the .data section, making the 2 sections overlap.
|
|
The loader appears to handle this situation gracefully, by simply
|
|
loading the bss section right after the end of the .data section.
|
|
|
|
This means that the .data and the .bss sections are sometimes
|
|
no longer relocated by the same amount. The problem is that
|
|
the ldinfo data does not contain any information regarding
|
|
the relocation of the .bss section, assuming that it would be
|
|
identical to the information provided for the .data section
|
|
(this is what would normally happen if the program was linked
|
|
correctly).
|
|
|
|
GDB therefore needs to detect those cases, and make the corresponding
|
|
adjustment to the .bss section offset computed from the ldinfo data
|
|
when necessary. This function returns the adjustment amount (or
|
|
zero when no adjustment is needed). */
|
|
|
|
static CORE_ADDR
|
|
solib_aix_bss_data_overlap (bfd *abfd)
|
|
{
|
|
struct bfd_section *data_sect, *bss_sect;
|
|
|
|
data_sect = bfd_get_section_by_name (abfd, ".data");
|
|
if (data_sect == NULL)
|
|
return 0; /* No overlap possible. */
|
|
|
|
bss_sect = bfd_get_section_by_name (abfd, ".bss");
|
|
if (bss_sect == NULL)
|
|
return 0; /* No overlap possible. */
|
|
|
|
/* Assume the problem only occurs with linkers that place the .bss
|
|
section after the .data section (the problem has only been
|
|
observed when using the GNU linker, and the default linker
|
|
script always places the .data and .bss sections in that order). */
|
|
if (bfd_section_vma (bss_sect) < bfd_section_vma (data_sect))
|
|
return 0;
|
|
|
|
if (bfd_section_vma (bss_sect)
|
|
< bfd_section_vma (data_sect) + bfd_section_size (data_sect))
|
|
return (bfd_section_vma (data_sect) + bfd_section_size (data_sect)
|
|
- bfd_section_vma (bss_sect));
|
|
|
|
return 0;
|
|
}
|
|
|
|
/* Implement the "relocate_section_addresses" target_so_ops method. */
|
|
|
|
static void
|
|
solib_aix_relocate_section_addresses (struct so_list *so,
|
|
struct target_section *sec)
|
|
{
|
|
struct bfd_section *bfd_sect = sec->the_bfd_section;
|
|
bfd *abfd = bfd_sect->owner;
|
|
const char *section_name = bfd_section_name (bfd_sect);
|
|
lm_info_aix *info = (lm_info_aix *) so->lm_info;
|
|
|
|
if (strcmp (section_name, ".text") == 0)
|
|
{
|
|
sec->addr = info->text_addr;
|
|
sec->endaddr = sec->addr + info->text_size;
|
|
|
|
/* The text address given to us by the loader contains
|
|
XCOFF headers, so we need to adjust by this much. */
|
|
sec->addr += bfd_sect->filepos;
|
|
}
|
|
else if (strcmp (section_name, ".data") == 0)
|
|
{
|
|
sec->addr = info->data_addr;
|
|
sec->endaddr = sec->addr + info->data_size;
|
|
}
|
|
else if (strcmp (section_name, ".bss") == 0)
|
|
{
|
|
/* The information provided by the loader does not include
|
|
the address of the .bss section, but we know that it gets
|
|
relocated by the same offset as the .data section. So,
|
|
compute the relocation offset for the .data section, and
|
|
apply it to the .bss section as well. If the .data section
|
|
is not defined (which seems highly unlikely), do our best
|
|
by assuming no relocation. */
|
|
struct bfd_section *data_sect
|
|
= bfd_get_section_by_name (abfd, ".data");
|
|
CORE_ADDR data_offset = 0;
|
|
|
|
if (data_sect != NULL)
|
|
data_offset = info->data_addr - bfd_section_vma (data_sect);
|
|
|
|
sec->addr = bfd_section_vma (bfd_sect) + data_offset;
|
|
sec->addr += solib_aix_bss_data_overlap (abfd);
|
|
sec->endaddr = sec->addr + bfd_section_size (bfd_sect);
|
|
}
|
|
else
|
|
{
|
|
/* All other sections should not be relocated. */
|
|
sec->addr = bfd_section_vma (bfd_sect);
|
|
sec->endaddr = sec->addr + bfd_section_size (bfd_sect);
|
|
}
|
|
}
|
|
|
|
/* Implement the "free_so" target_so_ops method. */
|
|
|
|
static void
|
|
solib_aix_free_so (struct so_list *so)
|
|
{
|
|
lm_info_aix *li = (lm_info_aix *) so->lm_info;
|
|
|
|
if (solib_aix_debug)
|
|
fprintf_unfiltered (gdb_stdlog, "DEBUG: solib_aix_free_so (%s)\n",
|
|
so->so_name);
|
|
|
|
delete li;
|
|
}
|
|
|
|
/* Implement the "clear_solib" target_so_ops method. */
|
|
|
|
static void
|
|
solib_aix_clear_solib (void)
|
|
{
|
|
/* Nothing needed. */
|
|
}
|
|
|
|
/* Compute and return the OBJFILE's section_offset array, using
|
|
the associated loader info (INFO). */
|
|
|
|
static section_offsets
|
|
solib_aix_get_section_offsets (struct objfile *objfile,
|
|
lm_info_aix *info)
|
|
{
|
|
bfd *abfd = objfile->obfd;
|
|
|
|
section_offsets offsets (objfile->section_offsets.size ());
|
|
|
|
/* .text */
|
|
|
|
if (objfile->sect_index_text != -1)
|
|
{
|
|
struct bfd_section *sect
|
|
= objfile->sections[objfile->sect_index_text].the_bfd_section;
|
|
|
|
offsets[objfile->sect_index_text]
|
|
= info->text_addr + sect->filepos - bfd_section_vma (sect);
|
|
}
|
|
|
|
/* .data */
|
|
|
|
if (objfile->sect_index_data != -1)
|
|
{
|
|
struct bfd_section *sect
|
|
= objfile->sections[objfile->sect_index_data].the_bfd_section;
|
|
|
|
offsets[objfile->sect_index_data]
|
|
= info->data_addr - bfd_section_vma (sect);
|
|
}
|
|
|
|
/* .bss
|
|
|
|
The offset of the .bss section should be identical to the offset
|
|
of the .data section. If no .data section (which seems hard to
|
|
believe it is possible), assume it is zero. */
|
|
|
|
if (objfile->sect_index_bss != -1
|
|
&& objfile->sect_index_data != -1)
|
|
{
|
|
offsets[objfile->sect_index_bss]
|
|
= (offsets[objfile->sect_index_data]
|
|
+ solib_aix_bss_data_overlap (abfd));
|
|
}
|
|
|
|
/* All other sections should not need relocation. */
|
|
|
|
return offsets;
|
|
}
|
|
|
|
/* Implement the "solib_create_inferior_hook" target_so_ops method. */
|
|
|
|
static void
|
|
solib_aix_solib_create_inferior_hook (int from_tty)
|
|
{
|
|
const char *warning_msg = "unable to relocate main executable";
|
|
|
|
/* We need to relocate the main executable... */
|
|
|
|
gdb::optional<std::vector<lm_info_aix>> &library_list
|
|
= solib_aix_get_library_list (current_inferior (), warning_msg);
|
|
if (!library_list.has_value ())
|
|
return; /* Warning already printed. */
|
|
|
|
if (library_list->empty ())
|
|
{
|
|
warning (_("unable to relocate main executable (no info from loader)"));
|
|
return;
|
|
}
|
|
|
|
lm_info_aix &exec_info = (*library_list)[0];
|
|
if (current_program_space->symfile_object_file != NULL)
|
|
{
|
|
objfile *objf = current_program_space->symfile_object_file;
|
|
section_offsets offsets = solib_aix_get_section_offsets (objf,
|
|
&exec_info);
|
|
|
|
objfile_relocate (objf, offsets);
|
|
}
|
|
}
|
|
|
|
/* Implement the "current_sos" target_so_ops method. */
|
|
|
|
static struct so_list *
|
|
solib_aix_current_sos (void)
|
|
{
|
|
struct so_list *start = NULL, *last = NULL;
|
|
int ix;
|
|
|
|
gdb::optional<std::vector<lm_info_aix>> &library_list
|
|
= solib_aix_get_library_list (current_inferior (), NULL);
|
|
if (!library_list.has_value ())
|
|
return NULL;
|
|
|
|
/* Build a struct so_list for each entry on the list.
|
|
We skip the first entry, since this is the entry corresponding
|
|
to the main executable, not a shared library. */
|
|
for (ix = 1; ix < library_list->size (); ix++)
|
|
{
|
|
struct so_list *new_solib = XCNEW (struct so_list);
|
|
std::string so_name;
|
|
|
|
lm_info_aix &info = (*library_list)[ix];
|
|
if (info.member_name.empty ())
|
|
{
|
|
/* INFO.FILENAME is probably not an archive, but rather
|
|
a shared object. Unusual, but it should be possible
|
|
to link a program against a shared object directory,
|
|
without having to put it in an archive first. */
|
|
so_name = info.filename;
|
|
}
|
|
else
|
|
{
|
|
/* This is the usual case on AIX, where the shared object
|
|
is a member of an archive. Create a synthetic so_name
|
|
that follows the same convention as AIX's ldd tool
|
|
(Eg: "/lib/libc.a(shr.o)"). */
|
|
so_name = string_printf ("%s(%s)", info.filename.c_str (),
|
|
info.member_name.c_str ());
|
|
}
|
|
strncpy (new_solib->so_original_name, so_name.c_str (),
|
|
SO_NAME_MAX_PATH_SIZE - 1);
|
|
new_solib->so_name[SO_NAME_MAX_PATH_SIZE - 1] = '\0';
|
|
memcpy (new_solib->so_name, new_solib->so_original_name,
|
|
SO_NAME_MAX_PATH_SIZE);
|
|
new_solib->lm_info = new lm_info_aix (info);
|
|
|
|
/* Add it to the list. */
|
|
if (!start)
|
|
last = start = new_solib;
|
|
else
|
|
{
|
|
last->next = new_solib;
|
|
last = new_solib;
|
|
}
|
|
}
|
|
|
|
return start;
|
|
}
|
|
|
|
/* Implement the "open_symbol_file_object" target_so_ops method. */
|
|
|
|
static int
|
|
solib_aix_open_symbol_file_object (int from_tty)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
/* Implement the "in_dynsym_resolve_code" target_so_ops method. */
|
|
|
|
static int
|
|
solib_aix_in_dynsym_resolve_code (CORE_ADDR pc)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
/* Implement the "bfd_open" target_so_ops method. */
|
|
|
|
static gdb_bfd_ref_ptr
|
|
solib_aix_bfd_open (const char *pathname)
|
|
{
|
|
/* The pathname is actually a synthetic filename with the following
|
|
form: "/path/to/sharedlib(member.o)" (double-quotes excluded).
|
|
split this into archive name and member name.
|
|
|
|
FIXME: This is a little hacky. Perhaps we should provide access
|
|
to the solib's lm_info here? */
|
|
const int path_len = strlen (pathname);
|
|
const char *sep;
|
|
int filename_len;
|
|
int found_file;
|
|
|
|
if (pathname[path_len - 1] != ')')
|
|
return solib_bfd_open (pathname);
|
|
|
|
/* Search for the associated parens. */
|
|
sep = strrchr (pathname, '(');
|
|
if (sep == NULL)
|
|
{
|
|
/* Should never happen, but recover as best as we can (trying
|
|
to open pathname without decoding, possibly leading to
|
|
a failure), rather than triggering an assert failure). */
|
|
warning (_("missing '(' in shared object pathname: %s"), pathname);
|
|
return solib_bfd_open (pathname);
|
|
}
|
|
filename_len = sep - pathname;
|
|
|
|
std::string filename (string_printf ("%.*s", filename_len, pathname));
|
|
std::string member_name (string_printf ("%.*s", path_len - filename_len - 2,
|
|
sep + 1));
|
|
|
|
/* Calling solib_find makes certain that sysroot path is set properly
|
|
if program has a dependency on .a archive and sysroot is set via
|
|
set sysroot command. */
|
|
gdb::unique_xmalloc_ptr<char> found_pathname
|
|
= solib_find (filename.c_str (), &found_file);
|
|
if (found_pathname == NULL)
|
|
perror_with_name (pathname);
|
|
gdb_bfd_ref_ptr archive_bfd (solib_bfd_fopen (found_pathname.get (),
|
|
found_file));
|
|
if (archive_bfd == NULL)
|
|
{
|
|
warning (_("Could not open `%s' as an executable file: %s"),
|
|
filename.c_str (), bfd_errmsg (bfd_get_error ()));
|
|
return NULL;
|
|
}
|
|
|
|
if (bfd_check_format (archive_bfd.get (), bfd_object))
|
|
return archive_bfd;
|
|
|
|
if (! bfd_check_format (archive_bfd.get (), bfd_archive))
|
|
{
|
|
warning (_("\"%s\": not in executable format: %s."),
|
|
filename.c_str (), bfd_errmsg (bfd_get_error ()));
|
|
return NULL;
|
|
}
|
|
|
|
gdb_bfd_ref_ptr object_bfd
|
|
(gdb_bfd_openr_next_archived_file (archive_bfd.get (), NULL));
|
|
while (object_bfd != NULL)
|
|
{
|
|
if (member_name == bfd_get_filename (object_bfd.get ()))
|
|
break;
|
|
|
|
object_bfd = gdb_bfd_openr_next_archived_file (archive_bfd.get (),
|
|
object_bfd.get ());
|
|
}
|
|
|
|
if (object_bfd == NULL)
|
|
{
|
|
warning (_("\"%s\": member \"%s\" missing."), filename.c_str (),
|
|
member_name.c_str ());
|
|
return NULL;
|
|
}
|
|
|
|
if (! bfd_check_format (object_bfd.get (), bfd_object))
|
|
{
|
|
warning (_("%s(%s): not in object format: %s."),
|
|
filename.c_str (), member_name.c_str (),
|
|
bfd_errmsg (bfd_get_error ()));
|
|
return NULL;
|
|
}
|
|
|
|
/* Override the returned bfd's name with the name returned from solib_find
|
|
along with appended parenthesized member name in order to allow commands
|
|
listing all shared libraries to display. Otherwise, we would only be
|
|
displaying the name of the archive member object. */
|
|
std::string fname = string_printf ("%s%s",
|
|
bfd_get_filename (archive_bfd.get ()),
|
|
sep);
|
|
bfd_set_filename (object_bfd.get (), fname.c_str ());
|
|
|
|
return object_bfd;
|
|
}
|
|
|
|
/* Return the obj_section corresponding to OBJFILE's data section,
|
|
or NULL if not found. */
|
|
/* FIXME: Define in a more general location? */
|
|
|
|
static struct obj_section *
|
|
data_obj_section_from_objfile (struct objfile *objfile)
|
|
{
|
|
struct obj_section *osect;
|
|
|
|
ALL_OBJFILE_OSECTIONS (objfile, osect)
|
|
if (strcmp (bfd_section_name (osect->the_bfd_section), ".data") == 0)
|
|
return osect;
|
|
|
|
return NULL;
|
|
}
|
|
|
|
/* Return the TOC value corresponding to the given PC address,
|
|
or raise an error if the value could not be determined. */
|
|
|
|
CORE_ADDR
|
|
solib_aix_get_toc_value (CORE_ADDR pc)
|
|
{
|
|
struct obj_section *pc_osect = find_pc_section (pc);
|
|
struct obj_section *data_osect;
|
|
CORE_ADDR result;
|
|
|
|
if (pc_osect == NULL)
|
|
error (_("unable to find TOC entry for pc %s "
|
|
"(no section contains this PC)"),
|
|
core_addr_to_string (pc));
|
|
|
|
data_osect = data_obj_section_from_objfile (pc_osect->objfile);
|
|
if (data_osect == NULL)
|
|
error (_("unable to find TOC entry for pc %s "
|
|
"(%s has no data section)"),
|
|
core_addr_to_string (pc), objfile_name (pc_osect->objfile));
|
|
|
|
result = (obj_section_addr (data_osect)
|
|
+ xcoff_get_toc_offset (pc_osect->objfile));
|
|
if (solib_aix_debug)
|
|
fprintf_unfiltered (gdb_stdlog,
|
|
"DEBUG: solib_aix_get_toc_value (pc=%s) -> %s\n",
|
|
core_addr_to_string (pc),
|
|
core_addr_to_string (result));
|
|
|
|
return result;
|
|
}
|
|
|
|
/* This module's normal_stop observer. */
|
|
|
|
static void
|
|
solib_aix_normal_stop_observer (struct bpstats *unused_1, int unused_2)
|
|
{
|
|
struct solib_aix_inferior_data *data
|
|
= get_solib_aix_inferior_data (current_inferior ());
|
|
|
|
/* The inferior execution has been resumed, and it just stopped
|
|
again. This means that the list of shared libraries may have
|
|
evolved. Reset our cached value. */
|
|
data->library_list.reset ();
|
|
}
|
|
|
|
/* Implements the "show debug aix-solib" command. */
|
|
|
|
static void
|
|
show_solib_aix_debug (struct ui_file *file, int from_tty,
|
|
struct cmd_list_element *c, const char *value)
|
|
{
|
|
fprintf_filtered (file, _("solib-aix debugging is %s.\n"), value);
|
|
}
|
|
|
|
/* The target_so_ops for AIX targets. */
|
|
struct target_so_ops solib_aix_so_ops;
|
|
|
|
void _initialize_solib_aix ();
|
|
void
|
|
_initialize_solib_aix ()
|
|
{
|
|
solib_aix_so_ops.relocate_section_addresses
|
|
= solib_aix_relocate_section_addresses;
|
|
solib_aix_so_ops.free_so = solib_aix_free_so;
|
|
solib_aix_so_ops.clear_solib = solib_aix_clear_solib;
|
|
solib_aix_so_ops.solib_create_inferior_hook
|
|
= solib_aix_solib_create_inferior_hook;
|
|
solib_aix_so_ops.current_sos = solib_aix_current_sos;
|
|
solib_aix_so_ops.open_symbol_file_object
|
|
= solib_aix_open_symbol_file_object;
|
|
solib_aix_so_ops.in_dynsym_resolve_code
|
|
= solib_aix_in_dynsym_resolve_code;
|
|
solib_aix_so_ops.bfd_open = solib_aix_bfd_open;
|
|
|
|
gdb::observers::normal_stop.attach (solib_aix_normal_stop_observer);
|
|
|
|
/* Debug this file's internals. */
|
|
add_setshow_boolean_cmd ("aix-solib", class_maintenance,
|
|
&solib_aix_debug, _("\
|
|
Control the debugging traces for the solib-aix module."), _("\
|
|
Show whether solib-aix debugging traces are enabled."), _("\
|
|
When on, solib-aix debugging traces are enabled."),
|
|
NULL,
|
|
show_solib_aix_debug,
|
|
&setdebuglist, &showdebuglist);
|
|
}
|