mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
dda83cd783
Many spots incorrectly use only spaces for indentation (for example, there are a lot of spots in ada-lang.c). I've always found it awkward when I needed to edit one of these spots: do I keep the original wrong indentation, or do I fix it? What if the lines around it are also wrong, do I fix them too? I probably don't want to fix them in the same patch, to avoid adding noise to my patch. So I propose to fix as much as possible once and for all (hopefully). One typical counter argument for this is that it makes code archeology more difficult, because git-blame will show this commit as the last change for these lines. My counter counter argument is: when git-blaming, you often need to do "blame the file at the parent commit" anyway, to go past some other refactor that touched the line you are interested in, but is not the change you are looking for. So you already need a somewhat efficient way to do this. Using some interactive tool, rather than plain git-blame, makes this trivial. For example, I use "tig blame <file>", where going back past the commit that changed the currently selected line is one keystroke. It looks like Magit in Emacs does it too (though I've never used it). Web viewers of Github and Gitlab do it too. My point is that it won't really make archeology more difficult. The other typical counter argument is that it will cause conflicts with existing patches. That's true... but it's a one time cost, and those are not conflicts that are difficult to resolve. I have also tried "git rebase --ignore-whitespace", it seems to work well. Although that will re-introduce the faulty indentation, so one needs to take care of fixing the indentation in the patch after that (which is easy). gdb/ChangeLog: * aarch64-linux-tdep.c: Fix indentation. * aarch64-ravenscar-thread.c: Fix indentation. * aarch64-tdep.c: Fix indentation. * aarch64-tdep.h: Fix indentation. * ada-lang.c: Fix indentation. * ada-lang.h: Fix indentation. * ada-tasks.c: Fix indentation. * ada-typeprint.c: Fix indentation. * ada-valprint.c: Fix indentation. * ada-varobj.c: Fix indentation. * addrmap.c: Fix indentation. * addrmap.h: Fix indentation. * agent.c: Fix indentation. * aix-thread.c: Fix indentation. * alpha-bsd-nat.c: Fix indentation. * alpha-linux-tdep.c: Fix indentation. * alpha-mdebug-tdep.c: Fix indentation. * alpha-nbsd-tdep.c: Fix indentation. * alpha-obsd-tdep.c: Fix indentation. * alpha-tdep.c: Fix indentation. * amd64-bsd-nat.c: Fix indentation. * amd64-darwin-tdep.c: Fix indentation. * amd64-linux-nat.c: Fix indentation. * amd64-linux-tdep.c: Fix indentation. * amd64-nat.c: Fix indentation. * amd64-obsd-tdep.c: Fix indentation. * amd64-tdep.c: Fix indentation. * amd64-windows-tdep.c: Fix indentation. * annotate.c: Fix indentation. * arc-tdep.c: Fix indentation. * arch-utils.c: Fix indentation. * arch/arm-get-next-pcs.c: Fix indentation. * arch/arm.c: Fix indentation. * arm-linux-nat.c: Fix indentation. * arm-linux-tdep.c: Fix indentation. * arm-nbsd-tdep.c: Fix indentation. * arm-pikeos-tdep.c: Fix indentation. * arm-tdep.c: Fix indentation. * arm-tdep.h: Fix indentation. * arm-wince-tdep.c: Fix indentation. * auto-load.c: Fix indentation. * auxv.c: Fix indentation. * avr-tdep.c: Fix indentation. * ax-gdb.c: Fix indentation. * ax-general.c: Fix indentation. * bfin-linux-tdep.c: Fix indentation. * block.c: Fix indentation. * block.h: Fix indentation. * blockframe.c: Fix indentation. * bpf-tdep.c: Fix indentation. * break-catch-sig.c: Fix indentation. * break-catch-syscall.c: Fix indentation. * break-catch-throw.c: Fix indentation. * breakpoint.c: Fix indentation. * breakpoint.h: Fix indentation. * bsd-uthread.c: Fix indentation. * btrace.c: Fix indentation. * build-id.c: Fix indentation. * buildsym-legacy.h: Fix indentation. * buildsym.c: Fix indentation. * c-typeprint.c: Fix indentation. * c-valprint.c: Fix indentation. * c-varobj.c: Fix indentation. * charset.c: Fix indentation. * cli/cli-cmds.c: Fix indentation. * cli/cli-decode.c: Fix indentation. * cli/cli-decode.h: Fix indentation. * cli/cli-script.c: Fix indentation. * cli/cli-setshow.c: Fix indentation. * coff-pe-read.c: Fix indentation. * coffread.c: Fix indentation. * compile/compile-cplus-types.c: Fix indentation. * compile/compile-object-load.c: Fix indentation. * compile/compile-object-run.c: Fix indentation. * completer.c: Fix indentation. * corefile.c: Fix indentation. * corelow.c: Fix indentation. * cp-abi.h: Fix indentation. * cp-namespace.c: Fix indentation. * cp-support.c: Fix indentation. * cp-valprint.c: Fix indentation. * cris-linux-tdep.c: Fix indentation. * cris-tdep.c: Fix indentation. * darwin-nat-info.c: Fix indentation. * darwin-nat.c: Fix indentation. * darwin-nat.h: Fix indentation. * dbxread.c: Fix indentation. * dcache.c: Fix indentation. * disasm.c: Fix indentation. * dtrace-probe.c: Fix indentation. * dwarf2/abbrev.c: Fix indentation. * dwarf2/attribute.c: Fix indentation. * dwarf2/expr.c: Fix indentation. * dwarf2/frame.c: Fix indentation. * dwarf2/index-cache.c: Fix indentation. * dwarf2/index-write.c: Fix indentation. * dwarf2/line-header.c: Fix indentation. * dwarf2/loc.c: Fix indentation. * dwarf2/macro.c: Fix indentation. * dwarf2/read.c: Fix indentation. * dwarf2/read.h: Fix indentation. * elfread.c: Fix indentation. * eval.c: Fix indentation. * event-top.c: Fix indentation. * exec.c: Fix indentation. * exec.h: Fix indentation. * expprint.c: Fix indentation. * f-lang.c: Fix indentation. * f-typeprint.c: Fix indentation. * f-valprint.c: Fix indentation. * fbsd-nat.c: Fix indentation. * fbsd-tdep.c: Fix indentation. * findvar.c: Fix indentation. * fork-child.c: Fix indentation. * frame-unwind.c: Fix indentation. * frame-unwind.h: Fix indentation. * frame.c: Fix indentation. * frv-linux-tdep.c: Fix indentation. * frv-tdep.c: Fix indentation. * frv-tdep.h: Fix indentation. * ft32-tdep.c: Fix indentation. * gcore.c: Fix indentation. * gdb_bfd.c: Fix indentation. * gdbarch.sh: Fix indentation. * gdbarch.c: Re-generate * gdbarch.h: Re-generate. * gdbcore.h: Fix indentation. * gdbthread.h: Fix indentation. * gdbtypes.c: Fix indentation. * gdbtypes.h: Fix indentation. * glibc-tdep.c: Fix indentation. * gnu-nat.c: Fix indentation. * gnu-nat.h: Fix indentation. * gnu-v2-abi.c: Fix indentation. * gnu-v3-abi.c: Fix indentation. * go32-nat.c: Fix indentation. * guile/guile-internal.h: Fix indentation. * guile/scm-cmd.c: Fix indentation. * guile/scm-frame.c: Fix indentation. * guile/scm-iterator.c: Fix indentation. * guile/scm-math.c: Fix indentation. * guile/scm-ports.c: Fix indentation. * guile/scm-pretty-print.c: Fix indentation. * guile/scm-value.c: Fix indentation. * h8300-tdep.c: Fix indentation. * hppa-linux-nat.c: Fix indentation. * hppa-linux-tdep.c: Fix indentation. * hppa-nbsd-nat.c: Fix indentation. * hppa-nbsd-tdep.c: Fix indentation. * hppa-obsd-nat.c: Fix indentation. * hppa-tdep.c: Fix indentation. * hppa-tdep.h: Fix indentation. * i386-bsd-nat.c: Fix indentation. * i386-darwin-nat.c: Fix indentation. * i386-darwin-tdep.c: Fix indentation. * i386-dicos-tdep.c: Fix indentation. * i386-gnu-nat.c: Fix indentation. * i386-linux-nat.c: Fix indentation. * i386-linux-tdep.c: Fix indentation. * i386-nto-tdep.c: Fix indentation. * i386-obsd-tdep.c: Fix indentation. * i386-sol2-nat.c: Fix indentation. * i386-tdep.c: Fix indentation. * i386-tdep.h: Fix indentation. * i386-windows-tdep.c: Fix indentation. * i387-tdep.c: Fix indentation. * i387-tdep.h: Fix indentation. * ia64-libunwind-tdep.c: Fix indentation. * ia64-libunwind-tdep.h: Fix indentation. * ia64-linux-nat.c: Fix indentation. * ia64-linux-tdep.c: Fix indentation. * ia64-tdep.c: Fix indentation. * ia64-tdep.h: Fix indentation. * ia64-vms-tdep.c: Fix indentation. * infcall.c: Fix indentation. * infcmd.c: Fix indentation. * inferior.c: Fix indentation. * infrun.c: Fix indentation. * iq2000-tdep.c: Fix indentation. * language.c: Fix indentation. * linespec.c: Fix indentation. * linux-fork.c: Fix indentation. * linux-nat.c: Fix indentation. * linux-tdep.c: Fix indentation. * linux-thread-db.c: Fix indentation. * lm32-tdep.c: Fix indentation. * m2-lang.c: Fix indentation. * m2-typeprint.c: Fix indentation. * m2-valprint.c: Fix indentation. * m32c-tdep.c: Fix indentation. * m32r-linux-tdep.c: Fix indentation. * m32r-tdep.c: Fix indentation. * m68hc11-tdep.c: Fix indentation. * m68k-bsd-nat.c: Fix indentation. * m68k-linux-nat.c: Fix indentation. * m68k-linux-tdep.c: Fix indentation. * m68k-tdep.c: Fix indentation. * machoread.c: Fix indentation. * macrocmd.c: Fix indentation. * macroexp.c: Fix indentation. * macroscope.c: Fix indentation. * macrotab.c: Fix indentation. * macrotab.h: Fix indentation. * main.c: Fix indentation. * mdebugread.c: Fix indentation. * mep-tdep.c: Fix indentation. * mi/mi-cmd-catch.c: Fix indentation. * mi/mi-cmd-disas.c: Fix indentation. * mi/mi-cmd-env.c: Fix indentation. * mi/mi-cmd-stack.c: Fix indentation. * mi/mi-cmd-var.c: Fix indentation. * mi/mi-cmds.c: Fix indentation. * mi/mi-main.c: Fix indentation. * mi/mi-parse.c: Fix indentation. * microblaze-tdep.c: Fix indentation. * minidebug.c: Fix indentation. * minsyms.c: Fix indentation. * mips-linux-nat.c: Fix indentation. * mips-linux-tdep.c: Fix indentation. * mips-nbsd-tdep.c: Fix indentation. * mips-tdep.c: Fix indentation. * mn10300-linux-tdep.c: Fix indentation. * mn10300-tdep.c: Fix indentation. * moxie-tdep.c: Fix indentation. * msp430-tdep.c: Fix indentation. * namespace.h: Fix indentation. * nat/fork-inferior.c: Fix indentation. * nat/gdb_ptrace.h: Fix indentation. * nat/linux-namespaces.c: Fix indentation. * nat/linux-osdata.c: Fix indentation. * nat/netbsd-nat.c: Fix indentation. * nat/x86-dregs.c: Fix indentation. * nbsd-nat.c: Fix indentation. * nbsd-tdep.c: Fix indentation. * nios2-linux-tdep.c: Fix indentation. * nios2-tdep.c: Fix indentation. * nto-procfs.c: Fix indentation. * nto-tdep.c: Fix indentation. * objfiles.c: Fix indentation. * objfiles.h: Fix indentation. * opencl-lang.c: Fix indentation. * or1k-tdep.c: Fix indentation. * osabi.c: Fix indentation. * osabi.h: Fix indentation. * osdata.c: Fix indentation. * p-lang.c: Fix indentation. * p-typeprint.c: Fix indentation. * p-valprint.c: Fix indentation. * parse.c: Fix indentation. * ppc-linux-nat.c: Fix indentation. * ppc-linux-tdep.c: Fix indentation. * ppc-nbsd-nat.c: Fix indentation. * ppc-nbsd-tdep.c: Fix indentation. * ppc-obsd-nat.c: Fix indentation. * ppc-ravenscar-thread.c: Fix indentation. * ppc-sysv-tdep.c: Fix indentation. * ppc64-tdep.c: Fix indentation. * printcmd.c: Fix indentation. * proc-api.c: Fix indentation. * producer.c: Fix indentation. * producer.h: Fix indentation. * prologue-value.c: Fix indentation. * prologue-value.h: Fix indentation. * psymtab.c: Fix indentation. * python/py-arch.c: Fix indentation. * python/py-bpevent.c: Fix indentation. * python/py-event.c: Fix indentation. * python/py-event.h: Fix indentation. * python/py-finishbreakpoint.c: Fix indentation. * python/py-frame.c: Fix indentation. * python/py-framefilter.c: Fix indentation. * python/py-inferior.c: Fix indentation. * python/py-infthread.c: Fix indentation. * python/py-objfile.c: Fix indentation. * python/py-prettyprint.c: Fix indentation. * python/py-registers.c: Fix indentation. * python/py-signalevent.c: Fix indentation. * python/py-stopevent.c: Fix indentation. * python/py-stopevent.h: Fix indentation. * python/py-threadevent.c: Fix indentation. * python/py-tui.c: Fix indentation. * python/py-unwind.c: Fix indentation. * python/py-value.c: Fix indentation. * python/py-xmethods.c: Fix indentation. * python/python-internal.h: Fix indentation. * python/python.c: Fix indentation. * ravenscar-thread.c: Fix indentation. * record-btrace.c: Fix indentation. * record-full.c: Fix indentation. * record.c: Fix indentation. * reggroups.c: Fix indentation. * regset.h: Fix indentation. * remote-fileio.c: Fix indentation. * remote.c: Fix indentation. * reverse.c: Fix indentation. * riscv-linux-tdep.c: Fix indentation. * riscv-ravenscar-thread.c: Fix indentation. * riscv-tdep.c: Fix indentation. * rl78-tdep.c: Fix indentation. * rs6000-aix-tdep.c: Fix indentation. * rs6000-lynx178-tdep.c: Fix indentation. * rs6000-nat.c: Fix indentation. * rs6000-tdep.c: Fix indentation. * rust-lang.c: Fix indentation. * rx-tdep.c: Fix indentation. * s12z-tdep.c: Fix indentation. * s390-linux-tdep.c: Fix indentation. * score-tdep.c: Fix indentation. * ser-base.c: Fix indentation. * ser-mingw.c: Fix indentation. * ser-uds.c: Fix indentation. * ser-unix.c: Fix indentation. * serial.c: Fix indentation. * sh-linux-tdep.c: Fix indentation. * sh-nbsd-tdep.c: Fix indentation. * sh-tdep.c: Fix indentation. * skip.c: Fix indentation. * sol-thread.c: Fix indentation. * solib-aix.c: Fix indentation. * solib-darwin.c: Fix indentation. * solib-frv.c: Fix indentation. * solib-svr4.c: Fix indentation. * solib.c: Fix indentation. * source.c: Fix indentation. * sparc-linux-tdep.c: Fix indentation. * sparc-nbsd-tdep.c: Fix indentation. * sparc-obsd-tdep.c: Fix indentation. * sparc-ravenscar-thread.c: Fix indentation. * sparc-tdep.c: Fix indentation. * sparc64-linux-tdep.c: Fix indentation. * sparc64-nbsd-tdep.c: Fix indentation. * sparc64-obsd-tdep.c: Fix indentation. * sparc64-tdep.c: Fix indentation. * stabsread.c: Fix indentation. * stack.c: Fix indentation. * stap-probe.c: Fix indentation. * stubs/ia64vms-stub.c: Fix indentation. * stubs/m32r-stub.c: Fix indentation. * stubs/m68k-stub.c: Fix indentation. * stubs/sh-stub.c: Fix indentation. * stubs/sparc-stub.c: Fix indentation. * symfile-mem.c: Fix indentation. * symfile.c: Fix indentation. * symfile.h: Fix indentation. * symmisc.c: Fix indentation. * symtab.c: Fix indentation. * symtab.h: Fix indentation. * target-float.c: Fix indentation. * target.c: Fix indentation. * target.h: Fix indentation. * tic6x-tdep.c: Fix indentation. * tilegx-linux-tdep.c: Fix indentation. * tilegx-tdep.c: Fix indentation. * top.c: Fix indentation. * tracefile-tfile.c: Fix indentation. * tracepoint.c: Fix indentation. * tui/tui-disasm.c: Fix indentation. * tui/tui-io.c: Fix indentation. * tui/tui-regs.c: Fix indentation. * tui/tui-stack.c: Fix indentation. * tui/tui-win.c: Fix indentation. * tui/tui-winsource.c: Fix indentation. * tui/tui.c: Fix indentation. * typeprint.c: Fix indentation. * ui-out.h: Fix indentation. * unittests/copy_bitwise-selftests.c: Fix indentation. * unittests/memory-map-selftests.c: Fix indentation. * utils.c: Fix indentation. * v850-tdep.c: Fix indentation. * valarith.c: Fix indentation. * valops.c: Fix indentation. * valprint.c: Fix indentation. * valprint.h: Fix indentation. * value.c: Fix indentation. * value.h: Fix indentation. * varobj.c: Fix indentation. * vax-tdep.c: Fix indentation. * windows-nat.c: Fix indentation. * windows-tdep.c: Fix indentation. * xcoffread.c: Fix indentation. * xml-syscall.c: Fix indentation. * xml-tdesc.c: Fix indentation. * xstormy16-tdep.c: Fix indentation. * xtensa-config.c: Fix indentation. * xtensa-linux-nat.c: Fix indentation. * xtensa-linux-tdep.c: Fix indentation. * xtensa-tdep.c: Fix indentation. gdbserver/ChangeLog: * ax.cc: Fix indentation. * dll.cc: Fix indentation. * inferiors.h: Fix indentation. * linux-low.cc: Fix indentation. * linux-nios2-low.cc: Fix indentation. * linux-ppc-ipa.cc: Fix indentation. * linux-ppc-low.cc: Fix indentation. * linux-x86-low.cc: Fix indentation. * linux-xtensa-low.cc: Fix indentation. * regcache.cc: Fix indentation. * server.cc: Fix indentation. * tracepoint.cc: Fix indentation. gdbsupport/ChangeLog: * common-exceptions.h: Fix indentation. * event-loop.cc: Fix indentation. * fileio.cc: Fix indentation. * filestuff.cc: Fix indentation. * gdb-dlfcn.cc: Fix indentation. * gdb_string_view.h: Fix indentation. * job-control.cc: Fix indentation. * signals.cc: Fix indentation. Change-Id: I4bad7ae6be0fbe14168b8ebafb98ffe14964a695
791 lines
21 KiB
C
791 lines
21 KiB
C
/* GNU/Linux native-dependent code for debugging multiple forks.
|
|
|
|
Copyright (C) 2005-2020 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "arch-utils.h"
|
|
#include "inferior.h"
|
|
#include "infrun.h"
|
|
#include "regcache.h"
|
|
#include "gdbcmd.h"
|
|
#include "infcall.h"
|
|
#include "objfiles.h"
|
|
#include "linux-fork.h"
|
|
#include "linux-nat.h"
|
|
#include "gdbthread.h"
|
|
#include "source.h"
|
|
|
|
#include "nat/gdb_ptrace.h"
|
|
#include "gdbsupport/gdb_wait.h"
|
|
#include <dirent.h>
|
|
#include <ctype.h>
|
|
|
|
#include <list>
|
|
|
|
/* Fork list data structure: */
|
|
struct fork_info
|
|
{
|
|
explicit fork_info (pid_t pid)
|
|
: ptid (pid, pid, 0)
|
|
{
|
|
}
|
|
|
|
~fork_info ()
|
|
{
|
|
/* Notes on step-resume breakpoints: since this is a concern for
|
|
threads, let's convince ourselves that it's not a concern for
|
|
forks. There are two ways for a fork_info to be created.
|
|
First, by the checkpoint command, in which case we're at a gdb
|
|
prompt and there can't be any step-resume breakpoint. Second,
|
|
by a fork in the user program, in which case we *may* have
|
|
stepped into the fork call, but regardless of whether we follow
|
|
the parent or the child, we will return to the same place and
|
|
the step-resume breakpoint, if any, will take care of itself as
|
|
usual. And unlike threads, we do not save a private copy of
|
|
the step-resume breakpoint -- so we're OK. */
|
|
|
|
if (savedregs)
|
|
delete savedregs;
|
|
|
|
xfree (filepos);
|
|
}
|
|
|
|
ptid_t ptid = null_ptid;
|
|
ptid_t parent_ptid = null_ptid;
|
|
|
|
/* Convenient handle (GDB fork id). */
|
|
int num = 0;
|
|
|
|
/* Convenient for info fork, saves having to actually switch
|
|
contexts. */
|
|
readonly_detached_regcache *savedregs = nullptr;
|
|
|
|
CORE_ADDR pc = 0;
|
|
|
|
/* Set of open file descriptors' offsets. */
|
|
off_t *filepos = nullptr;
|
|
|
|
int maxfd = 0;
|
|
};
|
|
|
|
static std::list<fork_info> fork_list;
|
|
static int highest_fork_num;
|
|
|
|
/* Fork list methods: */
|
|
|
|
int
|
|
forks_exist_p (void)
|
|
{
|
|
return !fork_list.empty ();
|
|
}
|
|
|
|
/* Return the last fork in the list. */
|
|
|
|
static struct fork_info *
|
|
find_last_fork (void)
|
|
{
|
|
if (fork_list.empty ())
|
|
return NULL;
|
|
|
|
return &fork_list.back ();
|
|
}
|
|
|
|
/* Return true iff there's one fork in the list. */
|
|
|
|
static bool
|
|
one_fork_p ()
|
|
{
|
|
return fork_list.size () == 1;
|
|
}
|
|
|
|
/* Add a new fork to the internal fork list. */
|
|
|
|
void
|
|
add_fork (pid_t pid)
|
|
{
|
|
fork_list.emplace_back (pid);
|
|
|
|
if (one_fork_p ())
|
|
highest_fork_num = 0;
|
|
|
|
fork_info *fp = &fork_list.back ();
|
|
fp->num = ++highest_fork_num;
|
|
}
|
|
|
|
static void
|
|
delete_fork (ptid_t ptid)
|
|
{
|
|
linux_target->low_forget_process (ptid.pid ());
|
|
|
|
for (auto it = fork_list.begin (); it != fork_list.end (); ++it)
|
|
if (it->ptid == ptid)
|
|
{
|
|
fork_list.erase (it);
|
|
|
|
/* Special case: if there is now only one process in the list,
|
|
and if it is (hopefully!) the current inferior_ptid, then
|
|
remove it, leaving the list empty -- we're now down to the
|
|
default case of debugging a single process. */
|
|
if (one_fork_p () && fork_list.front ().ptid == inferior_ptid)
|
|
{
|
|
/* Last fork -- delete from list and handle as solo
|
|
process (should be a safe recursion). */
|
|
delete_fork (inferior_ptid);
|
|
}
|
|
return;
|
|
}
|
|
}
|
|
|
|
/* Find a fork_info by matching PTID. */
|
|
static struct fork_info *
|
|
find_fork_ptid (ptid_t ptid)
|
|
{
|
|
for (fork_info &fi : fork_list)
|
|
if (fi.ptid == ptid)
|
|
return &fi;
|
|
|
|
return NULL;
|
|
}
|
|
|
|
/* Find a fork_info by matching ID. */
|
|
static struct fork_info *
|
|
find_fork_id (int num)
|
|
{
|
|
for (fork_info &fi : fork_list)
|
|
if (fi.num == num)
|
|
return &fi;
|
|
|
|
return NULL;
|
|
}
|
|
|
|
/* Find a fork_info by matching pid. */
|
|
extern struct fork_info *
|
|
find_fork_pid (pid_t pid)
|
|
{
|
|
for (fork_info &fi : fork_list)
|
|
if (pid == fi.ptid.pid ())
|
|
return &fi;
|
|
|
|
return NULL;
|
|
}
|
|
|
|
static ptid_t
|
|
fork_id_to_ptid (int num)
|
|
{
|
|
struct fork_info *fork = find_fork_id (num);
|
|
if (fork)
|
|
return fork->ptid;
|
|
else
|
|
return ptid_t (-1);
|
|
}
|
|
|
|
/* Fork list <-> gdb interface. */
|
|
|
|
/* Utility function for fork_load/fork_save.
|
|
Calls lseek in the (current) inferior process. */
|
|
|
|
static off_t
|
|
call_lseek (int fd, off_t offset, int whence)
|
|
{
|
|
char exp[80];
|
|
|
|
snprintf (&exp[0], sizeof (exp), "(long) lseek (%d, %ld, %d)",
|
|
fd, (long) offset, whence);
|
|
return (off_t) parse_and_eval_long (&exp[0]);
|
|
}
|
|
|
|
/* Load infrun state for the fork PTID. */
|
|
|
|
static void
|
|
fork_load_infrun_state (struct fork_info *fp)
|
|
{
|
|
int i;
|
|
|
|
linux_nat_switch_fork (fp->ptid);
|
|
|
|
if (fp->savedregs)
|
|
get_current_regcache ()->restore (fp->savedregs);
|
|
|
|
registers_changed ();
|
|
reinit_frame_cache ();
|
|
|
|
inferior_thread ()->suspend.stop_pc
|
|
= regcache_read_pc (get_current_regcache ());
|
|
nullify_last_target_wait_ptid ();
|
|
|
|
/* Now restore the file positions of open file descriptors. */
|
|
if (fp->filepos)
|
|
{
|
|
for (i = 0; i <= fp->maxfd; i++)
|
|
if (fp->filepos[i] != (off_t) -1)
|
|
call_lseek (i, fp->filepos[i], SEEK_SET);
|
|
/* NOTE: I can get away with using SEEK_SET and SEEK_CUR because
|
|
this is native-only. If it ever has to be cross, we'll have
|
|
to rethink this. */
|
|
}
|
|
}
|
|
|
|
/* Save infrun state for the fork FP. */
|
|
|
|
static void
|
|
fork_save_infrun_state (struct fork_info *fp)
|
|
{
|
|
char path[PATH_MAX];
|
|
struct dirent *de;
|
|
DIR *d;
|
|
|
|
if (fp->savedregs)
|
|
delete fp->savedregs;
|
|
|
|
fp->savedregs = new readonly_detached_regcache (*get_current_regcache ());
|
|
fp->pc = regcache_read_pc (get_current_regcache ());
|
|
|
|
/* Now save the 'state' (file position) of all open file descriptors.
|
|
Unfortunately fork does not take care of that for us... */
|
|
snprintf (path, PATH_MAX, "/proc/%ld/fd", (long) fp->ptid.pid ());
|
|
if ((d = opendir (path)) != NULL)
|
|
{
|
|
long tmp;
|
|
|
|
fp->maxfd = 0;
|
|
while ((de = readdir (d)) != NULL)
|
|
{
|
|
/* Count open file descriptors (actually find highest
|
|
numbered). */
|
|
tmp = strtol (&de->d_name[0], NULL, 10);
|
|
if (fp->maxfd < tmp)
|
|
fp->maxfd = tmp;
|
|
}
|
|
/* Allocate array of file positions. */
|
|
fp->filepos = XRESIZEVEC (off_t, fp->filepos, fp->maxfd + 1);
|
|
|
|
/* Initialize to -1 (invalid). */
|
|
for (tmp = 0; tmp <= fp->maxfd; tmp++)
|
|
fp->filepos[tmp] = -1;
|
|
|
|
/* Now find actual file positions. */
|
|
rewinddir (d);
|
|
while ((de = readdir (d)) != NULL)
|
|
if (isdigit (de->d_name[0]))
|
|
{
|
|
tmp = strtol (&de->d_name[0], NULL, 10);
|
|
fp->filepos[tmp] = call_lseek (tmp, 0, SEEK_CUR);
|
|
}
|
|
closedir (d);
|
|
}
|
|
}
|
|
|
|
/* Kill 'em all, let God sort 'em out... */
|
|
|
|
void
|
|
linux_fork_killall (void)
|
|
{
|
|
/* Walk list and kill every pid. No need to treat the
|
|
current inferior_ptid as special (we do not return a
|
|
status for it) -- however any process may be a child
|
|
or a parent, so may get a SIGCHLD from a previously
|
|
killed child. Wait them all out. */
|
|
|
|
for (fork_info &fi : fork_list)
|
|
{
|
|
pid_t pid = fi.ptid.pid ();
|
|
int status;
|
|
pid_t ret;
|
|
do {
|
|
/* Use SIGKILL instead of PTRACE_KILL because the former works even
|
|
if the thread is running, while the later doesn't. */
|
|
kill (pid, SIGKILL);
|
|
ret = waitpid (pid, &status, 0);
|
|
/* We might get a SIGCHLD instead of an exit status. This is
|
|
aggravated by the first kill above - a child has just
|
|
died. MVS comment cut-and-pasted from linux-nat. */
|
|
} while (ret == pid && WIFSTOPPED (status));
|
|
}
|
|
|
|
/* Clear list, prepare to start fresh. */
|
|
fork_list.clear ();
|
|
}
|
|
|
|
/* The current inferior_ptid has exited, but there are other viable
|
|
forks to debug. Delete the exiting one and context-switch to the
|
|
first available. */
|
|
|
|
void
|
|
linux_fork_mourn_inferior (void)
|
|
{
|
|
struct fork_info *last;
|
|
int status;
|
|
|
|
/* Wait just one more time to collect the inferior's exit status.
|
|
Do not check whether this succeeds though, since we may be
|
|
dealing with a process that we attached to. Such a process will
|
|
only report its exit status to its original parent. */
|
|
waitpid (inferior_ptid.pid (), &status, 0);
|
|
|
|
/* OK, presumably inferior_ptid is the one who has exited.
|
|
We need to delete that one from the fork_list, and switch
|
|
to the next available fork. */
|
|
delete_fork (inferior_ptid);
|
|
|
|
/* There should still be a fork - if there's only one left,
|
|
delete_fork won't remove it, because we haven't updated
|
|
inferior_ptid yet. */
|
|
gdb_assert (!fork_list.empty ());
|
|
|
|
last = find_last_fork ();
|
|
fork_load_infrun_state (last);
|
|
printf_filtered (_("[Switching to %s]\n"),
|
|
target_pid_to_str (inferior_ptid).c_str ());
|
|
|
|
/* If there's only one fork, switch back to non-fork mode. */
|
|
if (one_fork_p ())
|
|
delete_fork (inferior_ptid);
|
|
}
|
|
|
|
/* The current inferior_ptid is being detached, but there are other
|
|
viable forks to debug. Detach and delete it and context-switch to
|
|
the first available. */
|
|
|
|
void
|
|
linux_fork_detach (int from_tty)
|
|
{
|
|
/* OK, inferior_ptid is the one we are detaching from. We need to
|
|
delete it from the fork_list, and switch to the next available
|
|
fork. */
|
|
|
|
if (ptrace (PTRACE_DETACH, inferior_ptid.pid (), 0, 0))
|
|
error (_("Unable to detach %s"),
|
|
target_pid_to_str (inferior_ptid).c_str ());
|
|
|
|
delete_fork (inferior_ptid);
|
|
|
|
/* There should still be a fork - if there's only one left,
|
|
delete_fork won't remove it, because we haven't updated
|
|
inferior_ptid yet. */
|
|
gdb_assert (!fork_list.empty ());
|
|
|
|
fork_load_infrun_state (&fork_list.front ());
|
|
|
|
if (from_tty)
|
|
printf_filtered (_("[Switching to %s]\n"),
|
|
target_pid_to_str (inferior_ptid).c_str ());
|
|
|
|
/* If there's only one fork, switch back to non-fork mode. */
|
|
if (one_fork_p ())
|
|
delete_fork (inferior_ptid);
|
|
}
|
|
|
|
/* Temporarily switch to the infrun state stored on the fork_info
|
|
identified by a given ptid_t. When this object goes out of scope,
|
|
restore the currently selected infrun state. */
|
|
|
|
class scoped_switch_fork_info
|
|
{
|
|
public:
|
|
/* Switch to the infrun state held on the fork_info identified by
|
|
PPTID. If PPTID is the current inferior then no switch is done. */
|
|
explicit scoped_switch_fork_info (ptid_t pptid)
|
|
: m_oldfp (nullptr)
|
|
{
|
|
if (pptid != inferior_ptid)
|
|
{
|
|
struct fork_info *newfp = nullptr;
|
|
|
|
/* Switch to pptid. */
|
|
m_oldfp = find_fork_ptid (inferior_ptid);
|
|
gdb_assert (m_oldfp != nullptr);
|
|
newfp = find_fork_ptid (pptid);
|
|
gdb_assert (newfp != nullptr);
|
|
fork_save_infrun_state (m_oldfp);
|
|
remove_breakpoints ();
|
|
fork_load_infrun_state (newfp);
|
|
insert_breakpoints ();
|
|
}
|
|
}
|
|
|
|
/* Restore the previously selected infrun state. If the constructor
|
|
didn't need to switch states, then nothing is done here either. */
|
|
~scoped_switch_fork_info ()
|
|
{
|
|
if (m_oldfp != nullptr)
|
|
{
|
|
/* Switch back to inferior_ptid. */
|
|
try
|
|
{
|
|
remove_breakpoints ();
|
|
fork_load_infrun_state (m_oldfp);
|
|
insert_breakpoints ();
|
|
}
|
|
catch (const gdb_exception &ex)
|
|
{
|
|
warning (_("Couldn't restore checkpoint state in %s: %s"),
|
|
target_pid_to_str (m_oldfp->ptid).c_str (),
|
|
ex.what ());
|
|
}
|
|
}
|
|
}
|
|
|
|
DISABLE_COPY_AND_ASSIGN (scoped_switch_fork_info);
|
|
|
|
private:
|
|
/* The fork_info for the previously selected infrun state, or nullptr if
|
|
we were already in the desired state, and nothing needs to be
|
|
restored. */
|
|
struct fork_info *m_oldfp;
|
|
};
|
|
|
|
static int
|
|
inferior_call_waitpid (ptid_t pptid, int pid)
|
|
{
|
|
struct objfile *waitpid_objf;
|
|
struct value *waitpid_fn = NULL;
|
|
int ret = -1;
|
|
|
|
scoped_switch_fork_info switch_fork_info (pptid);
|
|
|
|
/* Get the waitpid_fn. */
|
|
if (lookup_minimal_symbol ("waitpid", NULL, NULL).minsym != NULL)
|
|
waitpid_fn = find_function_in_inferior ("waitpid", &waitpid_objf);
|
|
if (!waitpid_fn
|
|
&& lookup_minimal_symbol ("_waitpid", NULL, NULL).minsym != NULL)
|
|
waitpid_fn = find_function_in_inferior ("_waitpid", &waitpid_objf);
|
|
if (waitpid_fn != nullptr)
|
|
{
|
|
struct gdbarch *gdbarch = get_current_arch ();
|
|
struct value *argv[3], *retv;
|
|
|
|
/* Get the argv. */
|
|
argv[0] = value_from_longest (builtin_type (gdbarch)->builtin_int, pid);
|
|
argv[1] = value_from_pointer (builtin_type (gdbarch)->builtin_data_ptr, 0);
|
|
argv[2] = value_from_longest (builtin_type (gdbarch)->builtin_int, 0);
|
|
|
|
retv = call_function_by_hand (waitpid_fn, NULL, argv);
|
|
|
|
if (value_as_long (retv) >= 0)
|
|
ret = 0;
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
/* Fork list <-> user interface. */
|
|
|
|
static void
|
|
delete_checkpoint_command (const char *args, int from_tty)
|
|
{
|
|
ptid_t ptid, pptid;
|
|
struct fork_info *fi;
|
|
|
|
if (!args || !*args)
|
|
error (_("Requires argument (checkpoint id to delete)"));
|
|
|
|
ptid = fork_id_to_ptid (parse_and_eval_long (args));
|
|
if (ptid == minus_one_ptid)
|
|
error (_("No such checkpoint id, %s"), args);
|
|
|
|
if (ptid == inferior_ptid)
|
|
error (_("\
|
|
Please switch to another checkpoint before deleting the current one"));
|
|
|
|
if (ptrace (PTRACE_KILL, ptid.pid (), 0, 0))
|
|
error (_("Unable to kill pid %s"), target_pid_to_str (ptid).c_str ());
|
|
|
|
fi = find_fork_ptid (ptid);
|
|
gdb_assert (fi);
|
|
pptid = fi->parent_ptid;
|
|
|
|
if (from_tty)
|
|
printf_filtered (_("Killed %s\n"), target_pid_to_str (ptid).c_str ());
|
|
|
|
delete_fork (ptid);
|
|
|
|
/* If fi->parent_ptid is not a part of lwp but it's a part of checkpoint
|
|
list, waitpid the ptid.
|
|
If fi->parent_ptid is a part of lwp and it is stopped, waitpid the
|
|
ptid. */
|
|
thread_info *parent = find_thread_ptid (linux_target, pptid);
|
|
if ((parent == NULL && find_fork_ptid (pptid))
|
|
|| (parent != NULL && parent->state == THREAD_STOPPED))
|
|
{
|
|
if (inferior_call_waitpid (pptid, ptid.pid ()))
|
|
warning (_("Unable to wait pid %s"),
|
|
target_pid_to_str (ptid).c_str ());
|
|
}
|
|
}
|
|
|
|
static void
|
|
detach_checkpoint_command (const char *args, int from_tty)
|
|
{
|
|
ptid_t ptid;
|
|
|
|
if (!args || !*args)
|
|
error (_("Requires argument (checkpoint id to detach)"));
|
|
|
|
ptid = fork_id_to_ptid (parse_and_eval_long (args));
|
|
if (ptid == minus_one_ptid)
|
|
error (_("No such checkpoint id, %s"), args);
|
|
|
|
if (ptid == inferior_ptid)
|
|
error (_("\
|
|
Please switch to another checkpoint before detaching the current one"));
|
|
|
|
if (ptrace (PTRACE_DETACH, ptid.pid (), 0, 0))
|
|
error (_("Unable to detach %s"), target_pid_to_str (ptid).c_str ());
|
|
|
|
if (from_tty)
|
|
printf_filtered (_("Detached %s\n"), target_pid_to_str (ptid).c_str ());
|
|
|
|
delete_fork (ptid);
|
|
}
|
|
|
|
/* Print information about currently known checkpoints. */
|
|
|
|
static void
|
|
info_checkpoints_command (const char *arg, int from_tty)
|
|
{
|
|
struct gdbarch *gdbarch = get_current_arch ();
|
|
int requested = -1;
|
|
const fork_info *printed = NULL;
|
|
|
|
if (arg && *arg)
|
|
requested = (int) parse_and_eval_long (arg);
|
|
|
|
for (const fork_info &fi : fork_list)
|
|
{
|
|
if (requested > 0 && fi.num != requested)
|
|
continue;
|
|
|
|
printed = &fi;
|
|
if (fi.ptid == inferior_ptid)
|
|
printf_filtered ("* ");
|
|
else
|
|
printf_filtered (" ");
|
|
|
|
ULONGEST pc = fi.pc;
|
|
printf_filtered ("%d %s", fi.num, target_pid_to_str (fi.ptid).c_str ());
|
|
if (fi.num == 0)
|
|
printf_filtered (_(" (main process)"));
|
|
printf_filtered (_(" at "));
|
|
fputs_filtered (paddress (gdbarch, pc), gdb_stdout);
|
|
|
|
symtab_and_line sal = find_pc_line (pc, 0);
|
|
if (sal.symtab)
|
|
printf_filtered (_(", file %s"),
|
|
symtab_to_filename_for_display (sal.symtab));
|
|
if (sal.line)
|
|
printf_filtered (_(", line %d"), sal.line);
|
|
if (!sal.symtab && !sal.line)
|
|
{
|
|
struct bound_minimal_symbol msym;
|
|
|
|
msym = lookup_minimal_symbol_by_pc (pc);
|
|
if (msym.minsym)
|
|
printf_filtered (", <%s>", msym.minsym->linkage_name ());
|
|
}
|
|
|
|
putchar_filtered ('\n');
|
|
}
|
|
if (printed == NULL)
|
|
{
|
|
if (requested > 0)
|
|
printf_filtered (_("No checkpoint number %d.\n"), requested);
|
|
else
|
|
printf_filtered (_("No checkpoints.\n"));
|
|
}
|
|
}
|
|
|
|
/* The PID of the process we're checkpointing. */
|
|
static int checkpointing_pid = 0;
|
|
|
|
int
|
|
linux_fork_checkpointing_p (int pid)
|
|
{
|
|
return (checkpointing_pid == pid);
|
|
}
|
|
|
|
/* Return true if the current inferior is multi-threaded. */
|
|
|
|
static bool
|
|
inf_has_multiple_threads ()
|
|
{
|
|
int count = 0;
|
|
|
|
/* Return true as soon as we see the second thread of the current
|
|
inferior. */
|
|
for (thread_info *tp ATTRIBUTE_UNUSED : current_inferior ()->threads ())
|
|
if (++count > 1)
|
|
return true;
|
|
|
|
return false;
|
|
}
|
|
|
|
static void
|
|
checkpoint_command (const char *args, int from_tty)
|
|
{
|
|
struct objfile *fork_objf;
|
|
struct gdbarch *gdbarch;
|
|
struct target_waitstatus last_target_waitstatus;
|
|
ptid_t last_target_ptid;
|
|
struct value *fork_fn = NULL, *ret;
|
|
struct fork_info *fp;
|
|
pid_t retpid;
|
|
|
|
if (!target_has_execution ())
|
|
error (_("The program is not being run."));
|
|
|
|
/* Ensure that the inferior is not multithreaded. */
|
|
update_thread_list ();
|
|
if (inf_has_multiple_threads ())
|
|
error (_("checkpoint: can't checkpoint multiple threads."));
|
|
|
|
/* Make the inferior fork, record its (and gdb's) state. */
|
|
|
|
if (lookup_minimal_symbol ("fork", NULL, NULL).minsym != NULL)
|
|
fork_fn = find_function_in_inferior ("fork", &fork_objf);
|
|
if (!fork_fn)
|
|
if (lookup_minimal_symbol ("_fork", NULL, NULL).minsym != NULL)
|
|
fork_fn = find_function_in_inferior ("fork", &fork_objf);
|
|
if (!fork_fn)
|
|
error (_("checkpoint: can't find fork function in inferior."));
|
|
|
|
gdbarch = fork_objf->arch ();
|
|
ret = value_from_longest (builtin_type (gdbarch)->builtin_int, 0);
|
|
|
|
/* Tell linux-nat.c that we're checkpointing this inferior. */
|
|
{
|
|
scoped_restore save_pid
|
|
= make_scoped_restore (&checkpointing_pid, inferior_ptid.pid ());
|
|
|
|
ret = call_function_by_hand (fork_fn, NULL, {});
|
|
}
|
|
|
|
if (!ret) /* Probably can't happen. */
|
|
error (_("checkpoint: call_function_by_hand returned null."));
|
|
|
|
retpid = value_as_long (ret);
|
|
get_last_target_status (nullptr, &last_target_ptid, &last_target_waitstatus);
|
|
|
|
fp = find_fork_pid (retpid);
|
|
|
|
if (from_tty)
|
|
{
|
|
int parent_pid;
|
|
|
|
printf_filtered (_("checkpoint %d: fork returned pid %ld.\n"),
|
|
fp != NULL ? fp->num : -1, (long) retpid);
|
|
if (info_verbose)
|
|
{
|
|
parent_pid = last_target_ptid.lwp ();
|
|
if (parent_pid == 0)
|
|
parent_pid = last_target_ptid.pid ();
|
|
printf_filtered (_(" gdb says parent = %ld.\n"),
|
|
(long) parent_pid);
|
|
}
|
|
}
|
|
|
|
if (!fp)
|
|
error (_("Failed to find new fork"));
|
|
|
|
if (one_fork_p ())
|
|
{
|
|
/* Special case -- if this is the first fork in the list (the
|
|
list was hitherto empty), then add inferior_ptid first, as a
|
|
special zeroeth fork id. */
|
|
fork_list.emplace_front (inferior_ptid.pid ());
|
|
}
|
|
|
|
fork_save_infrun_state (fp);
|
|
fp->parent_ptid = last_target_ptid;
|
|
}
|
|
|
|
static void
|
|
linux_fork_context (struct fork_info *newfp, int from_tty)
|
|
{
|
|
/* Now we attempt to switch processes. */
|
|
struct fork_info *oldfp;
|
|
|
|
gdb_assert (newfp != NULL);
|
|
|
|
oldfp = find_fork_ptid (inferior_ptid);
|
|
gdb_assert (oldfp != NULL);
|
|
|
|
fork_save_infrun_state (oldfp);
|
|
remove_breakpoints ();
|
|
fork_load_infrun_state (newfp);
|
|
insert_breakpoints ();
|
|
|
|
printf_filtered (_("Switching to %s\n"),
|
|
target_pid_to_str (inferior_ptid).c_str ());
|
|
|
|
print_stack_frame (get_selected_frame (NULL), 1, SRC_AND_LOC, 1);
|
|
}
|
|
|
|
/* Switch inferior process (checkpoint) context, by checkpoint id. */
|
|
static void
|
|
restart_command (const char *args, int from_tty)
|
|
{
|
|
struct fork_info *fp;
|
|
|
|
if (!args || !*args)
|
|
error (_("Requires argument (checkpoint id to restart)"));
|
|
|
|
if ((fp = find_fork_id (parse_and_eval_long (args))) == NULL)
|
|
error (_("Not found: checkpoint id %s"), args);
|
|
|
|
linux_fork_context (fp, from_tty);
|
|
}
|
|
|
|
void _initialize_linux_fork ();
|
|
void
|
|
_initialize_linux_fork ()
|
|
{
|
|
/* Checkpoint command: create a fork of the inferior process
|
|
and set it aside for later debugging. */
|
|
|
|
add_com ("checkpoint", class_obscure, checkpoint_command, _("\
|
|
Fork a duplicate process (experimental)."));
|
|
|
|
/* Restart command: restore the context of a specified checkpoint
|
|
process. */
|
|
|
|
add_com ("restart", class_obscure, restart_command, _("\
|
|
Restore program context from a checkpoint.\n\
|
|
Usage: restart N\n\
|
|
Argument N is checkpoint ID, as displayed by 'info checkpoints'."));
|
|
|
|
/* Delete checkpoint command: kill the process and remove it from
|
|
the fork list. */
|
|
|
|
add_cmd ("checkpoint", class_obscure, delete_checkpoint_command, _("\
|
|
Delete a checkpoint (experimental)."),
|
|
&deletelist);
|
|
|
|
/* Detach checkpoint command: release the process to run independently,
|
|
and remove it from the fork list. */
|
|
|
|
add_cmd ("checkpoint", class_obscure, detach_checkpoint_command, _("\
|
|
Detach from a checkpoint (experimental)."),
|
|
&detachlist);
|
|
|
|
/* Info checkpoints command: list all forks/checkpoints
|
|
currently under gdb's control. */
|
|
|
|
add_info ("checkpoints", info_checkpoints_command,
|
|
_("IDs of currently known checkpoints."));
|
|
}
|