mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-24 12:35:55 +08:00
51a948fdf0
Update allocate_target_description to return a target_desc_up, a specialisation of unique_ptr. This commit does not attempt to make use of the unique_ptr in the best possible way, in almost all cases we immediately release the pointer from within the unique_ptr and then continue as before. There are a few places where it was easy to handle the unique_ptr, and in these cases I've done that. Everything under gdb/features/* is auto-regenerated. There should be no user visible changes after this commit. gdb/ChangeLog: * arch/aarch32.c (aarch32_create_target_description): Release unique_ptr returned from allocate_target_description. * arch/aarch64.c (aarch64_create_target_description): Likewise. * arch/amd64.c (amd64_create_target_description): Likewise. * arch/arc.c (arc_create_target_description): Likewise. * arch/arm.c (arm_create_target_description): Likewise. * arch/i386.c (i386_create_target_description): Likewise. * arch/riscv.c (riscv_create_target_description): Update return type. Handle allocate_target_description returning a unique_ptr. (riscv_lookup_target_description): Update to handle unique_ptr. * arch/tic6x.c (tic6x_create_target_description): Release unique_ptr returned from allocate_target_description. * features/microblaze-with-stack-protect.c: Regenerate. * features/microblaze.c: Regenerate. * features/mips-dsp-linux.c: Regenerate. * features/mips-linux.c: Regenerate. * features/mips64-dsp-linux.c: Regenerate. * features/mips64-linux.c: Regenerate. * features/nds32.c: Regenerate. * features/nios2.c: Regenerate. * features/or1k.c: Regenerate. * features/rs6000/powerpc-32.c: Regenerate. * features/rs6000/powerpc-32l.c: Regenerate. * features/rs6000/powerpc-403.c: Regenerate. * features/rs6000/powerpc-403gc.c: Regenerate. * features/rs6000/powerpc-405.c: Regenerate. * features/rs6000/powerpc-505.c: Regenerate. * features/rs6000/powerpc-601.c: Regenerate. * features/rs6000/powerpc-602.c: Regenerate. * features/rs6000/powerpc-603.c: Regenerate. * features/rs6000/powerpc-604.c: Regenerate. * features/rs6000/powerpc-64.c: Regenerate. * features/rs6000/powerpc-64l.c: Regenerate. * features/rs6000/powerpc-7400.c: Regenerate. * features/rs6000/powerpc-750.c: Regenerate. * features/rs6000/powerpc-860.c: Regenerate. * features/rs6000/powerpc-altivec32.c: Regenerate. * features/rs6000/powerpc-altivec32l.c: Regenerate. * features/rs6000/powerpc-altivec64.c: Regenerate. * features/rs6000/powerpc-altivec64l.c: Regenerate. * features/rs6000/powerpc-e500.c: Regenerate. * features/rs6000/powerpc-e500l.c: Regenerate. * features/rs6000/powerpc-isa205-32l.c: Regenerate. * features/rs6000/powerpc-isa205-64l.c: Regenerate. * features/rs6000/powerpc-isa205-altivec32l.c: Regenerate. * features/rs6000/powerpc-isa205-altivec64l.c: Regenerate. * features/rs6000/powerpc-isa205-ppr-dscr-vsx32l.c: Regenerate. * features/rs6000/powerpc-isa205-ppr-dscr-vsx64l.c: Regenerate. * features/rs6000/powerpc-isa205-vsx32l.c: Regenerate. * features/rs6000/powerpc-isa205-vsx64l.c: Regenerate. * features/rs6000/powerpc-isa207-htm-vsx32l.c: Regenerate. * features/rs6000/powerpc-isa207-htm-vsx64l.c: Regenerate. * features/rs6000/powerpc-isa207-vsx32l.c: Regenerate. * features/rs6000/powerpc-isa207-vsx64l.c: Regenerate. * features/rs6000/powerpc-vsx32.c: Regenerate. * features/rs6000/powerpc-vsx32l.c: Regenerate. * features/rs6000/powerpc-vsx64.c: Regenerate. * features/rs6000/powerpc-vsx64l.c: Regenerate. * features/rs6000/rs6000.c: Regenerate. * features/rx.c: Regenerate. * features/s390-gs-linux64.c: Regenerate. * features/s390-linux32.c: Regenerate. * features/s390-linux32v1.c: Regenerate. * features/s390-linux32v2.c: Regenerate. * features/s390-linux64.c: Regenerate. * features/s390-linux64v1.c: Regenerate. * features/s390-linux64v2.c: Regenerate. * features/s390-te-linux64.c: Regenerate. * features/s390-tevx-linux64.c: Regenerate. * features/s390-vx-linux64.c: Regenerate. * features/s390x-gs-linux64.c: Regenerate. * features/s390x-linux64.c: Regenerate. * features/s390x-linux64v1.c: Regenerate. * features/s390x-linux64v2.c: Regenerate. * features/s390x-te-linux64.c: Regenerate. * features/s390x-tevx-linux64.c: Regenerate. * features/s390x-vx-linux64.c: Regenerate. * mips-tdep.c (_initialize_mips_tdep): Release unique_ptr returned from allocate_target_description. * target-descriptions.c (allocate_target_description): Update return type. (print_c_tdesc::visit_pre): Release unique_ptr returned from allocate_target_description. gdbserver/ChangeLog: * linux-low.cc (linux_process_target::handle_extended_wait): Release the unique_ptr returned from allocate_target_description. * linux-riscv-low.cc (riscv_target::low_arch_setup): Likewise. * linux-x86-low.cc (tdesc_amd64_linux_no_xml): Change type. (tdesc_i386_linux_no_xml): Change type. (x86_linux_read_description): Borrow pointer from unique_ptr object. (x86_target::get_ipa_tdesc_idx): Likewise. (initialize_low_arch): Likewise. * tdesc.cc (allocate_target_description): Update return type. gdbsupport/ChangeLog: * tdesc.h (allocate_target_description): Update return type.
120 lines
3.6 KiB
C
120 lines
3.6 KiB
C
/* Copyright (C) 2018-2020 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "gdbsupport/common-defs.h"
|
|
#include "riscv.h"
|
|
#include <stdlib.h>
|
|
#include <unordered_map>
|
|
|
|
#include "../features/riscv/32bit-cpu.c"
|
|
#include "../features/riscv/64bit-cpu.c"
|
|
#include "../features/riscv/32bit-fpu.c"
|
|
#include "../features/riscv/64bit-fpu.c"
|
|
|
|
#ifndef GDBSERVER
|
|
#define STATIC_IN_GDB static
|
|
#else
|
|
#define STATIC_IN_GDB
|
|
#endif
|
|
|
|
/* See arch/riscv.h. */
|
|
|
|
STATIC_IN_GDB target_desc_up
|
|
riscv_create_target_description (const struct riscv_gdbarch_features features)
|
|
{
|
|
/* Now we should create a new target description. */
|
|
target_desc_up tdesc = allocate_target_description ();
|
|
|
|
#ifndef IN_PROCESS_AGENT
|
|
std::string arch_name = "riscv";
|
|
|
|
if (features.xlen == 4)
|
|
arch_name.append (":rv32i");
|
|
else if (features.xlen == 8)
|
|
arch_name.append (":rv64i");
|
|
else if (features.xlen == 16)
|
|
arch_name.append (":rv128i");
|
|
|
|
if (features.flen == 4)
|
|
arch_name.append ("f");
|
|
else if (features.flen == 8)
|
|
arch_name.append ("d");
|
|
else if (features.flen == 16)
|
|
arch_name.append ("q");
|
|
|
|
set_tdesc_architecture (tdesc.get (), arch_name.c_str ());
|
|
#endif
|
|
|
|
long regnum = 0;
|
|
|
|
/* For now we only support creating 32-bit or 64-bit x-registers. */
|
|
if (features.xlen == 4)
|
|
regnum = create_feature_riscv_32bit_cpu (tdesc.get (), regnum);
|
|
else if (features.xlen == 8)
|
|
regnum = create_feature_riscv_64bit_cpu (tdesc.get (), regnum);
|
|
|
|
/* For now we only support creating 32-bit or 64-bit f-registers. */
|
|
if (features.flen == 4)
|
|
regnum = create_feature_riscv_32bit_fpu (tdesc.get (), regnum);
|
|
else if (features.flen == 8)
|
|
regnum = create_feature_riscv_64bit_fpu (tdesc.get (), regnum);
|
|
|
|
return tdesc;
|
|
}
|
|
|
|
#ifndef GDBSERVER
|
|
|
|
/* Wrapper used by std::unordered_map to generate hash for feature set. */
|
|
struct riscv_gdbarch_features_hasher
|
|
{
|
|
std::size_t
|
|
operator() (const riscv_gdbarch_features &features) const noexcept
|
|
{
|
|
return features.hash ();
|
|
}
|
|
};
|
|
|
|
/* Cache of previously seen target descriptions, indexed by the feature set
|
|
that created them. */
|
|
static std::unordered_map<riscv_gdbarch_features,
|
|
const target_desc_up,
|
|
riscv_gdbarch_features_hasher> riscv_tdesc_cache;
|
|
|
|
/* See arch/riscv.h. */
|
|
|
|
const target_desc *
|
|
riscv_lookup_target_description (const struct riscv_gdbarch_features features)
|
|
{
|
|
/* Lookup in the cache. If we find it then return the pointer out of
|
|
the target_desc_up (which is a unique_ptr). This is safe as the
|
|
riscv_tdesc_cache will exist until GDB exits. */
|
|
const auto it = riscv_tdesc_cache.find (features);
|
|
if (it != riscv_tdesc_cache.end ())
|
|
return it->second.get ();
|
|
|
|
target_desc_up tdesc (riscv_create_target_description (features));
|
|
|
|
/* Add to the cache, and return a pointer borrowed from the
|
|
target_desc_up. This is safe as the cache (and the pointers
|
|
contained within it) are not deleted until GDB exits. */
|
|
target_desc *ptr = tdesc.get ();
|
|
riscv_tdesc_cache.emplace (features, std::move (tdesc));
|
|
return ptr;
|
|
}
|
|
|
|
#endif /* !GDBSERVER */
|