mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-02-05 12:53:16 +08:00
9be259865c
I was always a bit confused by next_adapter, because it kind of mixes the element type and the iterator type. In reality, it is not much more than a class that wraps two iterators (begin and end). However, it assumes that: - you can construct the begin iterator by passing a pointer to the first element of the iterable - you can default-construct iterator to make the end iterator I think that by generalizing it a little bit, we can re-use it at more places. Rename it to "iterator_range". I think it describes a bit better: it's a range made by wrapping a begin and end iterator. Move it to its own file, since it's not related to next_iterator anymore. iterator_range has two constructors. The variadic one, where arguments are forwarded to construct the underlying begin iterator. The end iterator is constructed through default construction. This is a generalization of what we have today. There is another constructor which receives already constructed begin and end iterators, useful if the end iterator can't be obtained by default-construction. Or, if you wanted to make a range that does not end at the end of the container, you could pass any iterator as the "end". This generalization allows removing some "range" classes, like all_inferiors_range. These classes existed only to pass some arguments when constructing the begin iterator. With iterator_range, those same arguments are passed to the iterator_range constructed and then forwarded to the constructed begin iterator. There is a small functional difference in how iterator_range works compared to next_adapter. next_adapter stored the pointer it received as argument and constructeur an iterator in the `begin` method. iterator_range constructs the begin iterator and stores it as a member. Its `begin` method returns a copy of that iterator. With just iterator_range, uses of next_adapter<foo> would be replaced with: using foo_iterator = next_iterator<foo>; using foo_range = iterator_range<foo_iterator>; However, I added a `next_range` wrapper as a direct replacement for next_adapter<foo>. IMO, next_range is a slightly better name than next_adapter. The rest of the changes are applications of this new class. gdbsupport/ChangeLog: * next-iterator.h (class next_adapter): Remove. * iterator-range.h: New. gdb/ChangeLog: * breakpoint.h (bp_locations_range): Remove. (bp_location_range): New. (struct breakpoint) <locations>: Adjust type. (breakpoint_range): Use iterator_range. (tracepoint_range): Use iterator_range. * breakpoint.c (breakpoint::locations): Adjust return type. * gdb_bfd.h (gdb_bfd_section_range): Use iterator_range. * gdbthread.h (all_threads_safe): Pass argument to all_threads_safe_range. * inferior-iter.h (all_inferiors_range): Use iterator_range. (all_inferiors_safe_range): Use iterator_range. (all_non_exited_inferiors_range): Use iterator_range. * inferior.h (all_inferiors, all_non_exited_inferiors): Pass inferior_list as argument. * objfiles.h (struct objfile) <compunits_range>: Remove. <compunits>: Return compunit_symtab_range. * progspace.h (unwrapping_objfile_iterator) <unwrapping_objfile_iterator>: Take parameter by value. (unwrapping_objfile_range): Use iterator_range. (struct program_space) <objfiles_range>: Define with "using". <objfiles>: Adjust. <objfiles_safe_range>: Define with "using". <objfiles_safe>: Adjust. <solibs>: Return so_list_range, define here. * progspace.c (program_space::solibs): Remove. * psymtab.h (class psymtab_storage) <partial_symtab_iterator>: New. <partial_symtab_range>: Use iterator_range. * solist.h (so_list_range): New. * symtab.h (compunit_symtab_range): New. (symtab_range): New. (compunit_filetabs): Change to a function. * thread-iter.h (inf_threads_range, inf_non_exited_threads_range, safe_inf_threads_range, all_threads_safe_range): Use iterator_range. * top.h (ui_range): New. (all_uis): Use ui_range. Change-Id: Ib7a9d2a3547f45f01aa1c6b24536ba159db9b854 |
||
|---|---|---|
| .. | ||
| .dir-locals.el | ||
| .gitattributes | ||
| acinclude.m4 | ||
| aclocal.m4 | ||
| agent.cc | ||
| agent.h | ||
| alt-stack.h | ||
| array-view.h | ||
| ax.def | ||
| block-signals.h | ||
| break-common.h | ||
| btrace-common.cc | ||
| btrace-common.h | ||
| buffer.cc | ||
| buffer.h | ||
| byte-vector.h | ||
| ChangeLog | ||
| check-defines.el | ||
| cleanups.cc | ||
| cleanups.h | ||
| common-debug.cc | ||
| common-debug.h | ||
| common-defs.h | ||
| common-exceptions.cc | ||
| common-exceptions.h | ||
| common-gdbthread.h | ||
| common-inferior.cc | ||
| common-inferior.h | ||
| common-regcache.cc | ||
| common-regcache.h | ||
| common-types.h | ||
| common-utils.cc | ||
| common-utils.h | ||
| common.m4 | ||
| config.in | ||
| configure | ||
| configure.ac | ||
| create-version.sh | ||
| def-vector.h | ||
| default-init-alloc.h | ||
| eintr.h | ||
| enum-flags.h | ||
| environ.cc | ||
| environ.h | ||
| errors.cc | ||
| errors.h | ||
| event-loop.cc | ||
| event-loop.h | ||
| fileio.cc | ||
| fileio.h | ||
| filestuff.cc | ||
| filestuff.h | ||
| filtered-iterator.h | ||
| format.cc | ||
| format.h | ||
| forward-scope-exit.h | ||
| function-view.h | ||
| gdb_assert.h | ||
| gdb_binary_search.h | ||
| gdb_locale.h | ||
| gdb_optional.h | ||
| gdb_proc_service.h | ||
| gdb_ref_ptr.h | ||
| gdb_select.h | ||
| gdb_setjmp.h | ||
| gdb_signals.h | ||
| gdb_splay_tree.h | ||
| gdb_string_view.h | ||
| gdb_string_view.tcc | ||
| gdb_sys_time.h | ||
| gdb_tilde_expand.cc | ||
| gdb_tilde_expand.h | ||
| gdb_unique_ptr.h | ||
| gdb_unlinker.h | ||
| gdb_vecs.cc | ||
| gdb_vecs.h | ||
| gdb_wait.cc | ||
| gdb_wait.h | ||
| gdb-dlfcn.cc | ||
| gdb-dlfcn.h | ||
| gdb-safe-ctype.h | ||
| gdb-sigmask.h | ||
| hash_enum.h | ||
| host-defs.h | ||
| iterator-range.h | ||
| job-control.cc | ||
| job-control.h | ||
| Makefile.am | ||
| Makefile.in | ||
| netstuff.cc | ||
| netstuff.h | ||
| new-op.cc | ||
| next-iterator.h | ||
| observable.h | ||
| offset-type.h | ||
| parallel-for.h | ||
| pathstuff.cc | ||
| pathstuff.h | ||
| poison.h | ||
| preprocessor.h | ||
| print-utils.cc | ||
| print-utils.h | ||
| ptid.cc | ||
| ptid.h | ||
| ptrace.m4 | ||
| README | ||
| refcounted-object.h | ||
| rsp-low.cc | ||
| rsp-low.h | ||
| run-time-clock.cc | ||
| run-time-clock.h | ||
| safe-iterator.h | ||
| safe-strerror.cc | ||
| scope-exit.h | ||
| scoped_fd.h | ||
| scoped_ignore_signal.h | ||
| scoped_ignore_sigttou.h | ||
| scoped_mmap.cc | ||
| scoped_mmap.h | ||
| scoped_restore.h | ||
| search.cc | ||
| search.h | ||
| selftest.cc | ||
| selftest.h | ||
| selftest.m4 | ||
| signals-state-save-restore.cc | ||
| signals-state-save-restore.h | ||
| signals.cc | ||
| symbol.h | ||
| tdesc.cc | ||
| tdesc.h | ||
| thread-pool.cc | ||
| thread-pool.h | ||
| traits.h | ||
| underlying.h | ||
| valid-expr.h | ||
| version.h | ||
| warning.m4 | ||
| x86-xstate.h | ||
| xml-utils.cc | ||
| xml-utils.h | ||
This is a helper library that is used by gdb and gdbserver. To send patches, follow the gdb patch submission instructions in ../gdb/CONTRIBUTE. For maintainers, see ../gdb/MAINTAINERS.