binutils-gdb/gdbserver
Simon Marchi 183be22290 gdb, gdbserver: make target_waitstatus safe
I stumbled on a bug caused by the fact that a code path read
target_waitstatus::value::sig (expecting it to contain a gdb_signal
value) while target_waitstatus::kind was TARGET_WAITKIND_FORKED.  This
meant that the active union field was in fact
target_waitstatus::value::related_pid, and contained a ptid.  The read
signal value was therefore garbage, and that caused GDB to crash soon
after.  Or, since that GDB was built with ubsan, this nice error
message:

    /home/simark/src/binutils-gdb/gdb/linux-nat.c:1271:12: runtime error: load of value 2686365, which is not a valid value for type 'gdb_signal'

Despite being a large-ish change, I think it would be nice to make
target_waitstatus safe against that kind of bug.  As already done
elsewhere (e.g. dynamic_prop), validate that the type of value read from
the union matches what is supposed to be the active field.

 - Make the kind and value of target_waitstatus private.
 - Make the kind initialized to TARGET_WAITKIND_IGNORE on
   target_waitstatus construction.  This is what most users appear to do
   explicitly.
 - Add setters, one for each kind.  Each setter takes as a parameter the
   data associated to that kind, if any.  This makes it impossible to
   forget to attach the associated data.
 - Add getters, one for each associated data type.  Each getter
   validates that the data type fetched by the user matches the wait
   status kind.
 - Change "integer" to "exit_status", "related_pid" to "child_ptid",
   just because that's more precise terminology.
 - Fix all users.

That last point is semi-mechanical.  There are a lot of obvious changes,
but some less obvious ones.  For example, it's not possible to set the
kind at some point and the associated data later, as some users did.
But in any case, the intent of the code should not change in this patch.

This was tested on x86-64 Linux (unix, native-gdbserver and
native-extended-gdbserver boards).  It was built-tested on x86-64
FreeBSD, NetBSD, MinGW and macOS.  The rest of the changes to native
files was done as a best effort.  If I forgot any place to update in
these files, it should be easy to fix (unless the change happens to
reveal an actual bug).

Change-Id: I0ae967df1ff6e28de78abbe3ac9b4b2ff4ad03b7
2021-10-21 16:13:56 -04:00
..
.dir-locals.el gdb: additional settings for emacs in .dir-locals.el 2021-05-17 20:47:46 +01:00
.gitattributes
.gitignore
acinclude.m4 gdb/gdbserver: switch to AC_CONFIG_MACRO_DIRS 2021-06-19 23:06:01 -04:00
aclocal.m4 gdb/gdbserver: switch to AC_CONFIG_MACRO_DIRS 2021-06-19 23:06:01 -04:00
ax.cc
ax.h
ChangeLog-2002-2021 gdb: move remaining ChangeLogs to legacy files 2021-07-26 12:20:33 +01:00
config.in gdbsupport/common.m4: check for sigtimedwait 2021-07-05 09:54:35 -04:00
configure [gdb/build] Add CXX_DIALECT to CXX 2021-10-04 18:51:09 +02:00
configure.ac gdb/gdbserver: switch to AC_CONFIG_MACRO_DIRS 2021-06-19 23:06:01 -04:00
configure.srv Remove process_stratum_target::hostio_last_error abstraction 2021-04-13 13:26:44 +01:00
debug.cc
debug.h
dll.cc gdbserver: convert the global dll list into a process_info field 2021-03-22 09:18:04 +01:00
dll.h gdbserver: convert the global dll list into a process_info field 2021-03-22 09:18:04 +01:00
fork-child.cc
gdb_proc_service.h
gdbreplay.cc Remove WinCE code from gdbreplay 2021-04-13 22:18:24 +01:00
gdbthread.h gdb, gdbserver: make target_waitstatus safe 2021-10-21 16:13:56 -04:00
hostio.cc Remove process_stratum_target::hostio_last_error abstraction 2021-04-13 13:26:44 +01:00
hostio.h Remove process_stratum_target::hostio_last_error abstraction 2021-04-13 13:26:44 +01:00
i387-fp.cc
i387-fp.h
inferiors.cc gdbserver: make thread_info non-POD 2021-10-21 16:10:54 -04:00
inferiors.h gdb: make inferior::m_cwd an std::string 2021-07-23 15:38:54 -04:00
linux-aarch32-low.cc
linux-aarch32-low.h
linux-aarch32-tdesc.cc
linux-aarch32-tdesc.h
linux-aarch64-ipa.cc AArch64: Add target description/feature for MTE registers 2021-03-24 14:52:08 -03:00
linux-aarch64-low.cc AArch64: Add gdbserver MTE support 2021-03-24 14:56:33 -03:00
linux-aarch64-tdesc.cc AArch64: Add target description/feature for MTE registers 2021-03-24 14:52:08 -03:00
linux-aarch64-tdesc.h AArch64: Add target description/feature for MTE registers 2021-03-24 14:52:08 -03:00
linux-amd64-ipa.cc
linux-arc-low.cc
linux-arm-low.cc
linux-arm-tdesc.cc
linux-arm-tdesc.h
linux-i386-ipa.cc
linux-ia64-low.cc
linux-low.cc gdb, gdbserver: make target_waitstatus safe 2021-10-21 16:13:56 -04:00
linux-low.h gdb, gdbserver: make target_waitstatus safe 2021-10-21 16:13:56 -04:00
linux-m68k-low.cc
linux-mips-low.cc
linux-nios2-low.cc
linux-ppc-ipa.cc
linux-ppc-low.cc
linux-ppc-tdesc-init.h
linux-riscv-low.cc
linux-s390-ipa.cc
linux-s390-low.cc gdb: fix some indentation issues 2021-05-27 15:01:28 -04:00
linux-s390-tdesc.h
linux-sh-low.cc
linux-sparc-low.cc
linux-tic6x-low.cc
linux-x86-low.cc
linux-x86-tdesc.cc
linux-x86-tdesc.h
linux-xtensa-low.cc
Makefile.in gnulib: define the path to gnulib's parent dir 2021-06-14 18:01:20 -04:00
mem-break.cc
mem-break.h
netbsd-aarch64-low.cc
netbsd-amd64-low.cc
netbsd-i386-low.cc
netbsd-low.cc gdb, gdbserver: make target_waitstatus safe 2021-10-21 16:13:56 -04:00
netbsd-low.h gdbserver: constify the 'pid_to_exec_file' target op 2021-04-12 16:36:25 +02:00
notif.cc
notif.h
proc-service.cc
proc-service.list
README
regcache.cc
regcache.h
remote-utils.cc gdb, gdbserver: make target_waitstatus safe 2021-10-21 16:13:56 -04:00
remote-utils.h GDBserver remote packet support for memory tagging 2021-03-24 14:49:21 -03:00
server.cc gdb, gdbserver: make target_waitstatus safe 2021-10-21 16:13:56 -04:00
server.h GDBserver remote packet support for memory tagging 2021-03-24 14:49:21 -03:00
symbol.cc
target.cc gdb, gdbserver: make target_waitstatus safe 2021-10-21 16:13:56 -04:00
target.h Remove process_stratum_target::hostio_last_error abstraction 2021-04-13 13:26:44 +01:00
tdesc.cc
tdesc.h
thread-db.cc Remove defaulted 'tid' parameter to ptid_t constructor 2021-09-23 09:30:54 -06:00
tracepoint.cc
tracepoint.h
utils.cc
utils.h
win32-i386-low.cc Fix x86_64 mingw build 2021-05-03 12:40:19 -06:00
win32-low.cc gdb, gdbserver: make target_waitstatus safe 2021-10-21 16:13:56 -04:00
win32-low.h Remove unused declaration from gdbserver/win32-low.h 2021-09-07 12:17:42 -06:00
x86-low.cc
x86-low.h
x86-tdesc.h
xtensa-xtregs.cc

		   README for GDBserver & GDBreplay
		    by Stu Grossman and Fred Fish

Introduction:

This is GDBserver, a remote server for Un*x-like systems.  It can be used to
control the execution of a program on a target system from a GDB on a different
host.  GDB and GDBserver communicate using the standard remote serial protocol.
They communicate via either a serial line or a TCP connection.

For more information about GDBserver, see the GDB manual:

    https://sourceware.org/gdb/current/onlinedocs/gdb/Remote-Protocol.html

Usage (server (target) side):

First, you need to have a copy of the program you want to debug put onto
the target system.  The program can be stripped to save space if needed, as
GDBserver doesn't care about symbols.  All symbol handling is taken care of by
the GDB running on the host system.

To use the server, you log on to the target system, and run the `gdbserver'
program.  You must tell it (a) how to communicate with GDB, (b) the name of
your program, and (c) its arguments.  The general syntax is:

	target> gdbserver COMM PROGRAM [ARGS ...]

For example, using a serial port, you might say:

	target> gdbserver /dev/com1 emacs foo.txt

This tells GDBserver to debug emacs with an argument of foo.txt, and to
communicate with GDB via /dev/com1.  GDBserver now waits patiently for the
host GDB to communicate with it.

To use a TCP connection, you could say:

	target> gdbserver host:2345 emacs foo.txt

This says pretty much the same thing as the last example, except that we are
going to communicate with the host GDB via TCP.  The `host:2345' argument means
that we are expecting to see a TCP connection to local TCP port 2345.
(Currently, the `host' part is ignored.)  You can choose any number you want for
the port number as long as it does not conflict with any existing TCP ports on
the target system.  This same port number must be used in the host GDB's
`target remote' command, which will be described shortly. Note that if you chose
a port number that conflicts with another service, GDBserver will print an error
message and exit.

On some targets, GDBserver can also attach to running programs.  This is
accomplished via the --attach argument.  The syntax is:

	target> gdbserver --attach COMM PID

PID is the process ID of a currently running process.  It isn't necessary
to point GDBserver at a binary for the running process.

Usage (host side):

You need an unstripped copy of the target program on your host system, since
GDB needs to examine it's symbol tables and such.  Start up GDB as you normally
would, with the target program as the first argument.  (You may need to use the
--baud option if the serial line is running at anything except 9600 baud.)
Ie: `gdb TARGET-PROG', or `gdb --baud BAUD TARGET-PROG'.  After that, the only
new command you need to know about is `target remote'.  It's argument is either
a device name (usually a serial device, like `/dev/ttyb'), or a HOST:PORT
descriptor.  For example:

	(gdb) target remote /dev/ttyb

communicates with the server via serial line /dev/ttyb, and:

	(gdb) target remote the-target:2345

communicates via a TCP connection to port 2345 on host `the-target', where
you previously started up GDBserver with the same port number.  Note that for
TCP connections, you must start up GDBserver prior to using the `target remote'
command, otherwise you may get an error that looks something like
`Connection refused'.

Building GDBserver:

See the `configure.srv` file for the list of host triplets you can build
GDBserver for.

Building GDBserver for your host is very straightforward.  If you build
GDB natively on a host which GDBserver supports, it will be built
automatically when you build GDB.  You can also build just GDBserver:

	% mkdir obj
	% cd obj
	% path-to-toplevel-sources/configure --disable-gdb
	% make all-gdbserver

(If you have a combined binutils+gdb tree, you may want to also
disable other directories when configuring, e.g., binutils, gas, gold,
gprof, and ld.)

If you prefer to cross-compile to your target, then you can also build
GDBserver that way.  For example:

	% export CC=your-cross-compiler
	% path-to-topevel-sources/configure --disable-gdb
	% make all-gdbserver

Using GDBreplay:

A special hacked down version of GDBserver can be used to replay remote
debug log files created by GDB.  Before using the GDB "target" command to
initiate a remote debug session, use "set remotelogfile <filename>" to tell
GDB that you want to make a recording of the serial or tcp session.  Note
that when replaying the session, GDB communicates with GDBreplay via tcp,
regardless of whether the original session was via a serial link or tcp.

Once you are done with the remote debug session, start GDBreplay and
tell it the name of the log file and the host and port number that GDB
should connect to (typically the same as the host running GDB):

	$ gdbreplay logfile host:port

Then start GDB (preferably in a different screen or window) and use the
"target" command to connect to GDBreplay:

	(gdb) target remote host:port

Repeat the same sequence of user commands to GDB that you gave in the
original debug session.  GDB should not be able to tell that it is talking
to GDBreplay rather than a real target, all other things being equal.  Note
that GDBreplay echos the command lines to stderr, as well as the contents of
the packets it sends and receives.  The last command echoed by GDBreplay is
the next command that needs to be typed to GDB to continue the session in
sync with the original session.