binutils-gdb/gdb/gdb_obstack.c
Patrick Palka 6c214e7cb3 Use gdbarch obstack to allocate the TYPE_NAME string in arch_type
Since the type whose name is being set is now being allocated on the
gdbarch obstack, we should allocate its TYPE_NAME on the obstack too.
This reduces the number of individual valgrind warnings for the command
"gdb gdb" from ~300 to ~150.

Tested on x86_64-unknown-linux-gnu.

gdb/ChangeLog:

	* gdb_obstack.h (obstack_strdup): Declare.
	* gdb_obstack.c (obstack_strdup): Define.
	* gdbarch.sh (gdbarch_obstack_strdup): Declare and define.
	* gdbarch.c: Regenerate.
	* gdbarch.h: Regenerate.
	* gdbtypes.c (arch_type): Use gdbarch_obstack_strdup.
2015-09-02 20:53:33 -04:00

58 lines
1.5 KiB
C

/* Obstack wrapper for GDB.
Copyright (C) 2013-2015 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "defs.h"
#include "gdb_obstack.h"
/* Concatenate NULL terminated variable argument list of `const char *'
strings; return the new string. Space is found in the OBSTACKP.
Argument list must be terminated by a sentinel expression `(char *)
NULL'. */
char *
obconcat (struct obstack *obstackp, ...)
{
va_list ap;
va_start (ap, obstackp);
for (;;)
{
const char *s = va_arg (ap, const char *);
if (s == NULL)
break;
obstack_grow_str (obstackp, s);
}
va_end (ap);
obstack_1grow (obstackp, 0);
return obstack_finish (obstackp);
}
/* See gdb_obstack.h. */
char *
obstack_strdup (struct obstack *obstackp, const char *string)
{
char *obstring = obstack_alloc (obstackp, strlen (string) + 1);
strcpy (obstring, string);
return obstring;
}