mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-15 04:31:49 +08:00
192b62ce0b
This introduces a new specialization of gdb::ref_ptr that can be used to manage BFD reference counts. Then it changes most places in gdb to use this new class, rather than explicit reference-counting or cleanups. This patch removes make_cleanup_bfd_unref. If you look you will see a couple of spots using "release" where a use of gdb_bfd_ref_ptr would be cleaner. These will be fixed in the next patch. I think this patch fixes some latent bugs. For example, it seems to me that previously objfpy_add_separate_debug_file leaked a BFD. I'm not 100% certain that the macho_symfile_read_all_oso change is correct. The existing code here is hard for me to follow. One goal of this sort of automated reference counting, though, is to make it more difficult to make logic errors; so hopefully the code is clear now. 2017-01-10 Tom Tromey <tom@tromey.com> * windows-tdep.c (windows_xfer_shared_library): Update. * windows-nat.c (windows_make_so): Update. * utils.h (make_cleanup_bfd_unref): Remove. * utils.c (do_bfd_close_cleanup, make_cleanup_bfd_unref): Remove. * symfile.h (symfile_bfd_open) (find_separate_debug_file_in_section): Return gdb_bfd_ref_ptr. * symfile.c (read_symbols, symbol_file_add) (separate_debug_file_exists): Update. (symfile_bfd_open): Return gdb_bfd_ref_ptr. (generic_load, reread_symbols): Update. * symfile-mem.c (symbol_file_add_from_memory): Update. * spu-linux-nat.c (spu_bfd_open): Return gdb_bfd_ref_ptr. (spu_symbol_file_add_from_memory): Update. * solist.h (struct target_so_ops) <bfd_open>: Return gdb_bfd_ref_ptr. (solib_bfd_fopen, solib_bfd_open): Return gdb_bfd_ref_ptr. * solib.c (solib_bfd_fopen, solib_bfd_open): Return gdb_bfd_ref_ptr. (solib_map_sections, reload_shared_libraries_1): Update. * solib-svr4.c (enable_break): Update. * solib-spu.c (spu_bfd_fopen): Return gdb_bfd_ref_ptr. * solib-frv.c (enable_break2): Update. * solib-dsbt.c (enable_break): Update. * solib-darwin.c (gdb_bfd_mach_o_fat_extract): Return gdb_bfd_ref_ptr. (darwin_solib_get_all_image_info_addr_at_init): Update. (darwin_bfd_open): Return gdb_bfd_ref_ptr. * solib-aix.c (solib_aix_bfd_open): Return gdb_bfd_ref_ptr. * record-full.c (record_full_save): Update. * python/py-objfile.c (objfpy_add_separate_debug_file): Update. * procfs.c (insert_dbx_link_bpt_in_file): Update. * minidebug.c (find_separate_debug_file_in_section): Return gdb_bfd_ref_ptr. * machoread.c (macho_add_oso_symfile): Change abfd to gdb_bfd_ref_ptr. (macho_symfile_read_all_oso): Update. (macho_check_dsym): Return gdb_bfd_ref_ptr. (macho_symfile_read): Update. * jit.c (bfd_open_from_target_memory): Return gdb_bfd_ref_ptr. (jit_bfd_try_read_symtab): Update. * gdb_bfd.h (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr) (gdb_bfd_openw, gdb_bfd_openr_iovec) (gdb_bfd_openr_next_archived_file, gdb_bfd_fdopenr): Return gdb_bfd_ref_ptr. (gdb_bfd_ref_policy): New struct. (gdb_bfd_ref_ptr): New typedef. * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr) (gdb_bfd_openw, gdb_bfd_openr_iovec) (gdb_bfd_openr_next_archived_file, gdb_bfd_fdopenr): Return gdb_bfd_ref_ptr. * gcore.h (create_gcore_bfd): Return gdb_bfd_ref_ptr. * gcore.c (create_gcore_bfd): Return gdb_bfd_ref_ptr. (gcore_command): Update. * exec.c (exec_file_attach): Update. * elfread.c (elf_symfile_read): Update. * dwarf2read.c (dwarf2_get_dwz_file): Update. (try_open_dwop_file, open_dwo_file): Return gdb_bfd_ref_ptr. (open_and_init_dwo_file): Update. (open_dwp_file): Return gdb_bfd_ref_ptr. (open_and_init_dwp_file): Update. * corelow.c (core_open): Update. * compile/compile-object-load.c (compile_object_load): Update. * common/gdb_ref_ptr.h (ref_ptr::operator->): New operator. * coffread.c (coff_symfile_read): Update. * cli/cli-dump.c (bfd_openr_or_error, bfd_openw_or_error): Return gdb_bfd_ref_ptr. Rename. (dump_bfd_file, restore_command): Update. * build-id.h (build_id_to_debug_bfd): Return gdb_bfd_ref_ptr. * build-id.c (build_id_to_debug_bfd): Return gdb_bfd_ref_ptr. (find_separate_debug_file_by_buildid): Update.
259 lines
8.3 KiB
C
259 lines
8.3 KiB
C
/* Reading symbol files from memory.
|
||
|
||
Copyright (C) 1986-2017 Free Software Foundation, Inc.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
/* This file defines functions (and commands to exercise those
|
||
functions) for reading debugging information from object files
|
||
whose images are mapped directly into the inferior's memory. For
|
||
example, the Linux kernel maps a "syscall DSO" into each process's
|
||
address space; this DSO provides kernel-specific code for some
|
||
system calls.
|
||
|
||
At the moment, BFD only has functions for parsing object files from
|
||
memory for the ELF format, even though the general idea isn't
|
||
ELF-specific. This means that BFD only provides the functions GDB
|
||
needs when configured for ELF-based targets. So these functions
|
||
may only be compiled on ELF-based targets.
|
||
|
||
GDB has no idea whether it has been configured for an ELF-based
|
||
target or not: it just tries to handle whatever files it is given.
|
||
But this means there are no preprocessor symbols on which we could
|
||
make these functions' compilation conditional.
|
||
|
||
So, for the time being, we put these functions alone in this file,
|
||
and have .mt files reference them as appropriate. In the future, I
|
||
hope BFD will provide a format-independent bfd_from_remote_memory
|
||
entry point. */
|
||
|
||
|
||
#include "defs.h"
|
||
#include "symtab.h"
|
||
#include "gdbcore.h"
|
||
#include "objfiles.h"
|
||
#include "gdbcmd.h"
|
||
#include "target.h"
|
||
#include "value.h"
|
||
#include "symfile.h"
|
||
#include "observer.h"
|
||
#include "auxv.h"
|
||
#include "elf/common.h"
|
||
#include "gdb_bfd.h"
|
||
|
||
/* Verify parameters of target_read_memory_bfd and target_read_memory are
|
||
compatible. */
|
||
|
||
gdb_static_assert (sizeof (CORE_ADDR) == sizeof (bfd_vma));
|
||
gdb_static_assert (sizeof (gdb_byte) == sizeof (bfd_byte));
|
||
gdb_static_assert (sizeof (ssize_t) <= sizeof (bfd_size_type));
|
||
|
||
/* Provide bfd/ compatible prototype for target_read_memory. Casting would not
|
||
be enough as LEN width may differ. */
|
||
|
||
static int
|
||
target_read_memory_bfd (bfd_vma memaddr, bfd_byte *myaddr, bfd_size_type len)
|
||
{
|
||
/* MYADDR must be already allocated for the LEN size so it has to fit in
|
||
ssize_t. */
|
||
gdb_assert ((ssize_t) len == len);
|
||
|
||
return target_read_memory (memaddr, myaddr, len);
|
||
}
|
||
|
||
/* Read inferior memory at ADDR to find the header of a loaded object file
|
||
and read its in-core symbols out of inferior memory. SIZE, if
|
||
non-zero, is the known size of the object. TEMPL is a bfd
|
||
representing the target's format. NAME is the name to use for this
|
||
symbol file in messages; it can be NULL or a malloc-allocated string
|
||
which will be attached to the BFD. */
|
||
static struct objfile *
|
||
symbol_file_add_from_memory (struct bfd *templ, CORE_ADDR addr,
|
||
size_t size, char *name, int from_tty)
|
||
{
|
||
struct objfile *objf;
|
||
struct bfd *nbfd;
|
||
struct bfd_section *sec;
|
||
bfd_vma loadbase;
|
||
struct section_addr_info *sai;
|
||
unsigned int i;
|
||
struct cleanup *cleanup;
|
||
symfile_add_flags add_flags = 0;
|
||
|
||
if (bfd_get_flavour (templ) != bfd_target_elf_flavour)
|
||
error (_("add-symbol-file-from-memory not supported for this target"));
|
||
|
||
nbfd = bfd_elf_bfd_from_remote_memory (templ, addr, size, &loadbase,
|
||
target_read_memory_bfd);
|
||
if (nbfd == NULL)
|
||
error (_("Failed to read a valid object file image from memory."));
|
||
|
||
gdb_bfd_ref (nbfd);
|
||
/* Manage the new reference for the duration of this function. */
|
||
gdb_bfd_ref_ptr nbfd_holder (nbfd);
|
||
|
||
xfree (bfd_get_filename (nbfd));
|
||
if (name == NULL)
|
||
nbfd->filename = xstrdup ("shared object read from target memory");
|
||
else
|
||
nbfd->filename = name;
|
||
|
||
if (!bfd_check_format (nbfd, bfd_object))
|
||
error (_("Got object file from memory but can't read symbols: %s."),
|
||
bfd_errmsg (bfd_get_error ()));
|
||
|
||
sai = alloc_section_addr_info (bfd_count_sections (nbfd));
|
||
cleanup = make_cleanup (xfree, sai);
|
||
i = 0;
|
||
for (sec = nbfd->sections; sec != NULL; sec = sec->next)
|
||
if ((bfd_get_section_flags (nbfd, sec) & (SEC_ALLOC|SEC_LOAD)) != 0)
|
||
{
|
||
sai->other[i].addr = bfd_get_section_vma (nbfd, sec) + loadbase;
|
||
sai->other[i].name = (char *) bfd_get_section_name (nbfd, sec);
|
||
sai->other[i].sectindex = sec->index;
|
||
++i;
|
||
}
|
||
sai->num_sections = i;
|
||
|
||
if (from_tty)
|
||
add_flags |= SYMFILE_VERBOSE;
|
||
|
||
objf = symbol_file_add_from_bfd (nbfd, bfd_get_filename (nbfd),
|
||
add_flags, sai, OBJF_SHARED, NULL);
|
||
|
||
add_target_sections_of_objfile (objf);
|
||
|
||
/* This might change our ideas about frames already looked at. */
|
||
reinit_frame_cache ();
|
||
|
||
do_cleanups (cleanup);
|
||
return objf;
|
||
}
|
||
|
||
|
||
static void
|
||
add_symbol_file_from_memory_command (char *args, int from_tty)
|
||
{
|
||
CORE_ADDR addr;
|
||
struct bfd *templ;
|
||
|
||
if (args == NULL)
|
||
error (_("add-symbol-file-from-memory requires an expression argument"));
|
||
|
||
addr = parse_and_eval_address (args);
|
||
|
||
/* We need some representative bfd to know the target we are looking at. */
|
||
if (symfile_objfile != NULL)
|
||
templ = symfile_objfile->obfd;
|
||
else
|
||
templ = exec_bfd;
|
||
if (templ == NULL)
|
||
error (_("Must use symbol-file or exec-file "
|
||
"before add-symbol-file-from-memory."));
|
||
|
||
symbol_file_add_from_memory (templ, addr, 0, NULL, from_tty);
|
||
}
|
||
|
||
/* Arguments for symbol_file_add_from_memory_wrapper. */
|
||
|
||
struct symbol_file_add_from_memory_args
|
||
{
|
||
struct bfd *bfd;
|
||
CORE_ADDR sysinfo_ehdr;
|
||
size_t size;
|
||
char *name;
|
||
int from_tty;
|
||
};
|
||
|
||
/* Wrapper function for symbol_file_add_from_memory, for
|
||
catch_exceptions. */
|
||
|
||
static int
|
||
symbol_file_add_from_memory_wrapper (struct ui_out *uiout, void *data)
|
||
{
|
||
struct symbol_file_add_from_memory_args *args
|
||
= (struct symbol_file_add_from_memory_args *) data;
|
||
|
||
symbol_file_add_from_memory (args->bfd, args->sysinfo_ehdr, args->size,
|
||
args->name, args->from_tty);
|
||
return 0;
|
||
}
|
||
|
||
/* Try to add the symbols for the vsyscall page, if there is one.
|
||
This function is called via the inferior_created observer. */
|
||
|
||
static void
|
||
add_vsyscall_page (struct target_ops *target, int from_tty)
|
||
{
|
||
struct mem_range vsyscall_range;
|
||
|
||
if (gdbarch_vsyscall_range (target_gdbarch (), &vsyscall_range))
|
||
{
|
||
struct bfd *bfd;
|
||
struct symbol_file_add_from_memory_args args;
|
||
|
||
if (core_bfd != NULL)
|
||
bfd = core_bfd;
|
||
else if (exec_bfd != NULL)
|
||
bfd = exec_bfd;
|
||
else
|
||
/* FIXME: cagney/2004-05-06: Should not require an existing
|
||
BFD when trying to create a run-time BFD of the VSYSCALL
|
||
page in the inferior. Unfortunately that's the current
|
||
interface so for the moment bail. Introducing a
|
||
``bfd_runtime'' (a BFD created using the loaded image) file
|
||
format should fix this. */
|
||
{
|
||
warning (_("Could not load vsyscall page "
|
||
"because no executable was specified"));
|
||
return;
|
||
}
|
||
args.bfd = bfd;
|
||
args.sysinfo_ehdr = vsyscall_range.start;
|
||
args.size = vsyscall_range.length;
|
||
|
||
args.name = xstrprintf ("system-supplied DSO at %s",
|
||
paddress (target_gdbarch (), vsyscall_range.start));
|
||
/* Pass zero for FROM_TTY, because the action of loading the
|
||
vsyscall DSO was not triggered by the user, even if the user
|
||
typed "run" at the TTY. */
|
||
args.from_tty = 0;
|
||
catch_exceptions (current_uiout, symbol_file_add_from_memory_wrapper,
|
||
&args, RETURN_MASK_ALL);
|
||
}
|
||
}
|
||
|
||
|
||
|
||
/* Provide a prototype to silence -Wmissing-prototypes. */
|
||
extern initialize_file_ftype _initialize_symfile_mem;
|
||
|
||
void
|
||
_initialize_symfile_mem (void)
|
||
{
|
||
add_cmd ("add-symbol-file-from-memory", class_files,
|
||
add_symbol_file_from_memory_command,
|
||
_("Load the symbols out of memory from a "
|
||
"dynamically loaded object file.\n"
|
||
"Give an expression for the address "
|
||
"of the file's shared object file header."),
|
||
&cmdlist);
|
||
|
||
/* Want to know of each new inferior so that its vsyscall info can
|
||
be extracted. */
|
||
observer_attach_inferior_created (add_vsyscall_page);
|
||
}
|