binutils-gdb/gdb/testsuite/gdb.python/py-pp-registration.exp
Simon Marchi 72ca041044 Change method of loading .py files in Python tests
With my debug build of Python (--with-pydebug), many tests fails because
of the same issue.  Python scripts are loaded by the tests using this
pattern:

  (gdb) python exec (open ('file.py').read ())

This causes Python to output this warning:

  __main__:1: ResourceWarning: unclosed file <_io.TextIOWrapper name='file.py' mode='r' encoding='ANSI_X3.4-1968'>

and the test to fail because of that extra output.  Instead of using the
open + read + exec trick which leaks the file and causes the warning,
why not just source the files?

  (gdb) source file.py

This patch changes this, and standardizes the test names of the tests I
touched to "load python file" (some of them were empty, others were
overly complicated).

gdb/testsuite/ChangeLog:

	* gdb.python/py-bad-printers.exp: Load python file using "source".
	* gdb.python/py-events.exp: Likewise.
	* gdb.python/py-evsignal.exp: Likewise.
	* gdb.python/py-evthreads.exp: Likewise.
	* gdb.python/py-frame-args.exp: Likewise.
	* gdb.python/py-framefilter-invalidarg.exp: Likewise.
	* gdb.python/py-framefilter-mi.exp: Likewise.
	* gdb.python/py-framefilter.exp: Likewise.
	* gdb.python/py-mi.exp: Likewise.
	* gdb.python/py-pp-maint.exp: Likewise.
	* gdb.python/py-pp-registration.exp: Likewise.
	* gdb.python/py-prettyprint.exp: Likewise.
	(run_lang_tests): Likewise.
	* gdb.python/py-typeprint.exp: Likewise.
2017-01-26 16:12:12 -05:00

121 lines
3.5 KiB
Plaintext

# Copyright (C) 2010-2017 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# This file is part of the GDB testsuite. It tests python pretty
# printer registration.
load_lib gdb-python.exp
standard_testfile
if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
return -1
}
# Skip all tests if Python scripting is not enabled.
if { [skip_python_tests] } { continue }
set remote_python_file [gdb_remote_download host \
${srcdir}/${subdir}/${testfile}.py]
if ![runto_main ] {
fail "can't run to main"
return -1
}
proc prepare_test { } {
global testfile remote_python_file
# Start with a fresh gdb.
clean_restart ${testfile}
set run_to_here [gdb_get_line_number {break to inspect} ${testfile}.c ]
if ![runto ${testfile}.c:$run_to_here message] {
return 0
}
gdb_test_no_output "source ${remote_python_file}" "read file"
gdb_test_no_output "py progspace = gdb.current_progspace()"
gdb_test_no_output "py my_pretty_printer1 = build_pretty_printer1()"
gdb_test_no_output "py my_pretty_printer2 = build_pretty_printer2()"
return 1
}
proc test_printers { s_prefix } {
global hex
gdb_test "print flt" " = x=<42> y=<43>" \
"print flt"
gdb_test "print s" " = ${s_prefix} a=<1> b=<$hex>" \
"print s"
}
# Test registration with verbose off.
with_test_prefix "verbose off" {
if ![prepare_test] {
return -1
}
gdb_test_no_output "set verbose off"
gdb_test_no_output "py gdb.printing.register_pretty_printer(gdb, lookup_function_lookup_test)"
gdb_test_no_output "py gdb.printing.register_pretty_printer(progspace, my_pretty_printer1)"
test_printers "s1"
}
# Test registration with verbose on.
with_test_prefix "verbose on" {
if ![prepare_test] {
return -1
}
gdb_test_no_output "set verbose on"
gdb_test "py gdb.printing.register_pretty_printer(gdb, lookup_function_lookup_test)" \
"Registering global lookup_function_lookup_test pretty-printer ..."
gdb_test "py gdb.printing.register_pretty_printer(progspace, my_pretty_printer1)" \
"Registering pp-test pretty-printer for .*/py-pp-registration ..."
test_printers "s1"
}
# Exercise the "replace" argument to register_pretty_printer.
with_test_prefix "replace" {
if ![prepare_test] {
return -1
}
gdb_test_no_output "py gdb.printing.register_pretty_printer(gdb, lookup_function_lookup_test)"
gdb_test_no_output "py gdb.printing.register_pretty_printer(progspace, my_pretty_printer1)"
gdb_test "py gdb.printing.register_pretty_printer(progspace, my_pretty_printer2, replace=False)" \
"RuntimeError: pretty-printer already registered: pp-test\r\nError while executing Python code."
with_test_prefix "test printers 1" {
test_printers "s1"
}
gdb_test_no_output "py gdb.printing.register_pretty_printer(progspace, my_pretty_printer2, replace=True)"
with_test_prefix "test printers 2" {
test_printers "s2"
}
}