mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-02-05 12:53:16 +08:00
ae2e4d4035
loongarch_elf_finish_dynamic_symbol is called after elf_link_sort_relocs
if -z combreloc. elf_link_sort_relocs redistributes the contents of
.rela.* sections those would be merged into .rela.dyn, so the slot for
R_LARCH_IRELATIVE may be out of relplt->contents now.
To make things worse, the boundary check
dyn < dyn + relplt->size / sizeof (*dyn)
is obviously wrong ("x + 10 < x"? :), causing the issue undetected
during the linking process and the resulted executable suddenly crashes
at runtime.
The issue was found during an attempt to add static-pie support to the
toolchain.
Fix it by iterating through the inputs of .rela.dyn to find the slot.
43 lines
1.3 KiB
Plaintext
43 lines
1.3 KiB
Plaintext
# Expect script for LoongArch ELF linker tests
|
|
# Copyright (C) 2021-2022 Free Software Foundation, Inc.
|
|
#
|
|
# This file is part of the GNU Binutils.
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write to the Free Software
|
|
# Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
|
|
# MA 02110-1301, USA.
|
|
#
|
|
|
|
proc loongarch_choose_lp64_emul {} {
|
|
if { [istarget "loongarch64be-*"] } {
|
|
return "elf64bloongarch"
|
|
}
|
|
return "elf64lloongarch"
|
|
}
|
|
|
|
if [istarget "loongarch64-*-*"] {
|
|
run_dump_test "jmp_op"
|
|
run_dump_test "macro_op"
|
|
run_dump_test "syscall"
|
|
run_dump_test "disas-jirl"
|
|
run_dump_test "local-ifunc-reloc"
|
|
}
|
|
|
|
if [istarget "loongarch32-*-*"] {
|
|
run_dump_test "jmp_op"
|
|
run_dump_test "macro_op_32"
|
|
run_dump_test "syscall"
|
|
run_dump_test "disas-jirl-32"
|
|
}
|