mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-03-07 13:39:43 +08:00
4dfef5be68
As follow-up to this discussion: https://sourceware.org/pipermail/gdb-patches/2020-August/171385.html ... make runto_main not pass no-message to runto. This means that if we fail to run to main, for some reason, we'll emit a FAIL. This is the behavior we want the majority of (if not all) the time. Without this, we rely on tests logging a failure if runto_main fails, otherwise. They do so in a very inconsisteny mannet, sometimes using "fail", "unsupported" or "untested". The messages also vary widly. This patch removes all these messages as well. Also, remove a few "fail" where we call runto (and not runto_main). by default (without an explicit no-message argument), runto prints a failure already. In two places, gdb.multi/multi-re-run.exp and gdb.python/py-pp-registration.exp, remove "message" passed to runto. This removes a few PASSes that we don't care about (but FAILs will still be printed if we fail to run to where we want to). This aligns their behavior with the rest of the testsuite. Change-Id: Ib763c98c5f4fb6898886b635210d7c34bd4b9023
69 lines
2.1 KiB
Plaintext
69 lines
2.1 KiB
Plaintext
# Copyright 2020-2021 Free Software Foundation, Inc.
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
#
|
|
# This file is part of the gdb testsuite.
|
|
|
|
# Test if GDB stops at various BRK instruction patterns inserted into
|
|
# the code.
|
|
|
|
if {![is_aarch64_target]} {
|
|
verbose "Skipping ${gdb_test_file_name}."
|
|
return
|
|
}
|
|
|
|
standard_testfile
|
|
if {[prepare_for_testing "failed to prepare" ${testfile} ${srcfile}]} {
|
|
return -1
|
|
}
|
|
|
|
if {![runto_main]} {
|
|
return -1
|
|
}
|
|
|
|
# Number of expected SIGTRAP's to get. This needs to be kept in sync
|
|
# with the source file.
|
|
set expected_traps 3
|
|
set keep_going 1
|
|
set count 0
|
|
|
|
# Make sure we have a lower timeout in case GDB doesn't support a particular
|
|
# instruction. Such instruction will cause GDB to loop infinitely.
|
|
while {$keep_going} {
|
|
# Continue to next program breakpoint instruction.
|
|
gdb_test_multiple "continue" "brk instruction $count causes SIGTRAP" {
|
|
-re "Program received signal SIGTRAP, Trace/breakpoint trap.*$gdb_prompt $" {
|
|
pass $gdb_test_name
|
|
|
|
# Insert a breakpoint at the program breakpoint instruction so
|
|
# GDB can step over it.
|
|
gdb_test "break" \
|
|
"Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
|
|
"insert breakpoint at brk instruction $count"
|
|
incr count
|
|
}
|
|
# We've reached the end of the test.
|
|
-re "exited normally.*$gdb_prompt $" {
|
|
set keep_going 0
|
|
}
|
|
timeout {
|
|
fail $gdb_test_name
|
|
set keep_going 0
|
|
}
|
|
}
|
|
}
|
|
|
|
# Verify we stopped at the expected number of SIGTRAP's.
|
|
gdb_assert {$count == $expected_traps} "all brk instructions triggered"
|