mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-02-17 13:10:12 +08:00
Many spots incorrectly use only spaces for indentation (for example, there are a lot of spots in ada-lang.c). I've always found it awkward when I needed to edit one of these spots: do I keep the original wrong indentation, or do I fix it? What if the lines around it are also wrong, do I fix them too? I probably don't want to fix them in the same patch, to avoid adding noise to my patch. So I propose to fix as much as possible once and for all (hopefully). One typical counter argument for this is that it makes code archeology more difficult, because git-blame will show this commit as the last change for these lines. My counter counter argument is: when git-blaming, you often need to do "blame the file at the parent commit" anyway, to go past some other refactor that touched the line you are interested in, but is not the change you are looking for. So you already need a somewhat efficient way to do this. Using some interactive tool, rather than plain git-blame, makes this trivial. For example, I use "tig blame <file>", where going back past the commit that changed the currently selected line is one keystroke. It looks like Magit in Emacs does it too (though I've never used it). Web viewers of Github and Gitlab do it too. My point is that it won't really make archeology more difficult. The other typical counter argument is that it will cause conflicts with existing patches. That's true... but it's a one time cost, and those are not conflicts that are difficult to resolve. I have also tried "git rebase --ignore-whitespace", it seems to work well. Although that will re-introduce the faulty indentation, so one needs to take care of fixing the indentation in the patch after that (which is easy). gdb/ChangeLog: * aarch64-linux-tdep.c: Fix indentation. * aarch64-ravenscar-thread.c: Fix indentation. * aarch64-tdep.c: Fix indentation. * aarch64-tdep.h: Fix indentation. * ada-lang.c: Fix indentation. * ada-lang.h: Fix indentation. * ada-tasks.c: Fix indentation. * ada-typeprint.c: Fix indentation. * ada-valprint.c: Fix indentation. * ada-varobj.c: Fix indentation. * addrmap.c: Fix indentation. * addrmap.h: Fix indentation. * agent.c: Fix indentation. * aix-thread.c: Fix indentation. * alpha-bsd-nat.c: Fix indentation. * alpha-linux-tdep.c: Fix indentation. * alpha-mdebug-tdep.c: Fix indentation. * alpha-nbsd-tdep.c: Fix indentation. * alpha-obsd-tdep.c: Fix indentation. * alpha-tdep.c: Fix indentation. * amd64-bsd-nat.c: Fix indentation. * amd64-darwin-tdep.c: Fix indentation. * amd64-linux-nat.c: Fix indentation. * amd64-linux-tdep.c: Fix indentation. * amd64-nat.c: Fix indentation. * amd64-obsd-tdep.c: Fix indentation. * amd64-tdep.c: Fix indentation. * amd64-windows-tdep.c: Fix indentation. * annotate.c: Fix indentation. * arc-tdep.c: Fix indentation. * arch-utils.c: Fix indentation. * arch/arm-get-next-pcs.c: Fix indentation. * arch/arm.c: Fix indentation. * arm-linux-nat.c: Fix indentation. * arm-linux-tdep.c: Fix indentation. * arm-nbsd-tdep.c: Fix indentation. * arm-pikeos-tdep.c: Fix indentation. * arm-tdep.c: Fix indentation. * arm-tdep.h: Fix indentation. * arm-wince-tdep.c: Fix indentation. * auto-load.c: Fix indentation. * auxv.c: Fix indentation. * avr-tdep.c: Fix indentation. * ax-gdb.c: Fix indentation. * ax-general.c: Fix indentation. * bfin-linux-tdep.c: Fix indentation. * block.c: Fix indentation. * block.h: Fix indentation. * blockframe.c: Fix indentation. * bpf-tdep.c: Fix indentation. * break-catch-sig.c: Fix indentation. * break-catch-syscall.c: Fix indentation. * break-catch-throw.c: Fix indentation. * breakpoint.c: Fix indentation. * breakpoint.h: Fix indentation. * bsd-uthread.c: Fix indentation. * btrace.c: Fix indentation. * build-id.c: Fix indentation. * buildsym-legacy.h: Fix indentation. * buildsym.c: Fix indentation. * c-typeprint.c: Fix indentation. * c-valprint.c: Fix indentation. * c-varobj.c: Fix indentation. * charset.c: Fix indentation. * cli/cli-cmds.c: Fix indentation. * cli/cli-decode.c: Fix indentation. * cli/cli-decode.h: Fix indentation. * cli/cli-script.c: Fix indentation. * cli/cli-setshow.c: Fix indentation. * coff-pe-read.c: Fix indentation. * coffread.c: Fix indentation. * compile/compile-cplus-types.c: Fix indentation. * compile/compile-object-load.c: Fix indentation. * compile/compile-object-run.c: Fix indentation. * completer.c: Fix indentation. * corefile.c: Fix indentation. * corelow.c: Fix indentation. * cp-abi.h: Fix indentation. * cp-namespace.c: Fix indentation. * cp-support.c: Fix indentation. * cp-valprint.c: Fix indentation. * cris-linux-tdep.c: Fix indentation. * cris-tdep.c: Fix indentation. * darwin-nat-info.c: Fix indentation. * darwin-nat.c: Fix indentation. * darwin-nat.h: Fix indentation. * dbxread.c: Fix indentation. * dcache.c: Fix indentation. * disasm.c: Fix indentation. * dtrace-probe.c: Fix indentation. * dwarf2/abbrev.c: Fix indentation. * dwarf2/attribute.c: Fix indentation. * dwarf2/expr.c: Fix indentation. * dwarf2/frame.c: Fix indentation. * dwarf2/index-cache.c: Fix indentation. * dwarf2/index-write.c: Fix indentation. * dwarf2/line-header.c: Fix indentation. * dwarf2/loc.c: Fix indentation. * dwarf2/macro.c: Fix indentation. * dwarf2/read.c: Fix indentation. * dwarf2/read.h: Fix indentation. * elfread.c: Fix indentation. * eval.c: Fix indentation. * event-top.c: Fix indentation. * exec.c: Fix indentation. * exec.h: Fix indentation. * expprint.c: Fix indentation. * f-lang.c: Fix indentation. * f-typeprint.c: Fix indentation. * f-valprint.c: Fix indentation. * fbsd-nat.c: Fix indentation. * fbsd-tdep.c: Fix indentation. * findvar.c: Fix indentation. * fork-child.c: Fix indentation. * frame-unwind.c: Fix indentation. * frame-unwind.h: Fix indentation. * frame.c: Fix indentation. * frv-linux-tdep.c: Fix indentation. * frv-tdep.c: Fix indentation. * frv-tdep.h: Fix indentation. * ft32-tdep.c: Fix indentation. * gcore.c: Fix indentation. * gdb_bfd.c: Fix indentation. * gdbarch.sh: Fix indentation. * gdbarch.c: Re-generate * gdbarch.h: Re-generate. * gdbcore.h: Fix indentation. * gdbthread.h: Fix indentation. * gdbtypes.c: Fix indentation. * gdbtypes.h: Fix indentation. * glibc-tdep.c: Fix indentation. * gnu-nat.c: Fix indentation. * gnu-nat.h: Fix indentation. * gnu-v2-abi.c: Fix indentation. * gnu-v3-abi.c: Fix indentation. * go32-nat.c: Fix indentation. * guile/guile-internal.h: Fix indentation. * guile/scm-cmd.c: Fix indentation. * guile/scm-frame.c: Fix indentation. * guile/scm-iterator.c: Fix indentation. * guile/scm-math.c: Fix indentation. * guile/scm-ports.c: Fix indentation. * guile/scm-pretty-print.c: Fix indentation. * guile/scm-value.c: Fix indentation. * h8300-tdep.c: Fix indentation. * hppa-linux-nat.c: Fix indentation. * hppa-linux-tdep.c: Fix indentation. * hppa-nbsd-nat.c: Fix indentation. * hppa-nbsd-tdep.c: Fix indentation. * hppa-obsd-nat.c: Fix indentation. * hppa-tdep.c: Fix indentation. * hppa-tdep.h: Fix indentation. * i386-bsd-nat.c: Fix indentation. * i386-darwin-nat.c: Fix indentation. * i386-darwin-tdep.c: Fix indentation. * i386-dicos-tdep.c: Fix indentation. * i386-gnu-nat.c: Fix indentation. * i386-linux-nat.c: Fix indentation. * i386-linux-tdep.c: Fix indentation. * i386-nto-tdep.c: Fix indentation. * i386-obsd-tdep.c: Fix indentation. * i386-sol2-nat.c: Fix indentation. * i386-tdep.c: Fix indentation. * i386-tdep.h: Fix indentation. * i386-windows-tdep.c: Fix indentation. * i387-tdep.c: Fix indentation. * i387-tdep.h: Fix indentation. * ia64-libunwind-tdep.c: Fix indentation. * ia64-libunwind-tdep.h: Fix indentation. * ia64-linux-nat.c: Fix indentation. * ia64-linux-tdep.c: Fix indentation. * ia64-tdep.c: Fix indentation. * ia64-tdep.h: Fix indentation. * ia64-vms-tdep.c: Fix indentation. * infcall.c: Fix indentation. * infcmd.c: Fix indentation. * inferior.c: Fix indentation. * infrun.c: Fix indentation. * iq2000-tdep.c: Fix indentation. * language.c: Fix indentation. * linespec.c: Fix indentation. * linux-fork.c: Fix indentation. * linux-nat.c: Fix indentation. * linux-tdep.c: Fix indentation. * linux-thread-db.c: Fix indentation. * lm32-tdep.c: Fix indentation. * m2-lang.c: Fix indentation. * m2-typeprint.c: Fix indentation. * m2-valprint.c: Fix indentation. * m32c-tdep.c: Fix indentation. * m32r-linux-tdep.c: Fix indentation. * m32r-tdep.c: Fix indentation. * m68hc11-tdep.c: Fix indentation. * m68k-bsd-nat.c: Fix indentation. * m68k-linux-nat.c: Fix indentation. * m68k-linux-tdep.c: Fix indentation. * m68k-tdep.c: Fix indentation. * machoread.c: Fix indentation. * macrocmd.c: Fix indentation. * macroexp.c: Fix indentation. * macroscope.c: Fix indentation. * macrotab.c: Fix indentation. * macrotab.h: Fix indentation. * main.c: Fix indentation. * mdebugread.c: Fix indentation. * mep-tdep.c: Fix indentation. * mi/mi-cmd-catch.c: Fix indentation. * mi/mi-cmd-disas.c: Fix indentation. * mi/mi-cmd-env.c: Fix indentation. * mi/mi-cmd-stack.c: Fix indentation. * mi/mi-cmd-var.c: Fix indentation. * mi/mi-cmds.c: Fix indentation. * mi/mi-main.c: Fix indentation. * mi/mi-parse.c: Fix indentation. * microblaze-tdep.c: Fix indentation. * minidebug.c: Fix indentation. * minsyms.c: Fix indentation. * mips-linux-nat.c: Fix indentation. * mips-linux-tdep.c: Fix indentation. * mips-nbsd-tdep.c: Fix indentation. * mips-tdep.c: Fix indentation. * mn10300-linux-tdep.c: Fix indentation. * mn10300-tdep.c: Fix indentation. * moxie-tdep.c: Fix indentation. * msp430-tdep.c: Fix indentation. * namespace.h: Fix indentation. * nat/fork-inferior.c: Fix indentation. * nat/gdb_ptrace.h: Fix indentation. * nat/linux-namespaces.c: Fix indentation. * nat/linux-osdata.c: Fix indentation. * nat/netbsd-nat.c: Fix indentation. * nat/x86-dregs.c: Fix indentation. * nbsd-nat.c: Fix indentation. * nbsd-tdep.c: Fix indentation. * nios2-linux-tdep.c: Fix indentation. * nios2-tdep.c: Fix indentation. * nto-procfs.c: Fix indentation. * nto-tdep.c: Fix indentation. * objfiles.c: Fix indentation. * objfiles.h: Fix indentation. * opencl-lang.c: Fix indentation. * or1k-tdep.c: Fix indentation. * osabi.c: Fix indentation. * osabi.h: Fix indentation. * osdata.c: Fix indentation. * p-lang.c: Fix indentation. * p-typeprint.c: Fix indentation. * p-valprint.c: Fix indentation. * parse.c: Fix indentation. * ppc-linux-nat.c: Fix indentation. * ppc-linux-tdep.c: Fix indentation. * ppc-nbsd-nat.c: Fix indentation. * ppc-nbsd-tdep.c: Fix indentation. * ppc-obsd-nat.c: Fix indentation. * ppc-ravenscar-thread.c: Fix indentation. * ppc-sysv-tdep.c: Fix indentation. * ppc64-tdep.c: Fix indentation. * printcmd.c: Fix indentation. * proc-api.c: Fix indentation. * producer.c: Fix indentation. * producer.h: Fix indentation. * prologue-value.c: Fix indentation. * prologue-value.h: Fix indentation. * psymtab.c: Fix indentation. * python/py-arch.c: Fix indentation. * python/py-bpevent.c: Fix indentation. * python/py-event.c: Fix indentation. * python/py-event.h: Fix indentation. * python/py-finishbreakpoint.c: Fix indentation. * python/py-frame.c: Fix indentation. * python/py-framefilter.c: Fix indentation. * python/py-inferior.c: Fix indentation. * python/py-infthread.c: Fix indentation. * python/py-objfile.c: Fix indentation. * python/py-prettyprint.c: Fix indentation. * python/py-registers.c: Fix indentation. * python/py-signalevent.c: Fix indentation. * python/py-stopevent.c: Fix indentation. * python/py-stopevent.h: Fix indentation. * python/py-threadevent.c: Fix indentation. * python/py-tui.c: Fix indentation. * python/py-unwind.c: Fix indentation. * python/py-value.c: Fix indentation. * python/py-xmethods.c: Fix indentation. * python/python-internal.h: Fix indentation. * python/python.c: Fix indentation. * ravenscar-thread.c: Fix indentation. * record-btrace.c: Fix indentation. * record-full.c: Fix indentation. * record.c: Fix indentation. * reggroups.c: Fix indentation. * regset.h: Fix indentation. * remote-fileio.c: Fix indentation. * remote.c: Fix indentation. * reverse.c: Fix indentation. * riscv-linux-tdep.c: Fix indentation. * riscv-ravenscar-thread.c: Fix indentation. * riscv-tdep.c: Fix indentation. * rl78-tdep.c: Fix indentation. * rs6000-aix-tdep.c: Fix indentation. * rs6000-lynx178-tdep.c: Fix indentation. * rs6000-nat.c: Fix indentation. * rs6000-tdep.c: Fix indentation. * rust-lang.c: Fix indentation. * rx-tdep.c: Fix indentation. * s12z-tdep.c: Fix indentation. * s390-linux-tdep.c: Fix indentation. * score-tdep.c: Fix indentation. * ser-base.c: Fix indentation. * ser-mingw.c: Fix indentation. * ser-uds.c: Fix indentation. * ser-unix.c: Fix indentation. * serial.c: Fix indentation. * sh-linux-tdep.c: Fix indentation. * sh-nbsd-tdep.c: Fix indentation. * sh-tdep.c: Fix indentation. * skip.c: Fix indentation. * sol-thread.c: Fix indentation. * solib-aix.c: Fix indentation. * solib-darwin.c: Fix indentation. * solib-frv.c: Fix indentation. * solib-svr4.c: Fix indentation. * solib.c: Fix indentation. * source.c: Fix indentation. * sparc-linux-tdep.c: Fix indentation. * sparc-nbsd-tdep.c: Fix indentation. * sparc-obsd-tdep.c: Fix indentation. * sparc-ravenscar-thread.c: Fix indentation. * sparc-tdep.c: Fix indentation. * sparc64-linux-tdep.c: Fix indentation. * sparc64-nbsd-tdep.c: Fix indentation. * sparc64-obsd-tdep.c: Fix indentation. * sparc64-tdep.c: Fix indentation. * stabsread.c: Fix indentation. * stack.c: Fix indentation. * stap-probe.c: Fix indentation. * stubs/ia64vms-stub.c: Fix indentation. * stubs/m32r-stub.c: Fix indentation. * stubs/m68k-stub.c: Fix indentation. * stubs/sh-stub.c: Fix indentation. * stubs/sparc-stub.c: Fix indentation. * symfile-mem.c: Fix indentation. * symfile.c: Fix indentation. * symfile.h: Fix indentation. * symmisc.c: Fix indentation. * symtab.c: Fix indentation. * symtab.h: Fix indentation. * target-float.c: Fix indentation. * target.c: Fix indentation. * target.h: Fix indentation. * tic6x-tdep.c: Fix indentation. * tilegx-linux-tdep.c: Fix indentation. * tilegx-tdep.c: Fix indentation. * top.c: Fix indentation. * tracefile-tfile.c: Fix indentation. * tracepoint.c: Fix indentation. * tui/tui-disasm.c: Fix indentation. * tui/tui-io.c: Fix indentation. * tui/tui-regs.c: Fix indentation. * tui/tui-stack.c: Fix indentation. * tui/tui-win.c: Fix indentation. * tui/tui-winsource.c: Fix indentation. * tui/tui.c: Fix indentation. * typeprint.c: Fix indentation. * ui-out.h: Fix indentation. * unittests/copy_bitwise-selftests.c: Fix indentation. * unittests/memory-map-selftests.c: Fix indentation. * utils.c: Fix indentation. * v850-tdep.c: Fix indentation. * valarith.c: Fix indentation. * valops.c: Fix indentation. * valprint.c: Fix indentation. * valprint.h: Fix indentation. * value.c: Fix indentation. * value.h: Fix indentation. * varobj.c: Fix indentation. * vax-tdep.c: Fix indentation. * windows-nat.c: Fix indentation. * windows-tdep.c: Fix indentation. * xcoffread.c: Fix indentation. * xml-syscall.c: Fix indentation. * xml-tdesc.c: Fix indentation. * xstormy16-tdep.c: Fix indentation. * xtensa-config.c: Fix indentation. * xtensa-linux-nat.c: Fix indentation. * xtensa-linux-tdep.c: Fix indentation. * xtensa-tdep.c: Fix indentation. gdbserver/ChangeLog: * ax.cc: Fix indentation. * dll.cc: Fix indentation. * inferiors.h: Fix indentation. * linux-low.cc: Fix indentation. * linux-nios2-low.cc: Fix indentation. * linux-ppc-ipa.cc: Fix indentation. * linux-ppc-low.cc: Fix indentation. * linux-x86-low.cc: Fix indentation. * linux-xtensa-low.cc: Fix indentation. * regcache.cc: Fix indentation. * server.cc: Fix indentation. * tracepoint.cc: Fix indentation. gdbsupport/ChangeLog: * common-exceptions.h: Fix indentation. * event-loop.cc: Fix indentation. * fileio.cc: Fix indentation. * filestuff.cc: Fix indentation. * gdb-dlfcn.cc: Fix indentation. * gdb_string_view.h: Fix indentation. * job-control.cc: Fix indentation. * signals.cc: Fix indentation. Change-Id: I4bad7ae6be0fbe14168b8ebafb98ffe14964a695
784 lines
20 KiB
C
784 lines
20 KiB
C
/* MI Command Set - varobj commands.
|
|
Copyright (C) 2000-2020 Free Software Foundation, Inc.
|
|
|
|
Contributed by Cygnus Solutions (a Red Hat company).
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "mi-cmds.h"
|
|
#include "mi-main.h"
|
|
#include "ui-out.h"
|
|
#include "mi-out.h"
|
|
#include "varobj.h"
|
|
#include "language.h"
|
|
#include "value.h"
|
|
#include <ctype.h>
|
|
#include "mi-getopt.h"
|
|
#include "gdbthread.h"
|
|
#include "mi-parse.h"
|
|
#include "gdbsupport/gdb_optional.h"
|
|
#include "inferior.h"
|
|
|
|
static void varobj_update_one (struct varobj *var,
|
|
enum print_values print_values,
|
|
bool is_explicit);
|
|
|
|
static int mi_print_value_p (struct varobj *var,
|
|
enum print_values print_values);
|
|
|
|
/* Print variable object VAR. The PRINT_VALUES parameter controls
|
|
if the value should be printed. The PRINT_EXPRESSION parameter
|
|
controls if the expression should be printed. */
|
|
|
|
static void
|
|
print_varobj (struct varobj *var, enum print_values print_values,
|
|
int print_expression)
|
|
{
|
|
struct ui_out *uiout = current_uiout;
|
|
int thread_id;
|
|
|
|
uiout->field_string ("name", varobj_get_objname (var));
|
|
if (print_expression)
|
|
{
|
|
std::string exp = varobj_get_expression (var);
|
|
|
|
uiout->field_string ("exp", exp.c_str ());
|
|
}
|
|
uiout->field_signed ("numchild", varobj_get_num_children (var));
|
|
|
|
if (mi_print_value_p (var, print_values))
|
|
{
|
|
std::string val = varobj_get_value (var);
|
|
|
|
uiout->field_string ("value", val.c_str ());
|
|
}
|
|
|
|
std::string type = varobj_get_type (var);
|
|
if (!type.empty ())
|
|
uiout->field_string ("type", type.c_str ());
|
|
|
|
thread_id = varobj_get_thread_id (var);
|
|
if (thread_id > 0)
|
|
uiout->field_signed ("thread-id", thread_id);
|
|
|
|
if (varobj_get_frozen (var))
|
|
uiout->field_signed ("frozen", 1);
|
|
|
|
gdb::unique_xmalloc_ptr<char> display_hint = varobj_get_display_hint (var);
|
|
if (display_hint)
|
|
uiout->field_string ("displayhint", display_hint.get ());
|
|
|
|
if (varobj_is_dynamic_p (var))
|
|
uiout->field_signed ("dynamic", 1);
|
|
}
|
|
|
|
/* VAROBJ operations */
|
|
|
|
void
|
|
mi_cmd_var_create (const char *command, char **argv, int argc)
|
|
{
|
|
struct ui_out *uiout = current_uiout;
|
|
CORE_ADDR frameaddr = 0;
|
|
struct varobj *var;
|
|
char *frame;
|
|
char *expr;
|
|
enum varobj_type var_type;
|
|
|
|
if (argc != 3)
|
|
error (_("-var-create: Usage: NAME FRAME EXPRESSION."));
|
|
|
|
frame = argv[1];
|
|
expr = argv[2];
|
|
|
|
const char *name = argv[0];
|
|
std::string gen_name;
|
|
if (strcmp (name, "-") == 0)
|
|
{
|
|
gen_name = varobj_gen_name ();
|
|
name = gen_name.c_str ();
|
|
}
|
|
else if (!isalpha (name[0]))
|
|
error (_("-var-create: name of object must begin with a letter"));
|
|
|
|
if (strcmp (frame, "*") == 0)
|
|
var_type = USE_CURRENT_FRAME;
|
|
else if (strcmp (frame, "@") == 0)
|
|
var_type = USE_SELECTED_FRAME;
|
|
else
|
|
{
|
|
var_type = USE_SPECIFIED_FRAME;
|
|
frameaddr = string_to_core_addr (frame);
|
|
}
|
|
|
|
if (varobjdebug)
|
|
fprintf_unfiltered (gdb_stdlog,
|
|
"Name=\"%s\", Frame=\"%s\" (%s), Expression=\"%s\"\n",
|
|
name, frame, hex_string (frameaddr), expr);
|
|
|
|
var = varobj_create (name, expr, frameaddr, var_type);
|
|
|
|
if (var == NULL)
|
|
error (_("-var-create: unable to create variable object"));
|
|
|
|
print_varobj (var, PRINT_ALL_VALUES, 0 /* don't print expression */);
|
|
|
|
uiout->field_signed ("has_more", varobj_has_more (var, 0));
|
|
}
|
|
|
|
void
|
|
mi_cmd_var_delete (const char *command, char **argv, int argc)
|
|
{
|
|
char *name;
|
|
struct varobj *var;
|
|
int numdel;
|
|
int children_only_p = 0;
|
|
struct ui_out *uiout = current_uiout;
|
|
|
|
if (argc < 1 || argc > 2)
|
|
error (_("-var-delete: Usage: [-c] EXPRESSION."));
|
|
|
|
name = argv[0];
|
|
|
|
/* If we have one single argument it cannot be '-c' or any string
|
|
starting with '-'. */
|
|
if (argc == 1)
|
|
{
|
|
if (strcmp (name, "-c") == 0)
|
|
error (_("-var-delete: Missing required "
|
|
"argument after '-c': variable object name"));
|
|
if (*name == '-')
|
|
error (_("-var-delete: Illegal variable object name"));
|
|
}
|
|
|
|
/* If we have 2 arguments they must be '-c' followed by a string
|
|
which would be the variable name. */
|
|
if (argc == 2)
|
|
{
|
|
if (strcmp (name, "-c") != 0)
|
|
error (_("-var-delete: Invalid option."));
|
|
children_only_p = 1;
|
|
name = argv[1];
|
|
}
|
|
|
|
/* If we didn't error out, now NAME contains the name of the
|
|
variable. */
|
|
|
|
var = varobj_get_handle (name);
|
|
|
|
numdel = varobj_delete (var, children_only_p);
|
|
|
|
uiout->field_signed ("ndeleted", numdel);
|
|
}
|
|
|
|
/* Parse a string argument into a format value. */
|
|
|
|
static enum varobj_display_formats
|
|
mi_parse_format (const char *arg)
|
|
{
|
|
if (arg != NULL)
|
|
{
|
|
int len;
|
|
|
|
len = strlen (arg);
|
|
|
|
if (strncmp (arg, "natural", len) == 0)
|
|
return FORMAT_NATURAL;
|
|
else if (strncmp (arg, "binary", len) == 0)
|
|
return FORMAT_BINARY;
|
|
else if (strncmp (arg, "decimal", len) == 0)
|
|
return FORMAT_DECIMAL;
|
|
else if (strncmp (arg, "hexadecimal", len) == 0)
|
|
return FORMAT_HEXADECIMAL;
|
|
else if (strncmp (arg, "octal", len) == 0)
|
|
return FORMAT_OCTAL;
|
|
else if (strncmp (arg, "zero-hexadecimal", len) == 0)
|
|
return FORMAT_ZHEXADECIMAL;
|
|
}
|
|
|
|
error (_("Must specify the format as: \"natural\", "
|
|
"\"binary\", \"decimal\", \"hexadecimal\", \"octal\" or \"zero-hexadecimal\""));
|
|
}
|
|
|
|
void
|
|
mi_cmd_var_set_format (const char *command, char **argv, int argc)
|
|
{
|
|
enum varobj_display_formats format;
|
|
struct varobj *var;
|
|
struct ui_out *uiout = current_uiout;
|
|
|
|
if (argc != 2)
|
|
error (_("-var-set-format: Usage: NAME FORMAT."));
|
|
|
|
/* Get varobj handle, if a valid var obj name was specified. */
|
|
var = varobj_get_handle (argv[0]);
|
|
|
|
format = mi_parse_format (argv[1]);
|
|
|
|
/* Set the format of VAR to the given format. */
|
|
varobj_set_display_format (var, format);
|
|
|
|
/* Report the new current format. */
|
|
uiout->field_string ("format", varobj_format_string[(int) format]);
|
|
|
|
/* Report the value in the new format. */
|
|
std::string val = varobj_get_value (var);
|
|
uiout->field_string ("value", val.c_str ());
|
|
}
|
|
|
|
void
|
|
mi_cmd_var_set_visualizer (const char *command, char **argv, int argc)
|
|
{
|
|
struct varobj *var;
|
|
|
|
if (argc != 2)
|
|
error (_("Usage: NAME VISUALIZER_FUNCTION."));
|
|
|
|
var = varobj_get_handle (argv[0]);
|
|
|
|
if (var == NULL)
|
|
error (_("Variable object not found"));
|
|
|
|
varobj_set_visualizer (var, argv[1]);
|
|
}
|
|
|
|
void
|
|
mi_cmd_var_set_frozen (const char *command, char **argv, int argc)
|
|
{
|
|
struct varobj *var;
|
|
bool frozen;
|
|
|
|
if (argc != 2)
|
|
error (_("-var-set-format: Usage: NAME FROZEN_FLAG."));
|
|
|
|
var = varobj_get_handle (argv[0]);
|
|
|
|
if (strcmp (argv[1], "0") == 0)
|
|
frozen = false;
|
|
else if (strcmp (argv[1], "1") == 0)
|
|
frozen = true;
|
|
else
|
|
error (_("Invalid flag value"));
|
|
|
|
varobj_set_frozen (var, frozen);
|
|
|
|
/* We don't automatically return the new value, or what varobjs got
|
|
new values during unfreezing. If this information is required,
|
|
client should call -var-update explicitly. */
|
|
}
|
|
|
|
void
|
|
mi_cmd_var_show_format (const char *command, char **argv, int argc)
|
|
{
|
|
struct ui_out *uiout = current_uiout;
|
|
enum varobj_display_formats format;
|
|
struct varobj *var;
|
|
|
|
if (argc != 1)
|
|
error (_("-var-show-format: Usage: NAME."));
|
|
|
|
/* Get varobj handle, if a valid var obj name was specified. */
|
|
var = varobj_get_handle (argv[0]);
|
|
|
|
format = varobj_get_display_format (var);
|
|
|
|
/* Report the current format. */
|
|
uiout->field_string ("format", varobj_format_string[(int) format]);
|
|
}
|
|
|
|
void
|
|
mi_cmd_var_info_num_children (const char *command, char **argv, int argc)
|
|
{
|
|
struct ui_out *uiout = current_uiout;
|
|
struct varobj *var;
|
|
|
|
if (argc != 1)
|
|
error (_("-var-info-num-children: Usage: NAME."));
|
|
|
|
/* Get varobj handle, if a valid var obj name was specified. */
|
|
var = varobj_get_handle (argv[0]);
|
|
|
|
uiout->field_signed ("numchild", varobj_get_num_children (var));
|
|
}
|
|
|
|
/* Return 1 if given the argument PRINT_VALUES we should display
|
|
the varobj VAR. */
|
|
|
|
static int
|
|
mi_print_value_p (struct varobj *var, enum print_values print_values)
|
|
{
|
|
struct type *type;
|
|
|
|
if (print_values == PRINT_NO_VALUES)
|
|
return 0;
|
|
|
|
if (print_values == PRINT_ALL_VALUES)
|
|
return 1;
|
|
|
|
if (varobj_is_dynamic_p (var))
|
|
return 1;
|
|
|
|
type = varobj_get_gdb_type (var);
|
|
if (type == NULL)
|
|
return 1;
|
|
else
|
|
{
|
|
type = check_typedef (type);
|
|
|
|
/* For PRINT_SIMPLE_VALUES, only print the value if it has a type
|
|
and that type is not a compound type. */
|
|
return (type->code () != TYPE_CODE_ARRAY
|
|
&& type->code () != TYPE_CODE_STRUCT
|
|
&& type->code () != TYPE_CODE_UNION);
|
|
}
|
|
}
|
|
|
|
void
|
|
mi_cmd_var_list_children (const char *command, char **argv, int argc)
|
|
{
|
|
struct ui_out *uiout = current_uiout;
|
|
struct varobj *var;
|
|
enum print_values print_values;
|
|
int from, to;
|
|
|
|
if (argc < 1 || argc > 4)
|
|
error (_("-var-list-children: Usage: "
|
|
"[PRINT_VALUES] NAME [FROM TO]"));
|
|
|
|
/* Get varobj handle, if a valid var obj name was specified. */
|
|
if (argc == 1 || argc == 3)
|
|
var = varobj_get_handle (argv[0]);
|
|
else
|
|
var = varobj_get_handle (argv[1]);
|
|
|
|
if (argc > 2)
|
|
{
|
|
from = atoi (argv[argc - 2]);
|
|
to = atoi (argv[argc - 1]);
|
|
}
|
|
else
|
|
{
|
|
from = -1;
|
|
to = -1;
|
|
}
|
|
|
|
const std::vector<varobj *> &children
|
|
= varobj_list_children (var, &from, &to);
|
|
|
|
uiout->field_signed ("numchild", to - from);
|
|
if (argc == 2 || argc == 4)
|
|
print_values = mi_parse_print_values (argv[0]);
|
|
else
|
|
print_values = PRINT_NO_VALUES;
|
|
|
|
gdb::unique_xmalloc_ptr<char> display_hint = varobj_get_display_hint (var);
|
|
if (display_hint)
|
|
uiout->field_string ("displayhint", display_hint.get ());
|
|
|
|
if (from < to)
|
|
{
|
|
/* For historical reasons this might emit a list or a tuple, so
|
|
we construct one or the other. */
|
|
gdb::optional<ui_out_emit_tuple> tuple_emitter;
|
|
gdb::optional<ui_out_emit_list> list_emitter;
|
|
|
|
if (mi_version (uiout) == 1)
|
|
tuple_emitter.emplace (uiout, "children");
|
|
else
|
|
list_emitter.emplace (uiout, "children");
|
|
for (int ix = from; ix < to && ix < children.size (); ix++)
|
|
{
|
|
ui_out_emit_tuple child_emitter (uiout, "child");
|
|
|
|
print_varobj (children[ix], print_values, 1 /* print expression */);
|
|
}
|
|
}
|
|
|
|
uiout->field_signed ("has_more", varobj_has_more (var, to));
|
|
}
|
|
|
|
void
|
|
mi_cmd_var_info_type (const char *command, char **argv, int argc)
|
|
{
|
|
struct ui_out *uiout = current_uiout;
|
|
struct varobj *var;
|
|
|
|
if (argc != 1)
|
|
error (_("-var-info-type: Usage: NAME."));
|
|
|
|
/* Get varobj handle, if a valid var obj name was specified. */
|
|
var = varobj_get_handle (argv[0]);
|
|
|
|
std::string type_name = varobj_get_type (var);
|
|
uiout->field_string ("type", type_name.c_str ());
|
|
}
|
|
|
|
void
|
|
mi_cmd_var_info_path_expression (const char *command, char **argv, int argc)
|
|
{
|
|
struct ui_out *uiout = current_uiout;
|
|
struct varobj *var;
|
|
|
|
if (argc != 1)
|
|
error (_("Usage: NAME."));
|
|
|
|
/* Get varobj handle, if a valid var obj name was specified. */
|
|
var = varobj_get_handle (argv[0]);
|
|
|
|
const char *path_expr = varobj_get_path_expr (var);
|
|
|
|
uiout->field_string ("path_expr", path_expr);
|
|
}
|
|
|
|
void
|
|
mi_cmd_var_info_expression (const char *command, char **argv, int argc)
|
|
{
|
|
struct ui_out *uiout = current_uiout;
|
|
const struct language_defn *lang;
|
|
struct varobj *var;
|
|
|
|
if (argc != 1)
|
|
error (_("-var-info-expression: Usage: NAME."));
|
|
|
|
/* Get varobj handle, if a valid var obj name was specified. */
|
|
var = varobj_get_handle (argv[0]);
|
|
|
|
lang = varobj_get_language (var);
|
|
|
|
uiout->field_string ("lang", lang->natural_name ());
|
|
|
|
std::string exp = varobj_get_expression (var);
|
|
uiout->field_string ("exp", exp.c_str ());
|
|
}
|
|
|
|
void
|
|
mi_cmd_var_show_attributes (const char *command, char **argv, int argc)
|
|
{
|
|
struct ui_out *uiout = current_uiout;
|
|
int attr;
|
|
const char *attstr;
|
|
struct varobj *var;
|
|
|
|
if (argc != 1)
|
|
error (_("-var-show-attributes: Usage: NAME."));
|
|
|
|
/* Get varobj handle, if a valid var obj name was specified */
|
|
var = varobj_get_handle (argv[0]);
|
|
|
|
attr = varobj_get_attributes (var);
|
|
/* FIXME: define masks for attributes */
|
|
if (attr & 0x00000001)
|
|
attstr = "editable";
|
|
else
|
|
attstr = "noneditable";
|
|
|
|
uiout->field_string ("attr", attstr);
|
|
}
|
|
|
|
void
|
|
mi_cmd_var_evaluate_expression (const char *command, char **argv, int argc)
|
|
{
|
|
struct ui_out *uiout = current_uiout;
|
|
struct varobj *var;
|
|
|
|
enum varobj_display_formats format;
|
|
int formatFound;
|
|
int oind;
|
|
char *oarg;
|
|
|
|
enum opt
|
|
{
|
|
OP_FORMAT
|
|
};
|
|
static const struct mi_opt opts[] =
|
|
{
|
|
{"f", OP_FORMAT, 1},
|
|
{ 0, 0, 0 }
|
|
};
|
|
|
|
/* Parse arguments. */
|
|
format = FORMAT_NATURAL;
|
|
formatFound = 0;
|
|
oind = 0;
|
|
while (1)
|
|
{
|
|
int opt = mi_getopt ("-var-evaluate-expression", argc, argv,
|
|
opts, &oind, &oarg);
|
|
|
|
if (opt < 0)
|
|
break;
|
|
switch ((enum opt) opt)
|
|
{
|
|
case OP_FORMAT:
|
|
if (formatFound)
|
|
error (_("Cannot specify format more than once"));
|
|
|
|
format = mi_parse_format (oarg);
|
|
formatFound = 1;
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (oind >= argc)
|
|
error (_("Usage: [-f FORMAT] NAME"));
|
|
|
|
if (oind < argc - 1)
|
|
error (_("Garbage at end of command"));
|
|
|
|
/* Get varobj handle, if a valid var obj name was specified. */
|
|
var = varobj_get_handle (argv[oind]);
|
|
|
|
if (formatFound)
|
|
{
|
|
std::string val = varobj_get_formatted_value (var, format);
|
|
|
|
uiout->field_string ("value", val.c_str ());
|
|
}
|
|
else
|
|
{
|
|
std::string val = varobj_get_value (var);
|
|
|
|
uiout->field_string ("value", val.c_str ());
|
|
}
|
|
}
|
|
|
|
void
|
|
mi_cmd_var_assign (const char *command, char **argv, int argc)
|
|
{
|
|
struct ui_out *uiout = current_uiout;
|
|
struct varobj *var;
|
|
|
|
if (argc != 2)
|
|
error (_("-var-assign: Usage: NAME EXPRESSION."));
|
|
|
|
/* Get varobj handle, if a valid var obj name was specified. */
|
|
var = varobj_get_handle (argv[0]);
|
|
|
|
if (!varobj_editable_p (var))
|
|
error (_("-var-assign: Variable object is not editable"));
|
|
|
|
const char *expression = argv[1];
|
|
|
|
/* MI command '-var-assign' may write memory, so suppress memory
|
|
changed notification if it does. */
|
|
scoped_restore save_suppress
|
|
= make_scoped_restore (&mi_suppress_notification.memory, 1);
|
|
|
|
if (!varobj_set_value (var, expression))
|
|
error (_("-var-assign: Could not assign "
|
|
"expression to variable object"));
|
|
|
|
std::string val = varobj_get_value (var);
|
|
uiout->field_string ("value", val.c_str ());
|
|
}
|
|
|
|
/* Type used for parameters passing to mi_cmd_var_update_iter. */
|
|
|
|
struct mi_cmd_var_update
|
|
{
|
|
int only_floating;
|
|
enum print_values print_values;
|
|
};
|
|
|
|
/* Helper for mi_cmd_var_update - update each VAR. */
|
|
|
|
static void
|
|
mi_cmd_var_update_iter (struct varobj *var, void *data_pointer)
|
|
{
|
|
struct mi_cmd_var_update *data = (struct mi_cmd_var_update *) data_pointer;
|
|
bool thread_stopped;
|
|
|
|
int thread_id = varobj_get_thread_id (var);
|
|
|
|
if (thread_id == -1)
|
|
{
|
|
thread_stopped = (inferior_ptid == null_ptid
|
|
|| inferior_thread ()->state == THREAD_STOPPED);
|
|
}
|
|
else
|
|
{
|
|
thread_info *tp = find_thread_global_id (thread_id);
|
|
|
|
thread_stopped = (tp == NULL
|
|
|| tp->state == THREAD_STOPPED);
|
|
}
|
|
|
|
if (thread_stopped
|
|
&& (!data->only_floating || varobj_floating_p (var)))
|
|
varobj_update_one (var, data->print_values, false /* implicit */);
|
|
}
|
|
|
|
void
|
|
mi_cmd_var_update (const char *command, char **argv, int argc)
|
|
{
|
|
struct ui_out *uiout = current_uiout;
|
|
char *name;
|
|
enum print_values print_values;
|
|
|
|
if (argc != 1 && argc != 2)
|
|
error (_("-var-update: Usage: [PRINT_VALUES] NAME."));
|
|
|
|
if (argc == 1)
|
|
name = argv[0];
|
|
else
|
|
name = argv[1];
|
|
|
|
if (argc == 2)
|
|
print_values = mi_parse_print_values (argv[0]);
|
|
else
|
|
print_values = PRINT_NO_VALUES;
|
|
|
|
/* For historical reasons this might emit a list or a tuple, so we
|
|
construct one or the other. */
|
|
gdb::optional<ui_out_emit_tuple> tuple_emitter;
|
|
gdb::optional<ui_out_emit_list> list_emitter;
|
|
|
|
if (mi_version (uiout) <= 1)
|
|
tuple_emitter.emplace (uiout, "changelist");
|
|
else
|
|
list_emitter.emplace (uiout, "changelist");
|
|
|
|
/* Check if the parameter is a "*", which means that we want to
|
|
update all variables. */
|
|
|
|
if ((*name == '*' || *name == '@') && (*(name + 1) == '\0'))
|
|
{
|
|
struct mi_cmd_var_update data;
|
|
|
|
data.only_floating = (*name == '@');
|
|
data.print_values = print_values;
|
|
|
|
/* varobj_update_one automatically updates all the children of
|
|
VAROBJ. Therefore update each VAROBJ only once by iterating
|
|
only the root VAROBJs. */
|
|
|
|
all_root_varobjs (mi_cmd_var_update_iter, &data);
|
|
}
|
|
else
|
|
{
|
|
/* Get varobj handle, if a valid var obj name was specified. */
|
|
struct varobj *var = varobj_get_handle (name);
|
|
|
|
varobj_update_one (var, print_values, true /* explicit */);
|
|
}
|
|
}
|
|
|
|
/* Helper for mi_cmd_var_update(). */
|
|
|
|
static void
|
|
varobj_update_one (struct varobj *var, enum print_values print_values,
|
|
bool is_explicit)
|
|
{
|
|
struct ui_out *uiout = current_uiout;
|
|
|
|
std::vector<varobj_update_result> changes = varobj_update (&var, is_explicit);
|
|
|
|
for (const varobj_update_result &r : changes)
|
|
{
|
|
int from, to;
|
|
|
|
gdb::optional<ui_out_emit_tuple> tuple_emitter;
|
|
if (mi_version (uiout) > 1)
|
|
tuple_emitter.emplace (uiout, nullptr);
|
|
uiout->field_string ("name", varobj_get_objname (r.varobj));
|
|
|
|
switch (r.status)
|
|
{
|
|
case VAROBJ_IN_SCOPE:
|
|
if (mi_print_value_p (r.varobj, print_values))
|
|
{
|
|
std::string val = varobj_get_value (r.varobj);
|
|
|
|
uiout->field_string ("value", val.c_str ());
|
|
}
|
|
uiout->field_string ("in_scope", "true");
|
|
break;
|
|
case VAROBJ_NOT_IN_SCOPE:
|
|
uiout->field_string ("in_scope", "false");
|
|
break;
|
|
case VAROBJ_INVALID:
|
|
uiout->field_string ("in_scope", "invalid");
|
|
break;
|
|
}
|
|
|
|
if (r.status != VAROBJ_INVALID)
|
|
{
|
|
if (r.type_changed)
|
|
uiout->field_string ("type_changed", "true");
|
|
else
|
|
uiout->field_string ("type_changed", "false");
|
|
}
|
|
|
|
if (r.type_changed)
|
|
{
|
|
std::string type_name = varobj_get_type (r.varobj);
|
|
|
|
uiout->field_string ("new_type", type_name.c_str ());
|
|
}
|
|
|
|
if (r.type_changed || r.children_changed)
|
|
uiout->field_signed ("new_num_children",
|
|
varobj_get_num_children (r.varobj));
|
|
|
|
gdb::unique_xmalloc_ptr<char> display_hint
|
|
= varobj_get_display_hint (r.varobj);
|
|
if (display_hint)
|
|
uiout->field_string ("displayhint", display_hint.get ());
|
|
|
|
if (varobj_is_dynamic_p (r.varobj))
|
|
uiout->field_signed ("dynamic", 1);
|
|
|
|
varobj_get_child_range (r.varobj, &from, &to);
|
|
uiout->field_signed ("has_more", varobj_has_more (r.varobj, to));
|
|
|
|
if (!r.newobj.empty ())
|
|
{
|
|
ui_out_emit_list list_emitter (uiout, "new_children");
|
|
|
|
for (varobj *child : r.newobj)
|
|
{
|
|
ui_out_emit_tuple inner_tuple_emitter (uiout, NULL);
|
|
print_varobj (child, print_values, 1 /* print_expression */);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
void
|
|
mi_cmd_enable_pretty_printing (const char *command, char **argv, int argc)
|
|
{
|
|
if (argc != 0)
|
|
error (_("-enable-pretty-printing: no arguments allowed"));
|
|
|
|
varobj_enable_pretty_printing ();
|
|
}
|
|
|
|
void
|
|
mi_cmd_var_set_update_range (const char *command, char **argv, int argc)
|
|
{
|
|
struct varobj *var;
|
|
int from, to;
|
|
|
|
if (argc != 3)
|
|
error (_("-var-set-update-range: Usage: VAROBJ FROM TO"));
|
|
|
|
var = varobj_get_handle (argv[0]);
|
|
from = atoi (argv[1]);
|
|
to = atoi (argv[2]);
|
|
|
|
varobj_set_child_range (var, from, to);
|
|
}
|