mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-15 04:31:49 +08:00
493ffac5aa
My original implementation for LDI32 pseudo does not conform to the TI ABI. I wrongly documented my TI PRU ELF object files inspection, which got propagated into my binutils implementation. Issue was exposed when running the GCC ABI testsuite against TI toolchain. According to TI ABI, LDI32 must use first LDI instruction to load the MSB 16bits, and second LDI instruction for the LSB 16bits. This patch will break binary compatibility with previously released binutils versions for PRU. Still, I think it is better to fix binutils to conform to the chip vendor ABI. bfd * elf32-pru.c (pru_elf32_do_ldi32_relocate): Make LDI32 relocation conformant to TI ABI. (pru_elf32_relax_section): Likewise. (pru_elf_relax_delete_bytes): Fix offsets for new LDI32 code. * elf32-pru.c (pru_elf32_do_ldi32_relocate): Ignore addend. (pru_elf32_pmem_relocate): Trap - should not get here. (pru_elf32_relocate_section): Add support for REL relocations. (elf_info_to_howto_rel): Enable REL. (elf_backend_may_use_rel_p): Likewise. (elf_backend_may_use_rela_p): Likewise. (elf_backend_default_use_rela_p): Likewise. gas * config/tc-pru.c (md_apply_fix): Make LDI32 relocation conformant to TI ABI. (pru_assemble_arg_i): Likewise. (output_insn_ldi32): Likewise. * testsuite/gas/pru/ldi.d: Update test for the now fixed LDI32. * gas/config/tc-pru.c (pru_assemble_arg_b): Check imm8 operand range. * gas/testsuite/gas/pru/illegal2.l: New test. * gas/testsuite/gas/pru/illegal2.s: New test. * gas/testsuite/gas/pru/pru.exp: Register new illegal2 test. ld * scripttempl/pru.sc: Add LD sections to allow linking TI toolchain object files. * scripttempl/pru.sc: Switch to init_array. * testsuite/ld-pru/ldi32.d: Update LDI32 test to conform to TI ABI. * testsuite/ld-pru/norelax_ldi32-data.d: Likewise. * testsuite/ld-pru/norelax_ldi32-dis.d: Likewise. * testsuite/ld-pru/relax_ldi32-data.d: Likewise. * testsuite/ld-pru/relax_ldi32-dis.d: Likewise.
28 lines
798 B
D
28 lines
798 B
D
#name: PRU LDI32 relaxation
|
|
#source: relax_ldi32.s
|
|
#source: relax_ldi32_symbol.s
|
|
#as: --mlink-relax
|
|
#ld: --relax
|
|
#objdump: -dr --prefix-addresses
|
|
|
|
# Test the LDI32 relaxation
|
|
.*: +file format elf32-pru
|
|
|
|
Disassembly of section .text:
|
|
..000000 <[^>]*> ldi r16.w2, 57005
|
|
..000004 <[^>]*> ldi r16.w0, 48879
|
|
..000008 <[^>]*> loop ..00003c <__end_loop>, r22
|
|
..00000c <[^>]*> ldi r16.w2, 57005
|
|
..000010 <[^>]*> ldi r16.w0, 48879
|
|
..000014 <[^>]*> ldi r16, 52938
|
|
..000018 <[^>]*> ldi r0, 52938
|
|
..00001c <[^>]*> ldi r16.w2, 1
|
|
..000020 <[^>]*> ldi r16.w0, 52938
|
|
..000024 <[^>]*> ldi r16.w2, 57004
|
|
..000028 <[^>]*> ldi r16.w0, 48879
|
|
..00002c <[^>]*> ldi r16.w2, 4660
|
|
..000030 <[^>]*> ldi r16.w0, 22136
|
|
..000034 <[^>]*> ldi r16, 22136
|
|
..000038 <[^>]*> ldi r16, 16
|
|
..00003c <[^>]*> qba ..000008 <__intermediate>
|