Go to file
Tom de Vries 55c3ad8801 [gdb/testsuite] Prevent pagination in GDB_INTERNALFLAGS
When running test-case gdb.base/corefile.exp with target board readnow, we run
into:
...
Reading symbols from outputs/gdb.base/corefile/corefile...^M
Expanding full symbols from outputs/gdb.base/corefile/corefile...^M
[New LWP 2293]^M
Core was generated by `outputs/gdb.base/corefile/co'.^M
Program terminated with signal SIGABRT, Aborted.^M
--Type <RET> for more, q to quit, c to continue without paging--\
  FAIL: gdb.base/corefile.exp: (timeout) starting with -core
...

In commit bd447abb24 "Make gdb.base/corefile.exp work on terminals with few
rows", pagination (in the same test-case) is prevented using:
...
set stty_init "rows 25 cols 80"
...
but this doesn't work in our case because using -readnow adds an extra line
"Expanding full symbols".

The test passes when increasing rows to 26.  However, increasing the rows by
some n only fixes the problem for n lines, and things will break again if
somehow we end up with n + 1 lines.

Instead, fix this by setting heigth and width in INTERNAL_GDBFLAGS.  This
solution was not chosen in commit bd447abb24 because it doesn't handle
pagination due to the introduction text.  But it does handle the pagination
due to the extra "Expanding full symbols", and any other line printed during
and after file loading.

Tested on x86_64-linux, with and without readnow.

With -readnow, fixes timeout FAILs in gdb.base/corefile.exp and
gdb.base/reread-readsym.exp.

gdb/testsuite/ChangeLog:

2020-10-26  Tom de Vries  <tdevries@suse.de>

	* lib/gdb.exp (INTERNAL_GDBFLAGS): Set heigth and width.
2020-10-26 16:05:15 +01:00
bfd Automatic date update in version.in 2020-10-26 00:00:07 +00:00
binutils binutils: Report error message on error 2020-10-22 04:48:29 -07:00
config
contrib
cpu
elfcpp gold: Update GNU_PROPERTY_X86_XXX macros 2020-10-13 05:21:05 -07:00
etc
gas gas: Clear all auto-assigned file slots 2020-10-26 06:16:21 -07:00
gdb [gdb/testsuite] Prevent pagination in GDB_INTERNALFLAGS 2020-10-26 16:05:15 +01:00
gdbserver gdb: move ptrace.m4 to gdbsupport 2020-10-25 21:08:49 -04:00
gdbsupport gdb: move ptrace.m4 to gdbsupport 2020-10-25 21:08:49 -04:00
gnulib gnulib: Ensure all libraries are used when building gdb/gdbserver 2020-10-09 09:31:43 +01:00
gold gold: Skip bootstrap-test/bootstrap-test-r for LTO build 2020-10-22 07:03:59 -07:00
gprof
include CSKY: Add version flag in eflag and fix bug in disassembling register. 2020-10-26 16:20:10 +08:00
intl
ld Invoke the linker's error handling script with the keyword "undefined-symbol" when using it to help with undefined symbol errors. 2020-10-26 12:39:50 +00:00
libctf Remove libctf/mkerrors.sed 2020-10-21 11:52:17 -06:00
libdecnumber
libiberty
opcodes CSKY: Change plsl.u16 to plsl.16. 2020-10-26 16:26:32 +08:00
readline
sim sim: move ChangeLog entries into the correct files 2020-10-22 13:39:26 +01:00
texinfo
zlib
.cvsignore
.gitattributes
.gitignore
ar-lib
ChangeLog gdb/gdbserver: add dependencies for distclean-gnulib 2020-10-14 15:05:14 +01:00
compile
config-ml.in
config.guess
config.rpath
config.sub
configure
configure.ac
COPYING
COPYING3
COPYING3.LIB
COPYING.LIB
COPYING.LIBGLOSS
COPYING.NEWLIB
depcomp
djunpack.bat
install-sh
libtool.m4
lt~obsolete.m4
ltgcc.m4
ltmain.sh
ltoptions.m4
ltsugar.m4
ltversion.m4
MAINTAINERS
Makefile.def gdb/gdbserver: add dependencies for distclean-gnulib 2020-10-14 15:05:14 +01:00
Makefile.in gdb/gdbserver: add dependencies for distclean-gnulib 2020-10-14 15:05:14 +01:00
Makefile.tpl
makefile.vms
missing
mkdep
mkinstalldirs
move-if-change
multilib.am
README
README-maintainer-mode
setup.com
src-release.sh
symlink-tree
test-driver
ylwrap

		   README for GNU development tools

This directory contains various GNU compilers, assemblers, linkers, 
debuggers, etc., plus their support routines, definitions, and documentation.

If you are receiving this as part of a GDB release, see the file gdb/README.
If with a binutils release, see binutils/README;  if with a libg++ release,
see libg++/README, etc.  That'll give you info about this
package -- supported targets, how to use it, how to report bugs, etc.

It is now possible to automatically configure and build a variety of
tools with one command.  To build all of the tools contained herein,
run the ``configure'' script here, e.g.:

	./configure 
	make

To install them (by default in /usr/local/bin, /usr/local/lib, etc),
then do:
	make install

(If the configure script can't determine your type of computer, give it
the name as an argument, for instance ``./configure sun4''.  You can
use the script ``config.sub'' to test whether a name is recognized; if
it is, config.sub translates it to a triplet specifying CPU, vendor,
and OS.)

If you have more than one compiler on your system, it is often best to
explicitly set CC in the environment before running configure, and to
also set CC when running make.  For example (assuming sh/bash/ksh):

	CC=gcc ./configure
	make

A similar example using csh:

	setenv CC gcc
	./configure
	make

Much of the code and documentation enclosed is copyright by
the Free Software Foundation, Inc.  See the file COPYING or
COPYING.LIB in the various directories, for a description of the
GNU General Public License terms under which you can copy the files.

REPORTING BUGS: Again, see gdb/README, binutils/README, etc., for info
on where and how to report problems.