mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-03-07 13:39:43 +08:00
348fe36b1d
ERROR should really be reserved for errors in the testsuite framework, not just normal errors from the tools under test. Removing use of perror has been suggested before but without action, over concerns that some test failures might be missed. This patch removes uses of perror in ld_assemble, ld_compile and ld_nm, and updates numerous places that ignored the result of these functions by inappropriately returning an "unresolved" test status. Net result over my large set of targets look good, in some cases improving the diagnostics, eg: i386-msdos -ERROR: tmpdir/script: nm failed i386-msdos -ERROR: tmpdir/script: nm failed i386-msdos -ERROR: tmpdir/script: nm failed i386-msdos -ERROR: tmpdir/script: nm failed i386-msdos +FAIL: script i386-msdos +FAIL: MRI script i386-msdos +FAIL: MEMORY i386-msdos +FAIL: MEMORY with symbols * testsuite/lib/ld-lib.exp (default_ld_compile): Don't perror on a compiler error. (default_ld_assemble): Similarly for an assembler error. (default_ld_nm): Similarly for an nm error. (run_ld_link_tests): Report ld_assemble errors as a fail. (check_as_cfi): Remove now unnecessary perror substitution. * testsuite/ld-elf/exclude.exp: Report ld_nm error return as test fails rather then unresolved. * testsuite/ld-gc/gc.exp: Likewise. * testsuite/ld-scripts/alignof.exp: Likewise. * testsuite/ld-scripts/defined.exp: Likewise. * testsuite/ld-scripts/script.exp: Likewise. * testsuite/ld-scripts/sizeof.exp: Likewise. * testsuite/ld-selective/selective.exp: Likewise. * testsuite/ld-scripts/extern.exp: Likewise. Return on ld_link failure. * testsuite/ld-elfweak/elfweak.exp: Report compiler errors as test unresolved. * testsuite/ld-fastcall/fastcall.exp: Report assember errors as test fails. * testsuite/ld-i386/i386.exp (iamcu_tests): Likewise. * testsuite/ld-ia64/line.exp: Likewise. * testsuite/ld-mep/mep.exp: Likewise. * testsuite/ld-mips-elf/mips-elf-flags.exp: Likewise. * testsuite/ld-nios2/nios2.exp: Likewise. * testsuite/ld-scripts/alignof.exp: Likewise. * testsuite/ld-x86-64/line.exp: Likewise. * testsuite/ld-x86-64/x86-64.exp: Likewise. * testsuite/ld-scripts/log2.exp: Formatting. * testsuite/ld-tic6x/tic6x.exp: Report ld_link errors as a test fail. |
||
|---|---|---|
| .. | ||
| abi-note.d | ||
| abi-note.s | ||
| all-debug-sections.d | ||
| all-debug-sections.s | ||
| dummy.s | ||
| gc.c | ||
| gc.exp | ||
| libpersonality.s | ||
| noent.d | ||
| noent.s | ||
| personality.d | ||
| personality.s | ||
| pr11218-1.c | ||
| pr11218-2.c | ||
| pr11218.d | ||
| pr13683.c | ||
| pr13683.d | ||
| pr14265.c | ||
| pr14265.d | ||
| pr14265.t | ||
| pr18223.d | ||
| pr18223.s | ||
| pr19161-1.c | ||
| pr19161-2.c | ||
| pr19161.d | ||
| pr19167.d | ||
| pr19167a.s | ||
| pr19167b.s | ||
| pr20022.d | ||
| pr20022a.s | ||
| pr20022b.s | ||
| pr20306.c | ||
| pr20306.d | ||
| pr20882.d | ||
| pr20882a.s | ||
| pr20882b.s | ||
| pr20882c.s | ||
| skip-map-discarded.d | ||
| skip-map-discarded.map | ||
| skip-map-discarded.s | ||
| start.d | ||
| start.s | ||
| stop.d | ||
| stop.s | ||