mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
6bd434d6ca
I'm trying to enable clang's -Wmissing-variable-declarations warning. This patch fixes all the obvious spots where we can simply add "static" (at least, found when building on x86-64 Linux). gdb/ChangeLog: * aarch64-linux-tdep.c (aarch64_linux_record_tdep): Make static. * aarch64-tdep.c (tdesc_aarch64_list, aarch64_prologue_unwind, aarch64_stub_unwind, aarch64_normal_base, ): Make static. * arm-linux-tdep.c (arm_prologue_unwind): Make static. * arm-tdep.c (struct frame_unwind): Make static. * auto-load.c (auto_load_safe_path_vec): Make static. * csky-tdep.c (csky_stub_unwind): Make static. * gdbarch.c (gdbarch_data_registry): Make static. * gnu-v2-abi.c (gnu_v2_abi_ops): Make static. * i386-netbsd-tdep.c (i386nbsd_mc_reg_offset): Make static. * i386-tdep.c (i386_frame_setup_skip_insns, i386_tramp_chain_in_reg_insns, i386_tramp_chain_on_stack_insns): Make static. * infrun.c (observer_mode): Make static. * linux-nat.c (sigchld_action): Make static. * linux-thread-db.c (thread_db_list): Make static. * maint-test-options.c (maintenance_test_options_list): * mep-tdep.c (mep_csr_registers): Make static. * mi/mi-cmds.c (struct mi_cmd_stats): Remove struct type name. (stats): Make static. * nat/linux-osdata.c (struct osdata_type): Make static. * ppc-netbsd-tdep.c (ppcnbsd_reg_offsets): Make static. * progspace.c (last_program_space_num): Make static. * python/py-param.c (struct parm_constant): Remove struct type name. (parm_constants): Make static. * python/py-record-btrace.c (btpy_list_methods): Make static. * python/py-record.c (recpy_gap_type): Make static. * record.c (record_goto_cmdlist): Make static. * regcache.c (regcache_descr_handle): Make static. * registry.h (DEFINE_REGISTRY): Make definition static. * symmisc.c (std_in, std_out, std_err): Make static. * top.c (previous_saved_command_line): Make static. * tracepoint.c (trace_user, trace_notes, trace_stop_notes): Make static. * unittests/command-def-selftests.c (nr_duplicates, nr_invalid_prefixcmd, lists): Make static. * unittests/observable-selftests.c (test_notification): Make static. * unittests/optional/assignment/1.cc (counter): Make static. * unittests/optional/assignment/2.cc (counter): Make static. * unittests/optional/assignment/3.cc (counter): Make static. * unittests/optional/assignment/4.cc (counter): Make static. * unittests/optional/assignment/5.cc (counter): Make static. * unittests/optional/assignment/6.cc (counter): Make static. gdbserver/ChangeLog: * ax.cc (bytecode_address_table): Make static. * debug.cc (debug_file): Make static. * linux-low.cc (stopping_threads): Make static. (step_over_bkpt): Make static. * linux-x86-low.cc (amd64_emit_ops, i386_emit_ops): Make static. * tracepoint.cc (stop_tracing_bkpt, flush_trace_buffer_bkpt, alloced_trace_state_variables, trace_buffer_ctrl, tracing_start_time, tracing_stop_time, tracing_user_name, tracing_notes, tracing_stop_note): Make static. Change-Id: Ic1d8034723b7802502bda23770893be2338ab020
137 lines
3.8 KiB
C
137 lines
3.8 KiB
C
/* Self tests for gdb::observers, GDB notifications to observers.
|
|
|
|
Copyright (C) 2003-2021 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "gdbsupport/selftest.h"
|
|
#include "gdbsupport/observable.h"
|
|
|
|
namespace selftests {
|
|
namespace observers {
|
|
|
|
static gdb::observers::observable<int> test_notification ("test_notification");
|
|
|
|
static int test_first_observer = 0;
|
|
static int test_second_observer = 0;
|
|
static int test_third_observer = 0;
|
|
|
|
static void
|
|
test_first_notification_function (int arg)
|
|
{
|
|
test_first_observer++;
|
|
}
|
|
|
|
static void
|
|
test_second_notification_function (int arg)
|
|
{
|
|
test_second_observer++;
|
|
}
|
|
|
|
static void
|
|
test_third_notification_function (int arg)
|
|
{
|
|
test_third_observer++;
|
|
}
|
|
|
|
static void
|
|
notify_check_counters (int one, int two, int three)
|
|
{
|
|
/* Reset. */
|
|
test_first_observer = 0;
|
|
test_second_observer = 0;
|
|
test_third_observer = 0;
|
|
/* Notify. */
|
|
test_notification.notify (0);
|
|
/* Check. */
|
|
SELF_CHECK (one == test_first_observer);
|
|
SELF_CHECK (two == test_second_observer);
|
|
SELF_CHECK (three == test_third_observer);
|
|
}
|
|
|
|
static void
|
|
run_tests ()
|
|
{
|
|
/* First, try sending a notification without any observer
|
|
attached. */
|
|
notify_check_counters (0, 0, 0);
|
|
|
|
const gdb::observers::token token1 {}, token2 {} , token3 {};
|
|
|
|
/* Now, attach one observer, and send a notification. */
|
|
test_notification.attach (&test_second_notification_function, token2);
|
|
notify_check_counters (0, 1, 0);
|
|
|
|
/* Remove the observer, and send a notification. */
|
|
test_notification.detach (token2);
|
|
notify_check_counters (0, 0, 0);
|
|
|
|
/* With a new observer. */
|
|
test_notification.attach (&test_first_notification_function, token1);
|
|
notify_check_counters (1, 0, 0);
|
|
|
|
/* With 2 observers. */
|
|
test_notification.attach (&test_second_notification_function, token2);
|
|
notify_check_counters (1, 1, 0);
|
|
|
|
/* With 3 observers. */
|
|
test_notification.attach (&test_third_notification_function, token3);
|
|
notify_check_counters (1, 1, 1);
|
|
|
|
/* Remove middle observer. */
|
|
test_notification.detach (token2);
|
|
notify_check_counters (1, 0, 1);
|
|
|
|
/* Remove first observer. */
|
|
test_notification.detach (token1);
|
|
notify_check_counters (0, 0, 1);
|
|
|
|
/* Remove last observer. */
|
|
test_notification.detach (token3);
|
|
notify_check_counters (0, 0, 0);
|
|
|
|
/* Go back to 3 observers, and remove them in a different
|
|
order... */
|
|
test_notification.attach (&test_first_notification_function, token1);
|
|
test_notification.attach (&test_second_notification_function, token2);
|
|
test_notification.attach (&test_third_notification_function, token3);
|
|
notify_check_counters (1, 1, 1);
|
|
|
|
/* Remove the third observer. */
|
|
test_notification.detach (token3);
|
|
notify_check_counters (1, 1, 0);
|
|
|
|
/* Remove the second observer. */
|
|
test_notification.detach (token2);
|
|
notify_check_counters (1, 0, 0);
|
|
|
|
/* Remove first observer, no more observers. */
|
|
test_notification.detach (token1);
|
|
notify_check_counters (0, 0, 0);
|
|
}
|
|
|
|
} /* namespace observers */
|
|
} /* namespace selftests */
|
|
|
|
void _initialize_observer_selftest ();
|
|
void
|
|
_initialize_observer_selftest ()
|
|
{
|
|
selftests::register_test ("gdb::observers",
|
|
selftests::observers::run_tests);
|
|
}
|