mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
cce0ae568c
The previous patch to add -prompt/-lbl to gdb_test introduced a regression: Before, you could specify an explicit empty message to indicate you didn't want to PASS, like so: gdb_test COMMAND PATTERN "" After said patch, gdb_test no longer distinguishes no-message-specified vs empty-message, so tests that previously would be silent on PASS, now started emitting PASS messages based on COMMAND. This in turn introduced a number of PATH/DUPLICATE violations in the testsuite. This commit fixes all the regressions I could see. This patch uses the new -nopass feature introduced in the previous commit, but tries to avoid it if possible. Most of the patch fixes DUPLICATE issues the usual way, of using with_test_prefix or explicit unique messages. See previous commit's log for more info. In addition to looking for DUPLICATEs, I also looked for cases where we would now end up with an empty message in gdb.sum, due to a gdb_test being passed both no message and empty command. E.g., this in gdb.ada/bp_reset.exp: gdb_run_cmd gdb_test "" "Breakpoint $decimal, foo\\.nested_sub \\(\\).*" was resulting in this in gdb.sum: PASS: gdb.ada/bp_reset.exp: I fixed such cases by passing an explicit message. We may want to make such cases error out. Tested on x86_64 GNU/Linux, native and native-extended-gdbserver. I see zero PATH cases now. I get zero DUPLICATEs with native testing now. I still see some DUPLICATEs with native-extended-gdbserver, but those were preexisting, unrelated to the gdb_test change. Change-Id: I5375f23f073493e0672190a0ec2e847938a580b2
115 lines
3.5 KiB
Plaintext
115 lines
3.5 KiB
Plaintext
# Copyright 2005-2022 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
load_lib "ada.exp"
|
|
|
|
if { [skip_ada_tests] } { return -1 }
|
|
|
|
# This testcase verifies the behavior of the `start' command, which
|
|
# does not work when we use the gdb stub...
|
|
if [use_gdb_stub] {
|
|
untested "skipping tests due to use_gdb_stub"
|
|
return
|
|
}
|
|
|
|
standard_ada_testfile first
|
|
|
|
# Build the first test program (note that cygwin needs the $EXEEXT).
|
|
if {[gdb_compile_ada "${srcfile}" "${binfile}$EXEEXT" executable {debug}] != ""} {
|
|
return -1
|
|
}
|
|
|
|
# Build the second test program
|
|
set srcfile2 ${srcdir}/${subdir}/${testdir}/second.adb
|
|
set binfile2 [standard_output_file second$EXEEXT]
|
|
|
|
if {[gdb_compile_ada "${srcfile2}" "${binfile2}" executable {debug}] != ""} {
|
|
return -1
|
|
}
|
|
|
|
# Start with a fresh gdb.
|
|
|
|
set common_binfile [standard_output_file common$EXEEXT]
|
|
|
|
gdb_start
|
|
gdb_reinitialize_dir $srcdir/$subdir
|
|
|
|
# Load the first executable.
|
|
|
|
gdb_test "shell mv ${binfile} ${common_binfile}" "" \
|
|
"shell mv \${binfile} \${common_binfile}"
|
|
gdb_load ${common_binfile}
|
|
|
|
# Start the program, we should land in the program main procedure
|
|
if { [gdb_start_cmd] < 0 } {
|
|
untested start
|
|
return -1
|
|
}
|
|
|
|
gdb_test "" \
|
|
"first \\(\\) at .*first.adb.*" \
|
|
"start first"
|
|
|
|
# Restore first executable to its original name, and move
|
|
# second executable into its place. Ensure that the new
|
|
# executable is at least a second newer than the old.
|
|
|
|
gdb_test "shell mv ${common_binfile} ${binfile}" "" \
|
|
"shell mv \${common_binfile} \${binfile}"
|
|
gdb_test "shell mv ${binfile2} ${common_binfile}" "" \
|
|
"shell mv \${binfile2} \${common_binfile}"
|
|
gdb_test "shell sleep 1" "" "shell sleep 1, once"
|
|
gdb_test "shell touch ${common_binfile}" "" \
|
|
"shell touch \${common_binfile}"
|
|
|
|
# Start the program a second time, GDB should land in procedure Second
|
|
# this time.
|
|
|
|
if { [gdb_start_cmd] < 0 } {
|
|
fail "start second"
|
|
} else {
|
|
gdb_test "" \
|
|
"second \\(\\) at .*second.adb.*" \
|
|
"start second"
|
|
}
|
|
|
|
# Try again, this time with just changing the file time of first.
|
|
|
|
clean_restart "${binfile}$EXEEXT"
|
|
|
|
# Ensure we don't accidently use the main symbol cache.
|
|
gdb_test_no_output "mt set symbol-cache-size 0"
|
|
|
|
# Put something in the symbol lookup cache that will get looked up when
|
|
# starting after having re-read symbols. PR 17855.
|
|
gdb_breakpoint break_me
|
|
|
|
gdb_test "shell touch ${binfile}$EXEEXT" "" \
|
|
"shell touch \${binfile}\$EXEEXT"
|
|
gdb_test "shell sleep 1" "" "shell sleep 1, twice"
|
|
|
|
if { [gdb_start_cmd] < 0 } {
|
|
# PR 17855: At this point gdb may have crashed or gotten an internal
|
|
# error, but we still need to detect this. Just issue any simple command
|
|
# to verify gdb is still running. This will establish in gdb.log whether
|
|
# gdb is still running.
|
|
gdb_test_no_output "set \$check_gdb_running = 0" "check gdb running"
|
|
fail "start just first"
|
|
} else {
|
|
gdb_test "" \
|
|
"first \\(\\) at .*first.adb.*" \
|
|
"start just first"
|
|
}
|