mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
a3b60e4588
Some unaligned watchpoints were currently missed. On old kernels as specified in kernel RFE: aarch64: ptrace: BAS: Support any contiguous range (edit) https://sourceware.org/bugzilla/show_bug.cgi?id=20207 after this patch some other unaligned watchpoints will get reported as false positives. With new kernels all the watchpoints should work exactly. There may be a regresion that it now less merges watchpoints so that with multiple overlapping watchpoints it may run out of the 4 hardware watchpoint registers. But as discussed in the original thread GDB needs some generic watchpoints merging framework to be used by all the target specific code. Even current FSF GDB code does not merge it perfectly. Also with the more precise watchpoints one can technically merge them less. And I do not think it matters too much to improve mergeability only for old kernels. Still even on new kernels some better merging logic would make sense. There remains one issue: kernel-4.15.14-300.fc27.armv7hl FAIL: gdb.base/watchpoint-unaligned.exp: continue FAIL: gdb.base/watchpoint-unaligned.exp: continue (gdb) continue Continuing. Unexpected error setting watchpoint: Invalid argument. (gdb) FAIL: gdb.base/watchpoint-unaligned.exp: continue But that looks as a kernel bug to me. (1) It is not a regression by this patch. (2) It is unrelated to this patch. gdb/ChangeLog 2018-05-04 Jan Kratochvil <jan.kratochvil@redhat.com> Pedro Alves <palves@redhat.com> PR breakpoints/19806 and support for PR external/20207. * NEWS: Mention Aarch64 watchpoint improvements. * aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed watchpoints and PR external/20207 watchpoints. * nat/aarch64-linux-hw-point.c (kernel_supports_any_contiguous_range): New. (aarch64_watchpoint_offset): New. (aarch64_watchpoint_length): Support PR external/20207 watchpoints. (aarch64_point_encode_ctrl_reg): New parameter offset, new asserts. (aarch64_point_is_aligned): Support PR external/20207 watchpoints. (aarch64_align_watchpoint): New parameters aligned_offset_p and next_addr_orig_p. Support PR external/20207 watchpoints. (aarch64_downgrade_regs): New. (aarch64_dr_state_insert_one_point): New parameters offset and addr_orig. (aarch64_dr_state_remove_one_point): Likewise. (aarch64_handle_breakpoint): Update caller. (aarch64_handle_aligned_watchpoint): Likewise. (aarch64_handle_unaligned_watchpoint): Support addr_orig and aligned_offset. (aarch64_linux_set_debug_regs): Remove const from state. Call aarch64_downgrade_regs. (aarch64_show_debug_reg_state): Print also dr_addr_orig_wp. * nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ... (DR_CONTROL_MASK): ... this. (struct aarch64_debug_reg_state): New field dr_addr_orig_wp. (unsigned int aarch64_watchpoint_offset): New prototype. (aarch64_linux_set_debug_regs): Remove const from state. * utils.c (align_up, align_down): Move to ... * common/common-utils.c (align_up, align_down): ... here. * utils.h (align_up, align_down): Move to ... * common/common-utils.h (align_up, align_down): ... here. gdb/gdbserver/ChangeLog 2018-05-04 Jan Kratochvil <jan.kratochvil@redhat.com> Pedro Alves <palves@redhat.com> * linux-aarch64-low.c (aarch64_stopped_data_address): Likewise. gdb/testsuite/ChangeLog 2018-05-04 Jan Kratochvil <jan.kratochvil@redhat.com> Pedro Alves <palves@redhat.com> PR breakpoints/19806 and support for PR external/20207. * gdb.base/watchpoint-unaligned.c: New file. * gdb.base/watchpoint-unaligned.exp: New file.
868 lines
25 KiB
C
868 lines
25 KiB
C
/* Native-dependent code for GNU/Linux AArch64.
|
||
|
||
Copyright (C) 2011-2018 Free Software Foundation, Inc.
|
||
Contributed by ARM Ltd.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
#include "defs.h"
|
||
|
||
#include "inferior.h"
|
||
#include "gdbcore.h"
|
||
#include "regcache.h"
|
||
#include "linux-nat.h"
|
||
#include "target-descriptions.h"
|
||
#include "auxv.h"
|
||
#include "gdbcmd.h"
|
||
#include "aarch64-tdep.h"
|
||
#include "aarch64-linux-tdep.h"
|
||
#include "aarch32-linux-nat.h"
|
||
#include "nat/aarch64-linux.h"
|
||
#include "nat/aarch64-linux-hw-point.h"
|
||
|
||
#include "elf/external.h"
|
||
#include "elf/common.h"
|
||
|
||
#include "nat/gdb_ptrace.h"
|
||
#include <sys/utsname.h>
|
||
#include <asm/ptrace.h>
|
||
|
||
#include "gregset.h"
|
||
|
||
/* Defines ps_err_e, struct ps_prochandle. */
|
||
#include "gdb_proc_service.h"
|
||
|
||
#ifndef TRAP_HWBKPT
|
||
#define TRAP_HWBKPT 0x0004
|
||
#endif
|
||
|
||
class aarch64_linux_nat_target final : public linux_nat_target
|
||
{
|
||
public:
|
||
/* Add our register access methods. */
|
||
void fetch_registers (struct regcache *, int) override;
|
||
void store_registers (struct regcache *, int) override;
|
||
|
||
const struct target_desc *read_description () override;
|
||
|
||
/* Add our hardware breakpoint and watchpoint implementation. */
|
||
int can_use_hw_breakpoint (enum bptype, int, int) override;
|
||
int insert_hw_breakpoint (struct gdbarch *, struct bp_target_info *) override;
|
||
int remove_hw_breakpoint (struct gdbarch *, struct bp_target_info *) override;
|
||
int region_ok_for_hw_watchpoint (CORE_ADDR, int) override;
|
||
int insert_watchpoint (CORE_ADDR, int, enum target_hw_bp_type,
|
||
struct expression *) override;
|
||
int remove_watchpoint (CORE_ADDR, int, enum target_hw_bp_type,
|
||
struct expression *) override;
|
||
bool stopped_by_watchpoint () override;
|
||
bool stopped_data_address (CORE_ADDR *) override;
|
||
bool watchpoint_addr_within_range (CORE_ADDR, CORE_ADDR, int) override;
|
||
|
||
int can_do_single_step () override;
|
||
|
||
/* Override the GNU/Linux inferior startup hook. */
|
||
void post_startup_inferior (ptid_t) override;
|
||
|
||
/* These three defer to common nat/ code. */
|
||
void low_new_thread (struct lwp_info *lp) override
|
||
{ aarch64_linux_new_thread (lp); }
|
||
void low_delete_thread (struct arch_lwp_info *lp) override
|
||
{ aarch64_linux_delete_thread (lp); }
|
||
void low_prepare_to_resume (struct lwp_info *lp) override
|
||
{ aarch64_linux_prepare_to_resume (lp); }
|
||
|
||
void low_new_fork (struct lwp_info *parent, pid_t child_pid) override;
|
||
void low_forget_process (pid_t pid) override;
|
||
|
||
/* Add our siginfo layout converter. */
|
||
bool low_siginfo_fixup (siginfo_t *ptrace, gdb_byte *inf, int direction)
|
||
override;
|
||
};
|
||
|
||
static aarch64_linux_nat_target the_aarch64_linux_nat_target;
|
||
|
||
/* Per-process data. We don't bind this to a per-inferior registry
|
||
because of targets like x86 GNU/Linux that need to keep track of
|
||
processes that aren't bound to any inferior (e.g., fork children,
|
||
checkpoints). */
|
||
|
||
struct aarch64_process_info
|
||
{
|
||
/* Linked list. */
|
||
struct aarch64_process_info *next;
|
||
|
||
/* The process identifier. */
|
||
pid_t pid;
|
||
|
||
/* Copy of aarch64 hardware debug registers. */
|
||
struct aarch64_debug_reg_state state;
|
||
};
|
||
|
||
static struct aarch64_process_info *aarch64_process_list = NULL;
|
||
|
||
/* Find process data for process PID. */
|
||
|
||
static struct aarch64_process_info *
|
||
aarch64_find_process_pid (pid_t pid)
|
||
{
|
||
struct aarch64_process_info *proc;
|
||
|
||
for (proc = aarch64_process_list; proc; proc = proc->next)
|
||
if (proc->pid == pid)
|
||
return proc;
|
||
|
||
return NULL;
|
||
}
|
||
|
||
/* Add process data for process PID. Returns newly allocated info
|
||
object. */
|
||
|
||
static struct aarch64_process_info *
|
||
aarch64_add_process (pid_t pid)
|
||
{
|
||
struct aarch64_process_info *proc;
|
||
|
||
proc = XCNEW (struct aarch64_process_info);
|
||
proc->pid = pid;
|
||
|
||
proc->next = aarch64_process_list;
|
||
aarch64_process_list = proc;
|
||
|
||
return proc;
|
||
}
|
||
|
||
/* Get data specific info for process PID, creating it if necessary.
|
||
Never returns NULL. */
|
||
|
||
static struct aarch64_process_info *
|
||
aarch64_process_info_get (pid_t pid)
|
||
{
|
||
struct aarch64_process_info *proc;
|
||
|
||
proc = aarch64_find_process_pid (pid);
|
||
if (proc == NULL)
|
||
proc = aarch64_add_process (pid);
|
||
|
||
return proc;
|
||
}
|
||
|
||
/* Called whenever GDB is no longer debugging process PID. It deletes
|
||
data structures that keep track of debug register state. */
|
||
|
||
void
|
||
aarch64_linux_nat_target::low_forget_process (pid_t pid)
|
||
{
|
||
struct aarch64_process_info *proc, **proc_link;
|
||
|
||
proc = aarch64_process_list;
|
||
proc_link = &aarch64_process_list;
|
||
|
||
while (proc != NULL)
|
||
{
|
||
if (proc->pid == pid)
|
||
{
|
||
*proc_link = proc->next;
|
||
|
||
xfree (proc);
|
||
return;
|
||
}
|
||
|
||
proc_link = &proc->next;
|
||
proc = *proc_link;
|
||
}
|
||
}
|
||
|
||
/* Get debug registers state for process PID. */
|
||
|
||
struct aarch64_debug_reg_state *
|
||
aarch64_get_debug_reg_state (pid_t pid)
|
||
{
|
||
return &aarch64_process_info_get (pid)->state;
|
||
}
|
||
|
||
/* Fill GDB's register array with the general-purpose register values
|
||
from the current thread. */
|
||
|
||
static void
|
||
fetch_gregs_from_thread (struct regcache *regcache)
|
||
{
|
||
int ret, tid;
|
||
struct gdbarch *gdbarch = regcache->arch ();
|
||
elf_gregset_t regs;
|
||
struct iovec iovec;
|
||
|
||
/* Make sure REGS can hold all registers contents on both aarch64
|
||
and arm. */
|
||
gdb_static_assert (sizeof (regs) >= 18 * 4);
|
||
|
||
tid = ptid_get_lwp (regcache_get_ptid (regcache));
|
||
|
||
iovec.iov_base = ®s;
|
||
if (gdbarch_bfd_arch_info (gdbarch)->bits_per_word == 32)
|
||
iovec.iov_len = 18 * 4;
|
||
else
|
||
iovec.iov_len = sizeof (regs);
|
||
|
||
ret = ptrace (PTRACE_GETREGSET, tid, NT_PRSTATUS, &iovec);
|
||
if (ret < 0)
|
||
perror_with_name (_("Unable to fetch general registers."));
|
||
|
||
if (gdbarch_bfd_arch_info (gdbarch)->bits_per_word == 32)
|
||
aarch32_gp_regcache_supply (regcache, (uint32_t *) regs, 1);
|
||
else
|
||
{
|
||
int regno;
|
||
|
||
for (regno = AARCH64_X0_REGNUM; regno <= AARCH64_CPSR_REGNUM; regno++)
|
||
regcache_raw_supply (regcache, regno, ®s[regno - AARCH64_X0_REGNUM]);
|
||
}
|
||
}
|
||
|
||
/* Store to the current thread the valid general-purpose register
|
||
values in the GDB's register array. */
|
||
|
||
static void
|
||
store_gregs_to_thread (const struct regcache *regcache)
|
||
{
|
||
int ret, tid;
|
||
elf_gregset_t regs;
|
||
struct iovec iovec;
|
||
struct gdbarch *gdbarch = regcache->arch ();
|
||
|
||
/* Make sure REGS can hold all registers contents on both aarch64
|
||
and arm. */
|
||
gdb_static_assert (sizeof (regs) >= 18 * 4);
|
||
tid = ptid_get_lwp (regcache_get_ptid (regcache));
|
||
|
||
iovec.iov_base = ®s;
|
||
if (gdbarch_bfd_arch_info (gdbarch)->bits_per_word == 32)
|
||
iovec.iov_len = 18 * 4;
|
||
else
|
||
iovec.iov_len = sizeof (regs);
|
||
|
||
ret = ptrace (PTRACE_GETREGSET, tid, NT_PRSTATUS, &iovec);
|
||
if (ret < 0)
|
||
perror_with_name (_("Unable to fetch general registers."));
|
||
|
||
if (gdbarch_bfd_arch_info (gdbarch)->bits_per_word == 32)
|
||
aarch32_gp_regcache_collect (regcache, (uint32_t *) regs, 1);
|
||
else
|
||
{
|
||
int regno;
|
||
|
||
for (regno = AARCH64_X0_REGNUM; regno <= AARCH64_CPSR_REGNUM; regno++)
|
||
if (REG_VALID == regcache_register_status (regcache, regno))
|
||
regcache_raw_collect (regcache, regno,
|
||
®s[regno - AARCH64_X0_REGNUM]);
|
||
}
|
||
|
||
ret = ptrace (PTRACE_SETREGSET, tid, NT_PRSTATUS, &iovec);
|
||
if (ret < 0)
|
||
perror_with_name (_("Unable to store general registers."));
|
||
}
|
||
|
||
/* Fill GDB's register array with the fp/simd register values
|
||
from the current thread. */
|
||
|
||
static void
|
||
fetch_fpregs_from_thread (struct regcache *regcache)
|
||
{
|
||
int ret, tid;
|
||
elf_fpregset_t regs;
|
||
struct iovec iovec;
|
||
struct gdbarch *gdbarch = regcache->arch ();
|
||
|
||
/* Make sure REGS can hold all VFP registers contents on both aarch64
|
||
and arm. */
|
||
gdb_static_assert (sizeof regs >= VFP_REGS_SIZE);
|
||
|
||
tid = ptid_get_lwp (regcache_get_ptid (regcache));
|
||
|
||
iovec.iov_base = ®s;
|
||
|
||
if (gdbarch_bfd_arch_info (gdbarch)->bits_per_word == 32)
|
||
{
|
||
iovec.iov_len = VFP_REGS_SIZE;
|
||
|
||
ret = ptrace (PTRACE_GETREGSET, tid, NT_ARM_VFP, &iovec);
|
||
if (ret < 0)
|
||
perror_with_name (_("Unable to fetch VFP registers."));
|
||
|
||
aarch32_vfp_regcache_supply (regcache, (gdb_byte *) ®s, 32);
|
||
}
|
||
else
|
||
{
|
||
int regno;
|
||
|
||
iovec.iov_len = sizeof (regs);
|
||
|
||
ret = ptrace (PTRACE_GETREGSET, tid, NT_FPREGSET, &iovec);
|
||
if (ret < 0)
|
||
perror_with_name (_("Unable to fetch vFP/SIMD registers."));
|
||
|
||
for (regno = AARCH64_V0_REGNUM; regno <= AARCH64_V31_REGNUM; regno++)
|
||
regcache_raw_supply (regcache, regno,
|
||
®s.vregs[regno - AARCH64_V0_REGNUM]);
|
||
|
||
regcache_raw_supply (regcache, AARCH64_FPSR_REGNUM, ®s.fpsr);
|
||
regcache_raw_supply (regcache, AARCH64_FPCR_REGNUM, ®s.fpcr);
|
||
}
|
||
}
|
||
|
||
/* Store to the current thread the valid fp/simd register
|
||
values in the GDB's register array. */
|
||
|
||
static void
|
||
store_fpregs_to_thread (const struct regcache *regcache)
|
||
{
|
||
int ret, tid;
|
||
elf_fpregset_t regs;
|
||
struct iovec iovec;
|
||
struct gdbarch *gdbarch = regcache->arch ();
|
||
|
||
/* Make sure REGS can hold all VFP registers contents on both aarch64
|
||
and arm. */
|
||
gdb_static_assert (sizeof regs >= VFP_REGS_SIZE);
|
||
tid = ptid_get_lwp (regcache_get_ptid (regcache));
|
||
|
||
iovec.iov_base = ®s;
|
||
|
||
if (gdbarch_bfd_arch_info (gdbarch)->bits_per_word == 32)
|
||
{
|
||
iovec.iov_len = VFP_REGS_SIZE;
|
||
|
||
ret = ptrace (PTRACE_GETREGSET, tid, NT_ARM_VFP, &iovec);
|
||
if (ret < 0)
|
||
perror_with_name (_("Unable to fetch VFP registers."));
|
||
|
||
aarch32_vfp_regcache_collect (regcache, (gdb_byte *) ®s, 32);
|
||
}
|
||
else
|
||
{
|
||
int regno;
|
||
|
||
iovec.iov_len = sizeof (regs);
|
||
|
||
ret = ptrace (PTRACE_GETREGSET, tid, NT_FPREGSET, &iovec);
|
||
if (ret < 0)
|
||
perror_with_name (_("Unable to fetch FP/SIMD registers."));
|
||
|
||
for (regno = AARCH64_V0_REGNUM; regno <= AARCH64_V31_REGNUM; regno++)
|
||
if (REG_VALID == regcache_register_status (regcache, regno))
|
||
regcache_raw_collect (regcache, regno,
|
||
(char *) ®s.vregs[regno - AARCH64_V0_REGNUM]);
|
||
|
||
if (REG_VALID == regcache_register_status (regcache, AARCH64_FPSR_REGNUM))
|
||
regcache_raw_collect (regcache, AARCH64_FPSR_REGNUM,
|
||
(char *) ®s.fpsr);
|
||
if (REG_VALID == regcache_register_status (regcache, AARCH64_FPCR_REGNUM))
|
||
regcache_raw_collect (regcache, AARCH64_FPCR_REGNUM,
|
||
(char *) ®s.fpcr);
|
||
}
|
||
|
||
if (gdbarch_bfd_arch_info (gdbarch)->bits_per_word == 32)
|
||
{
|
||
ret = ptrace (PTRACE_SETREGSET, tid, NT_ARM_VFP, &iovec);
|
||
if (ret < 0)
|
||
perror_with_name (_("Unable to store VFP registers."));
|
||
}
|
||
else
|
||
{
|
||
ret = ptrace (PTRACE_SETREGSET, tid, NT_FPREGSET, &iovec);
|
||
if (ret < 0)
|
||
perror_with_name (_("Unable to store FP/SIMD registers."));
|
||
}
|
||
}
|
||
|
||
/* Implement the "fetch_registers" target_ops method. */
|
||
|
||
void
|
||
aarch64_linux_nat_target::fetch_registers (struct regcache *regcache,
|
||
int regno)
|
||
{
|
||
if (regno == -1)
|
||
{
|
||
fetch_gregs_from_thread (regcache);
|
||
fetch_fpregs_from_thread (regcache);
|
||
}
|
||
else if (regno < AARCH64_V0_REGNUM)
|
||
fetch_gregs_from_thread (regcache);
|
||
else
|
||
fetch_fpregs_from_thread (regcache);
|
||
}
|
||
|
||
/* Implement the "store_registers" target_ops method. */
|
||
|
||
void
|
||
aarch64_linux_nat_target::store_registers (struct regcache *regcache,
|
||
int regno)
|
||
{
|
||
if (regno == -1)
|
||
{
|
||
store_gregs_to_thread (regcache);
|
||
store_fpregs_to_thread (regcache);
|
||
}
|
||
else if (regno < AARCH64_V0_REGNUM)
|
||
store_gregs_to_thread (regcache);
|
||
else
|
||
store_fpregs_to_thread (regcache);
|
||
}
|
||
|
||
/* Fill register REGNO (if it is a general-purpose register) in
|
||
*GREGSETPS with the value in GDB's register array. If REGNO is -1,
|
||
do this for all registers. */
|
||
|
||
void
|
||
fill_gregset (const struct regcache *regcache,
|
||
gdb_gregset_t *gregsetp, int regno)
|
||
{
|
||
regcache_collect_regset (&aarch64_linux_gregset, regcache,
|
||
regno, (gdb_byte *) gregsetp,
|
||
AARCH64_LINUX_SIZEOF_GREGSET);
|
||
}
|
||
|
||
/* Fill GDB's register array with the general-purpose register values
|
||
in *GREGSETP. */
|
||
|
||
void
|
||
supply_gregset (struct regcache *regcache, const gdb_gregset_t *gregsetp)
|
||
{
|
||
regcache_supply_regset (&aarch64_linux_gregset, regcache, -1,
|
||
(const gdb_byte *) gregsetp,
|
||
AARCH64_LINUX_SIZEOF_GREGSET);
|
||
}
|
||
|
||
/* Fill register REGNO (if it is a floating-point register) in
|
||
*FPREGSETP with the value in GDB's register array. If REGNO is -1,
|
||
do this for all registers. */
|
||
|
||
void
|
||
fill_fpregset (const struct regcache *regcache,
|
||
gdb_fpregset_t *fpregsetp, int regno)
|
||
{
|
||
regcache_collect_regset (&aarch64_linux_fpregset, regcache,
|
||
regno, (gdb_byte *) fpregsetp,
|
||
AARCH64_LINUX_SIZEOF_FPREGSET);
|
||
}
|
||
|
||
/* Fill GDB's register array with the floating-point register values
|
||
in *FPREGSETP. */
|
||
|
||
void
|
||
supply_fpregset (struct regcache *regcache, const gdb_fpregset_t *fpregsetp)
|
||
{
|
||
regcache_supply_regset (&aarch64_linux_fpregset, regcache, -1,
|
||
(const gdb_byte *) fpregsetp,
|
||
AARCH64_LINUX_SIZEOF_FPREGSET);
|
||
}
|
||
|
||
/* linux_nat_new_fork hook. */
|
||
|
||
void
|
||
aarch64_linux_nat_target::low_new_fork (struct lwp_info *parent,
|
||
pid_t child_pid)
|
||
{
|
||
pid_t parent_pid;
|
||
struct aarch64_debug_reg_state *parent_state;
|
||
struct aarch64_debug_reg_state *child_state;
|
||
|
||
/* NULL means no watchpoint has ever been set in the parent. In
|
||
that case, there's nothing to do. */
|
||
if (parent->arch_private == NULL)
|
||
return;
|
||
|
||
/* GDB core assumes the child inherits the watchpoints/hw
|
||
breakpoints of the parent, and will remove them all from the
|
||
forked off process. Copy the debug registers mirrors into the
|
||
new process so that all breakpoints and watchpoints can be
|
||
removed together. */
|
||
|
||
parent_pid = ptid_get_pid (parent->ptid);
|
||
parent_state = aarch64_get_debug_reg_state (parent_pid);
|
||
child_state = aarch64_get_debug_reg_state (child_pid);
|
||
*child_state = *parent_state;
|
||
}
|
||
|
||
|
||
/* Called by libthread_db. Returns a pointer to the thread local
|
||
storage (or its descriptor). */
|
||
|
||
ps_err_e
|
||
ps_get_thread_area (struct ps_prochandle *ph,
|
||
lwpid_t lwpid, int idx, void **base)
|
||
{
|
||
int is_64bit_p
|
||
= (gdbarch_bfd_arch_info (target_gdbarch ())->bits_per_word == 64);
|
||
|
||
return aarch64_ps_get_thread_area (ph, lwpid, idx, base, is_64bit_p);
|
||
}
|
||
|
||
|
||
/* Implement the "post_startup_inferior" target_ops method. */
|
||
|
||
void
|
||
aarch64_linux_nat_target::post_startup_inferior (ptid_t ptid)
|
||
{
|
||
low_forget_process (ptid_get_pid (ptid));
|
||
aarch64_linux_get_debug_reg_capacity (ptid_get_pid (ptid));
|
||
linux_nat_target::post_startup_inferior (ptid);
|
||
}
|
||
|
||
extern struct target_desc *tdesc_arm_with_neon;
|
||
|
||
/* Implement the "read_description" target_ops method. */
|
||
|
||
const struct target_desc *
|
||
aarch64_linux_nat_target::read_description ()
|
||
{
|
||
int ret, tid;
|
||
gdb_byte regbuf[VFP_REGS_SIZE];
|
||
struct iovec iovec;
|
||
|
||
tid = ptid_get_lwp (inferior_ptid);
|
||
|
||
iovec.iov_base = regbuf;
|
||
iovec.iov_len = VFP_REGS_SIZE;
|
||
|
||
ret = ptrace (PTRACE_GETREGSET, tid, NT_ARM_VFP, &iovec);
|
||
if (ret == 0)
|
||
return tdesc_arm_with_neon;
|
||
else
|
||
return aarch64_read_description ();
|
||
}
|
||
|
||
/* Convert a native/host siginfo object, into/from the siginfo in the
|
||
layout of the inferiors' architecture. Returns true if any
|
||
conversion was done; false otherwise. If DIRECTION is 1, then copy
|
||
from INF to NATIVE. If DIRECTION is 0, copy from NATIVE to
|
||
INF. */
|
||
|
||
bool
|
||
aarch64_linux_nat_target::low_siginfo_fixup (siginfo_t *native, gdb_byte *inf,
|
||
int direction)
|
||
{
|
||
struct gdbarch *gdbarch = get_frame_arch (get_current_frame ());
|
||
|
||
/* Is the inferior 32-bit? If so, then do fixup the siginfo
|
||
object. */
|
||
if (gdbarch_bfd_arch_info (gdbarch)->bits_per_word == 32)
|
||
{
|
||
if (direction == 0)
|
||
aarch64_compat_siginfo_from_siginfo ((struct compat_siginfo *) inf,
|
||
native);
|
||
else
|
||
aarch64_siginfo_from_compat_siginfo (native,
|
||
(struct compat_siginfo *) inf);
|
||
|
||
return true;
|
||
}
|
||
|
||
return false;
|
||
}
|
||
|
||
/* Returns the number of hardware watchpoints of type TYPE that we can
|
||
set. Value is positive if we can set CNT watchpoints, zero if
|
||
setting watchpoints of type TYPE is not supported, and negative if
|
||
CNT is more than the maximum number of watchpoints of type TYPE
|
||
that we can support. TYPE is one of bp_hardware_watchpoint,
|
||
bp_read_watchpoint, bp_write_watchpoint, or bp_hardware_breakpoint.
|
||
CNT is the number of such watchpoints used so far (including this
|
||
one). OTHERTYPE is non-zero if other types of watchpoints are
|
||
currently enabled. */
|
||
|
||
int
|
||
aarch64_linux_nat_target::can_use_hw_breakpoint (enum bptype type,
|
||
int cnt, int othertype)
|
||
{
|
||
if (type == bp_hardware_watchpoint || type == bp_read_watchpoint
|
||
|| type == bp_access_watchpoint || type == bp_watchpoint)
|
||
{
|
||
if (aarch64_num_wp_regs == 0)
|
||
return 0;
|
||
}
|
||
else if (type == bp_hardware_breakpoint)
|
||
{
|
||
if (aarch64_num_bp_regs == 0)
|
||
return 0;
|
||
}
|
||
else
|
||
gdb_assert_not_reached ("unexpected breakpoint type");
|
||
|
||
/* We always return 1 here because we don't have enough information
|
||
about possible overlap of addresses that they want to watch. As an
|
||
extreme example, consider the case where all the watchpoints watch
|
||
the same address and the same region length: then we can handle a
|
||
virtually unlimited number of watchpoints, due to debug register
|
||
sharing implemented via reference counts. */
|
||
return 1;
|
||
}
|
||
|
||
/* Insert a hardware-assisted breakpoint at BP_TGT->reqstd_address.
|
||
Return 0 on success, -1 on failure. */
|
||
|
||
int
|
||
aarch64_linux_nat_target::insert_hw_breakpoint (struct gdbarch *gdbarch,
|
||
struct bp_target_info *bp_tgt)
|
||
{
|
||
int ret;
|
||
CORE_ADDR addr = bp_tgt->placed_address = bp_tgt->reqstd_address;
|
||
int len;
|
||
const enum target_hw_bp_type type = hw_execute;
|
||
struct aarch64_debug_reg_state *state
|
||
= aarch64_get_debug_reg_state (ptid_get_pid (inferior_ptid));
|
||
|
||
gdbarch_breakpoint_from_pc (gdbarch, &addr, &len);
|
||
|
||
if (show_debug_regs)
|
||
fprintf_unfiltered
|
||
(gdb_stdlog,
|
||
"insert_hw_breakpoint on entry (addr=0x%08lx, len=%d))\n",
|
||
(unsigned long) addr, len);
|
||
|
||
ret = aarch64_handle_breakpoint (type, addr, len, 1 /* is_insert */, state);
|
||
|
||
if (show_debug_regs)
|
||
{
|
||
aarch64_show_debug_reg_state (state,
|
||
"insert_hw_breakpoint", addr, len, type);
|
||
}
|
||
|
||
return ret;
|
||
}
|
||
|
||
/* Remove a hardware-assisted breakpoint at BP_TGT->placed_address.
|
||
Return 0 on success, -1 on failure. */
|
||
|
||
int
|
||
aarch64_linux_nat_target::remove_hw_breakpoint (struct gdbarch *gdbarch,
|
||
struct bp_target_info *bp_tgt)
|
||
{
|
||
int ret;
|
||
CORE_ADDR addr = bp_tgt->placed_address;
|
||
int len = 4;
|
||
const enum target_hw_bp_type type = hw_execute;
|
||
struct aarch64_debug_reg_state *state
|
||
= aarch64_get_debug_reg_state (ptid_get_pid (inferior_ptid));
|
||
|
||
gdbarch_breakpoint_from_pc (gdbarch, &addr, &len);
|
||
|
||
if (show_debug_regs)
|
||
fprintf_unfiltered
|
||
(gdb_stdlog, "remove_hw_breakpoint on entry (addr=0x%08lx, len=%d))\n",
|
||
(unsigned long) addr, len);
|
||
|
||
ret = aarch64_handle_breakpoint (type, addr, len, 0 /* is_insert */, state);
|
||
|
||
if (show_debug_regs)
|
||
{
|
||
aarch64_show_debug_reg_state (state,
|
||
"remove_hw_watchpoint", addr, len, type);
|
||
}
|
||
|
||
return ret;
|
||
}
|
||
|
||
/* Implement the "insert_watchpoint" target_ops method.
|
||
|
||
Insert a watchpoint to watch a memory region which starts at
|
||
address ADDR and whose length is LEN bytes. Watch memory accesses
|
||
of the type TYPE. Return 0 on success, -1 on failure. */
|
||
|
||
int
|
||
aarch64_linux_nat_target::insert_watchpoint (CORE_ADDR addr, int len,
|
||
enum target_hw_bp_type type,
|
||
struct expression *cond)
|
||
{
|
||
int ret;
|
||
struct aarch64_debug_reg_state *state
|
||
= aarch64_get_debug_reg_state (ptid_get_pid (inferior_ptid));
|
||
|
||
if (show_debug_regs)
|
||
fprintf_unfiltered (gdb_stdlog,
|
||
"insert_watchpoint on entry (addr=0x%08lx, len=%d)\n",
|
||
(unsigned long) addr, len);
|
||
|
||
gdb_assert (type != hw_execute);
|
||
|
||
ret = aarch64_handle_watchpoint (type, addr, len, 1 /* is_insert */, state);
|
||
|
||
if (show_debug_regs)
|
||
{
|
||
aarch64_show_debug_reg_state (state,
|
||
"insert_watchpoint", addr, len, type);
|
||
}
|
||
|
||
return ret;
|
||
}
|
||
|
||
/* Implement the "remove_watchpoint" target_ops method.
|
||
Remove a watchpoint that watched the memory region which starts at
|
||
address ADDR, whose length is LEN bytes, and for accesses of the
|
||
type TYPE. Return 0 on success, -1 on failure. */
|
||
|
||
int
|
||
aarch64_linux_nat_target::remove_watchpoint (CORE_ADDR addr, int len,
|
||
enum target_hw_bp_type type,
|
||
struct expression *cond)
|
||
{
|
||
int ret;
|
||
struct aarch64_debug_reg_state *state
|
||
= aarch64_get_debug_reg_state (ptid_get_pid (inferior_ptid));
|
||
|
||
if (show_debug_regs)
|
||
fprintf_unfiltered (gdb_stdlog,
|
||
"remove_watchpoint on entry (addr=0x%08lx, len=%d)\n",
|
||
(unsigned long) addr, len);
|
||
|
||
gdb_assert (type != hw_execute);
|
||
|
||
ret = aarch64_handle_watchpoint (type, addr, len, 0 /* is_insert */, state);
|
||
|
||
if (show_debug_regs)
|
||
{
|
||
aarch64_show_debug_reg_state (state,
|
||
"remove_watchpoint", addr, len, type);
|
||
}
|
||
|
||
return ret;
|
||
}
|
||
|
||
/* Implement the "region_ok_for_hw_watchpoint" target_ops method. */
|
||
|
||
int
|
||
aarch64_linux_nat_target::region_ok_for_hw_watchpoint (CORE_ADDR addr, int len)
|
||
{
|
||
return aarch64_linux_region_ok_for_watchpoint (addr, len);
|
||
}
|
||
|
||
/* Implement the "stopped_data_address" target_ops method. */
|
||
|
||
bool
|
||
aarch64_linux_nat_target::stopped_data_address (CORE_ADDR *addr_p)
|
||
{
|
||
siginfo_t siginfo;
|
||
int i, tid;
|
||
struct aarch64_debug_reg_state *state;
|
||
|
||
if (!linux_nat_get_siginfo (inferior_ptid, &siginfo))
|
||
return false;
|
||
|
||
/* This must be a hardware breakpoint. */
|
||
if (siginfo.si_signo != SIGTRAP
|
||
|| (siginfo.si_code & 0xffff) != TRAP_HWBKPT)
|
||
return false;
|
||
|
||
/* Check if the address matches any watched address. */
|
||
state = aarch64_get_debug_reg_state (ptid_get_pid (inferior_ptid));
|
||
for (i = aarch64_num_wp_regs - 1; i >= 0; --i)
|
||
{
|
||
const unsigned int offset
|
||
= aarch64_watchpoint_offset (state->dr_ctrl_wp[i]);
|
||
const unsigned int len = aarch64_watchpoint_length (state->dr_ctrl_wp[i]);
|
||
const CORE_ADDR addr_trap = (CORE_ADDR) siginfo.si_addr;
|
||
const CORE_ADDR addr_watch = state->dr_addr_wp[i] + offset;
|
||
const CORE_ADDR addr_watch_aligned = align_down (state->dr_addr_wp[i], 8);
|
||
const CORE_ADDR addr_orig = state->dr_addr_orig_wp[i];
|
||
|
||
if (state->dr_ref_count_wp[i]
|
||
&& DR_CONTROL_ENABLED (state->dr_ctrl_wp[i])
|
||
&& addr_trap >= addr_watch_aligned
|
||
&& addr_trap < addr_watch + len)
|
||
{
|
||
/* ADDR_TRAP reports the first address of the memory range
|
||
accessed by the CPU, regardless of what was the memory
|
||
range watched. Thus, a large CPU access that straddles
|
||
the ADDR_WATCH..ADDR_WATCH+LEN range may result in an
|
||
ADDR_TRAP that is lower than the
|
||
ADDR_WATCH..ADDR_WATCH+LEN range. E.g.:
|
||
|
||
addr: | 4 | 5 | 6 | 7 | 8 |
|
||
|---- range watched ----|
|
||
|----------- range accessed ------------|
|
||
|
||
In this case, ADDR_TRAP will be 4.
|
||
|
||
To match a watchpoint known to GDB core, we must never
|
||
report *ADDR_P outside of any ADDR_WATCH..ADDR_WATCH+LEN
|
||
range. ADDR_WATCH <= ADDR_TRAP < ADDR_ORIG is a false
|
||
positive on kernels older than 4.10. See PR
|
||
external/20207. */
|
||
*addr_p = addr_orig;
|
||
return true;
|
||
}
|
||
}
|
||
|
||
return false;
|
||
}
|
||
|
||
/* Implement the "stopped_by_watchpoint" target_ops method. */
|
||
|
||
bool
|
||
aarch64_linux_nat_target::stopped_by_watchpoint ()
|
||
{
|
||
CORE_ADDR addr;
|
||
|
||
return stopped_data_address (&addr);
|
||
}
|
||
|
||
/* Implement the "watchpoint_addr_within_range" target_ops method. */
|
||
|
||
bool
|
||
aarch64_linux_nat_target::watchpoint_addr_within_range (CORE_ADDR addr,
|
||
CORE_ADDR start, int length)
|
||
{
|
||
return start <= addr && start + length - 1 >= addr;
|
||
}
|
||
|
||
/* Implement the "can_do_single_step" target_ops method. */
|
||
|
||
int
|
||
aarch64_linux_nat_target::can_do_single_step ()
|
||
{
|
||
return 1;
|
||
}
|
||
|
||
/* Define AArch64 maintenance commands. */
|
||
|
||
static void
|
||
add_show_debug_regs_command (void)
|
||
{
|
||
/* A maintenance command to enable printing the internal DRi mirror
|
||
variables. */
|
||
add_setshow_boolean_cmd ("show-debug-regs", class_maintenance,
|
||
&show_debug_regs, _("\
|
||
Set whether to show variables that mirror the AArch64 debug registers."), _("\
|
||
Show whether to show variables that mirror the AArch64 debug registers."), _("\
|
||
Use \"on\" to enable, \"off\" to disable.\n\
|
||
If enabled, the debug registers values are shown when GDB inserts\n\
|
||
or removes a hardware breakpoint or watchpoint, and when the inferior\n\
|
||
triggers a breakpoint or watchpoint."),
|
||
NULL,
|
||
NULL,
|
||
&maintenance_set_cmdlist,
|
||
&maintenance_show_cmdlist);
|
||
}
|
||
|
||
void
|
||
_initialize_aarch64_linux_nat (void)
|
||
{
|
||
add_show_debug_regs_command ();
|
||
|
||
/* Register the target. */
|
||
linux_target = &the_aarch64_linux_nat_target;
|
||
add_inf_child_target (&the_aarch64_linux_nat_target);
|
||
}
|