mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
de63c46b54
At <https://sourceware.org/ml/gdb-patches/2017-12/msg00298.html>, Joel wrote: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Consider the following code which first declares a tagged type (the equivalent of a class in Ada), and then a procedure which takes a pointer (access) to this type's 'Class. package Pck is type Top_T is tagged record N : Integer := 1; end record; procedure Inspect (Obj: access Top_T'Class); end Pck; Putting a breakpoint in that procedure and then running to it triggers an internal error: (gdb) break inspect (gdb) continue Breakpoint 1, pck.inspect (obj=0x63e010 /[...]/gdb/stack.c:621: internal-error: void print_frame_args(symbol*, frame_info*, int, ui_file*): Assertion `nsym != NULL' failed. What's special about this subprogram is that it takes an access to what we call a 'Class type, and for implementation reasons, the compiler adds an extra argument named "objL". If you are curious why, it allows the compiler for perform dynamic accessibility checks that are mandated by the language. If we look at the location where we get the internal error (in stack.c), we find that we are looping over the symbol of each parameter, and for each parameter, we do: /* We have to look up the symbol because arguments can have two entries (one a parameter, one a local) and the one we want is the local, which lookup_symbol will find for us. [...] nsym = lookup_symbol (SYMBOL_LINKAGE_NAME (sym), b, VAR_DOMAIN, NULL).symbol; gdb_assert (nsym != NULL); The lookup_symbol goes through the lookup structure, which means the symbol's linkage name ("objL") gets transformed into a lookup_name_info object (in block_lookup_symbol), before it gets fed to the block symbol dictionary iterators. This, in turn, triggers the symbol matching by comparing the "lookup" name which, for Ada, means among other things, lowercasing the given name to "objl". It is this transformation that causes the lookup find no matches, and therefore trip this assertion. Going back to the "offending" call to lookup_symbol in stack.c, what we are trying to do, here, is do a lookup by linkage name. So, I think what we mean to be doing is a completely literal symbol lookup, so maybe not even strcmp_iw, but actually just plain strcmp??? In the past, in practice, you could get that effect by doing a lookup using the C language. But that doesn't work, because we still end up somehow using Ada's lookup_name routine which transforms "objL". So, ideally, as I hinted before, I think what we need is a way to perform a literal lookup so that searches by linkage names like the above can be performed. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This commit fixes the problem by implementing something similar to Joel's literal idea, but with some important differences. I considered adding a symbol_name_match_type::LINKAGE and supporting searching by linkage name for any language, but the problem with that is that the dictionaries only work with SYMBOL_SEARCH_NAME, because that's what is used for hashing. We'd need separate dictionaries for hashed linkage names. So with the current symbol tables infrastructure, it's not literal linkage names that we want to pass down, but instead literal _search_ names (SYMBOL_SEARCH_NAME, etc.). However, psymbols have no overload/function parameter info in C++, so a straight strcmp doesn't work properly for C++ name matching. So what we do is be a little less aggressive then and add a new symbol_name_match_type::SEARCH_SYMBOL instead that takes as input a non-user-input search symbol, and then we skip any decoding/demangling steps and make: - Ada treat that as a verbatim match, - other languages treat it as symbol_name_match_type::FULL. This also fixes the new '"maint check-psymtabs" for Ada' testcase for me (gdb.ada/maint_with_ada.exp). I've not removed the kfail yet because Joel still sees that testcase failing with this patch. That'll be fixed in follow up patches. gdb/ChangeLog: 2018-01-05 Pedro Alves <palves@redhat.com> PR gdb/22670 * ada-lang.c (literal_symbol_name_matcher): New function. (ada_get_symbol_name_matcher): Use it for symbol_name_match_type::SEARCH_NAME. * block.c (block_lookup_symbol): New parameter 'match_type'. Pass it down instead of assuming symbol_name_match_type::FULL. * block.h (block_lookup_symbol): New parameter 'match_type'. * c-valprint.c (print_unpacked_pointer): Use lookup_symbol_search_name instead of lookup_symbol. * compile/compile-object-load.c (get_out_value_type): Pass down symbol_name_match_type::SEARCH_NAME. * cp-namespace.c (cp_basic_lookup_symbol): Pass down symbol_name_match_type::FULL. * cp-support.c (cp_get_symbol_name_matcher): Handle symbol_name_match_type::SEARCH_NAME. * infrun.c (insert_exception_resume_breakpoint): Use lookup_symbol_search_name. * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name. * psymtab.c (maintenance_check_psymtabs): Use symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME. * stack.c (print_frame_args): Use lookup_symbol_search_name and SYMBOL_SEARCH_NAME. * symtab.c (lookup_local_symbol): Don't demangle the lookup name if symbol_name_match_type::SEARCH_NAME. (lookup_symbol_in_language): Pass down symbol_name_match_type::FULL. (lookup_symbol_search_name): New. (lookup_language_this): Pass down symbol_name_match_type::SEARCH_NAME. (lookup_symbol_aux, lookup_local_symbol): New parameter 'match_type'. Pass it down. * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator. (lookup_symbol_search_name): New declaration. (lookup_symbol_in_block): New 'match_type' parameter. gdb/testsuite/ChangeLog: 2018-01-05 Joel Brobecker <brobecker@adacore.com> PR gdb/22670 * gdb.ada/access_tagged_param.exp: New file. * gdb.ada/access_tagged_param/foo.adb: New file.
326 lines
11 KiB
C
326 lines
11 KiB
C
/* Code dealing with blocks for GDB.
|
|
|
|
Copyright (C) 2003-2018 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef BLOCK_H
|
|
#define BLOCK_H
|
|
|
|
#include "dictionary.h"
|
|
|
|
/* Opaque declarations. */
|
|
|
|
struct symbol;
|
|
struct compunit_symtab;
|
|
struct block_namespace_info;
|
|
struct using_direct;
|
|
struct obstack;
|
|
struct addrmap;
|
|
|
|
/* All of the name-scope contours of the program
|
|
are represented by `struct block' objects.
|
|
All of these objects are pointed to by the blockvector.
|
|
|
|
Each block represents one name scope.
|
|
Each lexical context has its own block.
|
|
|
|
The blockvector begins with some special blocks.
|
|
The GLOBAL_BLOCK contains all the symbols defined in this compilation
|
|
whose scope is the entire program linked together.
|
|
The STATIC_BLOCK contains all the symbols whose scope is the
|
|
entire compilation excluding other separate compilations.
|
|
Blocks starting with the FIRST_LOCAL_BLOCK are not special.
|
|
|
|
Each block records a range of core addresses for the code that
|
|
is in the scope of the block. The STATIC_BLOCK and GLOBAL_BLOCK
|
|
give, for the range of code, the entire range of code produced
|
|
by the compilation that the symbol segment belongs to.
|
|
|
|
The blocks appear in the blockvector
|
|
in order of increasing starting-address,
|
|
and, within that, in order of decreasing ending-address.
|
|
|
|
This implies that within the body of one function
|
|
the blocks appear in the order of a depth-first tree walk. */
|
|
|
|
struct block
|
|
{
|
|
|
|
/* Addresses in the executable code that are in this block. */
|
|
|
|
CORE_ADDR startaddr;
|
|
CORE_ADDR endaddr;
|
|
|
|
/* The symbol that names this block, if the block is the body of a
|
|
function (real or inlined); otherwise, zero. */
|
|
|
|
struct symbol *function;
|
|
|
|
/* The `struct block' for the containing block, or 0 if none.
|
|
|
|
The superblock of a top-level local block (i.e. a function in the
|
|
case of C) is the STATIC_BLOCK. The superblock of the
|
|
STATIC_BLOCK is the GLOBAL_BLOCK. */
|
|
|
|
struct block *superblock;
|
|
|
|
/* This is used to store the symbols in the block. */
|
|
|
|
struct dictionary *dict;
|
|
|
|
/* Contains information about namespace-related info relevant to this block:
|
|
using directives and the current namespace scope. */
|
|
|
|
struct block_namespace_info *namespace_info;
|
|
};
|
|
|
|
/* The global block is singled out so that we can provide a back-link
|
|
to the compunit symtab. */
|
|
|
|
struct global_block
|
|
{
|
|
/* The block. */
|
|
|
|
struct block block;
|
|
|
|
/* This holds a pointer to the compunit symtab holding this block. */
|
|
|
|
struct compunit_symtab *compunit_symtab;
|
|
};
|
|
|
|
#define BLOCK_START(bl) (bl)->startaddr
|
|
#define BLOCK_END(bl) (bl)->endaddr
|
|
#define BLOCK_FUNCTION(bl) (bl)->function
|
|
#define BLOCK_SUPERBLOCK(bl) (bl)->superblock
|
|
#define BLOCK_DICT(bl) (bl)->dict
|
|
#define BLOCK_NAMESPACE(bl) (bl)->namespace_info
|
|
|
|
struct blockvector
|
|
{
|
|
/* Number of blocks in the list. */
|
|
int nblocks;
|
|
/* An address map mapping addresses to blocks in this blockvector.
|
|
This pointer is zero if the blocks' start and end addresses are
|
|
enough. */
|
|
struct addrmap *map;
|
|
/* The blocks themselves. */
|
|
struct block *block[1];
|
|
};
|
|
|
|
#define BLOCKVECTOR_NBLOCKS(blocklist) (blocklist)->nblocks
|
|
#define BLOCKVECTOR_BLOCK(blocklist,n) (blocklist)->block[n]
|
|
#define BLOCKVECTOR_MAP(blocklist) ((blocklist)->map)
|
|
|
|
/* Return the objfile of BLOCK, which must be non-NULL. */
|
|
|
|
extern struct objfile *block_objfile (const struct block *block);
|
|
|
|
/* Return the architecture of BLOCK, which must be non-NULL. */
|
|
|
|
extern struct gdbarch *block_gdbarch (const struct block *block);
|
|
|
|
extern struct symbol *block_linkage_function (const struct block *);
|
|
|
|
extern struct symbol *block_containing_function (const struct block *);
|
|
|
|
extern int block_inlined_p (const struct block *block);
|
|
|
|
extern int contained_in (const struct block *, const struct block *);
|
|
|
|
extern const struct blockvector *blockvector_for_pc (CORE_ADDR,
|
|
const struct block **);
|
|
|
|
extern const struct blockvector *
|
|
blockvector_for_pc_sect (CORE_ADDR, struct obj_section *,
|
|
const struct block **, struct compunit_symtab *);
|
|
|
|
extern int blockvector_contains_pc (const struct blockvector *bv, CORE_ADDR pc);
|
|
|
|
extern struct call_site *call_site_for_pc (struct gdbarch *gdbarch,
|
|
CORE_ADDR pc);
|
|
|
|
extern const struct block *block_for_pc (CORE_ADDR);
|
|
|
|
extern const struct block *block_for_pc_sect (CORE_ADDR, struct obj_section *);
|
|
|
|
extern const char *block_scope (const struct block *block);
|
|
|
|
extern void block_set_scope (struct block *block, const char *scope,
|
|
struct obstack *obstack);
|
|
|
|
extern struct using_direct *block_using (const struct block *block);
|
|
|
|
extern void block_set_using (struct block *block,
|
|
struct using_direct *using_decl,
|
|
struct obstack *obstack);
|
|
|
|
extern const struct block *block_static_block (const struct block *block);
|
|
|
|
extern const struct block *block_global_block (const struct block *block);
|
|
|
|
extern struct block *allocate_block (struct obstack *obstack);
|
|
|
|
extern struct block *allocate_global_block (struct obstack *obstack);
|
|
|
|
extern void set_block_compunit_symtab (struct block *,
|
|
struct compunit_symtab *);
|
|
|
|
/* Return a property to evaluate the static link associated to BLOCK.
|
|
|
|
In the context of nested functions (available in Pascal, Ada and GNU C, for
|
|
instance), a static link (as in DWARF's DW_AT_static_link attribute) for a
|
|
function is a way to get the frame corresponding to the enclosing function.
|
|
|
|
Note that only objfile-owned and function-level blocks can have a static
|
|
link. Return NULL if there is no such property. */
|
|
|
|
extern struct dynamic_prop *block_static_link (const struct block *block);
|
|
|
|
/* A block iterator. This structure should be treated as though it
|
|
were opaque; it is only defined here because we want to support
|
|
stack allocation of iterators. */
|
|
|
|
struct block_iterator
|
|
{
|
|
/* If we're iterating over a single block, this holds the block.
|
|
Otherwise, it holds the canonical compunit. */
|
|
|
|
union
|
|
{
|
|
struct compunit_symtab *compunit_symtab;
|
|
const struct block *block;
|
|
} d;
|
|
|
|
/* If we're iterating over a single block, this is always -1.
|
|
Otherwise, it holds the index of the current "included" symtab in
|
|
the canonical symtab (that is, d.symtab->includes[idx]), with -1
|
|
meaning the canonical symtab itself. */
|
|
|
|
int idx;
|
|
|
|
/* Which block, either static or global, to iterate over. If this
|
|
is FIRST_LOCAL_BLOCK, then we are iterating over a single block.
|
|
This is used to select which field of 'd' is in use. */
|
|
|
|
enum block_enum which;
|
|
|
|
/* The underlying dictionary iterator. */
|
|
|
|
struct dict_iterator dict_iter;
|
|
};
|
|
|
|
/* Initialize ITERATOR to point at the first symbol in BLOCK, and
|
|
return that first symbol, or NULL if BLOCK is empty. */
|
|
|
|
extern struct symbol *block_iterator_first (const struct block *block,
|
|
struct block_iterator *iterator);
|
|
|
|
/* Advance ITERATOR, and return the next symbol, or NULL if there are
|
|
no more symbols. Don't call this if you've previously received
|
|
NULL from block_iterator_first or block_iterator_next on this
|
|
iteration. */
|
|
|
|
extern struct symbol *block_iterator_next (struct block_iterator *iterator);
|
|
|
|
/* Initialize ITERATOR to point at the first symbol in BLOCK whose
|
|
SYMBOL_SEARCH_NAME matches NAME, and return that first symbol, or
|
|
NULL if there are no such symbols. */
|
|
|
|
extern struct symbol *block_iter_match_first (const struct block *block,
|
|
const lookup_name_info &name,
|
|
struct block_iterator *iterator);
|
|
|
|
/* Advance ITERATOR to point at the next symbol in BLOCK whose
|
|
SYMBOL_SEARCH_NAME matches NAME, or NULL if there are no more such
|
|
symbols. Don't call this if you've previously received NULL from
|
|
block_iterator_match_first or block_iterator_match_next on this
|
|
iteration. And don't call it unless ITERATOR was created by a
|
|
previous call to block_iter_match_first with the same NAME. */
|
|
|
|
extern struct symbol *block_iter_match_next
|
|
(const lookup_name_info &name, struct block_iterator *iterator);
|
|
|
|
/* Search BLOCK for symbol NAME in DOMAIN. */
|
|
|
|
extern struct symbol *block_lookup_symbol (const struct block *block,
|
|
const char *name,
|
|
symbol_name_match_type match_type,
|
|
const domain_enum domain);
|
|
|
|
/* Search BLOCK for symbol NAME in DOMAIN but only in primary symbol table of
|
|
BLOCK. BLOCK must be STATIC_BLOCK or GLOBAL_BLOCK. Function is useful if
|
|
one iterates all global/static blocks of an objfile. */
|
|
|
|
extern struct symbol *block_lookup_symbol_primary (const struct block *block,
|
|
const char *name,
|
|
const domain_enum domain);
|
|
|
|
/* The type of the MATCHER argument to block_find_symbol. */
|
|
|
|
typedef int (block_symbol_matcher_ftype) (struct symbol *, void *);
|
|
|
|
/* Find symbol NAME in BLOCK and in DOMAIN that satisfies MATCHER.
|
|
DATA is passed unchanged to MATCHER.
|
|
BLOCK must be STATIC_BLOCK or GLOBAL_BLOCK. */
|
|
|
|
extern struct symbol *block_find_symbol (const struct block *block,
|
|
const char *name,
|
|
const domain_enum domain,
|
|
block_symbol_matcher_ftype *matcher,
|
|
void *data);
|
|
|
|
/* A matcher function for block_find_symbol to find only symbols with
|
|
non-opaque types. */
|
|
|
|
extern int block_find_non_opaque_type (struct symbol *sym, void *data);
|
|
|
|
/* A matcher function for block_find_symbol to prefer symbols with
|
|
non-opaque types. The way to use this function is as follows:
|
|
|
|
struct symbol *with_opaque = NULL;
|
|
struct symbol *sym
|
|
= block_find_symbol (block, name, domain,
|
|
block_find_non_opaque_type_preferred, &with_opaque);
|
|
|
|
At this point if SYM is non-NULL then a non-opaque type has been found.
|
|
Otherwise, if WITH_OPAQUE is non-NULL then an opaque type has been found.
|
|
Otherwise, the symbol was not found. */
|
|
|
|
extern int block_find_non_opaque_type_preferred (struct symbol *sym,
|
|
void *data);
|
|
|
|
/* Macro to loop through all symbols in BLOCK, in no particular
|
|
order. ITER helps keep track of the iteration, and must be a
|
|
struct block_iterator. SYM points to the current symbol. */
|
|
|
|
#define ALL_BLOCK_SYMBOLS(block, iter, sym) \
|
|
for ((sym) = block_iterator_first ((block), &(iter)); \
|
|
(sym); \
|
|
(sym) = block_iterator_next (&(iter)))
|
|
|
|
/* Macro to loop through all symbols in BLOCK with a name that matches
|
|
NAME, in no particular order. ITER helps keep track of the
|
|
iteration, and must be a struct block_iterator. SYM points to the
|
|
current symbol. */
|
|
|
|
#define ALL_BLOCK_SYMBOLS_WITH_NAME(block, name, iter, sym) \
|
|
for ((sym) = block_iter_match_first ((block), (name), &(iter)); \
|
|
(sym) != NULL; \
|
|
(sym) = block_iter_match_next ((name), &(iter)))
|
|
|
|
#endif /* BLOCK_H */
|