mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-15 04:31:49 +08:00
b4b1a226df
Rationale
---------
Let's say you have multiple threads hitting a conditional breakpoint
at the same time, and all of these are going to evaluate to false.
All these threads will need to be resumed.
Currently, GDB fetches one target event (one SIGTRAP representing the
breakpoint hit) and decides that the thread should be resumed. It
calls resume and commit_resume immediately. It then fetches the
second target event, and does the same, until it went through all
threads.
The result is therefore something like:
- consume event for thread A
- resume thread A
- commit resume (affects thread A)
- consume event for thread B
- resume thread B
- commit resume (affects thread B)
- consume event for thread C
- resume thread C
- commit resume (affects thread C)
For targets where it's beneficial to group resumptions requests (most
likely those that implement target_ops::commit_resume), it would be
much better to have:
- consume event for thread A
- resume thread A
- consume event for thread B
- resume thread B
- consume event for thread C
- resume thread C
- commit resume (affects threads A, B and C)
Implementation details
----------------------
To achieve this, this patch adds another check in
maybe_set_commit_resumed_all_targets to avoid setting the
commit-resumed flag of targets that readily have events to provide to
infrun.
To determine if a target has events readily available to report, this
patch adds an `has_pending_events` target_ops method. The method
returns a simple bool to say whether or not it has pending events to
report.
Testing
=======
To test this, I start GDBserver with a program that spawns multiple
threads:
$ ../gdbserver/gdbserver --once :1234 ~/src/many-threads-stepping-over-breakpoints/many-threads-stepping-over-breakpoints
I then connect with GDB and install a conditional breakpoint that always
evaluates to false (and force the evaluation to be done by GDB):
$ ./gdb -nx --data-directory=data-directory \
/home/simark/src/many-threads-stepping-over-breakpoints/many-threads-stepping-over-breakpoints \
-ex "set breakpoint condition-evaluation host" \
-ex "set pag off" \
-ex "set confirm off" \
-ex "maint set target-non-stop on" \
-ex "tar rem :1234" \
-ex "tb main" \
-ex "b 13 if 0" \
-ex c \
-ex "set debug infrun" \
-ex "set debug remote 1" \
-ex "set debug displaced"
I then do "continue" and look at the log.
The remote target receives a bunch of stop notifications for all
threads that have hit the breakpoint. infrun consumes and processes
one event, decides it should not cause a stop, prepares a displaced
step, after which we should see:
[infrun] maybe_set_commit_resumed_all_process_targets: not requesting commit-resumed for target remote, target has pending events
Same for a second thread (since we have 2 displaced step buffers).
For the following threads, their displaced step is deferred since
there are no more buffers available.
After consuming the last event the remote target has to offer, we get:
[infrun] maybe_set_commit_resumed_all_process_targets: enabling commit-resumed for target remote
[infrun] maybe_call_commit_resumed_all_process_targets: calling commit_resumed for target remote
[remote] Sending packet: $vCont;s:p14d16b.14d1b1;s:p14d16b.14d1b2#55
[remote] Packet received: OK
Without the patch, there would have been one vCont;s just after each
prepared displaced step.
gdb/ChangeLog:
yyyy-mm-dd Simon Marchi <simon.marchi@efficios.com>
Pedro Alves <pedro@palves.net>
* async-event.c (async_event_handler_marked): New.
* async-event.h (async_event_handler_marked): Declare.
* infrun.c (maybe_set_commit_resumed_all_targets): Switch to
inferior before calling target method. Don't commit-resumed if
target_has_pending_events is true.
* remote.c (remote_target::has_pending_events): New.
* target-delegates.c: Regenerate.
* target.c (target_has_pending_events): New.
* target.h (target_ops::has_pending_events): New target method.
(target_has_pending_events): New.
Change-Id: I18112ba19a1ff4986530c660f530d847bb4a1f1d
91 lines
3.2 KiB
C
91 lines
3.2 KiB
C
/* Async events for the GDB event loop.
|
|
Copyright (C) 1999-2021 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef ASYNC_EVENT_H
|
|
#define ASYNC_EVENT_H
|
|
|
|
#include "gdbsupport/event-loop.h"
|
|
|
|
struct async_signal_handler;
|
|
struct async_event_handler;
|
|
typedef void (sig_handler_func) (gdb_client_data);
|
|
|
|
/* Type of async event handler callbacks.
|
|
|
|
DATA is the client data originally passed to create_async_event_handler.
|
|
|
|
The callback is called when the async event handler is marked. The callback
|
|
is responsible for clearing the async event handler if it no longer needs
|
|
to be called. */
|
|
|
|
typedef void (async_event_handler_func) (gdb_client_data);
|
|
|
|
extern struct async_signal_handler *
|
|
create_async_signal_handler (sig_handler_func *proc,
|
|
gdb_client_data client_data,
|
|
const char *name);
|
|
extern void delete_async_signal_handler (struct async_signal_handler **);
|
|
|
|
/* Call the handler from HANDLER the next time through the event
|
|
loop. */
|
|
extern void mark_async_signal_handler (struct async_signal_handler *handler);
|
|
|
|
/* Returns true if HANDLER is marked ready. */
|
|
|
|
extern int
|
|
async_signal_handler_is_marked (struct async_signal_handler *handler);
|
|
|
|
/* Mark HANDLER as NOT ready. */
|
|
|
|
extern void clear_async_signal_handler (struct async_signal_handler *handler);
|
|
|
|
/* Create and register an asynchronous event source in the event loop,
|
|
and set PROC as its callback. CLIENT_DATA is passed as argument to
|
|
PROC upon its invocation. Returns a pointer to an opaque structure
|
|
used to mark as ready and to later delete this event source from
|
|
the event loop.
|
|
|
|
NAME is a user-friendly name for the handler, used in debug statements. The
|
|
name is not copied: its lifetime should be at least as long as that of the
|
|
handler. */
|
|
|
|
extern struct async_event_handler *
|
|
create_async_event_handler (async_event_handler_func *proc,
|
|
gdb_client_data client_data,
|
|
const char *name);
|
|
|
|
/* Remove the event source pointed by HANDLER_PTR created by
|
|
CREATE_ASYNC_EVENT_HANDLER from the event loop, and release it. */
|
|
extern void
|
|
delete_async_event_handler (struct async_event_handler **handler_ptr);
|
|
|
|
/* Call the handler from HANDLER the next time through the event
|
|
loop. */
|
|
extern void mark_async_event_handler (struct async_event_handler *handler);
|
|
|
|
/* Return true if HANDLER is marked. */
|
|
extern bool async_event_handler_marked (async_event_handler *handler);
|
|
|
|
/* Mark the handler (ASYNC_HANDLER_PTR) as NOT ready. */
|
|
|
|
extern void clear_async_event_handler (struct async_event_handler *handler);
|
|
|
|
extern void initialize_async_signal_handlers (void);
|
|
|
|
#endif /* ASYNC_EVENT_H */
|