mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-09 04:21:49 +08:00
224c3ddb89
Most allocation functions (if not all) return a void* pointing to the allocated memory. In C++, we need to add an explicit cast when assigning the result to a pointer to another type (which is the case more often than not). The content of this patch is taken from Pedro's branch, from commit "(mostly) auto-generated patch to insert casts needed for C++". I validated that the changes make sense and manually reflowed the code to make it respect the coding style. I also found multiple places where I could use XNEW/XNEWVEC/XRESIZEVEC/etc. Thanks a lot to whoever did that automated script to insert casts, doing it completely by hand would have taken a ridiculous amount of time. Only files built on x86 with --enable-targets=all are modified. This means that all other -nat.c files are untouched and will have to be dealt with later by using appropiate compilers. Or maybe we can try to build them with a regular g++ just to know where to add casts, I don't know. I built-tested this with --enable-targets=all and reg-tested. Here's the changelog entry, which was not too bad to make despite the size, thanks to David Malcom's script. I fixed some bits by hand, but there might be some wrong parts left (hopefully not). gdb/ChangeLog: * aarch64-linux-tdep.c (aarch64_stap_parse_special_token): Add cast to allocation result assignment. * ada-exp.y (write_object_renaming): Likewise. (write_ambiguous_var): Likewise. (ada_nget_field_index): Likewise. (write_var_or_type): Likewise. * ada-lang.c (ada_decode_symbol): Likewise. (ada_value_assign): Likewise. (value_pointer): Likewise. (cache_symbol): Likewise. (add_nonlocal_symbols): Likewise. (ada_name_for_lookup): Likewise. (symbol_completion_add): Likewise. (ada_to_fixed_type_1): Likewise. (ada_get_next_arg): Likewise. (defns_collected): Likewise. * ada-lex.l (processId): Likewise. (processString): Likewise. * ada-tasks.c (read_known_tasks_array): Likewise. (read_known_tasks_list): Likewise. * ada-typeprint.c (decoded_type_name): Likewise. * addrmap.c (addrmap_mutable_create_fixed): Likewise. * amd64-tdep.c (amd64_push_arguments): Likewise. (amd64_displaced_step_copy_insn): Likewise. (amd64_classify_insn_at): Likewise. (amd64_relocate_instruction): Likewise. * amd64obsd-tdep.c (amd64obsd_sigtramp_p): Likewise. * arch-utils.c (simple_displaced_step_copy_insn): Likewise. (initialize_current_architecture): Likewise. * arm-linux-tdep.c (arm_stap_parse_special_token): Likewise. * arm-symbian-tdep.c (arm_symbian_osabi_sniffer): Likewise. * arm-tdep.c (arm_exidx_new_objfile): Likewise. (arm_push_dummy_call): Likewise. (extend_buffer_earlier): Likewise. (arm_adjust_breakpoint_address): Likewise. (arm_skip_stub): Likewise. * auto-load.c (filename_is_in_pattern): Likewise. (maybe_add_script_file): Likewise. (maybe_add_script_text): Likewise. (auto_load_objfile_script_1): Likewise. * auxv.c (ld_so_xfer_auxv): Likewise. * ax-general.c (new_agent_expr): Likewise. (grow_expr): Likewise. (ax_reg_mask): Likewise. * bcache.c (bcache_full): Likewise. * breakpoint.c (program_breakpoint_here_p): Likewise. * btrace.c (parse_xml_raw): Likewise. * build-id.c (build_id_to_debug_bfd): Likewise. * buildsym.c (end_symtab_with_blockvector): Likewise. * c-exp.y (string_exp): Likewise. (qualified_name): Likewise. (write_destructor_name): Likewise. (operator_stoken): Likewise. (parse_number): Likewise. (scan_macro_expansion): Likewise. (yylex): Likewise. (c_print_token): Likewise. * c-lang.c (c_get_string): Likewise. (emit_numeric_character): Likewise. * charset.c (wchar_iterate): Likewise. * cli/cli-cmds.c (complete_command): Likewise. (make_command): Likewise. * cli/cli-dump.c (restore_section_callback): Likewise. (restore_binary_file): Likewise. * cli/cli-interp.c (cli_interpreter_exec): Likewise. * cli/cli-script.c (execute_control_command): Likewise. * cli/cli-setshow.c (do_set_command): Likewise. * coff-pe-read.c (add_pe_forwarded_sym): Likewise. (read_pe_exported_syms): Likewise. * coffread.c (coff_read_struct_type): Likewise. (coff_read_enum_type): Likewise. * common/btrace-common.c (btrace_data_append): Likewise. * common/buffer.c (buffer_grow): Likewise. * common/filestuff.c (gdb_fopen_cloexec): Likewise. * common/format.c (parse_format_string): Likewise. * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append): Likewise. * common/xml-utils.c (xml_escape_text): Likewise. * compile/compile-object-load.c (copy_sections): Likewise. (compile_object_load): Likewise. * compile/compile-object-run.c (compile_object_run): Likewise. * completer.c (filename_completer): Likewise. * corefile.c (read_memory_typed_address): Likewise. (write_memory_unsigned_integer): Likewise. (write_memory_signed_integer): Likewise. (complete_set_gnutarget): Likewise. * corelow.c (get_core_register_section): Likewise. * cp-name-parser.y (d_grab): Likewise. (allocate_info): Likewise. (cp_new_demangle_parse_info): Likewise. * cp-namespace.c (cp_scan_for_anonymous_namespaces): Likewise. (cp_lookup_symbol_in_namespace): Likewise. (lookup_namespace_scope): Likewise. (find_symbol_in_baseclass): Likewise. (cp_lookup_nested_symbol): Likewise. (cp_lookup_transparent_type_loop): Likewise. * cp-support.c (copy_string_to_obstack): Likewise. (make_symbol_overload_list): Likewise. (make_symbol_overload_list_namespace): Likewise. (make_symbol_overload_list_adl_namespace): Likewise. (first_component_command): Likewise. * cp-valprint.c (cp_print_value): Likewise. * ctf.c (ctf_xfer_partial): Likewise. * d-exp.y (StringExp): Likewise. * d-namespace.c (d_lookup_symbol_in_module): Likewise. (lookup_module_scope): Likewise. (find_symbol_in_baseclass): Likewise. (d_lookup_nested_symbol): Likewise. * dbxread.c (find_stab_function_addr): Likewise. (read_dbx_symtab): Likewise. (dbx_end_psymtab): Likewise. (cp_set_block_scope): Likewise. * dcache.c (dcache_alloc): Likewise. * demangle.c (_initialize_demangler): Likewise. * dicos-tdep.c (dicos_load_module_p): Likewise. * dictionary.c (dict_create_hashed_expandable): Likewise. (dict_create_linear_expandable): Likewise. (expand_hashtable): Likewise. (add_symbol_linear_expandable): Likewise. * dwarf2-frame.c (add_cie): Likewise. (add_fde): Likewise. (dwarf2_build_frame_info): Likewise. * dwarf2expr.c (dwarf_expr_grow_stack): Likewise. (dwarf_expr_fetch_address): Likewise. (add_piece): Likewise. (execute_stack_op): Likewise. * dwarf2loc.c (chain_candidate): Likewise. (dwarf_entry_parameter_to_value): Likewise. (read_pieced_value): Likewise. (write_pieced_value): Likewise. * dwarf2read.c (dwarf2_read_section): Likewise. (add_type_unit): Likewise. (read_comp_units_from_section): Likewise. (fixup_go_packaging): Likewise. (dwarf2_compute_name): Likewise. (dwarf2_physname): Likewise. (create_dwo_unit_in_dwp_v1): Likewise. (create_dwo_unit_in_dwp_v2): Likewise. (read_func_scope): Likewise. (read_call_site_scope): Likewise. (dwarf2_attach_fields_to_type): Likewise. (process_structure_scope): Likewise. (mark_common_block_symbol_computed): Likewise. (read_common_block): Likewise. (abbrev_table_read_table): Likewise. (guess_partial_die_structure_name): Likewise. (fixup_partial_die): Likewise. (add_file_name): Likewise. (dwarf2_const_value_data): Likewise. (dwarf2_const_value_attr): Likewise. (build_error_marker_type): Likewise. (guess_full_die_structure_name): Likewise. (anonymous_struct_prefix): Likewise. (typename_concat): Likewise. (dwarf2_canonicalize_name): Likewise. (dwarf2_name): Likewise. (write_constant_as_bytes): Likewise. (dwarf2_fetch_constant_bytes): Likewise. (copy_string): Likewise. (parse_macro_definition): Likewise. * elfread.c (elf_symfile_segments): Likewise. (elf_rel_plt_read): Likewise. (elf_gnu_ifunc_resolve_by_cache): Likewise. (elf_gnu_ifunc_resolve_by_got): Likewise. (elf_read_minimal_symbols): Likewise. (elf_gnu_ifunc_record_cache): Likewise. * event-top.c (top_level_prompt): Likewise. (command_line_handler): Likewise. * exec.c (resize_section_table): Likewise. * expprint.c (print_subexp_standard): Likewise. * fbsd-tdep.c (fbsd_collect_regset_section_cb): Likewise. * findcmd.c (parse_find_args): Likewise. * findvar.c (address_from_register): Likewise. * frame.c (get_prev_frame_always): Likewise. * gdb_bfd.c (gdb_bfd_ref): Likewise. (get_section_descriptor): Likewise. * gdb_obstack.c (obconcat): Likewise. (obstack_strdup): Likewise. * gdbtypes.c (lookup_function_type_with_arguments): Likewise. (create_set_type): Likewise. (lookup_unsigned_typename): Likewise. (lookup_signed_typename): Likewise. (resolve_dynamic_union): Likewise. (resolve_dynamic_struct): Likewise. (add_dyn_prop): Likewise. (copy_dynamic_prop_list): Likewise. (arch_flags_type): Likewise. (append_composite_type_field_raw): Likewise. * gdbtypes.h (INIT_FUNC_SPECIFIC): Likewise. * gnu-v3-abi.c (gnuv3_rtti_type): Likewise. * go-exp.y (string_exp): Likewise. * go-lang.c (go_demangle): Likewise. * guile/guile.c (compute_scheme_string): Likewise. * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise. (gdbscm_canonicalize_command_name): Likewise. * guile/scm-ports.c (ioscm_init_stdio_buffers): Likewise. (ioscm_init_memory_port): Likewise. (ioscm_reinit_memory_port): Likewise. * guile/scm-utils.c (gdbscm_gc_xstrdup): Likewise. (gdbscm_gc_dup_argv): Likewise. * h8300-tdep.c (h8300_push_dummy_call): Likewise. * hppa-tdep.c (internalize_unwinds): Likewise. (read_unwind_info): Likewise. * i386-cygwin-tdep.c (core_process_module_section): Likewise. (windows_core_xfer_shared_libraries): Likewise. * i386-tdep.c (i386_displaced_step_copy_insn): Likewise. (i386_stap_parse_special_token_triplet): Likewise. (i386_stap_parse_special_token_three_arg_disp): Likewise. * i386obsd-tdep.c (i386obsd_sigtramp_p): Likewise. * inf-child.c (inf_child_fileio_readlink): Likewise. * inf-ptrace.c (inf_ptrace_fetch_register): Likewise. (inf_ptrace_store_register): Likewise. * infrun.c (follow_exec): Likewise. (displaced_step_prepare_throw): Likewise. (save_stop_context): Likewise. (save_infcall_suspend_state): Likewise. * jit.c (jit_read_descriptor): Likewise. (jit_read_code_entry): Likewise. (jit_symtab_line_mapping_add_impl): Likewise. (finalize_symtab): Likewise. (jit_unwind_reg_get_impl): Likewise. * jv-exp.y (QualifiedName): Likewise. * jv-lang.c (get_java_utf8_name): Likewise. (type_from_class): Likewise. (java_demangle_type_signature): Likewise. (java_class_name_from_physname): Likewise. * jv-typeprint.c (java_type_print_base): Likewise. * jv-valprint.c (java_value_print): Likewise. * language.c (add_language): Likewise. * linespec.c (add_sal_to_sals_basic): Likewise. (add_sal_to_sals): Likewise. (decode_objc): Likewise. (find_linespec_symbols): Likewise. * linux-fork.c (fork_save_infrun_state): Likewise. * linux-nat.c (linux_nat_detach): Likewise. (linux_nat_fileio_readlink): Likewise. * linux-record.c (record_linux_sockaddr): Likewise. (record_linux_msghdr): Likewise. (Do): Likewise. * linux-tdep.c (linux_core_info_proc_mappings): Likewise. (linux_collect_regset_section_cb): Likewise. (linux_get_siginfo_data): Likewise. * linux-thread-db.c (try_thread_db_load_from_pdir_1): Likewise. (try_thread_db_load_from_dir): Likewise. (thread_db_load_search): Likewise. (info_auto_load_libthread_db): Likewise. * m32c-tdep.c (m32c_m16c_address_to_pointer): Likewise. (m32c_m16c_pointer_to_address): Likewise. * m68hc11-tdep.c (m68hc11_pseudo_register_write): Likewise. * m68k-tdep.c (m68k_get_longjmp_target): Likewise. * machoread.c (macho_check_dsym): Likewise. * macroexp.c (resize_buffer): Likewise. (gather_arguments): Likewise. (maybe_expand): Likewise. * macrotab.c (new_macro_key): Likewise. (new_source_file): Likewise. (new_macro_definition): Likewise. * mdebugread.c (parse_symbol): Likewise. (parse_type): Likewise. (parse_partial_symbols): Likewise. (psymtab_to_symtab_1): Likewise. * mem-break.c (default_memory_insert_breakpoint): Likewise. * mi/mi-cmd-break.c (mi_argv_to_format): Likewise. * mi/mi-main.c (mi_cmd_data_read_memory): Likewise. (mi_cmd_data_read_memory_bytes): Likewise. (mi_cmd_data_write_memory_bytes): Likewise. (mi_cmd_trace_frame_collected): Likewise. * mi/mi-parse.c (mi_parse_argv): Likewise. (mi_parse): Likewise. * minidebug.c (lzma_open): Likewise. (lzma_pread): Likewise. * mips-tdep.c (mips_read_fp_register_single): Likewise. (mips_print_fp_register): Likewise. * mipsnbsd-tdep.c (mipsnbsd_get_longjmp_target): Likewise. * mipsread.c (read_alphacoff_dynamic_symtab): Likewise. * mt-tdep.c (mt_register_name): Likewise. (mt_registers_info): Likewise. (mt_push_dummy_call): Likewise. * namespace.c (add_using_directive): Likewise. * nat/linux-btrace.c (perf_event_read): Likewise. (linux_enable_bts): Likewise. * nat/linux-osdata.c (linux_common_core_of_thread): Likewise. * nat/linux-ptrace.c (linux_ptrace_test_ret_to_nx): Likewise. * nto-tdep.c (nto_find_and_open_solib): Likewise. (nto_parse_redirection): Likewise. * objc-lang.c (objc_demangle): Likewise. (find_methods): Likewise. * objfiles.c (get_objfile_bfd_data): Likewise. (set_objfile_main_name): Likewise. (allocate_objfile): Likewise. (objfile_relocate): Likewise. (update_section_map): Likewise. * osabi.c (generic_elf_osabi_sniff_abi_tag_sections): Likewise. * p-exp.y (exp): Likewise. (yylex): Likewise. * p-valprint.c (pascal_object_print_value): Likewise. * parse.c (initialize_expout): Likewise. (mark_completion_tag): Likewise. (copy_name): Likewise. (parse_float): Likewise. (type_stack_reserve): Likewise. * ppc-linux-tdep.c (ppc_stap_parse_special_token): Likewise. (ppu2spu_prev_register): Likewise. * ppc-ravenscar-thread.c (supply_register_at_address): Likewise. * printcmd.c (printf_wide_c_string): Likewise. (printf_pointer): Likewise. * probe.c (parse_probes): Likewise. * python/py-cmd.c (gdbpy_parse_command_name): Likewise. (cmdpy_init): Likewise. * python/py-gdb-readline.c (gdbpy_readline_wrapper): Likewise. * python/py-symtab.c (set_sal): Likewise. * python/py-unwind.c (pyuw_sniffer): Likewise. * python/python.c (python_interactive_command): Likewise. (compute_python_string): Likewise. * ravenscar-thread.c (get_running_thread_id): Likewise. * record-full.c (record_full_exec_insn): Likewise. (record_full_core_open_1): Likewise. * regcache.c (regcache_raw_read_signed): Likewise. (regcache_raw_read_unsigned): Likewise. (regcache_cooked_read_signed): Likewise. (regcache_cooked_read_unsigned): Likewise. * remote-fileio.c (remote_fileio_func_open): Likewise. (remote_fileio_func_rename): Likewise. (remote_fileio_func_unlink): Likewise. (remote_fileio_func_stat): Likewise. (remote_fileio_func_system): Likewise. * remote-mips.c (mips_xfer_memory): Likewise. (mips_load_srec): Likewise. (pmon_end_download): Likewise. * remote.c (new_remote_state): Likewise. (map_regcache_remote_table): Likewise. (remote_register_number_and_offset): Likewise. (init_remote_state): Likewise. (get_memory_packet_size): Likewise. (remote_pass_signals): Likewise. (remote_program_signals): Likewise. (remote_start_remote): Likewise. (remote_check_symbols): Likewise. (remote_query_supported): Likewise. (extended_remote_attach): Likewise. (process_g_packet): Likewise. (store_registers_using_G): Likewise. (putpkt_binary): Likewise. (read_frame): Likewise. (compare_sections_command): Likewise. (remote_hostio_pread): Likewise. (remote_hostio_readlink): Likewise. (remote_file_put): Likewise. (remote_file_get): Likewise. (remote_pid_to_exec_file): Likewise. (_initialize_remote): Likewise. * rs6000-aix-tdep.c (rs6000_aix_ld_info_to_xml): Likewise. (rs6000_aix_core_xfer_shared_libraries_aix): Likewise. * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise. (bfd_uses_spe_extensions): Likewise. * s390-linux-tdep.c (s390_displaced_step_copy_insn): Likewise. * score-tdep.c (score7_malloc_and_get_memblock): Likewise. * solib-dsbt.c (decode_loadmap): Likewise. (fetch_loadmap): Likewise. (scan_dyntag): Likewise. (enable_break): Likewise. (dsbt_relocate_main_executable): Likewise. * solib-frv.c (fetch_loadmap): Likewise. (enable_break2): Likewise. (frv_relocate_main_executable): Likewise. * solib-spu.c (spu_relocate_main_executable): Likewise. (spu_bfd_open): Likewise. * solib-svr4.c (lm_info_read): Likewise. (read_program_header): Likewise. (find_program_interpreter): Likewise. (scan_dyntag): Likewise. (elf_locate_base): Likewise. (open_symbol_file_object): Likewise. (read_program_headers_from_bfd): Likewise. (svr4_relocate_main_executable): Likewise. * solib-target.c (solib_target_relocate_section_addresses): Likewise. * solib.c (solib_find_1): Likewise. (exec_file_find): Likewise. (solib_find): Likewise. * source.c (openp): Likewise. (print_source_lines_base): Likewise. (forward_search_command): Likewise. * sparc-ravenscar-thread.c (supply_register_at_address): Likewise. * spu-tdep.c (spu2ppu_prev_register): Likewise. (spu_get_overlay_table): Likewise. * stabsread.c (patch_block_stabs): Likewise. (define_symbol): Likewise. (again:): Likewise. (read_member_functions): Likewise. (read_one_struct_field): Likewise. (read_enum_type): Likewise. (common_block_start): Likewise. * stack.c (read_frame_arg): Likewise. (backtrace_command): Likewise. * stap-probe.c (stap_parse_register_operand): Likewise. * symfile.c (syms_from_objfile_1): Likewise. (find_separate_debug_file): Likewise. (load_command): Likewise. (load_progress): Likewise. (load_section_callback): Likewise. (reread_symbols): Likewise. (add_filename_language): Likewise. (allocate_compunit_symtab): Likewise. (read_target_long_array): Likewise. (simple_read_overlay_table): Likewise. * symtab.c (symbol_set_names): Likewise. (resize_symbol_cache): Likewise. (rbreak_command): Likewise. (completion_list_add_name): Likewise. (completion_list_objc_symbol): Likewise. (add_filename_to_list): Likewise. * target-descriptions.c (maint_print_c_tdesc_cmd): Likewise. * target-memory.c (target_write_memory_blocks): Likewise. * target.c (target_read_string): Likewise. (read_whatever_is_readable): Likewise. (target_read_alloc_1): Likewise. (simple_search_memory): Likewise. (target_fileio_read_alloc_1): Likewise. * tilegx-tdep.c (tilegx_push_dummy_call): Likewise. * top.c (command_line_input): Likewise. * tracefile-tfile.c (tfile_fetch_registers): Likewise. * tracefile.c (tracefile_fetch_registers): Likewise. * tracepoint.c (add_memrange): Likewise. (init_collection_list): Likewise. (add_aexpr): Likewise. (trace_dump_actions): Likewise. (parse_trace_status): Likewise. (parse_tracepoint_definition): Likewise. (parse_tsv_definition): Likewise. (parse_static_tracepoint_marker_definition): Likewise. * tui/tui-file.c (tui_sfileopen): Likewise. (tui_file_adjust_strbuf): Likewise. * tui/tui-io.c (tui_expand_tabs): Likewise. * tui/tui-source.c (tui_set_source_content): Likewise. * typeprint.c (find_global_typedef): Likewise. * ui-file.c (do_ui_file_xstrdup): Likewise. (ui_file_obsavestring): Likewise. (mem_file_write): Likewise. * utils.c (make_hex_string): Likewise. (get_regcomp_error): Likewise. (puts_filtered_tabular): Likewise. (gdb_realpath_keepfile): Likewise. (ldirname): Likewise. (gdb_bfd_errmsg): Likewise. (substitute_path_component): Likewise. * valops.c (search_struct_method): Likewise. (find_oload_champ_namespace_loop): Likewise. * valprint.c (print_decimal_chars): Likewise. (read_string): Likewise. (generic_emit_char): Likewise. * varobj.c (varobj_delete): Likewise. (varobj_value_get_print_value): Likewise. * vaxobsd-tdep.c (vaxobsd_sigtramp_sniffer): Likewise. * windows-tdep.c (display_one_tib): Likewise. * xcoffread.c (read_xcoff_symtab): Likewise. (process_xcoff_symbol): Likewise. (swap_sym): Likewise. (scan_xcoff_symtab): Likewise. (xcoff_initial_scan): Likewise. * xml-support.c (gdb_xml_end_element): Likewise. (xml_process_xincludes): Likewise. (xml_fetch_content_from_file): Likewise. * xml-syscall.c (xml_list_of_syscalls): Likewise. * xstormy16-tdep.c (xstormy16_push_dummy_call): Likewise. gdb/gdbserver/ChangeLog: * ax.c (gdb_parse_agent_expr): Add cast to allocation result assignment. (gdb_unparse_agent_expr): Likewise. * hostio.c (require_data): Likewise. (handle_pread): Likewise. * linux-low.c (disable_regset): Likewise. (fetch_register): Likewise. (store_register): Likewise. (get_dynamic): Likewise. (linux_qxfer_libraries_svr4): Likewise. * mem-break.c (delete_fast_tracepoint_jump): Likewise. (set_fast_tracepoint_jump): Likewise. (uninsert_fast_tracepoint_jumps_at): Likewise. (reinsert_fast_tracepoint_jumps_at): Likewise. (validate_inserted_breakpoint): Likewise. (clone_agent_expr): Likewise. * regcache.c (init_register_cache): Likewise. * remote-utils.c (putpkt_binary_1): Likewise. (decode_M_packet): Likewise. (decode_X_packet): Likewise. (look_up_one_symbol): Likewise. (relocate_instruction): Likewise. (monitor_output): Likewise. * server.c (handle_search_memory): Likewise. (handle_qxfer_exec_file): Likewise. (handle_qxfer_libraries): Likewise. (handle_qxfer): Likewise. (handle_query): Likewise. (handle_v_cont): Likewise. (handle_v_run): Likewise. (captured_main): Likewise. * target.c (write_inferior_memory): Likewise. * thread-db.c (try_thread_db_load_from_dir): Likewise. * tracepoint.c (init_trace_buffer): Likewise. (add_tracepoint_action): Likewise. (add_traceframe): Likewise. (add_traceframe_block): Likewise. (cmd_qtdpsrc): Likewise. (cmd_qtdv): Likewise. (cmd_qtstatus): Likewise. (response_source): Likewise. (response_tsv): Likewise. (cmd_qtnotes): Likewise. (gdb_collect): Likewise. (initialize_tracepoint): Likewise.
1089 lines
29 KiB
C
1089 lines
29 KiB
C
/* Work with executable files, for GDB.
|
||
|
||
Copyright (C) 1988-2015 Free Software Foundation, Inc.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
#include "defs.h"
|
||
#include "frame.h"
|
||
#include "inferior.h"
|
||
#include "target.h"
|
||
#include "gdbcmd.h"
|
||
#include "language.h"
|
||
#include "filenames.h"
|
||
#include "symfile.h"
|
||
#include "objfiles.h"
|
||
#include "completer.h"
|
||
#include "value.h"
|
||
#include "exec.h"
|
||
#include "observer.h"
|
||
#include "arch-utils.h"
|
||
#include "gdbthread.h"
|
||
#include "progspace.h"
|
||
#include "gdb_bfd.h"
|
||
#include "gcore.h"
|
||
|
||
#include <fcntl.h>
|
||
#include "readline/readline.h"
|
||
#include "gdbcore.h"
|
||
|
||
#include <ctype.h>
|
||
#include <sys/stat.h>
|
||
#include "solist.h"
|
||
|
||
void (*deprecated_file_changed_hook) (char *);
|
||
|
||
/* Prototypes for local functions */
|
||
|
||
static void file_command (char *, int);
|
||
|
||
static void set_section_command (char *, int);
|
||
|
||
static void exec_files_info (struct target_ops *);
|
||
|
||
static void init_exec_ops (void);
|
||
|
||
void _initialize_exec (void);
|
||
|
||
/* The target vector for executable files. */
|
||
|
||
static struct target_ops exec_ops;
|
||
|
||
/* Whether to open exec and core files read-only or read-write. */
|
||
|
||
int write_files = 0;
|
||
static void
|
||
show_write_files (struct ui_file *file, int from_tty,
|
||
struct cmd_list_element *c, const char *value)
|
||
{
|
||
fprintf_filtered (file, _("Writing into executable and core files is %s.\n"),
|
||
value);
|
||
}
|
||
|
||
|
||
static void
|
||
exec_open (const char *args, int from_tty)
|
||
{
|
||
target_preopen (from_tty);
|
||
exec_file_attach (args, from_tty);
|
||
}
|
||
|
||
/* Close and clear exec_bfd. If we end up with no target sections to
|
||
read memory from, this unpushes the exec_ops target. */
|
||
|
||
void
|
||
exec_close (void)
|
||
{
|
||
if (exec_bfd)
|
||
{
|
||
bfd *abfd = exec_bfd;
|
||
|
||
gdb_bfd_unref (abfd);
|
||
|
||
/* Removing target sections may close the exec_ops target.
|
||
Clear exec_bfd before doing so to prevent recursion. */
|
||
exec_bfd = NULL;
|
||
exec_bfd_mtime = 0;
|
||
|
||
remove_target_sections (&exec_bfd);
|
||
|
||
xfree (exec_filename);
|
||
exec_filename = NULL;
|
||
}
|
||
}
|
||
|
||
/* This is the target_close implementation. Clears all target
|
||
sections and closes all executable bfds from all program spaces. */
|
||
|
||
static void
|
||
exec_close_1 (struct target_ops *self)
|
||
{
|
||
struct program_space *ss;
|
||
struct cleanup *old_chain;
|
||
|
||
old_chain = save_current_program_space ();
|
||
ALL_PSPACES (ss)
|
||
{
|
||
set_current_program_space (ss);
|
||
clear_section_table (current_target_sections);
|
||
exec_close ();
|
||
}
|
||
|
||
do_cleanups (old_chain);
|
||
}
|
||
|
||
void
|
||
exec_file_clear (int from_tty)
|
||
{
|
||
/* Remove exec file. */
|
||
exec_close ();
|
||
|
||
if (from_tty)
|
||
printf_unfiltered (_("No executable file now.\n"));
|
||
}
|
||
|
||
/* See gdbcore.h. */
|
||
|
||
void
|
||
exec_file_locate_attach (int pid, int from_tty)
|
||
{
|
||
char *exec_file, *full_exec_path = NULL;
|
||
|
||
/* Do nothing if we already have an executable filename. */
|
||
exec_file = (char *) get_exec_file (0);
|
||
if (exec_file != NULL)
|
||
return;
|
||
|
||
/* Try to determine a filename from the process itself. */
|
||
exec_file = target_pid_to_exec_file (pid);
|
||
if (exec_file == NULL)
|
||
return;
|
||
|
||
/* If gdb_sysroot is not empty and the discovered filename
|
||
is absolute then prefix the filename with gdb_sysroot. */
|
||
if (*gdb_sysroot != '\0' && IS_ABSOLUTE_PATH (exec_file))
|
||
full_exec_path = exec_file_find (exec_file, NULL);
|
||
|
||
if (full_exec_path == NULL)
|
||
{
|
||
/* It's possible we don't have a full path, but rather just a
|
||
filename. Some targets, such as HP-UX, don't provide the
|
||
full path, sigh.
|
||
|
||
Attempt to qualify the filename against the source path.
|
||
(If that fails, we'll just fall back on the original
|
||
filename. Not much more we can do...) */
|
||
if (!source_full_path_of (exec_file, &full_exec_path))
|
||
full_exec_path = xstrdup (exec_file);
|
||
}
|
||
|
||
exec_file_attach (full_exec_path, from_tty);
|
||
symbol_file_add_main (full_exec_path, from_tty);
|
||
}
|
||
|
||
/* Set FILENAME as the new exec file.
|
||
|
||
This function is intended to be behave essentially the same
|
||
as exec_file_command, except that the latter will detect when
|
||
a target is being debugged, and will ask the user whether it
|
||
should be shut down first. (If the answer is "no", then the
|
||
new file is ignored.)
|
||
|
||
This file is used by exec_file_command, to do the work of opening
|
||
and processing the exec file after any prompting has happened.
|
||
|
||
And, it is used by child_attach, when the attach command was
|
||
given a pid but not a exec pathname, and the attach command could
|
||
figure out the pathname from the pid. (In this case, we shouldn't
|
||
ask the user whether the current target should be shut down --
|
||
we're supplying the exec pathname late for good reason.) */
|
||
|
||
void
|
||
exec_file_attach (const char *filename, int from_tty)
|
||
{
|
||
struct cleanup *cleanups;
|
||
|
||
/* First, acquire a reference to the current exec_bfd. We release
|
||
this at the end of the function; but acquiring it now lets the
|
||
BFD cache return it if this call refers to the same file. */
|
||
gdb_bfd_ref (exec_bfd);
|
||
cleanups = make_cleanup_bfd_unref (exec_bfd);
|
||
|
||
/* Remove any previous exec file. */
|
||
exec_close ();
|
||
|
||
/* Now open and digest the file the user requested, if any. */
|
||
|
||
if (!filename)
|
||
{
|
||
if (from_tty)
|
||
printf_unfiltered (_("No executable file now.\n"));
|
||
|
||
set_gdbarch_from_file (NULL);
|
||
}
|
||
else
|
||
{
|
||
int load_via_target = 0;
|
||
char *scratch_pathname, *canonical_pathname;
|
||
int scratch_chan;
|
||
struct target_section *sections = NULL, *sections_end = NULL;
|
||
char **matching;
|
||
|
||
if (is_target_filename (filename))
|
||
{
|
||
if (target_filesystem_is_local ())
|
||
filename += strlen (TARGET_SYSROOT_PREFIX);
|
||
else
|
||
load_via_target = 1;
|
||
}
|
||
|
||
if (load_via_target)
|
||
{
|
||
/* gdb_bfd_fopen does not support "target:" filenames. */
|
||
if (write_files)
|
||
warning (_("writing into executable files is "
|
||
"not supported for %s sysroots"),
|
||
TARGET_SYSROOT_PREFIX);
|
||
|
||
scratch_pathname = xstrdup (filename);
|
||
make_cleanup (xfree, scratch_pathname);
|
||
|
||
scratch_chan = -1;
|
||
|
||
canonical_pathname = scratch_pathname;
|
||
}
|
||
else
|
||
{
|
||
scratch_chan = openp (getenv ("PATH"), OPF_TRY_CWD_FIRST,
|
||
filename, write_files ?
|
||
O_RDWR | O_BINARY : O_RDONLY | O_BINARY,
|
||
&scratch_pathname);
|
||
#if defined(__GO32__) || defined(_WIN32) || defined(__CYGWIN__)
|
||
if (scratch_chan < 0)
|
||
{
|
||
char *exename = alloca (strlen (filename) + 5);
|
||
|
||
strcat (strcpy (exename, filename), ".exe");
|
||
scratch_chan = openp (getenv ("PATH"), OPF_TRY_CWD_FIRST,
|
||
exename, write_files ?
|
||
O_RDWR | O_BINARY
|
||
: O_RDONLY | O_BINARY,
|
||
&scratch_pathname);
|
||
}
|
||
#endif
|
||
if (scratch_chan < 0)
|
||
perror_with_name (filename);
|
||
|
||
make_cleanup (xfree, scratch_pathname);
|
||
|
||
/* gdb_bfd_open (and its variants) prefers canonicalized
|
||
pathname for better BFD caching. */
|
||
canonical_pathname = gdb_realpath (scratch_pathname);
|
||
make_cleanup (xfree, canonical_pathname);
|
||
}
|
||
|
||
if (write_files && !load_via_target)
|
||
exec_bfd = gdb_bfd_fopen (canonical_pathname, gnutarget,
|
||
FOPEN_RUB, scratch_chan);
|
||
else
|
||
exec_bfd = gdb_bfd_open (canonical_pathname, gnutarget, scratch_chan);
|
||
|
||
if (!exec_bfd)
|
||
{
|
||
error (_("\"%s\": could not open as an executable file: %s."),
|
||
scratch_pathname, bfd_errmsg (bfd_get_error ()));
|
||
}
|
||
|
||
/* gdb_realpath_keepfile resolves symlinks on the local
|
||
filesystem and so cannot be used for "target:" files. */
|
||
gdb_assert (exec_filename == NULL);
|
||
if (load_via_target)
|
||
exec_filename = xstrdup (bfd_get_filename (exec_bfd));
|
||
else
|
||
exec_filename = gdb_realpath_keepfile (scratch_pathname);
|
||
|
||
if (!bfd_check_format_matches (exec_bfd, bfd_object, &matching))
|
||
{
|
||
/* Make sure to close exec_bfd, or else "run" might try to use
|
||
it. */
|
||
exec_close ();
|
||
error (_("\"%s\": not in executable format: %s"),
|
||
scratch_pathname,
|
||
gdb_bfd_errmsg (bfd_get_error (), matching));
|
||
}
|
||
|
||
if (build_section_table (exec_bfd, §ions, §ions_end))
|
||
{
|
||
/* Make sure to close exec_bfd, or else "run" might try to use
|
||
it. */
|
||
exec_close ();
|
||
error (_("\"%s\": can't find the file sections: %s"),
|
||
scratch_pathname, bfd_errmsg (bfd_get_error ()));
|
||
}
|
||
|
||
exec_bfd_mtime = bfd_get_mtime (exec_bfd);
|
||
|
||
validate_files ();
|
||
|
||
set_gdbarch_from_file (exec_bfd);
|
||
|
||
/* Add the executable's sections to the current address spaces'
|
||
list of sections. This possibly pushes the exec_ops
|
||
target. */
|
||
add_target_sections (&exec_bfd, sections, sections_end);
|
||
xfree (sections);
|
||
|
||
/* Tell display code (if any) about the changed file name. */
|
||
if (deprecated_exec_file_display_hook)
|
||
(*deprecated_exec_file_display_hook) (filename);
|
||
}
|
||
|
||
do_cleanups (cleanups);
|
||
|
||
bfd_cache_close_all ();
|
||
observer_notify_executable_changed ();
|
||
}
|
||
|
||
/* Process the first arg in ARGS as the new exec file.
|
||
|
||
Note that we have to explicitly ignore additional args, since we can
|
||
be called from file_command(), which also calls symbol_file_command()
|
||
which can take multiple args.
|
||
|
||
If ARGS is NULL, we just want to close the exec file. */
|
||
|
||
static void
|
||
exec_file_command (char *args, int from_tty)
|
||
{
|
||
char **argv;
|
||
char *filename;
|
||
|
||
if (from_tty && target_has_execution
|
||
&& !query (_("A program is being debugged already.\n"
|
||
"Are you sure you want to change the file? ")))
|
||
error (_("File not changed."));
|
||
|
||
if (args)
|
||
{
|
||
struct cleanup *cleanups;
|
||
|
||
/* Scan through the args and pick up the first non option arg
|
||
as the filename. */
|
||
|
||
argv = gdb_buildargv (args);
|
||
cleanups = make_cleanup_freeargv (argv);
|
||
|
||
for (; (*argv != NULL) && (**argv == '-'); argv++)
|
||
{;
|
||
}
|
||
if (*argv == NULL)
|
||
error (_("No executable file name was specified"));
|
||
|
||
filename = tilde_expand (*argv);
|
||
make_cleanup (xfree, filename);
|
||
exec_file_attach (filename, from_tty);
|
||
|
||
do_cleanups (cleanups);
|
||
}
|
||
else
|
||
exec_file_attach (NULL, from_tty);
|
||
}
|
||
|
||
/* Set both the exec file and the symbol file, in one command.
|
||
What a novelty. Why did GDB go through four major releases before this
|
||
command was added? */
|
||
|
||
static void
|
||
file_command (char *arg, int from_tty)
|
||
{
|
||
/* FIXME, if we lose on reading the symbol file, we should revert
|
||
the exec file, but that's rough. */
|
||
exec_file_command (arg, from_tty);
|
||
symbol_file_command (arg, from_tty);
|
||
if (deprecated_file_changed_hook)
|
||
deprecated_file_changed_hook (arg);
|
||
}
|
||
|
||
|
||
/* Locate all mappable sections of a BFD file.
|
||
table_pp_char is a char * to get it through bfd_map_over_sections;
|
||
we cast it back to its proper type. */
|
||
|
||
static void
|
||
add_to_section_table (bfd *abfd, struct bfd_section *asect,
|
||
void *table_pp_char)
|
||
{
|
||
struct target_section **table_pp = (struct target_section **) table_pp_char;
|
||
flagword aflag;
|
||
|
||
gdb_assert (abfd == asect->owner);
|
||
|
||
/* Check the section flags, but do not discard zero-length sections, since
|
||
some symbols may still be attached to this section. For instance, we
|
||
encountered on sparc-solaris 2.10 a shared library with an empty .bss
|
||
section to which a symbol named "_end" was attached. The address
|
||
of this symbol still needs to be relocated. */
|
||
aflag = bfd_get_section_flags (abfd, asect);
|
||
if (!(aflag & SEC_ALLOC))
|
||
return;
|
||
|
||
(*table_pp)->owner = NULL;
|
||
(*table_pp)->the_bfd_section = asect;
|
||
(*table_pp)->addr = bfd_section_vma (abfd, asect);
|
||
(*table_pp)->endaddr = (*table_pp)->addr + bfd_section_size (abfd, asect);
|
||
(*table_pp)++;
|
||
}
|
||
|
||
/* See exec.h. */
|
||
|
||
void
|
||
clear_section_table (struct target_section_table *table)
|
||
{
|
||
xfree (table->sections);
|
||
table->sections = table->sections_end = NULL;
|
||
}
|
||
|
||
/* Resize section table TABLE by ADJUSTMENT.
|
||
ADJUSTMENT may be negative, in which case the caller must have already
|
||
removed the sections being deleted.
|
||
Returns the old size. */
|
||
|
||
static int
|
||
resize_section_table (struct target_section_table *table, int adjustment)
|
||
{
|
||
int old_count;
|
||
int new_count;
|
||
|
||
old_count = table->sections_end - table->sections;
|
||
|
||
new_count = adjustment + old_count;
|
||
|
||
if (new_count)
|
||
{
|
||
table->sections = XRESIZEVEC (struct target_section, table->sections,
|
||
new_count);
|
||
table->sections_end = table->sections + new_count;
|
||
}
|
||
else
|
||
clear_section_table (table);
|
||
|
||
return old_count;
|
||
}
|
||
|
||
/* Builds a section table, given args BFD, SECTABLE_PTR, SECEND_PTR.
|
||
Returns 0 if OK, 1 on error. */
|
||
|
||
int
|
||
build_section_table (struct bfd *some_bfd, struct target_section **start,
|
||
struct target_section **end)
|
||
{
|
||
unsigned count;
|
||
|
||
count = bfd_count_sections (some_bfd);
|
||
if (*start)
|
||
xfree (* start);
|
||
*start = XNEWVEC (struct target_section, count);
|
||
*end = *start;
|
||
bfd_map_over_sections (some_bfd, add_to_section_table, (char *) end);
|
||
if (*end > *start + count)
|
||
internal_error (__FILE__, __LINE__,
|
||
_("failed internal consistency check"));
|
||
/* We could realloc the table, but it probably loses for most files. */
|
||
return 0;
|
||
}
|
||
|
||
/* Add the sections array defined by [SECTIONS..SECTIONS_END[ to the
|
||
current set of target sections. */
|
||
|
||
void
|
||
add_target_sections (void *owner,
|
||
struct target_section *sections,
|
||
struct target_section *sections_end)
|
||
{
|
||
int count;
|
||
struct target_section_table *table = current_target_sections;
|
||
|
||
count = sections_end - sections;
|
||
|
||
if (count > 0)
|
||
{
|
||
int space = resize_section_table (table, count);
|
||
int i;
|
||
|
||
for (i = 0; i < count; ++i)
|
||
{
|
||
table->sections[space + i] = sections[i];
|
||
table->sections[space + i].owner = owner;
|
||
}
|
||
|
||
/* If these are the first file sections we can provide memory
|
||
from, push the file_stratum target. */
|
||
if (!target_is_pushed (&exec_ops))
|
||
push_target (&exec_ops);
|
||
}
|
||
}
|
||
|
||
/* Add the sections of OBJFILE to the current set of target sections. */
|
||
|
||
void
|
||
add_target_sections_of_objfile (struct objfile *objfile)
|
||
{
|
||
struct target_section_table *table = current_target_sections;
|
||
struct obj_section *osect;
|
||
int space;
|
||
unsigned count = 0;
|
||
struct target_section *ts;
|
||
|
||
if (objfile == NULL)
|
||
return;
|
||
|
||
/* Compute the number of sections to add. */
|
||
ALL_OBJFILE_OSECTIONS (objfile, osect)
|
||
{
|
||
if (bfd_get_section_size (osect->the_bfd_section) == 0)
|
||
continue;
|
||
count++;
|
||
}
|
||
|
||
if (count == 0)
|
||
return;
|
||
|
||
space = resize_section_table (table, count);
|
||
|
||
ts = table->sections + space;
|
||
|
||
ALL_OBJFILE_OSECTIONS (objfile, osect)
|
||
{
|
||
if (bfd_get_section_size (osect->the_bfd_section) == 0)
|
||
continue;
|
||
|
||
gdb_assert (ts < table->sections + space + count);
|
||
|
||
ts->addr = obj_section_addr (osect);
|
||
ts->endaddr = obj_section_endaddr (osect);
|
||
ts->the_bfd_section = osect->the_bfd_section;
|
||
ts->owner = (void *) objfile;
|
||
|
||
ts++;
|
||
}
|
||
}
|
||
|
||
/* Remove all target sections owned by OWNER.
|
||
OWNER must be the same value passed to add_target_sections. */
|
||
|
||
void
|
||
remove_target_sections (void *owner)
|
||
{
|
||
struct target_section *src, *dest;
|
||
struct target_section_table *table = current_target_sections;
|
||
|
||
gdb_assert (owner != NULL);
|
||
|
||
dest = table->sections;
|
||
for (src = table->sections; src < table->sections_end; src++)
|
||
if (src->owner != owner)
|
||
{
|
||
/* Keep this section. */
|
||
if (dest < src)
|
||
*dest = *src;
|
||
dest++;
|
||
}
|
||
|
||
/* If we've dropped any sections, resize the section table. */
|
||
if (dest < src)
|
||
{
|
||
int old_count;
|
||
|
||
old_count = resize_section_table (table, dest - src);
|
||
|
||
/* If we don't have any more sections to read memory from,
|
||
remove the file_stratum target from the stack. */
|
||
if (old_count + (dest - src) == 0)
|
||
{
|
||
struct program_space *pspace;
|
||
|
||
ALL_PSPACES (pspace)
|
||
if (pspace->target_sections.sections
|
||
!= pspace->target_sections.sections_end)
|
||
return;
|
||
|
||
unpush_target (&exec_ops);
|
||
}
|
||
}
|
||
}
|
||
|
||
|
||
|
||
enum target_xfer_status
|
||
exec_read_partial_read_only (gdb_byte *readbuf, ULONGEST offset,
|
||
ULONGEST len, ULONGEST *xfered_len)
|
||
{
|
||
/* It's unduly pedantic to refuse to look at the executable for
|
||
read-only pieces; so do the equivalent of readonly regions aka
|
||
QTro packet. */
|
||
if (exec_bfd != NULL)
|
||
{
|
||
asection *s;
|
||
bfd_size_type size;
|
||
bfd_vma vma;
|
||
|
||
for (s = exec_bfd->sections; s; s = s->next)
|
||
{
|
||
if ((s->flags & SEC_LOAD) == 0
|
||
|| (s->flags & SEC_READONLY) == 0)
|
||
continue;
|
||
|
||
vma = s->vma;
|
||
size = bfd_get_section_size (s);
|
||
if (vma <= offset && offset < (vma + size))
|
||
{
|
||
ULONGEST amt;
|
||
|
||
amt = (vma + size) - offset;
|
||
if (amt > len)
|
||
amt = len;
|
||
|
||
amt = bfd_get_section_contents (exec_bfd, s,
|
||
readbuf, offset - vma, amt);
|
||
|
||
if (amt == 0)
|
||
return TARGET_XFER_EOF;
|
||
else
|
||
{
|
||
*xfered_len = amt;
|
||
return TARGET_XFER_OK;
|
||
}
|
||
}
|
||
}
|
||
}
|
||
|
||
/* Indicate failure to find the requested memory block. */
|
||
return TARGET_XFER_E_IO;
|
||
}
|
||
|
||
/* Appends all read-only memory ranges found in the target section
|
||
table defined by SECTIONS and SECTIONS_END, starting at (and
|
||
intersected with) MEMADDR for LEN bytes. Returns the augmented
|
||
VEC. */
|
||
|
||
static VEC(mem_range_s) *
|
||
section_table_available_memory (VEC(mem_range_s) *memory,
|
||
CORE_ADDR memaddr, ULONGEST len,
|
||
struct target_section *sections,
|
||
struct target_section *sections_end)
|
||
{
|
||
struct target_section *p;
|
||
|
||
for (p = sections; p < sections_end; p++)
|
||
{
|
||
if ((bfd_get_section_flags (p->the_bfd_section->owner,
|
||
p->the_bfd_section)
|
||
& SEC_READONLY) == 0)
|
||
continue;
|
||
|
||
/* Copy the meta-data, adjusted. */
|
||
if (mem_ranges_overlap (p->addr, p->endaddr - p->addr, memaddr, len))
|
||
{
|
||
ULONGEST lo1, hi1, lo2, hi2;
|
||
struct mem_range *r;
|
||
|
||
lo1 = memaddr;
|
||
hi1 = memaddr + len;
|
||
|
||
lo2 = p->addr;
|
||
hi2 = p->endaddr;
|
||
|
||
r = VEC_safe_push (mem_range_s, memory, NULL);
|
||
|
||
r->start = max (lo1, lo2);
|
||
r->length = min (hi1, hi2) - r->start;
|
||
}
|
||
}
|
||
|
||
return memory;
|
||
}
|
||
|
||
enum target_xfer_status
|
||
section_table_read_available_memory (gdb_byte *readbuf, ULONGEST offset,
|
||
ULONGEST len, ULONGEST *xfered_len)
|
||
{
|
||
VEC(mem_range_s) *available_memory = NULL;
|
||
struct target_section_table *table;
|
||
struct cleanup *old_chain;
|
||
mem_range_s *r;
|
||
int i;
|
||
|
||
table = target_get_section_table (&exec_ops);
|
||
available_memory = section_table_available_memory (available_memory,
|
||
offset, len,
|
||
table->sections,
|
||
table->sections_end);
|
||
|
||
old_chain = make_cleanup (VEC_cleanup(mem_range_s),
|
||
&available_memory);
|
||
|
||
normalize_mem_ranges (available_memory);
|
||
|
||
for (i = 0;
|
||
VEC_iterate (mem_range_s, available_memory, i, r);
|
||
i++)
|
||
{
|
||
if (mem_ranges_overlap (r->start, r->length, offset, len))
|
||
{
|
||
CORE_ADDR end;
|
||
enum target_xfer_status status;
|
||
|
||
/* Get the intersection window. */
|
||
end = min (offset + len, r->start + r->length);
|
||
|
||
gdb_assert (end - offset <= len);
|
||
|
||
if (offset >= r->start)
|
||
status = exec_read_partial_read_only (readbuf, offset,
|
||
end - offset,
|
||
xfered_len);
|
||
else
|
||
{
|
||
*xfered_len = r->start - offset;
|
||
status = TARGET_XFER_UNAVAILABLE;
|
||
}
|
||
do_cleanups (old_chain);
|
||
return status;
|
||
}
|
||
}
|
||
do_cleanups (old_chain);
|
||
|
||
*xfered_len = len;
|
||
return TARGET_XFER_UNAVAILABLE;
|
||
}
|
||
|
||
enum target_xfer_status
|
||
section_table_xfer_memory_partial (gdb_byte *readbuf, const gdb_byte *writebuf,
|
||
ULONGEST offset, ULONGEST len,
|
||
ULONGEST *xfered_len,
|
||
struct target_section *sections,
|
||
struct target_section *sections_end,
|
||
const char *section_name)
|
||
{
|
||
int res;
|
||
struct target_section *p;
|
||
ULONGEST memaddr = offset;
|
||
ULONGEST memend = memaddr + len;
|
||
|
||
if (len == 0)
|
||
internal_error (__FILE__, __LINE__,
|
||
_("failed internal consistency check"));
|
||
|
||
for (p = sections; p < sections_end; p++)
|
||
{
|
||
struct bfd_section *asect = p->the_bfd_section;
|
||
bfd *abfd = asect->owner;
|
||
|
||
if (section_name && strcmp (section_name, asect->name) != 0)
|
||
continue; /* not the section we need. */
|
||
if (memaddr >= p->addr)
|
||
{
|
||
if (memend <= p->endaddr)
|
||
{
|
||
/* Entire transfer is within this section. */
|
||
if (writebuf)
|
||
res = bfd_set_section_contents (abfd, asect,
|
||
writebuf, memaddr - p->addr,
|
||
len);
|
||
else
|
||
res = bfd_get_section_contents (abfd, asect,
|
||
readbuf, memaddr - p->addr,
|
||
len);
|
||
|
||
if (res != 0)
|
||
{
|
||
*xfered_len = len;
|
||
return TARGET_XFER_OK;
|
||
}
|
||
else
|
||
return TARGET_XFER_EOF;
|
||
}
|
||
else if (memaddr >= p->endaddr)
|
||
{
|
||
/* This section ends before the transfer starts. */
|
||
continue;
|
||
}
|
||
else
|
||
{
|
||
/* This section overlaps the transfer. Just do half. */
|
||
len = p->endaddr - memaddr;
|
||
if (writebuf)
|
||
res = bfd_set_section_contents (abfd, asect,
|
||
writebuf, memaddr - p->addr,
|
||
len);
|
||
else
|
||
res = bfd_get_section_contents (abfd, asect,
|
||
readbuf, memaddr - p->addr,
|
||
len);
|
||
if (res != 0)
|
||
{
|
||
*xfered_len = len;
|
||
return TARGET_XFER_OK;
|
||
}
|
||
else
|
||
return TARGET_XFER_EOF;
|
||
}
|
||
}
|
||
}
|
||
|
||
return TARGET_XFER_EOF; /* We can't help. */
|
||
}
|
||
|
||
static struct target_section_table *
|
||
exec_get_section_table (struct target_ops *ops)
|
||
{
|
||
return current_target_sections;
|
||
}
|
||
|
||
static enum target_xfer_status
|
||
exec_xfer_partial (struct target_ops *ops, enum target_object object,
|
||
const char *annex, gdb_byte *readbuf,
|
||
const gdb_byte *writebuf,
|
||
ULONGEST offset, ULONGEST len, ULONGEST *xfered_len)
|
||
{
|
||
struct target_section_table *table = target_get_section_table (ops);
|
||
|
||
if (object == TARGET_OBJECT_MEMORY)
|
||
return section_table_xfer_memory_partial (readbuf, writebuf,
|
||
offset, len, xfered_len,
|
||
table->sections,
|
||
table->sections_end,
|
||
NULL);
|
||
else
|
||
return TARGET_XFER_E_IO;
|
||
}
|
||
|
||
|
||
void
|
||
print_section_info (struct target_section_table *t, bfd *abfd)
|
||
{
|
||
struct gdbarch *gdbarch = gdbarch_from_bfd (abfd);
|
||
struct target_section *p;
|
||
/* FIXME: 16 is not wide enough when gdbarch_addr_bit > 64. */
|
||
int wid = gdbarch_addr_bit (gdbarch) <= 32 ? 8 : 16;
|
||
|
||
printf_filtered ("\t`%s', ", bfd_get_filename (abfd));
|
||
wrap_here (" ");
|
||
printf_filtered (_("file type %s.\n"), bfd_get_target (abfd));
|
||
if (abfd == exec_bfd)
|
||
{
|
||
/* gcc-3.4 does not like the initialization in
|
||
<p == t->sections_end>. */
|
||
bfd_vma displacement = 0;
|
||
bfd_vma entry_point;
|
||
|
||
for (p = t->sections; p < t->sections_end; p++)
|
||
{
|
||
struct bfd_section *psect = p->the_bfd_section;
|
||
bfd *pbfd = psect->owner;
|
||
|
||
if ((bfd_get_section_flags (pbfd, psect) & (SEC_ALLOC | SEC_LOAD))
|
||
!= (SEC_ALLOC | SEC_LOAD))
|
||
continue;
|
||
|
||
if (bfd_get_section_vma (pbfd, psect) <= abfd->start_address
|
||
&& abfd->start_address < (bfd_get_section_vma (pbfd, psect)
|
||
+ bfd_get_section_size (psect)))
|
||
{
|
||
displacement = p->addr - bfd_get_section_vma (pbfd, psect);
|
||
break;
|
||
}
|
||
}
|
||
if (p == t->sections_end)
|
||
warning (_("Cannot find section for the entry point of %s."),
|
||
bfd_get_filename (abfd));
|
||
|
||
entry_point = gdbarch_addr_bits_remove (gdbarch,
|
||
bfd_get_start_address (abfd)
|
||
+ displacement);
|
||
printf_filtered (_("\tEntry point: %s\n"),
|
||
paddress (gdbarch, entry_point));
|
||
}
|
||
for (p = t->sections; p < t->sections_end; p++)
|
||
{
|
||
struct bfd_section *psect = p->the_bfd_section;
|
||
bfd *pbfd = psect->owner;
|
||
|
||
printf_filtered ("\t%s", hex_string_custom (p->addr, wid));
|
||
printf_filtered (" - %s", hex_string_custom (p->endaddr, wid));
|
||
|
||
/* FIXME: A format of "08l" is not wide enough for file offsets
|
||
larger than 4GB. OTOH, making it "016l" isn't desirable either
|
||
since most output will then be much wider than necessary. It
|
||
may make sense to test the size of the file and choose the
|
||
format string accordingly. */
|
||
/* FIXME: i18n: Need to rewrite this sentence. */
|
||
if (info_verbose)
|
||
printf_filtered (" @ %s",
|
||
hex_string_custom (psect->filepos, 8));
|
||
printf_filtered (" is %s", bfd_section_name (pbfd, psect));
|
||
if (pbfd != abfd)
|
||
printf_filtered (" in %s", bfd_get_filename (pbfd));
|
||
printf_filtered ("\n");
|
||
}
|
||
}
|
||
|
||
static void
|
||
exec_files_info (struct target_ops *t)
|
||
{
|
||
if (exec_bfd)
|
||
print_section_info (current_target_sections, exec_bfd);
|
||
else
|
||
puts_filtered (_("\t<no file loaded>\n"));
|
||
}
|
||
|
||
static void
|
||
set_section_command (char *args, int from_tty)
|
||
{
|
||
struct target_section *p;
|
||
char *secname;
|
||
unsigned seclen;
|
||
unsigned long secaddr;
|
||
char secprint[100];
|
||
long offset;
|
||
struct target_section_table *table;
|
||
|
||
if (args == 0)
|
||
error (_("Must specify section name and its virtual address"));
|
||
|
||
/* Parse out section name. */
|
||
for (secname = args; !isspace (*args); args++);
|
||
seclen = args - secname;
|
||
|
||
/* Parse out new virtual address. */
|
||
secaddr = parse_and_eval_address (args);
|
||
|
||
table = current_target_sections;
|
||
for (p = table->sections; p < table->sections_end; p++)
|
||
{
|
||
if (!strncmp (secname, bfd_section_name (p->bfd,
|
||
p->the_bfd_section), seclen)
|
||
&& bfd_section_name (p->bfd, p->the_bfd_section)[seclen] == '\0')
|
||
{
|
||
offset = secaddr - p->addr;
|
||
p->addr += offset;
|
||
p->endaddr += offset;
|
||
if (from_tty)
|
||
exec_files_info (&exec_ops);
|
||
return;
|
||
}
|
||
}
|
||
if (seclen >= sizeof (secprint))
|
||
seclen = sizeof (secprint) - 1;
|
||
strncpy (secprint, secname, seclen);
|
||
secprint[seclen] = '\0';
|
||
error (_("Section %s not found"), secprint);
|
||
}
|
||
|
||
/* If we can find a section in FILENAME with BFD index INDEX, adjust
|
||
it to ADDRESS. */
|
||
|
||
void
|
||
exec_set_section_address (const char *filename, int index, CORE_ADDR address)
|
||
{
|
||
struct target_section *p;
|
||
struct target_section_table *table;
|
||
|
||
table = current_target_sections;
|
||
for (p = table->sections; p < table->sections_end; p++)
|
||
{
|
||
if (filename_cmp (filename, p->the_bfd_section->owner->filename) == 0
|
||
&& index == p->the_bfd_section->index)
|
||
{
|
||
p->endaddr += address - p->addr;
|
||
p->addr = address;
|
||
}
|
||
}
|
||
}
|
||
|
||
/* If mourn is being called in all the right places, this could be say
|
||
`gdb internal error' (since generic_mourn calls
|
||
breakpoint_init_inferior). */
|
||
|
||
static int
|
||
ignore (struct target_ops *ops, struct gdbarch *gdbarch,
|
||
struct bp_target_info *bp_tgt)
|
||
{
|
||
return 0;
|
||
}
|
||
|
||
static int
|
||
exec_has_memory (struct target_ops *ops)
|
||
{
|
||
/* We can provide memory if we have any file/target sections to read
|
||
from. */
|
||
return (current_target_sections->sections
|
||
!= current_target_sections->sections_end);
|
||
}
|
||
|
||
static char *
|
||
exec_make_note_section (struct target_ops *self, bfd *obfd, int *note_size)
|
||
{
|
||
error (_("Can't create a corefile"));
|
||
}
|
||
|
||
/* Fill in the exec file target vector. Very few entries need to be
|
||
defined. */
|
||
|
||
static void
|
||
init_exec_ops (void)
|
||
{
|
||
exec_ops.to_shortname = "exec";
|
||
exec_ops.to_longname = "Local exec file";
|
||
exec_ops.to_doc = "Use an executable file as a target.\n\
|
||
Specify the filename of the executable file.";
|
||
exec_ops.to_open = exec_open;
|
||
exec_ops.to_close = exec_close_1;
|
||
exec_ops.to_xfer_partial = exec_xfer_partial;
|
||
exec_ops.to_get_section_table = exec_get_section_table;
|
||
exec_ops.to_files_info = exec_files_info;
|
||
exec_ops.to_insert_breakpoint = ignore;
|
||
exec_ops.to_remove_breakpoint = ignore;
|
||
exec_ops.to_stratum = file_stratum;
|
||
exec_ops.to_has_memory = exec_has_memory;
|
||
exec_ops.to_make_corefile_notes = exec_make_note_section;
|
||
exec_ops.to_find_memory_regions = objfile_find_memory_regions;
|
||
exec_ops.to_magic = OPS_MAGIC;
|
||
}
|
||
|
||
void
|
||
_initialize_exec (void)
|
||
{
|
||
struct cmd_list_element *c;
|
||
|
||
init_exec_ops ();
|
||
|
||
if (!dbx_commands)
|
||
{
|
||
c = add_cmd ("file", class_files, file_command, _("\
|
||
Use FILE as program to be debugged.\n\
|
||
It is read for its symbols, for getting the contents of pure memory,\n\
|
||
and it is the program executed when you use the `run' command.\n\
|
||
If FILE cannot be found as specified, your execution directory path\n\
|
||
($PATH) is searched for a command of that name.\n\
|
||
No arg means to have no executable file and no symbols."), &cmdlist);
|
||
set_cmd_completer (c, filename_completer);
|
||
}
|
||
|
||
c = add_cmd ("exec-file", class_files, exec_file_command, _("\
|
||
Use FILE as program for getting contents of pure memory.\n\
|
||
If FILE cannot be found as specified, your execution directory path\n\
|
||
is searched for a command of that name.\n\
|
||
No arg means have no executable file."), &cmdlist);
|
||
set_cmd_completer (c, filename_completer);
|
||
|
||
add_com ("section", class_files, set_section_command, _("\
|
||
Change the base address of section SECTION of the exec file to ADDR.\n\
|
||
This can be used if the exec file does not contain section addresses,\n\
|
||
(such as in the a.out format), or when the addresses specified in the\n\
|
||
file itself are wrong. Each section must be changed separately. The\n\
|
||
``info files'' command lists all the sections and their addresses."));
|
||
|
||
add_setshow_boolean_cmd ("write", class_support, &write_files, _("\
|
||
Set writing into executable and core files."), _("\
|
||
Show writing into executable and core files."), NULL,
|
||
NULL,
|
||
show_write_files,
|
||
&setlist, &showlist);
|
||
|
||
add_target_with_completer (&exec_ops, filename_completer);
|
||
}
|